Skip to content

feat(models): add underline to rich text section block element - #1771

Merged
zimeg merged 1 commit into
mainfrom
zimeg-feat-models-rich-text-underline
Oct 29, 2025
Merged

feat(models): add underline to rich text section block element#1771
zimeg merged 1 commit into
mainfrom
zimeg-feat-models-rich-text-underline

Conversation

@zimeg

@zimegzimeg commented Oct 22, 2025

Copy link
Copy Markdown
Member

Summary

This PR adds underline to the rich text section block element style.

Testing

This snippet might be useful in testing:

fromslack_sdk.models.blocksimport (
RichTextBlock,
RichTextElementParts,
RichTextSectionElement,
)
client.chat_postMessage(
channel=channel_id,
blocks=[
RichTextBlock(
elements=[
RichTextSectionElement(
elements=[
RichTextElementParts.Text(
text="important",
style=RichTextElementParts.TextStyle(
bold=True,
underline=True,
),
),
],
),
],
)
],
)

Category

  • slack_sdk.models (UI component builders)

Notes

🏁 This style has not been released to all teams yet! Hoping to have this ready to release when this does go public!

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@zimegzimeg added this to the 3.38.0 milestone Oct 22, 2025
@zimegzimeg self-assigned this Oct 22, 2025
@zimegzimeg added enhancement M-T: A feature request for new functionality Version: 3x labels Oct 22, 2025
@codecov

codecovBot commented Oct 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.15%. Comparing base (e9e64d8) to head (25e9ec7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #1771 +/- ##
=======================================
Coverage 85.15% 85.15% =======================================
Files 115 115 Lines 13068 13069 +1 =======================================
+ Hits 11128 11129 +1 
Misses 1940 1940 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamBergaminWilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise 🚀

@mwbrooksmwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅🏻 Yay! Great to see Underline support coming out!

@zimeg

Copy link
Copy Markdown
MemberAuthor

@WilliamBergamin@mwbrooks I share kind agreement of this excitement so let's merge this now for an upcoming release 👾 ✨

@zimeg
zimeg merged commit e5a2825 into mainOct 29, 2025
13 checks passed
@zimeg
zimeg deleted the zimeg-feat-models-rich-text-underline branch October 29, 2025 03:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementM-T: A feature request for new functionalityVersion: 3x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@zimeg@mwbrooks@WilliamBergamin