Uh oh!
There was an error while loading. Please reload this page.
fix: resolve OAuth installation store bugs and typos - #1864
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@## main #1864 +/- ##
==========================================
- Coverage 84.01% 83.97% -0.04%
==========================================
Files 117 117 Lines 13256 13257 +1 ==========================================
- Hits 11137 11133 -4 - Misses 2119 2124 +5 ☔ View full report in Codecov by Sentry. |
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin LGTM but before merging might the PR title describe the guarded cache removal more?
WilliamBergamin
commented
Apr 28, 2026
@zimeg good catch my PR title changed due to follow up commits |
Uh oh!
There was an error while loading. Please reload this page.
Summary
KeyErrorinAsyncCacheableInstallationStore.async_delete_botwhen deleting a bot that isn't cached (aligns with sync version's guard)"Failed to find bot installation data"instead of"Failed to delete""absense"→"absence"in log messages across file, S3, and SQLite3 installation storesTesting
CI coverage should be sufficient
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.