Skip to content

fix: address lipgloss styling gaps - #391

Merged
srtaalej merged 4 commits into
mainfrom
charm-review-feedback
Mar 12, 2026
Merged

fix: address lipgloss styling gaps#391
srtaalej merged 4 commits into
mainfrom
charm-review-feedback

Conversation

@srtaalej

Copy link
Copy Markdown
Contributor

Summary

  • Fix Warning() rendering in slackGreen instead of slackYellow under the charm experiment
  • Migrate last Styler().Red()/Styler().Green() calls in cmd/sandbox/list.go to
    style.Red()/style.Green()

Context

Follow-up from PR #365 (charm-lipgloss-migration) addressing deferred review feedback.

Test plan

  • Run go test ./internal/style/... ./cmd/sandbox/... — all pass
  • Verify Warning() renders yellow (not green) with charm enabled
  • Verify sandbox list status colors (red for archived, green for active) render correctly

Requirements

@srtaalejsrtaalej added this to the Next Release milestone Mar 11, 2026
@srtaalejsrtaalej self-assigned this Mar 11, 2026
@srtaalej
srtaalej requested a review from a team as a code ownerMarch 11, 2026 20:52
@srtaalejsrtaalej added experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment labels Mar 11, 2026
@codecov

codecovBot commented Mar 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.00%. Comparing base (ca87f1d) to head (1393151).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #391 +/- ##
==========================================
+ Coverage 66.97% 67.00% +0.03% 
==========================================
Files 218 218 Lines 18090 18090 ==========================================
+ Hits 12116 12122 +6 + Misses 4837 4831 -6 
Partials 1137 1137 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooksmwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good on my side! 💅🏻

@srtaalej
srtaalej merged commit 4d5f768 into mainMar 12, 2026
8 checks passed
@srtaalej
srtaalej deleted the charm-review-feedback branch March 12, 2026 16:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimentExperimental feature accessed behind the --experiment flag or togglesemver:patchUse on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@srtaalej@mwbrooks