Uh oh!
There was an error while loading. Please reload this page.
test: increase test coverage for slackerror - #413
Conversation
Rename Test_AppendMessage to Test_Error_AppendMessage to follow the Test_StructName_FunctionName convention for struct methods. Reorder Test_Error_AppendMessage, Test_Is, and Test_IsErrorType to their correct alphabetical positions in the file.
mwbrooks
left a comment
There was a problem hiding this comment.
Sharing a few comments for the brave reviewers!
| # macOS | ||
| .DS_Store | ||
| # For GoLand users |
There was a problem hiding this comment.
note: Just updating the comment to be consistent with the other comments
| # For GoLand users | ||
| # Git | ||
| .worktrees/ |
There was a problem hiding this comment.
note: Hope this is alright, but I'm starting to store my git worktrees in slack-cli/.worktrees/ and it would be nice to ignore that directory.
There was a problem hiding this comment.
🌲 praise: @mwbrooks All things in iteration! Let's keep track of changes in commits instead, I agree.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #413 +/- ##
==========================================
+ Coverage 68.34% 68.44% +0.09%
==========================================
Files 218 218 Lines 18058 18058 ==========================================
+ Hits 12341 12359 +18 + Misses 4565 4541 -24 - Partials 1152 1158 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }{ | ||
| "returns true when error contains the code": { | ||
| err: New(ErrAccessDenied), | ||
| errorCode: ErrAccessDenied, |
| # For GoLand users | ||
| # Git | ||
| .worktrees/ |
There was a problem hiding this comment.
🌲 praise: @mwbrooks All things in iteration! Let's keep track of changes in commits instead, I agree.
mwbrooks
commented
Mar 18, 2026
@zimeg Thanks for the quick review! 🙇🏻 I'll continue to try to keep these test coverage PRs smaller, so they aren't a burden to look over 😄 |
Changelog
Summary
This pull request increases the test coverage of the
internal/slackerrorpackage. It's a very small code coverage bump, but I wanted to keep the lines of code low. I'll follow-up with more PRs in the future!All test functions match our new naming and ordering conventions.
Requirements