Uh oh!
There was an error while loading. Please reload this page.
test: increase test coverage for slackhttp and update - #416
Merged
Conversation
Rename test functions to use full struct name (Test_UpdateNotification_*) and reorder alphabetically by base method name with getter/setter grouping.
mwbrooks
marked this pull request as ready for review
March 19, 2026 05:28
zimeg
approved these changes
Mar 19, 2026
| func Test_Update_isIgnoredCommand(t *testing.T) { | ||
| func Test_UpdateNotification_SetHours(t *testing.T) { | ||
| u := &UpdateNotification{} | ||
| u.SetHours(48.0) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #416 +/- ##
==========================================
+ Coverage 68.52% 68.58% +0.06%
==========================================
Files 218 218 Lines 18162 18162 ==========================================
+ Hits 12446 12457 +11 + Misses 4554 4542 -12 - Partials 1162 1163 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
commented
Mar 19, 2026
MemberAuthor
Uh oh!
There was an error while loading. Please reload this page.
zimeg pushed a commit
that referenced
this pull request
Mar 19, 2026
* test: increase test coverage for slackhttp and update * test: rename and reorder update test functions to match conventions Rename test functions to use full struct name (Test_UpdateNotification_*) and reorder alphabetically by base method name with getter/setter grouping.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This pull request increases our test coverage for the
internal/slackhttpandinternal/updatepackages. This is a very small code coverage bump, but something-something about slow-and-steady. 🏁 🐢 💨 🍃Requirements