Uh oh!
There was an error while loading. Please reload this page.
test: increase test coverage for activity package event routing - #420
Merged
Conversation
…outing Add tests for prettifyActivity event type routing to verify all EventType cases in the switch statement dispatch to the correct formatting functions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #420 +/- ##
==========================================
+ Coverage 69.49% 69.74% +0.24%
==========================================
Files 220 220 Lines 18446 18446 ==========================================
+ Hits 12819 12865 +46 + Misses 4453 4409 -44 + Partials 1174 1172 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
marked this pull request as ready for review
March 19, 2026 21:41
zimeg
approved these changes
Mar 20, 2026
| } | ||
| } | ||
| func Test_prettifyActivity_allEventTypes(t *testing.T) { |
Resolve conflict in activity_test.go by keeping both the prettifyActivity routing tests (HEAD) and individual function tests (origin/main).
mwbrooks
commented
Mar 20, 2026
MemberAuthor
@zimeg Thank you again for your tireless reviews of my test coverage pull requests 😆 Happy to see this one land! From here, I'll need to take a step back to see where I can focus next. ⛰️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This pull request increasing test coverage for the
internal/pkg/platform/activitypackage.prettifyActivityevent type routing to verify event typesprettifyActivitycoverage from 33.3% to 97.0%Requirements