Skip to content

test: support fish deploy hook checks - #561

Draft
Muhtasham wants to merge 1 commit into
slackapi:mainfrom
Muhtasham:codex/fix-deploy-hook-fish-tests
Draft

test: support fish deploy hook checks#561
Muhtasham wants to merge 1 commit into
slackapi:mainfrom
Muhtasham:codex/fix-deploy-hook-fish-tests

Conversation

@Muhtasham

Copy link
Copy Markdown

Changelog

N/A - Testing changes.

Summary

Fixes#462 by making the deploy hook test expectations work when the test process runs with SHELL set to fish.

The stderr hook case now uses redirection syntax that works in fish and POSIX-like shells, and the missing deployer case accepts fish's Unknown command wording in addition to the existing shell-specific messages.

Validation

  • PATH="/opt/homebrew/bin:$PATH" SHELL=/opt/homebrew/bin/fish go test ./cmd/platform -count=1
  • PATH="/opt/homebrew/bin:$PATH" SHELL=/bin/bash go test ./cmd/platform -count=1
  • PATH="/opt/homebrew/bin:$PATH" SHELL=/opt/homebrew/bin/fish go test ./...

Requirements

@salesforce-clasalesforce-claBot added the cla:missing The CLA was not signed label May 24, 2026
@salesforce-cla

Copy link
Copy Markdown

Thanks for the contribution! Before we can merge this, we need @Muhtasham to sign the Salesforce Inc. Contributor License Agreement.

@MuhtashamMuhtasham changed the title [codex] test: support fish deploy hook checkstest: support fish deploy hook checksMay 24, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:missingThe CLA was not signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fail when using fish (and possibly other shells)

1 participant

@Muhtasham