Skip to content

ci: use idempotent labels when creating a release candidate pull request - #578

Merged
zimeg merged 1 commit into
mainfrom
zimeg-patch-1
Jun 4, 2026
Merged

ci: use idempotent labels when creating a release candidate pull request#578
zimeg merged 1 commit into
mainfrom
zimeg-patch-1

Conversation

@zimeg

@zimegzimeg commented Jun 4, 2026

Copy link
Copy Markdown
Member

Changelog

N/A - We're testing RC in "production" it seems...

Summary

This PR follows #558 to use idempotent labels when creating a release candidate pull request instead of attempting to add labels to a new request.

Preview

Error: https://github.com/slackapi/slack-cli/actions/runs/26968804619/job/79578379382

unknown flag: --add-label

Testing

Sharing here with findings 🫡

Notes

The "remove" tag and "add" tag in updated PRs causes clutter but might be separate to follow up on I think!

Requirements

@zimegzimeg added this to the Next Release milestone Jun 4, 2026
@zimegzimeg self-assigned this Jun 4, 2026
@zimeg
zimeg requested a review from a team as a code ownerJune 4, 2026 17:43
@zimegzimeg added semver:patch Use on pull requests to describe the release version increment build M-T: Changes to compilation and CI processes labels Jun 4, 2026
@zimeg
zimeg merged commit 711bfee into mainJun 4, 2026
7 checks passed
@zimeg
zimeg deleted the zimeg-patch-1 branch June 4, 2026 17:43
@zimeg

zimeg commented Jun 4, 2026

Copy link
Copy Markdown
MemberAuthor

🚢 Fast merge to follow up as needed!

@zimeg

zimeg commented Jun 4, 2026

Copy link
Copy Markdown
MemberAuthor

🥂 Success: #579

@codecov

codecovBot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.67%. Comparing base (8bd01fe) to head (4474887).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #578 +/- ##
==========================================
+ Coverage 71.66% 71.67% +0.01% 
==========================================
Files 226 226 Lines 19148 19148 ==========================================
+ Hits 13723 13725 +2 - Misses 4216 4217 +1 + Partials 1209 1206 -3 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildM-T: Changes to compilation and CI processessemver:patchUse on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@zimeg