Skip to content

Build Docker images using goreleaser-pro instead of make - #1230

Open
tashian wants to merge 2 commits into
masterfrom
carl/docker-goreleaser
Open

Build Docker images using goreleaser-pro instead of make#1230
tashian wants to merge 2 commits into
masterfrom
carl/docker-goreleaser

Conversation

@tashian

@tashiantashian commented Jul 10, 2024

Copy link
Copy Markdown
Member

Note: We need to wait for a release of GoReleaser Pro before we can merge this.

This PR builds bin/step using the same GoReleaser Pro workflow as in other parts of the CI system:

goreleaser build \
--id default \
--single-target \
--auto-snapshot \
--clean \
--output bin/step

It should use the version number from the most recent tag.
The --auto-snapshot flag appends -next to the version number if the git repo is dirty.

The --single-target flag builds for the current GOOS, GOARCH, and GOARM only.

  • Test that Docker images build properly across different platforms
  • Do a prerelease build, to see the whole thing working properly

@github-actionsgithub-actionsBot added the needs triage Waiting for discussion / prioritization by team label Jul 10, 2024
@tashian
tashian requested a review from dopeyJuly 10, 2024 19:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triageWaiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tashian@dopey