Skip to content

change mmap return MAP_FAILED on error and set errno - #125

Merged
AndreCostaaa merged 1 commit into
smartobjectoriented:mainfrom
clemdiep:124-mmap-return-map-failed
Mar 6, 2025
Merged

change mmap return MAP_FAILED on error and set errno#125
AndreCostaaa merged 1 commit into
smartobjectoriented:mainfrom
clemdiep:124-mmap-return-map-failed

Conversation

@clemdiep

@clemdiepclemdiep commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

close#124

@clemdiep

clemdiep commented Feb 19, 2025

Copy link
Copy Markdown
ContributorAuthor

Put the PR in draft as it's a follow up of #122, so should be merge only after it.

Actual change of this branch can be seen in last commit for now.

@clemdiep
clemdiepforce-pushed the 124-mmap-return-map-failed branch from 2528adc to 3c6403cCompareFebruary 19, 2025 12:41
@clemdiep
clemdiep marked this pull request as ready for review February 19, 2025 12:42
@clemdiep

clemdiep commented Feb 19, 2025

Copy link
Copy Markdown
ContributorAuthor

It's now ready for review!

daniel-rossier
daniel-rossier approved these changes Mar 5, 2025
View reviewed changes

@daniel-rossierdaniel-rossier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean, thank you!

AndreCostaaa
AndreCostaaa reviewed Mar 5, 2025
View reviewed changes

@AndreCostaaaAndreCostaaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @clemdiep, thank you for your PR and sorry for the delay in getting this merged

There's a lot of changes to user space live in main now, could you rebase your branch ?

With these new updates the only call to mmap in usr space is located inside usr/lib/slv/slv_fb.c and the files inside stress and widgets should no longer exist so you're free to remove them to resolve the conflicts :)

If you need any pointers in order to finish this PR let me know ! 🚀

Comment threadusr/src/widgets/demofb.c
Comment threadusr/src/stress/lvgl_perf.c Outdated
@AndreCostaaaAndreCostaaa mentioned this pull request Mar 5, 2025
Merged
@clemdiep
clemdiepforce-pushed the 124-mmap-return-map-failed branch from 3c6403c to 1780ae2CompareMarch 6, 2025 07:17
@clemdiepclemdiep mentioned this pull request Mar 6, 2025
Merged
@AndreCostaaa

AndreCostaaa commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Thank you !

@AndreCostaaa
AndreCostaaa merged commit 88a79b8 into smartobjectoriented:mainMar 6, 2025
@clemdiep
clemdiep deleted the 124-mmap-return-map-failed branch March 6, 2025 07:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreCostaaaAndreCostaaaAndreCostaaa left review comments
@daniel-rossierdaniel-rossierdaniel-rossier approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mmap should return MAP_FAILED (-1) on error

3 participants

@clemdiep@AndreCostaaa@daniel-rossier