Eliminating unneeded dependencies in the build config#122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewdavidsmith merged 2 commits into from
Aug 31, 2026
+16 −106
Merged

Eliminating unneeded dependencies in the build config #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5075f4e
CMakeLists.txt: fixing link interfaces to remove unneeded dependencies
andrewdavidsmith Aug 31, 2026
87cb028
src/falco_file_format.hcpp: removing unused function and adding a header
andrewdavidsmith Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 14 additions & 91 deletions CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,126 +80,49 @@ endif()
add_library(adapter_set OBJECT src/adapter_set.cpp)
add_library(falco_utils OBJECT src/falco_utils.cpp)
add_library(base_groups OBJECT src/base_groups.cpp)

add_library(bgzf_block OBJECT src/bgzf_block.cpp)
target_link_libraries(bgzf_block PUBLIC LIBDEFLATE::LIBDEFLATE)

add_library(bgzf_reader OBJECT src/bgzf_reader.cpp)
target_link_libraries(bgzf_reader PUBLIC bgzf_block)

add_library(fastq_file OBJECT src/fastq_file.cpp)
target_link_libraries(fastq_file PUBLIC HTSLIB::HTSLIB)

add_library(fastq_gz_file OBJECT src/fastq_gz_file.cpp)
target_link_libraries(fastq_gz_file PUBLIC HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_library(fastq_bgzf_file OBJECT src/fastq_bgzf_file.cpp)
target_link_libraries(fastq_bgzf_file PUBLIC
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)

add_library(bam_header OBJECT src/bam_header.cpp)

add_library(bamrec OBJECT src/bamrec.cpp)
add_library(bam_file OBJECT src/bam_file.cpp)
target_link_libraries(bam_file PUBLIC HTSLIB::HTSLIB)

add_library(samrec OBJECT src/samrec.cpp)
add_library(sam_file OBJECT src/sam_file.cpp)
target_link_libraries(sam_file PUBLIC HTSLIB::HTSLIB)

add_library(falco_file_format OBJECT src/falco_file_format.cpp)
target_link_libraries(falco_file_format PUBLIC HTSLIB::HTSLIB)

add_library(quality_score OBJECT src/quality_score.cpp)
target_link_libraries(quality_score PUBLIC falco_file_format)

add_library(tile_processor OBJECT src/tile_processor.cpp)
target_link_libraries(tile_processor PUBLIC
falco_file_format
HTSLIB::HTSLIB
)

add_library(falco_grade OBJECT src/falco_grade.cpp)
target_link_libraries(falco_grade PUBLIC
falco_utils
quality_score
)

add_library(kmer_counter OBJECT src/kmer_counter.cpp)
target_link_libraries(kmer_counter PUBLIC
falco_grade
falco_utils
)

add_library(contaminants OBJECT src/contaminants.cpp)

add_library(duplication_results OBJECT src/duplication_results.cpp)
target_link_libraries(duplication_results PUBLIC
falco_grade
falco_utils
contaminants
)

add_library(adapter_matcher OBJECT src/adapter_matcher.cpp)
target_link_libraries(adapter_matcher PUBLIC
falco_utils
falco_grade
adapter_set
)

add_library(report OBJECT src/report.cpp)
target_link_libraries(report PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(html OBJECT src/html.cpp)
target_link_libraries(html PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(results_collector INTERFACE)
target_link_libraries(results_collector INTERFACE fastq_file)

add_library(results_summary OBJECT src/results_summary.cpp)
target_link_libraries(results_summary PUBLIC
adapter_matcher
duplication_results
falco_grade
falco_utils
html
kmer_counter
quality_score
report
tile_processor
results_collector
)

add_library(falco_analyzer OBJECT src/falco_analyzer.cpp)
# ADS: not sure why the line below is needed on some systems, but dependencies
# in this file are a mess
target_link_libraries(falco_analyzer PUBLIC HTSLIB::HTSLIB)

add_library(get_binary_dir OBJECT src/get_binary_dir.cpp)
add_library(run_mode OBJECT src/run_mode.cpp)
add_library(falco_config OBJECT src/falco_config.cpp)
target_link_libraries(falco_config PUBLIC run_mode)

add_library(original_duplicates OBJECT src/original_duplicates.cpp)
target_link_libraries(original_duplicates PUBLIC HTSLIB::HTSLIB)

target_link_libraries(bgzf_block PRIVATE LIBDEFLATE::LIBDEFLATE)
target_link_libraries(fastq_bgzf_file PRIVATE
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)
target_link_libraries(bam_file PRIVATE HTSLIB::HTSLIB)
target_link_libraries(falco_file_format PRIVATE HTSLIB::HTSLIB)
target_link_libraries(tile_processor PRIVATE HTSLIB::HTSLIB)
target_link_libraries(fastq_gz_file PRIVATE HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_executable(falco src/falco.cpp)
target_link_libraries(falco PUBLIC
target_link_libraries(falco PRIVATE
tile_processor
contaminants
adapter_matcher
Expand Down
2 changes: 2 additions & 0 deletions src/falco_file_format.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@

#include "falco_file_format.hpp"

#include <htslib/sam.h>

#include <array>
#include <cstdlib>
#include <filesystem>
Expand Down
15 changes: 0 additions & 15 deletions src/falco_file_format.hpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

#include "nlohmann/json.hpp"

#include <htslib/sam.h>

#include <cstdint>
#include <format>
#include <iterator>
Expand DownExpand Up@@ -70,19 +68,6 @@ struct std::formatter<falco::file_format> : std::formatter<std::string> {
}
};

// ADS: unused?
[[nodiscard]] constexpr auto
is_sequence_data(const auto hts_fp) -> bool {
return hts_get_format(hts_fp)->category == sequence_data;
}

[[nodiscard]] constexpr auto
is_sequence_data(const std::string &filename) -> bool {
using hts_file_unique_ptr = std::unique_ptr<htsFile, int (*)(htsFile *)>;
hts_file_unique_ptr fp(hts_open(std::data(filename), "r"), &hts_close);
return is_sequence_data(fp.get());
}

[[nodiscard]] auto
get_file_format(const std::string &filename)
-> std::tuple<falco::file_format, std::string>;
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Eliminating unneeded dependencies in the build config#122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewdavidsmith merged 2 commits into from
Aug 31, 2026
+16 −106
Merged

Eliminating unneeded dependencies in the build config #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5075f4e
CMakeLists.txt: fixing link interfaces to remove unneeded dependencies
andrewdavidsmith Aug 31, 2026
87cb028
src/falco_file_format.hcpp: removing unused function and adding a header
andrewdavidsmith Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 14 additions & 91 deletions CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,126 +80,49 @@ endif()
add_library(adapter_set OBJECT src/adapter_set.cpp)
add_library(falco_utils OBJECT src/falco_utils.cpp)
add_library(base_groups OBJECT src/base_groups.cpp)

add_library(bgzf_block OBJECT src/bgzf_block.cpp)
target_link_libraries(bgzf_block PUBLIC LIBDEFLATE::LIBDEFLATE)

add_library(bgzf_reader OBJECT src/bgzf_reader.cpp)
target_link_libraries(bgzf_reader PUBLIC bgzf_block)

add_library(fastq_file OBJECT src/fastq_file.cpp)
target_link_libraries(fastq_file PUBLIC HTSLIB::HTSLIB)

add_library(fastq_gz_file OBJECT src/fastq_gz_file.cpp)
target_link_libraries(fastq_gz_file PUBLIC HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_library(fastq_bgzf_file OBJECT src/fastq_bgzf_file.cpp)
target_link_libraries(fastq_bgzf_file PUBLIC
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)

add_library(bam_header OBJECT src/bam_header.cpp)

add_library(bamrec OBJECT src/bamrec.cpp)
add_library(bam_file OBJECT src/bam_file.cpp)
target_link_libraries(bam_file PUBLIC HTSLIB::HTSLIB)

add_library(samrec OBJECT src/samrec.cpp)
add_library(sam_file OBJECT src/sam_file.cpp)
target_link_libraries(sam_file PUBLIC HTSLIB::HTSLIB)

add_library(falco_file_format OBJECT src/falco_file_format.cpp)
target_link_libraries(falco_file_format PUBLIC HTSLIB::HTSLIB)

add_library(quality_score OBJECT src/quality_score.cpp)
target_link_libraries(quality_score PUBLIC falco_file_format)

add_library(tile_processor OBJECT src/tile_processor.cpp)
target_link_libraries(tile_processor PUBLIC
falco_file_format
HTSLIB::HTSLIB
)

add_library(falco_grade OBJECT src/falco_grade.cpp)
target_link_libraries(falco_grade PUBLIC
falco_utils
quality_score
)

add_library(kmer_counter OBJECT src/kmer_counter.cpp)
target_link_libraries(kmer_counter PUBLIC
falco_grade
falco_utils
)

add_library(contaminants OBJECT src/contaminants.cpp)

add_library(duplication_results OBJECT src/duplication_results.cpp)
target_link_libraries(duplication_results PUBLIC
falco_grade
falco_utils
contaminants
)

add_library(adapter_matcher OBJECT src/adapter_matcher.cpp)
target_link_libraries(adapter_matcher PUBLIC
falco_utils
falco_grade
adapter_set
)

add_library(report OBJECT src/report.cpp)
target_link_libraries(report PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(html OBJECT src/html.cpp)
target_link_libraries(html PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(results_collector INTERFACE)
target_link_libraries(results_collector INTERFACE fastq_file)

add_library(results_summary OBJECT src/results_summary.cpp)
target_link_libraries(results_summary PUBLIC
adapter_matcher
duplication_results
falco_grade
falco_utils
html
kmer_counter
quality_score
report
tile_processor
results_collector
)

add_library(falco_analyzer OBJECT src/falco_analyzer.cpp)
# ADS: not sure why the line below is needed on some systems, but dependencies
# in this file are a mess
target_link_libraries(falco_analyzer PUBLIC HTSLIB::HTSLIB)

add_library(get_binary_dir OBJECT src/get_binary_dir.cpp)
add_library(run_mode OBJECT src/run_mode.cpp)
add_library(falco_config OBJECT src/falco_config.cpp)
target_link_libraries(falco_config PUBLIC run_mode)

add_library(original_duplicates OBJECT src/original_duplicates.cpp)
target_link_libraries(original_duplicates PUBLIC HTSLIB::HTSLIB)

target_link_libraries(bgzf_block PRIVATE LIBDEFLATE::LIBDEFLATE)
target_link_libraries(fastq_bgzf_file PRIVATE
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)
target_link_libraries(bam_file PRIVATE HTSLIB::HTSLIB)
target_link_libraries(falco_file_format PRIVATE HTSLIB::HTSLIB)
target_link_libraries(tile_processor PRIVATE HTSLIB::HTSLIB)
target_link_libraries(fastq_gz_file PRIVATE HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_executable(falco src/falco.cpp)
target_link_libraries(falco PUBLIC
target_link_libraries(falco PRIVATE
tile_processor
contaminants
adapter_matcher
Expand Down
2 changes: 2 additions & 0 deletions src/falco_file_format.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@

#include "falco_file_format.hpp"

#include <htslib/sam.h>

#include <array>
#include <cstdlib>
#include <filesystem>
Expand Down
15 changes: 0 additions & 15 deletions src/falco_file_format.hpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

#include "nlohmann/json.hpp"

#include <htslib/sam.h>

#include <cstdint>
#include <format>
#include <iterator>
Expand DownExpand Up@@ -70,19 +68,6 @@ struct std::formatter<falco::file_format> : std::formatter<std::string> {
}
};

// ADS: unused?
[[nodiscard]] constexpr auto
is_sequence_data(const auto hts_fp) -> bool {
return hts_get_format(hts_fp)->category == sequence_data;
}

[[nodiscard]] constexpr auto
is_sequence_data(const std::string &filename) -> bool {
using hts_file_unique_ptr = std::unique_ptr<htsFile, int (*)(htsFile *)>;
hts_file_unique_ptr fp(hts_open(std::data(filename), "r"), &hts_close);
return is_sequence_data(fp.get());
}

[[nodiscard]] auto
get_file_format(const std::string &filename)
-> std::tuple<falco::file_format, std::string>;
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Eliminating unneeded dependencies in the build config#122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewdavidsmith merged 2 commits into from
Aug 31, 2026
+16 −106
Merged

Eliminating unneeded dependencies in the build config #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5075f4e
CMakeLists.txt: fixing link interfaces to remove unneeded dependencies
andrewdavidsmith Aug 31, 2026
87cb028
src/falco_file_format.hcpp: removing unused function and adding a header
andrewdavidsmith Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 14 additions & 91 deletions CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,126 +80,49 @@ endif()
add_library(adapter_set OBJECT src/adapter_set.cpp)
add_library(falco_utils OBJECT src/falco_utils.cpp)
add_library(base_groups OBJECT src/base_groups.cpp)

add_library(bgzf_block OBJECT src/bgzf_block.cpp)
target_link_libraries(bgzf_block PUBLIC LIBDEFLATE::LIBDEFLATE)

add_library(bgzf_reader OBJECT src/bgzf_reader.cpp)
target_link_libraries(bgzf_reader PUBLIC bgzf_block)

add_library(fastq_file OBJECT src/fastq_file.cpp)
target_link_libraries(fastq_file PUBLIC HTSLIB::HTSLIB)

add_library(fastq_gz_file OBJECT src/fastq_gz_file.cpp)
target_link_libraries(fastq_gz_file PUBLIC HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_library(fastq_bgzf_file OBJECT src/fastq_bgzf_file.cpp)
target_link_libraries(fastq_bgzf_file PUBLIC
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)

add_library(bam_header OBJECT src/bam_header.cpp)

add_library(bamrec OBJECT src/bamrec.cpp)
add_library(bam_file OBJECT src/bam_file.cpp)
target_link_libraries(bam_file PUBLIC HTSLIB::HTSLIB)

add_library(samrec OBJECT src/samrec.cpp)
add_library(sam_file OBJECT src/sam_file.cpp)
target_link_libraries(sam_file PUBLIC HTSLIB::HTSLIB)

add_library(falco_file_format OBJECT src/falco_file_format.cpp)
target_link_libraries(falco_file_format PUBLIC HTSLIB::HTSLIB)

add_library(quality_score OBJECT src/quality_score.cpp)
target_link_libraries(quality_score PUBLIC falco_file_format)

add_library(tile_processor OBJECT src/tile_processor.cpp)
target_link_libraries(tile_processor PUBLIC
falco_file_format
HTSLIB::HTSLIB
)

add_library(falco_grade OBJECT src/falco_grade.cpp)
target_link_libraries(falco_grade PUBLIC
falco_utils
quality_score
)

add_library(kmer_counter OBJECT src/kmer_counter.cpp)
target_link_libraries(kmer_counter PUBLIC
falco_grade
falco_utils
)

add_library(contaminants OBJECT src/contaminants.cpp)

add_library(duplication_results OBJECT src/duplication_results.cpp)
target_link_libraries(duplication_results PUBLIC
falco_grade
falco_utils
contaminants
)

add_library(adapter_matcher OBJECT src/adapter_matcher.cpp)
target_link_libraries(adapter_matcher PUBLIC
falco_utils
falco_grade
adapter_set
)

add_library(report OBJECT src/report.cpp)
target_link_libraries(report PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(html OBJECT src/html.cpp)
target_link_libraries(html PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(results_collector INTERFACE)
target_link_libraries(results_collector INTERFACE fastq_file)

add_library(results_summary OBJECT src/results_summary.cpp)
target_link_libraries(results_summary PUBLIC
adapter_matcher
duplication_results
falco_grade
falco_utils
html
kmer_counter
quality_score
report
tile_processor
results_collector
)

add_library(falco_analyzer OBJECT src/falco_analyzer.cpp)
# ADS: not sure why the line below is needed on some systems, but dependencies
# in this file are a mess
target_link_libraries(falco_analyzer PUBLIC HTSLIB::HTSLIB)

add_library(get_binary_dir OBJECT src/get_binary_dir.cpp)
add_library(run_mode OBJECT src/run_mode.cpp)
add_library(falco_config OBJECT src/falco_config.cpp)
target_link_libraries(falco_config PUBLIC run_mode)

add_library(original_duplicates OBJECT src/original_duplicates.cpp)
target_link_libraries(original_duplicates PUBLIC HTSLIB::HTSLIB)

target_link_libraries(bgzf_block PRIVATE LIBDEFLATE::LIBDEFLATE)
target_link_libraries(fastq_bgzf_file PRIVATE
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)
target_link_libraries(bam_file PRIVATE HTSLIB::HTSLIB)
target_link_libraries(falco_file_format PRIVATE HTSLIB::HTSLIB)
target_link_libraries(tile_processor PRIVATE HTSLIB::HTSLIB)
target_link_libraries(fastq_gz_file PRIVATE HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_executable(falco src/falco.cpp)
target_link_libraries(falco PUBLIC
target_link_libraries(falco PRIVATE
tile_processor
contaminants
adapter_matcher
Expand Down
2 changes: 2 additions & 0 deletions src/falco_file_format.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@

#include "falco_file_format.hpp"

#include <htslib/sam.h>

#include <array>
#include <cstdlib>
#include <filesystem>
Expand Down
15 changes: 0 additions & 15 deletions src/falco_file_format.hpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

#include "nlohmann/json.hpp"

#include <htslib/sam.h>

#include <cstdint>
#include <format>
#include <iterator>
Expand DownExpand Up@@ -70,19 +68,6 @@ struct std::formatter<falco::file_format> : std::formatter<std::string> {
}
};

// ADS: unused?
[[nodiscard]] constexpr auto
is_sequence_data(const auto hts_fp) -> bool {
return hts_get_format(hts_fp)->category == sequence_data;
}

[[nodiscard]] constexpr auto
is_sequence_data(const std::string &filename) -> bool {
using hts_file_unique_ptr = std::unique_ptr<htsFile, int (*)(htsFile *)>;
hts_file_unique_ptr fp(hts_open(std::data(filename), "r"), &hts_close);
return is_sequence_data(fp.get());
}

[[nodiscard]] auto
get_file_format(const std::string &filename)
-> std::tuple<falco::file_format, std::string>;
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Eliminating unneeded dependencies in the build config#122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewdavidsmith merged 2 commits into from
Aug 31, 2026
+16 −106
Merged

Eliminating unneeded dependencies in the build config #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5075f4e
CMakeLists.txt: fixing link interfaces to remove unneeded dependencies
andrewdavidsmith Aug 31, 2026
87cb028
src/falco_file_format.hcpp: removing unused function and adding a header
andrewdavidsmith Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 14 additions & 91 deletions CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,126 +80,49 @@ endif()
add_library(adapter_set OBJECT src/adapter_set.cpp)
add_library(falco_utils OBJECT src/falco_utils.cpp)
add_library(base_groups OBJECT src/base_groups.cpp)

add_library(bgzf_block OBJECT src/bgzf_block.cpp)
target_link_libraries(bgzf_block PUBLIC LIBDEFLATE::LIBDEFLATE)

add_library(bgzf_reader OBJECT src/bgzf_reader.cpp)
target_link_libraries(bgzf_reader PUBLIC bgzf_block)

add_library(fastq_file OBJECT src/fastq_file.cpp)
target_link_libraries(fastq_file PUBLIC HTSLIB::HTSLIB)

add_library(fastq_gz_file OBJECT src/fastq_gz_file.cpp)
target_link_libraries(fastq_gz_file PUBLIC HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_library(fastq_bgzf_file OBJECT src/fastq_bgzf_file.cpp)
target_link_libraries(fastq_bgzf_file PUBLIC
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)

add_library(bam_header OBJECT src/bam_header.cpp)

add_library(bamrec OBJECT src/bamrec.cpp)
add_library(bam_file OBJECT src/bam_file.cpp)
target_link_libraries(bam_file PUBLIC HTSLIB::HTSLIB)

add_library(samrec OBJECT src/samrec.cpp)
add_library(sam_file OBJECT src/sam_file.cpp)
target_link_libraries(sam_file PUBLIC HTSLIB::HTSLIB)

add_library(falco_file_format OBJECT src/falco_file_format.cpp)
target_link_libraries(falco_file_format PUBLIC HTSLIB::HTSLIB)

add_library(quality_score OBJECT src/quality_score.cpp)
target_link_libraries(quality_score PUBLIC falco_file_format)

add_library(tile_processor OBJECT src/tile_processor.cpp)
target_link_libraries(tile_processor PUBLIC
falco_file_format
HTSLIB::HTSLIB
)

add_library(falco_grade OBJECT src/falco_grade.cpp)
target_link_libraries(falco_grade PUBLIC
falco_utils
quality_score
)

add_library(kmer_counter OBJECT src/kmer_counter.cpp)
target_link_libraries(kmer_counter PUBLIC
falco_grade
falco_utils
)

add_library(contaminants OBJECT src/contaminants.cpp)

add_library(duplication_results OBJECT src/duplication_results.cpp)
target_link_libraries(duplication_results PUBLIC
falco_grade
falco_utils
contaminants
)

add_library(adapter_matcher OBJECT src/adapter_matcher.cpp)
target_link_libraries(adapter_matcher PUBLIC
falco_utils
falco_grade
adapter_set
)

add_library(report OBJECT src/report.cpp)
target_link_libraries(report PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(html OBJECT src/html.cpp)
target_link_libraries(html PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(results_collector INTERFACE)
target_link_libraries(results_collector INTERFACE fastq_file)

add_library(results_summary OBJECT src/results_summary.cpp)
target_link_libraries(results_summary PUBLIC
adapter_matcher
duplication_results
falco_grade
falco_utils
html
kmer_counter
quality_score
report
tile_processor
results_collector
)

add_library(falco_analyzer OBJECT src/falco_analyzer.cpp)
# ADS: not sure why the line below is needed on some systems, but dependencies
# in this file are a mess
target_link_libraries(falco_analyzer PUBLIC HTSLIB::HTSLIB)

add_library(get_binary_dir OBJECT src/get_binary_dir.cpp)
add_library(run_mode OBJECT src/run_mode.cpp)
add_library(falco_config OBJECT src/falco_config.cpp)
target_link_libraries(falco_config PUBLIC run_mode)

add_library(original_duplicates OBJECT src/original_duplicates.cpp)
target_link_libraries(original_duplicates PUBLIC HTSLIB::HTSLIB)

target_link_libraries(bgzf_block PRIVATE LIBDEFLATE::LIBDEFLATE)
target_link_libraries(fastq_bgzf_file PRIVATE
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)
target_link_libraries(bam_file PRIVATE HTSLIB::HTSLIB)
target_link_libraries(falco_file_format PRIVATE HTSLIB::HTSLIB)
target_link_libraries(tile_processor PRIVATE HTSLIB::HTSLIB)
target_link_libraries(fastq_gz_file PRIVATE HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_executable(falco src/falco.cpp)
target_link_libraries(falco PUBLIC
target_link_libraries(falco PRIVATE
tile_processor
contaminants
adapter_matcher
Expand Down
2 changes: 2 additions & 0 deletions src/falco_file_format.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@

#include "falco_file_format.hpp"

#include <htslib/sam.h>

#include <array>
#include <cstdlib>
#include <filesystem>
Expand Down
15 changes: 0 additions & 15 deletions src/falco_file_format.hpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

#include "nlohmann/json.hpp"

#include <htslib/sam.h>

#include <cstdint>
#include <format>
#include <iterator>
Expand DownExpand Up@@ -70,19 +68,6 @@ struct std::formatter<falco::file_format> : std::formatter<std::string> {
}
};

// ADS: unused?
[[nodiscard]] constexpr auto
is_sequence_data(const auto hts_fp) -> bool {
return hts_get_format(hts_fp)->category == sequence_data;
}

[[nodiscard]] constexpr auto
is_sequence_data(const std::string &filename) -> bool {
using hts_file_unique_ptr = std::unique_ptr<htsFile, int (*)(htsFile *)>;
hts_file_unique_ptr fp(hts_open(std::data(filename), "r"), &hts_close);
return is_sequence_data(fp.get());
}

[[nodiscard]] auto
get_file_format(const std::string &filename)
-> std::tuple<falco::file_format, std::string>;
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Eliminating unneeded dependencies in the build config#122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewdavidsmith merged 2 commits into from
Aug 31, 2026
+16 −106
Merged

Eliminating unneeded dependencies in the build config #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5075f4e
CMakeLists.txt: fixing link interfaces to remove unneeded dependencies
andrewdavidsmith Aug 31, 2026
87cb028
src/falco_file_format.hcpp: removing unused function and adding a header
andrewdavidsmith Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 14 additions & 91 deletions CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,126 +80,49 @@ endif()
add_library(adapter_set OBJECT src/adapter_set.cpp)
add_library(falco_utils OBJECT src/falco_utils.cpp)
add_library(base_groups OBJECT src/base_groups.cpp)

add_library(bgzf_block OBJECT src/bgzf_block.cpp)
target_link_libraries(bgzf_block PUBLIC LIBDEFLATE::LIBDEFLATE)

add_library(bgzf_reader OBJECT src/bgzf_reader.cpp)
target_link_libraries(bgzf_reader PUBLIC bgzf_block)

add_library(fastq_file OBJECT src/fastq_file.cpp)
target_link_libraries(fastq_file PUBLIC HTSLIB::HTSLIB)

add_library(fastq_gz_file OBJECT src/fastq_gz_file.cpp)
target_link_libraries(fastq_gz_file PUBLIC HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_library(fastq_bgzf_file OBJECT src/fastq_bgzf_file.cpp)
target_link_libraries(fastq_bgzf_file PUBLIC
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)

add_library(bam_header OBJECT src/bam_header.cpp)

add_library(bamrec OBJECT src/bamrec.cpp)
add_library(bam_file OBJECT src/bam_file.cpp)
target_link_libraries(bam_file PUBLIC HTSLIB::HTSLIB)

add_library(samrec OBJECT src/samrec.cpp)
add_library(sam_file OBJECT src/sam_file.cpp)
target_link_libraries(sam_file PUBLIC HTSLIB::HTSLIB)

add_library(falco_file_format OBJECT src/falco_file_format.cpp)
target_link_libraries(falco_file_format PUBLIC HTSLIB::HTSLIB)

add_library(quality_score OBJECT src/quality_score.cpp)
target_link_libraries(quality_score PUBLIC falco_file_format)

add_library(tile_processor OBJECT src/tile_processor.cpp)
target_link_libraries(tile_processor PUBLIC
falco_file_format
HTSLIB::HTSLIB
)

add_library(falco_grade OBJECT src/falco_grade.cpp)
target_link_libraries(falco_grade PUBLIC
falco_utils
quality_score
)

add_library(kmer_counter OBJECT src/kmer_counter.cpp)
target_link_libraries(kmer_counter PUBLIC
falco_grade
falco_utils
)

add_library(contaminants OBJECT src/contaminants.cpp)

add_library(duplication_results OBJECT src/duplication_results.cpp)
target_link_libraries(duplication_results PUBLIC
falco_grade
falco_utils
contaminants
)

add_library(adapter_matcher OBJECT src/adapter_matcher.cpp)
target_link_libraries(adapter_matcher PUBLIC
falco_utils
falco_grade
adapter_set
)

add_library(report OBJECT src/report.cpp)
target_link_libraries(report PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(html OBJECT src/html.cpp)
target_link_libraries(html PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(results_collector INTERFACE)
target_link_libraries(results_collector INTERFACE fastq_file)

add_library(results_summary OBJECT src/results_summary.cpp)
target_link_libraries(results_summary PUBLIC
adapter_matcher
duplication_results
falco_grade
falco_utils
html
kmer_counter
quality_score
report
tile_processor
results_collector
)

add_library(falco_analyzer OBJECT src/falco_analyzer.cpp)
# ADS: not sure why the line below is needed on some systems, but dependencies
# in this file are a mess
target_link_libraries(falco_analyzer PUBLIC HTSLIB::HTSLIB)

add_library(get_binary_dir OBJECT src/get_binary_dir.cpp)
add_library(run_mode OBJECT src/run_mode.cpp)
add_library(falco_config OBJECT src/falco_config.cpp)
target_link_libraries(falco_config PUBLIC run_mode)

add_library(original_duplicates OBJECT src/original_duplicates.cpp)
target_link_libraries(original_duplicates PUBLIC HTSLIB::HTSLIB)

target_link_libraries(bgzf_block PRIVATE LIBDEFLATE::LIBDEFLATE)
target_link_libraries(fastq_bgzf_file PRIVATE
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)
target_link_libraries(bam_file PRIVATE HTSLIB::HTSLIB)
target_link_libraries(falco_file_format PRIVATE HTSLIB::HTSLIB)
target_link_libraries(tile_processor PRIVATE HTSLIB::HTSLIB)
target_link_libraries(fastq_gz_file PRIVATE HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_executable(falco src/falco.cpp)
target_link_libraries(falco PUBLIC
target_link_libraries(falco PRIVATE
tile_processor
contaminants
adapter_matcher
Expand Down
2 changes: 2 additions & 0 deletions src/falco_file_format.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@

#include "falco_file_format.hpp"

#include <htslib/sam.h>

#include <array>
#include <cstdlib>
#include <filesystem>
Expand Down
15 changes: 0 additions & 15 deletions src/falco_file_format.hpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

#include "nlohmann/json.hpp"

#include <htslib/sam.h>

#include <cstdint>
#include <format>
#include <iterator>
Expand DownExpand Up@@ -70,19 +68,6 @@ struct std::formatter<falco::file_format> : std::formatter<std::string> {
}
};

// ADS: unused?
[[nodiscard]] constexpr auto
is_sequence_data(const auto hts_fp) -> bool {
return hts_get_format(hts_fp)->category == sequence_data;
}

[[nodiscard]] constexpr auto
is_sequence_data(const std::string &filename) -> bool {
using hts_file_unique_ptr = std::unique_ptr<htsFile, int (*)(htsFile *)>;
hts_file_unique_ptr fp(hts_open(std::data(filename), "r"), &hts_close);
return is_sequence_data(fp.get());
}

[[nodiscard]] auto
get_file_format(const std::string &filename)
-> std::tuple<falco::file_format, std::string>;
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Eliminating unneeded dependencies in the build config#122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewdavidsmith merged 2 commits into from
Aug 31, 2026
+16 −106
Merged

Eliminating unneeded dependencies in the build config #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5075f4e
CMakeLists.txt: fixing link interfaces to remove unneeded dependencies
andrewdavidsmith Aug 31, 2026
87cb028
src/falco_file_format.hcpp: removing unused function and adding a header
andrewdavidsmith Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 14 additions & 91 deletions CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,126 +80,49 @@ endif()
add_library(adapter_set OBJECT src/adapter_set.cpp)
add_library(falco_utils OBJECT src/falco_utils.cpp)
add_library(base_groups OBJECT src/base_groups.cpp)

add_library(bgzf_block OBJECT src/bgzf_block.cpp)
target_link_libraries(bgzf_block PUBLIC LIBDEFLATE::LIBDEFLATE)

add_library(bgzf_reader OBJECT src/bgzf_reader.cpp)
target_link_libraries(bgzf_reader PUBLIC bgzf_block)

add_library(fastq_file OBJECT src/fastq_file.cpp)
target_link_libraries(fastq_file PUBLIC HTSLIB::HTSLIB)

add_library(fastq_gz_file OBJECT src/fastq_gz_file.cpp)
target_link_libraries(fastq_gz_file PUBLIC HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_library(fastq_bgzf_file OBJECT src/fastq_bgzf_file.cpp)
target_link_libraries(fastq_bgzf_file PUBLIC
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)

add_library(bam_header OBJECT src/bam_header.cpp)

add_library(bamrec OBJECT src/bamrec.cpp)
add_library(bam_file OBJECT src/bam_file.cpp)
target_link_libraries(bam_file PUBLIC HTSLIB::HTSLIB)

add_library(samrec OBJECT src/samrec.cpp)
add_library(sam_file OBJECT src/sam_file.cpp)
target_link_libraries(sam_file PUBLIC HTSLIB::HTSLIB)

add_library(falco_file_format OBJECT src/falco_file_format.cpp)
target_link_libraries(falco_file_format PUBLIC HTSLIB::HTSLIB)

add_library(quality_score OBJECT src/quality_score.cpp)
target_link_libraries(quality_score PUBLIC falco_file_format)

add_library(tile_processor OBJECT src/tile_processor.cpp)
target_link_libraries(tile_processor PUBLIC
falco_file_format
HTSLIB::HTSLIB
)

add_library(falco_grade OBJECT src/falco_grade.cpp)
target_link_libraries(falco_grade PUBLIC
falco_utils
quality_score
)

add_library(kmer_counter OBJECT src/kmer_counter.cpp)
target_link_libraries(kmer_counter PUBLIC
falco_grade
falco_utils
)

add_library(contaminants OBJECT src/contaminants.cpp)

add_library(duplication_results OBJECT src/duplication_results.cpp)
target_link_libraries(duplication_results PUBLIC
falco_grade
falco_utils
contaminants
)

add_library(adapter_matcher OBJECT src/adapter_matcher.cpp)
target_link_libraries(adapter_matcher PUBLIC
falco_utils
falco_grade
adapter_set
)

add_library(report OBJECT src/report.cpp)
target_link_libraries(report PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(html OBJECT src/html.cpp)
target_link_libraries(html PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(results_collector INTERFACE)
target_link_libraries(results_collector INTERFACE fastq_file)

add_library(results_summary OBJECT src/results_summary.cpp)
target_link_libraries(results_summary PUBLIC
adapter_matcher
duplication_results
falco_grade
falco_utils
html
kmer_counter
quality_score
report
tile_processor
results_collector
)

add_library(falco_analyzer OBJECT src/falco_analyzer.cpp)
# ADS: not sure why the line below is needed on some systems, but dependencies
# in this file are a mess
target_link_libraries(falco_analyzer PUBLIC HTSLIB::HTSLIB)

add_library(get_binary_dir OBJECT src/get_binary_dir.cpp)
add_library(run_mode OBJECT src/run_mode.cpp)
add_library(falco_config OBJECT src/falco_config.cpp)
target_link_libraries(falco_config PUBLIC run_mode)

add_library(original_duplicates OBJECT src/original_duplicates.cpp)
target_link_libraries(original_duplicates PUBLIC HTSLIB::HTSLIB)

target_link_libraries(bgzf_block PRIVATE LIBDEFLATE::LIBDEFLATE)
target_link_libraries(fastq_bgzf_file PRIVATE
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)
target_link_libraries(bam_file PRIVATE HTSLIB::HTSLIB)
target_link_libraries(falco_file_format PRIVATE HTSLIB::HTSLIB)
target_link_libraries(tile_processor PRIVATE HTSLIB::HTSLIB)
target_link_libraries(fastq_gz_file PRIVATE HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_executable(falco src/falco.cpp)
target_link_libraries(falco PUBLIC
target_link_libraries(falco PRIVATE
tile_processor
contaminants
adapter_matcher
Expand Down
2 changes: 2 additions & 0 deletions src/falco_file_format.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@

#include "falco_file_format.hpp"

#include <htslib/sam.h>

#include <array>
#include <cstdlib>
#include <filesystem>
Expand Down
15 changes: 0 additions & 15 deletions src/falco_file_format.hpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

#include "nlohmann/json.hpp"

#include <htslib/sam.h>

#include <cstdint>
#include <format>
#include <iterator>
Expand DownExpand Up@@ -70,19 +68,6 @@ struct std::formatter<falco::file_format> : std::formatter<std::string> {
}
};

// ADS: unused?
[[nodiscard]] constexpr auto
is_sequence_data(const auto hts_fp) -> bool {
return hts_get_format(hts_fp)->category == sequence_data;
}

[[nodiscard]] constexpr auto
is_sequence_data(const std::string &filename) -> bool {
using hts_file_unique_ptr = std::unique_ptr<htsFile, int (*)(htsFile *)>;
hts_file_unique_ptr fp(hts_open(std::data(filename), "r"), &hts_close);
return is_sequence_data(fp.get());
}

[[nodiscard]] auto
get_file_format(const std::string &filename)
-> std::tuple<falco::file_format, std::string>;
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Eliminating unneeded dependencies in the build config#122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewdavidsmith merged 2 commits into from
Aug 31, 2026
+16 −106
Merged

Eliminating unneeded dependencies in the build config #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5075f4e
CMakeLists.txt: fixing link interfaces to remove unneeded dependencies
andrewdavidsmith Aug 31, 2026
87cb028
src/falco_file_format.hcpp: removing unused function and adding a header
andrewdavidsmith Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 14 additions & 91 deletions CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,126 +80,49 @@ endif()
add_library(adapter_set OBJECT src/adapter_set.cpp)
add_library(falco_utils OBJECT src/falco_utils.cpp)
add_library(base_groups OBJECT src/base_groups.cpp)

add_library(bgzf_block OBJECT src/bgzf_block.cpp)
target_link_libraries(bgzf_block PUBLIC LIBDEFLATE::LIBDEFLATE)

add_library(bgzf_reader OBJECT src/bgzf_reader.cpp)
target_link_libraries(bgzf_reader PUBLIC bgzf_block)

add_library(fastq_file OBJECT src/fastq_file.cpp)
target_link_libraries(fastq_file PUBLIC HTSLIB::HTSLIB)

add_library(fastq_gz_file OBJECT src/fastq_gz_file.cpp)
target_link_libraries(fastq_gz_file PUBLIC HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_library(fastq_bgzf_file OBJECT src/fastq_bgzf_file.cpp)
target_link_libraries(fastq_bgzf_file PUBLIC
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)

add_library(bam_header OBJECT src/bam_header.cpp)

add_library(bamrec OBJECT src/bamrec.cpp)
add_library(bam_file OBJECT src/bam_file.cpp)
target_link_libraries(bam_file PUBLIC HTSLIB::HTSLIB)

add_library(samrec OBJECT src/samrec.cpp)
add_library(sam_file OBJECT src/sam_file.cpp)
target_link_libraries(sam_file PUBLIC HTSLIB::HTSLIB)

add_library(falco_file_format OBJECT src/falco_file_format.cpp)
target_link_libraries(falco_file_format PUBLIC HTSLIB::HTSLIB)

add_library(quality_score OBJECT src/quality_score.cpp)
target_link_libraries(quality_score PUBLIC falco_file_format)

add_library(tile_processor OBJECT src/tile_processor.cpp)
target_link_libraries(tile_processor PUBLIC
falco_file_format
HTSLIB::HTSLIB
)

add_library(falco_grade OBJECT src/falco_grade.cpp)
target_link_libraries(falco_grade PUBLIC
falco_utils
quality_score
)

add_library(kmer_counter OBJECT src/kmer_counter.cpp)
target_link_libraries(kmer_counter PUBLIC
falco_grade
falco_utils
)

add_library(contaminants OBJECT src/contaminants.cpp)

add_library(duplication_results OBJECT src/duplication_results.cpp)
target_link_libraries(duplication_results PUBLIC
falco_grade
falco_utils
contaminants
)

add_library(adapter_matcher OBJECT src/adapter_matcher.cpp)
target_link_libraries(adapter_matcher PUBLIC
falco_utils
falco_grade
adapter_set
)

add_library(report OBJECT src/report.cpp)
target_link_libraries(report PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(html OBJECT src/html.cpp)
target_link_libraries(html PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(results_collector INTERFACE)
target_link_libraries(results_collector INTERFACE fastq_file)

add_library(results_summary OBJECT src/results_summary.cpp)
target_link_libraries(results_summary PUBLIC
adapter_matcher
duplication_results
falco_grade
falco_utils
html
kmer_counter
quality_score
report
tile_processor
results_collector
)

add_library(falco_analyzer OBJECT src/falco_analyzer.cpp)
# ADS: not sure why the line below is needed on some systems, but dependencies
# in this file are a mess
target_link_libraries(falco_analyzer PUBLIC HTSLIB::HTSLIB)

add_library(get_binary_dir OBJECT src/get_binary_dir.cpp)
add_library(run_mode OBJECT src/run_mode.cpp)
add_library(falco_config OBJECT src/falco_config.cpp)
target_link_libraries(falco_config PUBLIC run_mode)

add_library(original_duplicates OBJECT src/original_duplicates.cpp)
target_link_libraries(original_duplicates PUBLIC HTSLIB::HTSLIB)

target_link_libraries(bgzf_block PRIVATE LIBDEFLATE::LIBDEFLATE)
target_link_libraries(fastq_bgzf_file PRIVATE
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)
target_link_libraries(bam_file PRIVATE HTSLIB::HTSLIB)
target_link_libraries(falco_file_format PRIVATE HTSLIB::HTSLIB)
target_link_libraries(tile_processor PRIVATE HTSLIB::HTSLIB)
target_link_libraries(fastq_gz_file PRIVATE HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_executable(falco src/falco.cpp)
target_link_libraries(falco PUBLIC
target_link_libraries(falco PRIVATE
tile_processor
contaminants
adapter_matcher
Expand Down
2 changes: 2 additions & 0 deletions src/falco_file_format.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@

#include "falco_file_format.hpp"

#include <htslib/sam.h>

#include <array>
#include <cstdlib>
#include <filesystem>
Expand Down
15 changes: 0 additions & 15 deletions src/falco_file_format.hpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

#include "nlohmann/json.hpp"

#include <htslib/sam.h>

#include <cstdint>
#include <format>
#include <iterator>
Expand DownExpand Up@@ -70,19 +68,6 @@ struct std::formatter<falco::file_format> : std::formatter<std::string> {
}
};

// ADS: unused?
[[nodiscard]] constexpr auto
is_sequence_data(const auto hts_fp) -> bool {
return hts_get_format(hts_fp)->category == sequence_data;
}

[[nodiscard]] constexpr auto
is_sequence_data(const std::string &filename) -> bool {
using hts_file_unique_ptr = std::unique_ptr<htsFile, int (*)(htsFile *)>;
hts_file_unique_ptr fp(hts_open(std::data(filename), "r"), &hts_close);
return is_sequence_data(fp.get());
}

[[nodiscard]] auto
get_file_format(const std::string &filename)
-> std::tuple<falco::file_format, std::string>;
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Eliminating unneeded dependencies in the build config#122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewdavidsmith merged 2 commits into from
Aug 31, 2026
+16 −106
Merged

Eliminating unneeded dependencies in the build config #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5075f4e
CMakeLists.txt: fixing link interfaces to remove unneeded dependencies
andrewdavidsmith Aug 31, 2026
87cb028
src/falco_file_format.hcpp: removing unused function and adding a header
andrewdavidsmith Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 14 additions & 91 deletions CMakeLists.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,126 +80,49 @@ endif()
add_library(adapter_set OBJECT src/adapter_set.cpp)
add_library(falco_utils OBJECT src/falco_utils.cpp)
add_library(base_groups OBJECT src/base_groups.cpp)

add_library(bgzf_block OBJECT src/bgzf_block.cpp)
target_link_libraries(bgzf_block PUBLIC LIBDEFLATE::LIBDEFLATE)

add_library(bgzf_reader OBJECT src/bgzf_reader.cpp)
target_link_libraries(bgzf_reader PUBLIC bgzf_block)

add_library(fastq_file OBJECT src/fastq_file.cpp)
target_link_libraries(fastq_file PUBLIC HTSLIB::HTSLIB)

add_library(fastq_gz_file OBJECT src/fastq_gz_file.cpp)
target_link_libraries(fastq_gz_file PUBLIC HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_library(fastq_bgzf_file OBJECT src/fastq_bgzf_file.cpp)
target_link_libraries(fastq_bgzf_file PUBLIC
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)

add_library(bam_header OBJECT src/bam_header.cpp)

add_library(bamrec OBJECT src/bamrec.cpp)
add_library(bam_file OBJECT src/bam_file.cpp)
target_link_libraries(bam_file PUBLIC HTSLIB::HTSLIB)

add_library(samrec OBJECT src/samrec.cpp)
add_library(sam_file OBJECT src/sam_file.cpp)
target_link_libraries(sam_file PUBLIC HTSLIB::HTSLIB)

add_library(falco_file_format OBJECT src/falco_file_format.cpp)
target_link_libraries(falco_file_format PUBLIC HTSLIB::HTSLIB)

add_library(quality_score OBJECT src/quality_score.cpp)
target_link_libraries(quality_score PUBLIC falco_file_format)

add_library(tile_processor OBJECT src/tile_processor.cpp)
target_link_libraries(tile_processor PUBLIC
falco_file_format
HTSLIB::HTSLIB
)

add_library(falco_grade OBJECT src/falco_grade.cpp)
target_link_libraries(falco_grade PUBLIC
falco_utils
quality_score
)

add_library(kmer_counter OBJECT src/kmer_counter.cpp)
target_link_libraries(kmer_counter PUBLIC
falco_grade
falco_utils
)

add_library(contaminants OBJECT src/contaminants.cpp)

add_library(duplication_results OBJECT src/duplication_results.cpp)
target_link_libraries(duplication_results PUBLIC
falco_grade
falco_utils
contaminants
)

add_library(adapter_matcher OBJECT src/adapter_matcher.cpp)
target_link_libraries(adapter_matcher PUBLIC
falco_utils
falco_grade
adapter_set
)

add_library(report OBJECT src/report.cpp)
target_link_libraries(report PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(html OBJECT src/html.cpp)
target_link_libraries(html PUBLIC
tile_processor
quality_score
kmer_counter
falco_utils
)

add_library(results_collector INTERFACE)
target_link_libraries(results_collector INTERFACE fastq_file)

add_library(results_summary OBJECT src/results_summary.cpp)
target_link_libraries(results_summary PUBLIC
adapter_matcher
duplication_results
falco_grade
falco_utils
html
kmer_counter
quality_score
report
tile_processor
results_collector
)

add_library(falco_analyzer OBJECT src/falco_analyzer.cpp)
# ADS: not sure why the line below is needed on some systems, but dependencies
# in this file are a mess
target_link_libraries(falco_analyzer PUBLIC HTSLIB::HTSLIB)

add_library(get_binary_dir OBJECT src/get_binary_dir.cpp)
add_library(run_mode OBJECT src/run_mode.cpp)
add_library(falco_config OBJECT src/falco_config.cpp)
target_link_libraries(falco_config PUBLIC run_mode)

add_library(original_duplicates OBJECT src/original_duplicates.cpp)
target_link_libraries(original_duplicates PUBLIC HTSLIB::HTSLIB)

target_link_libraries(bgzf_block PRIVATE LIBDEFLATE::LIBDEFLATE)
target_link_libraries(fastq_bgzf_file PRIVATE
HTSLIB::HTSLIB
LIBDEFLATE::LIBDEFLATE
)
target_link_libraries(bam_file PRIVATE HTSLIB::HTSLIB)
target_link_libraries(falco_file_format PRIVATE HTSLIB::HTSLIB)
target_link_libraries(tile_processor PRIVATE HTSLIB::HTSLIB)
target_link_libraries(fastq_gz_file PRIVATE HTSLIB::HTSLIB)
if(USE_ISAL)
target_link_libraries(fastq_gz_file PUBLIC ISAL::ISAL)
endif()

add_executable(falco src/falco.cpp)
target_link_libraries(falco PUBLIC
target_link_libraries(falco PRIVATE
tile_processor
contaminants
adapter_matcher
Expand Down
2 changes: 2 additions & 0 deletions src/falco_file_format.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,8 @@

#include "falco_file_format.hpp"

#include <htslib/sam.h>

#include <array>
#include <cstdlib>
#include <filesystem>
Expand Down
15 changes: 0 additions & 15 deletions src/falco_file_format.hpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,6 @@

#include "nlohmann/json.hpp"

#include <htslib/sam.h>

#include <cstdint>
#include <format>
#include <iterator>
Expand DownExpand Up@@ -70,19 +68,6 @@ struct std::formatter<falco::file_format> : std::formatter<std::string> {
}
};

// ADS: unused?
[[nodiscard]] constexpr auto
is_sequence_data(const auto hts_fp) -> bool {
return hts_get_format(hts_fp)->category == sequence_data;
}

[[nodiscard]] constexpr auto
is_sequence_data(const std::string &filename) -> bool {
using hts_file_unique_ptr = std::unique_ptr<htsFile, int (*)(htsFile *)>;
hts_file_unique_ptr fp(hts_open(std::data(filename), "r"), &hts_close);
return is_sequence_data(fp.get());
}

[[nodiscard]] auto
get_file_format(const std::string &filename)
-> std::tuple<falco::file_format, std::string>;
Expand Down