Skip to content

force disconnect player if invalid lobby is provided - #11

Open
gyorokpeter wants to merge 5 commits into
socialgorithm:masterfrom
gyorokpeter:fixMatch
Open

force disconnect player if invalid lobby is provided#11
gyorokpeter wants to merge 5 commits into
socialgorithm:masterfrom
gyorokpeter:fixMatch

Conversation

@gyorokpeter

@gyorokpetergyorokpeter commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@netlify

netlifyBot commented Feb 9, 2022•
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for kind-sammet-1cead0 canceled.

🔨 Explore the source changes: 0391d53

🔍 Inspect the deploy log: https://app.netlify.com/sites/kind-sammet-1cead0/deploys/620cad871950460008ddbbde

@gyorokpetergyorokpeter changed the title Fix matchforce disconnect player if invalid lobby is providedFeb 9, 2022
@gyorokpeter
gyorokpeter requested review from aurbano and reddyalready and removed request for reddyalreadyFebruary 9, 2022 22:38
reddyalready
reddyalready approved these changes Feb 15, 2022
View reviewed changes

@reddyalreadyreddyalready left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much awaited, thanks!

Comment threadpackages/ui/src/components/Lobby/Tournament/index.js Outdated
Comment threadpackages/server/src/socket/SocketServer.ts Outdated
}
}

private disconnectPlayer = (data: Messages.ADD_PLAYER_TO_NAMESPACE_MESSAGE) => {

@reddyalreadyreddyalreadyFeb 13, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a PlayerAdviceMessage? or PLAYER_ADVICE_MESSAGE to be consistent?

Comment threadpackages/server/src/lobby/LobbyManager.ts Outdated
gyorokpeterand others added 3 commits February 16, 2022 07:36
@gyorokpeter@reddyalready
Update packages/ui/src/components/Lobby/Tournament/index.js
f99abd1
Co-authored-by: Bharat Reddy <me@bharatreddy.com>
@gyorokpeter@reddyalready
Update packages/server/src/lobby/LobbyManager.ts
711d27b
Co-authored-by: Bharat Reddy <me@bharatreddy.com>
gyorokpeter
add PLAYER_ADVICE_MESSAGE
0391d53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reddyalreadyreddyalreadyreddyalready approved these changes
@aurbanoaurbanoAwaiting requested review from aurbano

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gyorokpeter@reddyalready