Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 29, 2024. It is now read-only.
Add functionality to be able to peek n bytes off the wire - #72
Merged
Conversation
maruth-stripe
marked this pull request as draft
November 6, 2023 19:25
ioquatix
commented
Nov 6, 2023
Member
This is a great idea, I like it. |
ioquatix
commented
Nov 6, 2023
Member
Do you mind adding some tests? |
maruth-stripe
commented
Nov 6, 2023
ContributorAuthor
Yup I'll get on it! thanks for the feedback |
ioquatix
commented
Nov 7, 2023
Member
I'll also fix CI. Looks like there are some issues with Async v1 / Ruby 2.7. |
maruth-stripe
marked this pull request as ready for review
November 7, 2023 01:38
maruth-stripe
commented
Nov 7, 2023
ContributorAuthor
@ioquatix added a couple of tests! |
ioquatix
commented
Nov 7, 2023
Member
Are you able to agree to the developer certificate of origin? |
maruth-stripe
commented
Nov 7, 2023
ContributorAuthor
@ioquatix yup did it! Sorry for multiple pushes, unable to get tests run locally due to environment issues |
maruth-stripe
commented
Nov 7, 2023
ContributorAuthor
ah managed to get tests running locally, they pass for me now! |
maruth-stripe
commented
Nov 8, 2023
ContributorAuthor
@ioquatix seems like the same (unrelated?) failures for 2.7/v1, any action needed from me? |
ioquatix
commented
Nov 9, 2023
Member
No I will sort this out on the weekend, LGTM. |
1 task
3 tasks
dentarg added a commit
to dentarg/sinatra
that referenced
this pull request
Nov 11, 2023
Due to socketry/async-io#72 released in async-io 1.37.0 We will need this fix as long as we want to test Falcon in Ruby 2.6, as the "fix" in async-io will be to raise the min Ruby version: socketry/async-io#74
dentarg added a commit
to sinatra/sinatra
that referenced
this pull request
Nov 11, 2023
Due to socketry/async-io#72 released in async-io 1.37.0 We will need this fix as long as we want to test Falcon in Ruby 2.6, as the "fix" in async-io will be to raise the min Ruby version: socketry/async-io#74 Fail can be seen at https://github.com/sinatra/sinatra/actions/runs/6836408460/job/18591270458#step:5:19
ioquatix added a commit
that referenced
this pull request
Nov 17, 2023
ioquatix added a commit
that referenced
this pull request
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fixsocketry/protocol-http2#14 , one approach is to maintain the invariant that the read buffer / wire is always frame-aligned. We propose doing this by always reading a full frame at a time. To do this, instead of reading data off the wire when reading the header for an H/2 frame, we just peek the header and then read the full frame.
Types of Changes
Contribution