Uh oh!
There was an error while loading. Please reload this page.
Support Ruby 3.3 - #79
Conversation
ioquatix
commented
Jul 26, 2023
Thanks for this! @tarcieri if you don't want to maintain this gem, do you want to:
I can triage this issue and release. LMK what you prefer to do. |
tarcieri
commented
Jul 26, 2023
Sure, that sounds good to me. Let's transfer it to socketry |
ioquatix
commented
Jul 27, 2023
Okay, I'll await your transfer. |
tarcieri
commented
Jul 27, 2023
It's transferred |
ioquatix
commented
Jul 27, 2023
Thanks @tarcieri do you mind adding me as an owner on Rubygems.org too? Thanks! |
tarcieri
commented
Jul 27, 2023
Invite sent |
ioquatix
commented
Jul 27, 2023
@k0kubun I want to add CI before we merge this PR, please give me a couple of days to sort it out. |
k0kubun
commented
Jul 27, 2023
Sure, that makes sense. Thank you for working on that. |
b3bc86f to
17b12faCompareioquatix
commented
Aug 2, 2023
@k0kubun I could not get this to pass CI, but master branch is passing. Do you mind taking a look if you have time? |
ioquatix
commented
Aug 2, 2023
(it might just be flaky test suite... I tried several times, even master is a bit unreliable). |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ioquatix
commented
Aug 2, 2023
This looks okay to me now. I think we should try to move |
Well, two out of the three |
k0kubun
commented
Aug 2, 2023
Fixed the other one though 390ff4e. Only this one makes sense to me. |
ioquatix
commented
Aug 3, 2023
Thanks for your effort. I'll try to cut a release soon. |
ioquatix
commented
Aug 3, 2023
@k0kubun it sounds like you may have software using cool.io - can you test it with the latest release if so? |
My contribution socketry/cool.io#79 has been merged and released.
k0kubun
commented
Aug 3, 2023
I upgraded cool.io to the released version on yjit-bench ruby/ruby-bench@2858bc3. The extension compiles correctly on Ruby master. The |
Fix#77
This follows the example fix shown in [Feature #19057] at 94dbdd9497. I also changed
#if HAVE_RB_IO_Tto#if defined(HAVE_RB_IO_T)so that it will not print warnings when not defined.