Uh oh!
There was an error while loading. Please reload this page.
Normalize abrupt TLS EOF during non-blocking reads - #17
Draft
samuel-williams-shopify wants to merge 1 commit into
Draft
Normalize abrupt TLS EOF during non-blocking reads#17samuel-williams-shopify wants to merge 1 commit into
samuel-williams-shopify wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat OpenSSL unexpected EOF during both blocking and non-blocking reads as IO::Stream::ConnectionResetError.
This keeps peek_partial from leaking a transport-specific SSLError when a TLS peer closes abruptly, while preserving genuine TLS protocol errors unchanged. It also shares the existing read-error normalization between both read paths.
Related to socketry/async-http#223.
Validation: