This repository was archived by the owner on Aug 24, 2019. It is now read-only.
fixed deprecated call in drawRect: - #2
Open
Zhukn1 wants to merge 3 commits into
Open
Conversation
soffes
commented
Nov 29, 2013
Owner
Thanks for this! The check seems a bit heavy though. You could just see if the first character is 7 or higher. I'll think on it. |
marcelofabri
commented
Dec 2, 2013
Isn't it better to check if |
soffes
commented
Dec 2, 2013
Owner
@marcelofabri good call! |
Zhukn1
commented
Dec 2, 2013
Author
kinda awkward that I didn't do that from the start:) thanks, @marcelofabri! |
soffes
commented
Dec 2, 2013
Owner
Can you merge master into your branch? Thanks! |
Zhukn1
commented
Dec 3, 2013
Author
@soffes done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call drawInRect:withFont:lineBreakMode:alignment: is deprecated in iOS 7 and needs to be switched to drawInRect:withAttributes: