feat: encoder - #1183
Open
mdydek wants to merge 18 commits into
Open
feat: encoder#1183mdydek wants to merge 18 commits into
mdydek wants to merge 18 commits into
Conversation
Resolves conflicts between the encoder work and the OS-APIs decoding refactor (#1177): - AudioFileConcatenator: main's decoder-factory WAV path + encoder's OS remux (M4A/MP4) path; all FFmpeg remux code removed - AudioEventHandlerRegistry -> IAudioEventHandlerRegistry (#1212) in encoder file writers - AndroidEncoding/AndroidRemux moved to android/src/main/cpp/audioapi/android/ to match AndroidDecoding placement - docs/flags updated: recording and concatAudioFiles are FFmpeg-free Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
WPT non-regression comparisonPASS — no regressions · 0 improved section(s) · overall 2665 → 2665 (0) Unchanged sections (28)
Baseline: Workflow run · this comment is updated on every push. |
mdydek
marked this pull request as ready for review
August 18, 2026 08:35
closetcaiman
requested changes
Aug 21, 2026
closetcaiman
left a comment
Member
There was a problem hiding this comment.
Please add description to the PR for fast-access reference to the scope of these changes.
maciejmakowski2003
requested changes
Aug 21, 2026
maciejmakowski2003
left a comment
Collaborator
There was a problem hiding this comment.
could you add an overview of refactor? would be great to get some diagram
maciejmakowski2003
requested changes
Aug 25, 2026
Comment on lines
+53
to
+58
| Result<NoneType, std::string> setOnAudioReadyCallback( | ||
| float sampleRate, | ||
| size_t bufferLength, | ||
| int channelCount, | ||
| uint64_t callbackId) = 0; | ||
| virtual void clearOnAudioReadyCallback() = 0; | ||
| uint64_t callbackId); | ||
| void clearOnAudioReadyCallback(); |
Collaborator
There was a problem hiding this comment.
imo AudioRecorder should know only about a fact that has some side effects like callback or file writer, but not explicitly register them. let's create some abstraction over side effects -> easier to scale and integrate with worklets in future
Collaborator
There was a problem hiding this comment.
I would suggest to create a stack PR with AudioRecorder rework.
Member
Author
There was a problem hiding this comment.
can we delegate it to the different pr than here, it is too large anywa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Proposed architecture:
Checklist