Uh oh!
There was an error while loading. Please reload this page.
Prevent case that login search string is empty - #9
Conversation
Might prevent a situation like solid-contrib#8
jaxoncreed
left a comment
There was a problem hiding this comment.
Could you provide a unit test for this?
jaxoncreed
left a comment
There was a problem hiding this comment.
Perhaps it would be better to error rather than creating an empty object.
linonetwo
commented
Jan 10, 2020
Ok, I simply throw an error instead. |
jaxoncreed
left a comment
There was a problem hiding this comment.
I would still be great to have a simple unit test for this.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
I'm going to add a test case, using |
linonetwo
commented
Jan 11, 2020
isn't easy to mock using jest-fetch mock, would you mind I refactor it to node-fetch? |
jaxoncreed
commented
Jan 28, 2020
I think that should be fine @linonetwo |
Might prevent a situation like #8