Skip to content

fix: remove sd-notification margin - #3147

Merged
rahulsuvarna18 merged 52 commits into
nextfrom
fix/sd-notification-margin
Aug 12, 2026
Merged

fix: remove sd-notification margin#3147
rahulsuvarna18 merged 52 commits into
nextfrom
fix/sd-notification-margin

Conversation

@rahulsuvarna18

@rahulsuvarna18rahulsuvarna18 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description:

closes: #3074

Definition of Reviewable:

  • Migration Guide
  • relevant tickets are linked

@changeset-bot

changeset-botBot commented Jul 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1240098

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
NameType
@solid-design-system/componentsMajor
@solid-design-system/docsPatch
@solid-design-system/mcpMajor
@solid-design-system/stylesMajor
@solid-design-system/tokensMajor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Storybook has been deployed for branch fix_sd-notification-margin

@rahulsuvarna18rahulsuvarna18 changed the title fix: sd-notification base style overridefix: remove sd-notification marginJul 13, 2026
MartaPintoTeixeira
MartaPintoTeixeira previously approved these changes Jul 13, 2026
@rahulsuvarna18rahulsuvarna18 moved this from 📋 Backlog to 👀 In review in Solid Design System Project BoardJul 13, 2026
auroraVasconcelos
auroraVasconcelos previously approved these changes Aug 3, 2026
@coraliefeil

Copy link
Copy Markdown
Contributor

Approved. THX

coraliefeil
coraliefeil previously approved these changes Aug 4, 2026
Comment threadpackages/docs/.storybook/preview.css Outdated
@auroraVasconcelos

Copy link
Copy Markdown
Contributor

This looks a bit weird, should be fixed?

image

Comment threadpackages/docs/src/stories/components/notification.stories.ts Outdated
Comment threadpackages/components/src/solid-components.css Outdated

@mariohamannmariohamann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean this whole thing up and do only the chnges that are needed.

Comment threadpackages/docs/src/stories/components/notification.stories.ts Outdated
Comment threadpackages/docs/src/stories/components/notification.stories.ts Outdated
Comment threadpackages/docs/src/stories/packages/components/Migration/from-v6.mdx Outdated
Comment threadpackages/docs/src/stories/templates/notification.stories.ts Outdated
Comment threadpackages/components/src/solid-components.css Outdated
Comment threadpackages/components/src/solid-components.css Outdated
mariohamann
mariohamann previously requested changes Aug 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

fix: sd-notification padding

8 participants

@rahulsuvarna18@auroraVasconcelos@mariohamann@coraliefeil@van-nguyen-ht@MartaPintoTeixeira@martascorreia@balco0110