Skip to content

fix: datepicker selected state - #3225

Merged
balco0110 merged 17 commits into
mainfrom
fix/datepicker-selected-state
Aug 19, 2026
Merged

fix: datepicker selected state#3225
balco0110 merged 17 commits into
mainfrom
fix/datepicker-selected-state

Conversation

@balco0110

@balco0110balco0110 commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Description:

Closes#2847

Definition of Reviewable:

  • Documentation is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@balco0110balco0110 self-assigned this Aug 5, 2026
@changeset-bot

changeset-botBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0559790

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
NameType
@solid-design-system/componentsPatch
@solid-design-system/mcpPatch
@solid-design-system/stylesPatch
@solid-design-system/tokensPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@balco0110balco0110 moved this from 📋 Backlog to 👀 In review in Solid Design System Project BoardAug 5, 2026
@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Storybook has been deployed for branch fix_datepicker-selected-state

@balco0110
balco0110 marked this pull request as ready for review August 7, 2026 13:59
@coraliefeil

coraliefeil commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Approved

@coraliefeilcoraliefeil removed their assignment Aug 10, 2026
@rahulsuvarna18

rahulsuvarna18 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

I noticed that the selected date which is not in the same month has some different styling when selected.
image
Looking at Figma, the styling does not match any of the given styles. I believe the sale should be the same for the selected date (Blue bg and white text)
image

rahulsuvarna18
rahulsuvarna18 previously requested changes Aug 10, 2026
View reviewed changes

@rahulsuvarna18rahulsuvarna18 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comment above

auroraVasconcelos
auroraVasconcelos reviewed Aug 19, 2026
View reviewed changes
Comment threadpackages/components/src/components/datepicker/datepicker.ts
Comment thread.changeset/quick-snails-raise.md Outdated
Comment thread.changeset/quick-snails-raise.md Outdated
Comment thread.changeset/quick-snails-raise.md Outdated
Comment thread.changeset/quick-snails-raise.md Outdated
Comment threadpackages/components/src/components/datepicker/datepicker.test.ts Outdated
Comment threadpackages/components/src/components/datepicker/datepicker.test.ts Outdated
Comment threadpackages/components/src/components/datepicker/datepicker.ts
@balco0110@auroraVasconcelos
Update .changeset/quick-snails-raise.md
21b7029
Co-authored-by: Aurora Vasconcelos <aurora.vasconcelos@virtual-identity.com>
balco0110and others added 2 commits August 19, 2026 15:37
@balco0110@auroraVasconcelos
Update .changeset/quick-snails-raise.md
776521b
Co-authored-by: Aurora Vasconcelos <aurora.vasconcelos@virtual-identity.com>
@balco0110@auroraVasconcelos
Update .changeset/quick-snails-raise.md
b612cb4
Co-authored-by: Aurora Vasconcelos <aurora.vasconcelos@virtual-identity.com>
@balco0110@auroraVasconcelos
Update .changeset/quick-snails-raise.md
efe7d90
Co-authored-by: Aurora Vasconcelos <aurora.vasconcelos@virtual-identity.com>
martascorreia
martascorreia previously approved these changes Aug 19, 2026
View reviewed changes
@balco0110
balco0110 merged commit 8d1a601 into mainAug 19, 2026
18 of 20 checks passed
@balco0110
balco0110 deleted the fix/datepicker-selected-state branch August 19, 2026 15:19
@github-project-automationgithub-project-automationBot moved this from 👀 In review to ✅ Done in Solid Design System Project BoardAug 19, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@auroraVasconcelosauroraVasconcelosauroraVasconcelos approved these changes
@martascorreiamartascorreiamartascorreia left review comments
@rahulsuvarna18rahulsuvarna18rahulsuvarna18 left review comments

Assignees

@mariohamannmariohamann

@martascorreiamartascorreia

@rahulsuvarna18rahulsuvarna18

@balco0110balco0110

@auroraVasconcelosauroraVasconcelos

@yoezlemyoezlem

Labels

None yet

Projects

Solid Design System Project Board
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: datepicker selected state

7 participants

@balco0110@coraliefeil@rahulsuvarna18@martascorreia@auroraVasconcelos@mariohamann@yoezlem