Skip to content

сhore: upgrade dart sdk - #349

Open
solid-illiaaihistov wants to merge 27 commits into
solid-software:masterfrom
solid-illiaaihistov:chore/upgrade-dart-sdk
Open

сhore: upgrade dart sdk#349
solid-illiaaihistov wants to merge 27 commits into
solid-software:masterfrom
solid-illiaaihistov:chore/upgrade-dart-sdk

Conversation

@solid-illiaaihistov

@solid-illiaaihistovsolid-illiaaihistov commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes

    • Improved detection for duplicate code, unused parameters, magic numbers in records, extension types, and nearest context parameters.
    • Corrected handling of named arguments, abstract methods, default parameters, and extension type declarations.
    • Updated automated lint fixes for more reliable compatibility with current analysis tooling.
  • Maintenance

    • Refined analyzer configuration and modernized project compatibility for the latest Dart tooling.
    • Removed an obsolete public library export.

Illia Aihistov added 26 commits August 25, 2026 09:52
…rom argument expressions instead of arguments directly
… method declarations instead of abstract ones
@coderabbitai

coderabbitaiBot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 43 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ac4abdb-0ac3-422a-a156-9f02df574310

📥 Commits

Reviewing files that changed from the base of the PR and between 500083d and 3df96b8.

📒 Files selected for processing (2)
  • lib/src/lints/no_magic_number/visitors/no_magic_number_rule_visitor.dart
  • test/src/lints/no_magic_number/no_magic_number_rule_test.dart

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: eb84a08a-ac3a-4c80-9f99-524e439fe12b

📥 Commits

Reviewing files that changed from the base of the PR and between c9e5a6e and 500083d.

📒 Files selected for processing (34)
  • CHANGELOG.md
  • lib/analysis_options.yaml
  • lib/solid_lints.dart
  • lib/src/common/parameter_parser/analysis_options_loader.dart
  • lib/src/common/parameter_parser/package_config_resolver.dart
  • lib/src/lints/avoid_duplicate_code/visitors/ast_structural_hash_visitor.dart
  • lib/src/lints/avoid_duplicate_code/visitors/avoid_duplicate_code_visitor.dart
  • lib/src/lints/avoid_final_with_getter/fixes/avoid_final_with_getter_fix.dart
  • lib/src/lints/avoid_returning_widgets/visitors/avoid_returning_widgets_visitor.dart
  • lib/src/lints/avoid_unnecessary_type_assertions/fixes/avoid_unnecessary_type_assertions_fix.dart
  • lib/src/lints/avoid_unused_parameters/visitors/avoid_unused_parameters_visitor.dart
  • lib/src/lints/double_literal_format/fixes/double_literal_format_fix.dart
  • lib/src/lints/feature_envy/utils/member_access_utils.dart
  • lib/src/lints/member_ordering/visitors/declaration_ordering_visitor.dart
  • lib/src/lints/member_ordering/visitors/member_ordering_reporter.dart
  • lib/src/lints/named_parameters_ordering/fixes/named_parameters_ordering_fix.dart
  • lib/src/lints/named_parameters_ordering/models/parameter_type.dart
  • lib/src/lints/no_empty_block/visitors/no_empty_block_visitor.dart
  • lib/src/lints/no_magic_number/visitors/no_magic_number_rule_visitor.dart
  • lib/src/lints/prefer_conditional_expressions/fixes/prefer_conditional_expressions_fix.dart
  • lib/src/lints/prefer_conditional_expressions/visitors/prefer_conditional_expressions_visitor.dart
  • lib/src/lints/prefer_first/fixes/prefer_first_fix.dart
  • lib/src/lints/prefer_last/fixes/prefer_last_fix.dart
  • lib/src/lints/prefer_match_file_name/visitors/prefer_match_file_name_visitor.dart
  • lib/src/lints/use_descriptive_names_for_type_parameters/visitors/use_descriptive_names_for_type_parameters_visitor.dart
  • lib/src/lints/use_nearest_context/fixes/rename_nearest_context_parameter_fix.dart
  • lib/src/lints/use_nearest_context/fixes/replace_with_nearest_context_parameter_fix.dart
  • lib/src/lints/use_nearest_context/utils/use_nearest_context_utils.dart
  • lib/src/models/solid_diagnostic_message.dart
  • lib/src/models/solid_lint_rule.dart
  • lib/src/models/solid_multi_lint_rule.dart
  • lib/src/utils/node_utils.dart
  • pubspec.yaml
  • test/src/common/parameter_parser/analysis_options_loader_test.dart
💤 Files with no reviewable changes (2)
  • lib/solid_lints.dart
  • lib/analysis_options.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The package now requires Dart 3.12, uses newer analyzer tooling, removes the main.dart export, updates analyzer AST integrations, changes several lint classifications, and modernizes internal constructor initialization.

Changes

Analyzer migration and lint updates

Layer / File(s)Summary
Tooling and fix API migration
pubspec.yaml, lib/analysis_options.yaml, lib/src/lints/*/fixes/*, CHANGELOG.md
Dependency constraints and fix imports now use the newer analyzer server APIs. Four lint rules were removed.
Analyzer AST adaptation
lib/src/utils/node_utils.dart, lib/src/lints/avoid_duplicate_code/..., lib/src/lints/prefer_match_file_name/..., lib/src/lints/use_descriptive_names_for_type_parameters/..., lib/src/common/parameter_parser/..., test/src/common/parameter_parser/...
Code now uses updated analyzer AST members, formal-parameter types, ancestor traversal, and file lookup APIs.
Lint behavior updates
lib/src/lints/avoid_returning_widgets/..., lib/src/lints/avoid_unused_parameters/..., lib/src/lints/named_parameters_ordering/..., lib/src/lints/no_magic_number/..., lib/src/lints/prefer_conditional_expressions/..., lib/src/lints/use_nearest_context/...
Visitors now classify complete methods, initializing formals, record literal fields, parameter kinds, and nearest context parameters with updated AST behavior.
Constructor initialization modernization
lib/src/lints/*/visitors/*, lib/src/models/*
Internal constructors now use initializing or field-formal parameters.
Library and source cleanup
lib/solid_lints.dart, lib/src/lints/feature_envy/utils/member_access_utils.dart, lib/src/common/parameter_parser/package_config_resolver.dart
The main.dart export was removed, and selected source formatting was updated.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk:⚪ Minimal · up to 50008

This SDK upgrade has no actionable merge-blocking risk in the supplied evidence and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the main change: upgrading the Dart SDK. It is concise and related to the pull request, although the first character in "сhore" appears to be Cyrillic.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (32 skipped: 32 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danylo-safonov-soliddanylo-safonov-solid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@solid-illiaaihistov@danylo-safonov-solid