Use current inbox property

[csarven]

As per:

• 519e654#diff-04c6e90faac2675aa89e2176d2eec7d8R239
• nodeSolidServer/node-solid-server@9af2c51
• nodeSolidServer/node-solid-server@8b1dc11
• solid/vocab@1cd827c
• ...

[melvincarvalho]

Thanks for raising this and the pointers. We have a big release on node solid server coming up. Let's revisit after that.

[dmitrizagidulin]

👍 looks good to me. Thanks @csarven!

[RubenVerborgh]

Hi @melvincarvalho, I think we should move on with this. Using the old property is an error in the documentation that we don't want to propagate.

I've done a grep on the entire repository and @csarven has changed all occurrences. So I will provide a positive review on this PR and merge tomorrow, unless strong objections come up.

[RubenVerborgh]

All occurrences have been correctly changed.

[kjetilk]

Thanks @csarven ! I too think that this is something that should be fixed for 5.0.0, so lets go.

[melvincarvalho]

@RubenVerborgh@dmitrizagidulin really appreciate your eyes on this, and thank you!

So, there's a couple of subtle points here, which I think think would be helpful go over.

This has been open for ages, isnt hurting anyone, let's discuss in a week or two, if that's OK?

IMHO some really good and exciting developments coming after this week, would just like to put this on hold until after, if that is ok ...

[melvincarvalho]

Addendum : please dont let me get in the way of consensus, but have you really evaluated this spec change fully? Does solid : inbox occur in any of the tests?

IMHO changes to the spec are worth taking a bit of time over! But, I can live with this change :)

[melvincarvalho]

Concretely, please consider that if we want to go this route, the tests should match the proposal, as an example :

https://github.com/solid/node-solid-server/blob/6f160a5f3000862c6f55d68dcda1aeaa52e4a5b9/test/resources/accounts-acl/config/templates/new-account/profile/card#L21

[kjetilk]

OK, thanks, @melvincarvalho ! It didn't look like a big burden on the 5.0.0 release, and I didn't realize you actually felt it was premature. Sorry I was making assumptions about your motivation rather than just asking.

But yeah, we need to follow up with a bug on node-solid-server, and a fix in there. Anyone up for creating that issue? And possibly fix the bug? :-)

[RubenVerborgh]

So what I'm hearing is that this PR is correct and approved, but that there might be issues in other repositories. So let me merge this and track the rest in #108.

[melvincarvalho]

good stuff! FYI : chatted to @RubenVerborgh out of band and went over the background, we've identified some areas to cleanup, which will be covered in other issues