Skip to content

Describe N3 Patch - #346

Merged
csarven merged 30 commits into
mainfrom
feature/n3-patch
Dec 15, 2021
Merged

Describe N3 Patch#346
csarven merged 30 commits into
mainfrom
feature/n3-patch

Conversation

@RubenVerborgh

Copy link
Copy Markdown
Contributor

Closes#332

@RubenVerborghRubenVerborgh left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the initially proposed text; if approved, I can also add an example.

Comment threadprotocol.html Outdated
Comment threadprotocol.html Outdated
Comment threadprotocol.html Outdated
@RubenVerborghRubenVerborgh added the category: revisit for 1.0 Temporary resolution achieved for 0.9, but might want to reconsider for 1.0. label Nov 10, 2021
@RubenVerborgh

This comment has been minimized.

@RubenVerborgh
RubenVerborgh marked this pull request as ready for review November 10, 2021 18:03
@RubenVerborgh

Copy link
Copy Markdown
ContributorAuthor

@csarven@justinwb@kjetilk@timbl Ready for review.

Comment threadprotocol.html Outdated

@kjetilkkjetilk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going in a direction that will be workable very soon. My comments are mostly editorial, but I think needed to get into line with the language of the rest of the spec.

Comment threadprotocol.html Outdated
Comment threadprotocol.html Outdated
Comment threadprotocol.html Outdated
Comment threadprotocol.html Outdated
Comment threadprotocol.html Outdated

@kjetilkkjetilk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, it should mention what kind of operations these are (i.e. append, read, write), so that authz systems can hook into that, also in line with #220 . I guess you can adopt some of the language I used for this #320.

@justinwbjustinwb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good - just a few comments

Comment threadprotocol.html Outdated
Comment threadprotocol.html Outdated
Comment threadprotocol.html Outdated
Comment threadprotocol.html Outdated
@RubenVerborgh

Copy link
Copy Markdown
ContributorAuthor

One more thing, it should mention what kind of operations these are (i.e. append, read, write), so that authz systems can hook into that, also in line with #220 . I guess you can adopt some of the language I used for this #320.

In 76398fe

Comment threadprotocol.html Outdated
@RubenVerborgh

Copy link
Copy Markdown
ContributorAuthor

Rebased; requested change in cd44b69 /CC @timbl

Comment threadprotocol.html Outdated
Comment threadprotocol.html Outdated
Comment threadprotocol.html Outdated
@RubenVerborgh

Copy link
Copy Markdown
ContributorAuthor

@csarven Thanks, amended 2a99d6a

@kjetilkkjetilk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, great! I think we should think economy when requiring new triples, but indeed, the extensibility that this affords is important.

@kjetilkkjetilk linked an issue Dec 14, 2021 that may be closed by this pull request
@csarven
csarven merged commit bcb778b into mainDec 15, 2021
@csarven

csarven commented Dec 19, 2021

Copy link
Copy Markdown
Member

dokieli implements clients side of N3 Patch: dokieli/dokieli@f4c1a0a

Currently used for patching a Memento TimeMap resource:

timemap-n3-patch

@csarven
csarven deleted the feature/n3-patch branch May 12, 2022 16:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: new functionalityConcerns a new featurecategory: revisit for 1.0Temporary resolution achieved for 0.9, but might want to reconsider for 1.0.doc: Protocoltopic: resource access

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Alternative update support with N3 patch Is Read required on top of Write for PATCH delete and where ?

6 participants

@RubenVerborgh@kjetilk@csarven@justinwb@timbl@TallTed