Uh oh!
There was an error while loading. Please reload this page.
fix: use @solidjs/web as jsxImportSource in solid-v2 jsconfig - #83
Merged
Conversation
The JS variants of the Solid 2.0 templates were getting a jsconfig.json with jsxImportSource "solid-js", but the templates' own tsconfig.json declares "@solidjs/web" (Solid 2.0's JSX runtime lives there, and vite-plugin-solid 3.x compiles against it). Match the templates. Raised by @brenelz in #82 review. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsconfig.jsonwritten for JS variants of the Solid 2.0 templates usedjsxImportSource: "solid-js", but the solid-v2 templates' owntsconfig.jsonfiles all declare"@solidjs/web"— Solid 2.0's JSX runtime lives in@solidjs/web, and vite-plugin-solid 3.x compiles against it (moduleName: '@solidjs/web').JS_CONFIG_SOLID_V2; no changeset needed since the affected code is unreleased (covered by the existingsolid-v2-templateschangeset).Test plan
pnpm test— 16/16 passingMade with Cursor