Uh oh!
There was an error while loading. Please reload this page.
chore: bump TEMPLATES_REF to templates main (4f54cb7) for browser-mode cleanup - #85
Merged
Merged
Conversation
…e cleanup solid-v2/with-vitest-browser-mode drops its environment: 'node' workaround now that vite-plugin-solid 3.0.0-next.26 gates its jsdom default on browser.enabled; the templates commit was verified on a fresh install (pnpm install && pnpm test exits 0, test passes in real Chromium). Co-authored-by: Cursor <cursoragent@cursor.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
environment: 'node'workaround insolid-v2/with-vitest-browser-mode— vite-plugin-solid 3.0.0-next.26 (pinned by templates fb4c013) now gates its jsdom default onbrowser.enabled, so the vitest startup probe that forced the override no longer fires.packages/create/src/utils/download.ts, no changeset needed (unreleased code covered by the existingsolid-v2-templateschangeset).Test plan
pnpm install && pnpm testexits 0, test passes in real Chromium, no jsdom probe errorpnpm test— 16/16 passing against live GitHub with the new refMade with Cursor