Test environment detection doesn't consider Vitest workspaces

[carloitaben]

Hello! I am integrating the new Vitest Browser mode into a project using Solid. Their guide suggests that if you want to use it alongside other test environments, you should configure it using workspaces.

The Solid Vite plugin does not appear to read the user test.workspace configuration and defaults to jsdom.

// ...
 const userTest = (userConfig as any).test ?? {};
 const test = {} as any;
 if (userConfig.mode === 'test') {
 // ...
 if (!userTest.environment && !options.ssr) {
 test.environment = 'jsdom';
 }
// ...

Which results on being prompted to install jsdom each time

Reproduction

I made a quick reproduction here.

Workaround

My current workaround is to do this on my vite.config.ts:

import { defineConfig } from "vite"
import solid from "vite-plugin-solid"
import tsConfigPaths from "vite-tsconfig-paths"

export default defineConfig({
 plugins: [tsConfigPaths(), solid()],
 test: {
 // Workaround for Solid Vite plugin. Get's superseeded by `workspace` config
 environment: "node",
 workspace: [
 {
 extends: true,
 test: {
 include: ["**/*.test.{ts,tsx}"],
 name: "Node.js",
 environment: "node",
 },
 },
 {
 extends: true,
 test: {
 include: ["**/*.test.dom.{ts,tsx}"],
 browser: {
 enabled: true,
 headless: true,
 ui: false,
 provider: "playwright",
 instances: [
 {
 browser: "chromium",
 name: "DOM",
 },
 ],
 },
 },
 },
 ],
 },
})

Could the Solid Vite plugin also check the user test.workspace configuration? 🙂 I can draft a PR if the request makes sense

[brenelz]

If you could draft a PR that would be great