Skip to content

2.0.0-rc nested render effect cleanup run too early #3404

Description

@GabbeV

Describe the bug

When a render effect reading async value is nested within another effect reading another async value cleanup sometimes run too early.

Your Example Website or App

https://s.olid.uk/id/oHOnRtMeTDKAY2kJ-DQQ3w

Steps to Reproduce the Bug or Issue

  1. click button
  2. observe how the portal disappear before later reappearing instead of atomically swapping.

Expected behavior

The result is observably atomic once the entire update is done.

Screenshots or Videos

No response

Platform

  • OS: Windows
  • Browser: Firefox

Additional context

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions