fix(signals): parent the pending companion's lane before poking it (#3379) - #3400
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: fec8f85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Sep 12, 2026
…3379) `notifyStatus` poked a node's companions (`_updatePendingSignal`) before assigning the node's optimistic lane. The companion's child lane takes its parent from the node's lane at creation, so a memo made pending by propagation before it rode the lane got a parentless companion lane; the isPending effect, which also depends on the memo, merged that lane into the held lane and its run waited on the async it reports. The lane is now assigned first inside the same `!blockStatus` block. Co-authored-by: Claude via Cursor <noreply@cursor.com> Co-authored-by: Cursor <cursoragent@cursor.com>
ryansolid
force-pushed
the
fix/pending-companion-lane-parent
branch
from
September 13, 2026 00:09
e1e8e5c to
fec8f85
Compare
Coverage Report for CI Build 34727239915Coverage remained the same at 71.842%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3379 (Cluster 3 of gabbev's 2026-09-11 batch; its sibling #3378 is fixed by #3397). Independent of #3381/#3392 — based on
next.#3379 —
isPending(details)false whiledetailsloads the optimistic value through an async memoisPending/latestcompanions ride child lanes that deliberately do not merge with the owner's lane (A14), so an indicator can flush while the owner's async is in flight. The child lane takes its parent from the owner's_optimisticLanewhen it is created (getOrCreateLane).In
notifyStatus, the companion poke (_updatePendingSignal) ran beforeassignOrMergeLane(el, lane). Whencopy's pending status propagated ontodetails,detailshad no lane yet, so the companion lane it created was born parentless. ThePendingeffect depends on bothdetails(thevaluelane) and the companion (the orphan lane); with no parent/child relation between them,assignOrMergeLanemerged the companion lane into the heldvaluelane and the indicator's run sat in that lane's effect queue until the async landed. Readingvalue()directly indetails"worked" becausedetailsjoined the lane throughinsertSubsbefore the poke.Fix: assign the lane first, inside the same
!blockStatusblock. A reorder; −4 B minified.Frames after the fix (the
Vieweffect readsdetails, so it correctly holds0 / 0until the derivation lands; the indicator no longer waits):Before the fix,
3000: Pending: trueis missing and 4000 showsView: 1 / 1alone — the issue's symptom.Size
Core floor 22,648 → 22,644 B. Four
size-limitcaps bumped by one step with notes; all brotli noise (next's caps sit within ~10–30 B of their measurements).Verification
signals 1752/1752 (+1 skipped), solid 595, web 734;
tscclean forsrc/and the new test;size-limitpasses. No existing test expectation changed.Co-authored-by: Claude via Cursor