docs(contributing): name the merge rules main now enforces - #1
Merged
Conversation
…умеваются Ветка не принимает прямой push, все восемь проверок обязательны, и ветка должна быть актуальной к моменту merge — то есть CI прогнан против того, что реально ляжет, а не против снимка, который с тех пор сдвинулся. Апрува не требуется: review, который здесь имеет вес, это список «что заворачивается» выше. История линейная, merge-коммиты выключены на уровне репозитория, чтобы кнопка в UI не предлагала то, что правило отклонит.
Uh oh!
There was an error while loading. Please reload this page.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe contribution guide adds an “Opening a pull request” section covering protected changes to ChangesPull Request Guidelines
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
CONTRIBUTING gains a short
Opening a pull requestsection:maintakes no direct push, all eight CI checks are required, the branch must be current at merge time, no approval is required, and history stays linear.Why
Branch protection was just enabled. A rule the contributing guide does not name is a rule people meet as a surprise at merge time.
This pull request is also the empirical check that the gate works — it is the first one the protection has seen.
How it was verified
go test -race ./...passesgo vet ./... && go vet -tags=live ./... && gofmt -l .is cleango run honnef.co/go/tools/cmd/staticcheck@v0.7.0 ./...is cleango run golang.org/x/vuln/cmd/govulncheck@latest ./...reports nothingTestPublishedDocsNameOnlyRealCommandsAndFlagscovers the edited file and passesInvariants
Touches invariants: none — documentation only.
Dependencies
go.modis unchangedSummary by CodeRabbit
mainare not permitted.