[FR] Add /api/health/ready endpoint with dependency health checks (Postgres, Redis, Zoekt) #1506

Description

@Harsh23Kashyap

Problem

GET /api/health currently returns a hardcoded { "status": "ok" } regardless of whether Sourcebot's actual dependencies (Postgres, Redis, Zoekt) are reachable. Self-hosted operators using Kubernetes, Docker Compose with a healthcheck, an external load balancer, or a monitoring system cannot distinguish a healthy Sourcebot from one whose database connection has dropped, whose Redis is unreachable, or whose Zoekt indexer is dead.

The previous FR for this (#727) was closed because the endpoint already existed, but the original ask was for a "structured response with details on its inner components' health status" — which was never delivered. PR #728 was opened to document the existing endpoint and closed without merging.

Current behavior

$ curl -sS https://sourcebot.example.com/api/health
{"status":"ok"}

This is a 12-line stub in packages/web/src/app/api/(server)/health/route.ts. It runs on every orchestrator probe interval, logs a debug line, and returns the same payload whether or not Postgres, Redis, or Zoekt are reachable. A pod that has lost its database connection will still report "ok" to a Kubernetes readiness probe, and traffic will continue to be routed to a broken instance.

Expected behavior

A new GET /api/health/ready endpoint that:

  • Checks Postgres via __unsafePrisma.$queryRaw\SELECT 1``
  • Checks Redis via redis.ping()
  • Checks Zoekt via a lightweight gRPC call (a List request with q: { and: { children: [] } } and a small opts: { max_wall_time: 1s })
  • Runs the three checks in parallel with a per-check timeout (default 2s)
  • Returns 200 with {"status":"ok","checks":{...}} if all pass
  • Returns 503 with {"status":"degraded","checks":{...}} if any fail; per-check payload includes {status, latencyMs, error?}

The existing GET /api/health stays exactly as it is (liveness probe) — a process-up signal that does not depend on any external service.

The two endpoints give operators the standard Kubernetes liveness/readiness pair out of the box.

Proposed solution

Add packages/web/src/app/api/(server)/health/ready/route.ts:

import{apiHandler}from"@/lib/apiHandler";import{__unsafePrisma}from"@/prisma";import{getRedisClient}from"@/lib/redis";import{createLogger}from"@sourcebot/shared";import*asgrpcfrom"@grpc/grpc-js";import*asprotoLoaderfrom"@grpc/proto-loader";importpathfrom"path";import{env}from"@sourcebot/shared";constREADINESS_TIMEOUT_MS=2000;constlogger=createLogger("health-ready");typeCheckResult={status: "ok"|"error";latencyMs: number;error?: string};typeReadinessResponse={status: "ok"|"degraded";checks: Record<string,CheckResult>};// Each check returns a CheckResult after at most READINESS_TIMEOUT_MS.asyncfunctioncheckPostgres(): Promise<CheckResult>{ ... }asyncfunctioncheckRedis(): Promise<CheckResult>{ ... }asyncfunctioncheckZoekt(): Promise<CheckResult>{ ... }exportconstGET=apiHandler(async()=>{const[postgres,redis,zoekt]=awaitPromise.all([checkPostgres(),checkRedis(),checkZoekt(),]);constchecks={ postgres, redis, zoekt };consthealthy=Object.values(checks).every(c=>c.status==="ok");constbody: ReadinessResponse={status: healthy ? "ok" : "degraded",
checks,};returnResponse.json(body,{status: healthy ? 200 : 503});},{track: false});

Tests: packages/web/src/app/api/(server)/health/ready/route.test.ts covering the healthy / degraded paths with mocked prisma + redis + gRPC client.

Docs: a new docs/docs/api-reference/health.mdx describing both endpoints and the liveness-vs-readiness split, with example probes for Docker Compose and Kubernetes. Add it to the API Reference group in docs/docs.json.

Alternatives considered

  • A single/api/healththat does both. Rejected: makes Kubernetes-style splitting impossible, and a liveness probe that touches the database can cause cascading restarts when the database is briefly unreachable.
  • Prometheus metrics-only (the spirit ofFR: Add Prometheus support #119**).** Rejected for this PR: not actionable from an orchestrator probe. Could be a follow-up — checkZoekt and the timing data are already in the right shape to emit as metrics.
  • AWebserverService.HealthgRPC method. Not available in the vendored Zoekt proto; would require an upstream change. A List with a 1s wall-time cap is the smallest thing that proves the gRPC channel is alive and the server is responsive.

Scope

  • One new route file + one new test file + one new docs file + one line in docs/docs.json
  • No schema changes
  • No new dependencies
  • No changes to the existing /api/health liveness endpoint
  • No changes to the existing API key, auth, or entitlement systems — this endpoint is unauthenticated and matches the existing /api/health policy (no user data returned)

Acceptance criteria

  • GET /api/health/ready returns 200 with {"status":"ok",...} when all three dependencies are reachable
  • GET /api/health/ready returns 503 with {"status":"degraded",...} and the failing check's {status:"error", error:...} when any dependency is unreachable
  • All three checks are bounded by a 2s timeout; the worst-case request time is ~2s even when one dependency hangs
  • All three checks run in parallel (Promise.all) — total request time is max(timeouts), not sum(timeouts)
  • GET /api/health (liveness) is unchanged
  • Tests pass for both healthy and each-of-three-degraded permutations
  • Docs page describes both endpoints with example Docker Compose healthcheck: and Kubernetes livenessProbe/readinessProbe blocks
  • No PostHog tracking on the new endpoint (track: false, matching the existing liveness endpoint)
  • A CHANGELOG.md entry under [Unreleased] → Added references this PR

Backward compatibility

Fully backwards compatible. The existing /api/health endpoint is unchanged. The new endpoint is purely additive. Operators who do not use it see no change.

Risks

  • A misconfigured /api/health/ready could cause Kubernetes to pull all pods out of rotation if the probe interval collides with a database blip. Mitigated by the per-check timeout and the standard recommendation of a 3-failure failureThreshold on the readiness probe.
  • The Zoekt gRPC check calls List with a 1s wall-time cap; under load this could add to Zoekt's request rate. The check runs at most once per probe interval per pod; for the default 10s interval on a 3-pod deployment this is ~0.3 RPS, negligible.
  • The getRedisClient() lazy singleton means the first readiness probe on a cold pod will create the Redis connection. The 2s timeout is more than enough headroom for the first connect.

Future work (out of scope for this PR)

  • Prometheus metrics for each check (sourcebot_readiness_check_duration_seconds{check="postgres"}, etc.) — would build on the same per-check helpers introduced here.
  • A /api/health/ready?strict=true mode that treats Zoekt shards-empty as a degraded state (currently List returns success even with zero repos).
  • A /api/health/metrics JSON endpoint that returns Prometheus-style text without exposing /metrics directly.
  • Cache the readiness result for ~1s to absorb thundering-herd probes from multiple orchestrators.

Happy to take this on. Implementation plan, test plan, and docs update all fit in one focused PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
     blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
    }
    } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
    })();
    (function(){
    try {
    var __m = "github.com";
    var __re = new RegExp('^' + "github\\.com" + '
    
    Skip to content

    [FR] Add /api/health/ready endpoint with dependency health checks (Postgres, Redis, Zoekt) #1506

    Description

    @Harsh23Kashyap

    Problem

    GET /api/health currently returns a hardcoded { "status": "ok" } regardless of whether Sourcebot's actual dependencies (Postgres, Redis, Zoekt) are reachable. Self-hosted operators using Kubernetes, Docker Compose with a healthcheck, an external load balancer, or a monitoring system cannot distinguish a healthy Sourcebot from one whose database connection has dropped, whose Redis is unreachable, or whose Zoekt indexer is dead.

    The previous FR for this (#727) was closed because the endpoint already existed, but the original ask was for a "structured response with details on its inner components' health status" — which was never delivered. PR #728 was opened to document the existing endpoint and closed without merging.

    Current behavior

    $ curl -sS https://sourcebot.example.com/api/health
    {"status":"ok"}

    This is a 12-line stub in packages/web/src/app/api/(server)/health/route.ts. It runs on every orchestrator probe interval, logs a debug line, and returns the same payload whether or not Postgres, Redis, or Zoekt are reachable. A pod that has lost its database connection will still report "ok" to a Kubernetes readiness probe, and traffic will continue to be routed to a broken instance.

    Expected behavior

    A new GET /api/health/ready endpoint that:

    • Checks Postgres via __unsafePrisma.$queryRaw\SELECT 1``
    • Checks Redis via redis.ping()
    • Checks Zoekt via a lightweight gRPC call (a List request with q: { and: { children: [] } } and a small opts: { max_wall_time: 1s })
    • Runs the three checks in parallel with a per-check timeout (default 2s)
    • Returns 200 with {"status":"ok","checks":{...}} if all pass
    • Returns 503 with {"status":"degraded","checks":{...}} if any fail; per-check payload includes {status, latencyMs, error?}

    The existing GET /api/health stays exactly as it is (liveness probe) — a process-up signal that does not depend on any external service.

    The two endpoints give operators the standard Kubernetes liveness/readiness pair out of the box.

    Proposed solution

    Add packages/web/src/app/api/(server)/health/ready/route.ts:

    import{apiHandler}from"@/lib/apiHandler";import{__unsafePrisma}from"@/prisma";import{getRedisClient}from"@/lib/redis";import{createLogger}from"@sourcebot/shared";import*asgrpcfrom"@grpc/grpc-js";import*asprotoLoaderfrom"@grpc/proto-loader";importpathfrom"path";import{env}from"@sourcebot/shared";constREADINESS_TIMEOUT_MS=2000;constlogger=createLogger("health-ready");typeCheckResult={status: "ok"|"error";latencyMs: number;error?: string};typeReadinessResponse={status: "ok"|"degraded";checks: Record<string,CheckResult>};// Each check returns a CheckResult after at most READINESS_TIMEOUT_MS.asyncfunctioncheckPostgres(): Promise<CheckResult>{ ... }asyncfunctioncheckRedis(): Promise<CheckResult>{ ... }asyncfunctioncheckZoekt(): Promise<CheckResult>{ ... }exportconstGET=apiHandler(async()=>{const[postgres,redis,zoekt]=awaitPromise.all([checkPostgres(),checkRedis(),checkZoekt(),]);constchecks={ postgres, redis, zoekt };consthealthy=Object.values(checks).every(c=>c.status==="ok");constbody: ReadinessResponse={status: healthy ? "ok" : "degraded",
    checks,};returnResponse.json(body,{status: healthy ? 200 : 503});},{track: false});

    Tests: packages/web/src/app/api/(server)/health/ready/route.test.ts covering the healthy / degraded paths with mocked prisma + redis + gRPC client.

    Docs: a new docs/docs/api-reference/health.mdx describing both endpoints and the liveness-vs-readiness split, with example probes for Docker Compose and Kubernetes. Add it to the API Reference group in docs/docs.json.

    Alternatives considered

    • A single/api/healththat does both. Rejected: makes Kubernetes-style splitting impossible, and a liveness probe that touches the database can cause cascading restarts when the database is briefly unreachable.
    • Prometheus metrics-only (the spirit ofFR: Add Prometheus support #119**).** Rejected for this PR: not actionable from an orchestrator probe. Could be a follow-up — checkZoekt and the timing data are already in the right shape to emit as metrics.
    • AWebserverService.HealthgRPC method. Not available in the vendored Zoekt proto; would require an upstream change. A List with a 1s wall-time cap is the smallest thing that proves the gRPC channel is alive and the server is responsive.

    Scope

    • One new route file + one new test file + one new docs file + one line in docs/docs.json
    • No schema changes
    • No new dependencies
    • No changes to the existing /api/health liveness endpoint
    • No changes to the existing API key, auth, or entitlement systems — this endpoint is unauthenticated and matches the existing /api/health policy (no user data returned)

    Acceptance criteria

    • GET /api/health/ready returns 200 with {"status":"ok",...} when all three dependencies are reachable
    • GET /api/health/ready returns 503 with {"status":"degraded",...} and the failing check's {status:"error", error:...} when any dependency is unreachable
    • All three checks are bounded by a 2s timeout; the worst-case request time is ~2s even when one dependency hangs
    • All three checks run in parallel (Promise.all) — total request time is max(timeouts), not sum(timeouts)
    • GET /api/health (liveness) is unchanged
    • Tests pass for both healthy and each-of-three-degraded permutations
    • Docs page describes both endpoints with example Docker Compose healthcheck: and Kubernetes livenessProbe/readinessProbe blocks
    • No PostHog tracking on the new endpoint (track: false, matching the existing liveness endpoint)
    • A CHANGELOG.md entry under [Unreleased] → Added references this PR

    Backward compatibility

    Fully backwards compatible. The existing /api/health endpoint is unchanged. The new endpoint is purely additive. Operators who do not use it see no change.

    Risks

    • A misconfigured /api/health/ready could cause Kubernetes to pull all pods out of rotation if the probe interval collides with a database blip. Mitigated by the per-check timeout and the standard recommendation of a 3-failure failureThreshold on the readiness probe.
    • The Zoekt gRPC check calls List with a 1s wall-time cap; under load this could add to Zoekt's request rate. The check runs at most once per probe interval per pod; for the default 10s interval on a 3-pod deployment this is ~0.3 RPS, negligible.
    • The getRedisClient() lazy singleton means the first readiness probe on a cold pod will create the Redis connection. The 2s timeout is more than enough headroom for the first connect.

    Future work (out of scope for this PR)

    • Prometheus metrics for each check (sourcebot_readiness_check_duration_seconds{check="postgres"}, etc.) — would build on the same per-check helpers introduced here.
    • A /api/health/ready?strict=true mode that treats Zoekt shards-empty as a degraded state (currently List returns success even with zero repos).
    • A /api/health/metrics JSON endpoint that returns Prometheus-style text without exposing /metrics directly.
    • Cache the readiness result for ~1s to absorb thundering-herd probes from multiple orchestrators.

    Happy to take this on. Implementation plan, test plan, and docs update all fit in one focused PR.

    Activity

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
      Skip to content

      [FR] Add /api/health/ready endpoint with dependency health checks (Postgres, Redis, Zoekt) #1506

      Description

      @Harsh23Kashyap

      Problem

      GET /api/health currently returns a hardcoded { "status": "ok" } regardless of whether Sourcebot's actual dependencies (Postgres, Redis, Zoekt) are reachable. Self-hosted operators using Kubernetes, Docker Compose with a healthcheck, an external load balancer, or a monitoring system cannot distinguish a healthy Sourcebot from one whose database connection has dropped, whose Redis is unreachable, or whose Zoekt indexer is dead.

      The previous FR for this (#727) was closed because the endpoint already existed, but the original ask was for a "structured response with details on its inner components' health status" — which was never delivered. PR #728 was opened to document the existing endpoint and closed without merging.

      Current behavior

      $ curl -sS https://sourcebot.example.com/api/health
      {"status":"ok"}

      This is a 12-line stub in packages/web/src/app/api/(server)/health/route.ts. It runs on every orchestrator probe interval, logs a debug line, and returns the same payload whether or not Postgres, Redis, or Zoekt are reachable. A pod that has lost its database connection will still report "ok" to a Kubernetes readiness probe, and traffic will continue to be routed to a broken instance.

      Expected behavior

      A new GET /api/health/ready endpoint that:

      • Checks Postgres via __unsafePrisma.$queryRaw\SELECT 1``
      • Checks Redis via redis.ping()
      • Checks Zoekt via a lightweight gRPC call (a List request with q: { and: { children: [] } } and a small opts: { max_wall_time: 1s })
      • Runs the three checks in parallel with a per-check timeout (default 2s)
      • Returns 200 with {"status":"ok","checks":{...}} if all pass
      • Returns 503 with {"status":"degraded","checks":{...}} if any fail; per-check payload includes {status, latencyMs, error?}

      The existing GET /api/health stays exactly as it is (liveness probe) — a process-up signal that does not depend on any external service.

      The two endpoints give operators the standard Kubernetes liveness/readiness pair out of the box.

      Proposed solution

      Add packages/web/src/app/api/(server)/health/ready/route.ts:

      import{apiHandler}from"@/lib/apiHandler";import{__unsafePrisma}from"@/prisma";import{getRedisClient}from"@/lib/redis";import{createLogger}from"@sourcebot/shared";import*asgrpcfrom"@grpc/grpc-js";import*asprotoLoaderfrom"@grpc/proto-loader";importpathfrom"path";import{env}from"@sourcebot/shared";constREADINESS_TIMEOUT_MS=2000;constlogger=createLogger("health-ready");typeCheckResult={status: "ok"|"error";latencyMs: number;error?: string};typeReadinessResponse={status: "ok"|"degraded";checks: Record<string,CheckResult>};// Each check returns a CheckResult after at most READINESS_TIMEOUT_MS.asyncfunctioncheckPostgres(): Promise<CheckResult>{ ... }asyncfunctioncheckRedis(): Promise<CheckResult>{ ... }asyncfunctioncheckZoekt(): Promise<CheckResult>{ ... }exportconstGET=apiHandler(async()=>{const[postgres,redis,zoekt]=awaitPromise.all([checkPostgres(),checkRedis(),checkZoekt(),]);constchecks={ postgres, redis, zoekt };consthealthy=Object.values(checks).every(c=>c.status==="ok");constbody: ReadinessResponse={status: healthy ? "ok" : "degraded",
      checks,};returnResponse.json(body,{status: healthy ? 200 : 503});},{track: false});

      Tests: packages/web/src/app/api/(server)/health/ready/route.test.ts covering the healthy / degraded paths with mocked prisma + redis + gRPC client.

      Docs: a new docs/docs/api-reference/health.mdx describing both endpoints and the liveness-vs-readiness split, with example probes for Docker Compose and Kubernetes. Add it to the API Reference group in docs/docs.json.

      Alternatives considered

      • A single/api/healththat does both. Rejected: makes Kubernetes-style splitting impossible, and a liveness probe that touches the database can cause cascading restarts when the database is briefly unreachable.
      • Prometheus metrics-only (the spirit ofFR: Add Prometheus support #119**).** Rejected for this PR: not actionable from an orchestrator probe. Could be a follow-up — checkZoekt and the timing data are already in the right shape to emit as metrics.
      • AWebserverService.HealthgRPC method. Not available in the vendored Zoekt proto; would require an upstream change. A List with a 1s wall-time cap is the smallest thing that proves the gRPC channel is alive and the server is responsive.

      Scope

      • One new route file + one new test file + one new docs file + one line in docs/docs.json
      • No schema changes
      • No new dependencies
      • No changes to the existing /api/health liveness endpoint
      • No changes to the existing API key, auth, or entitlement systems — this endpoint is unauthenticated and matches the existing /api/health policy (no user data returned)

      Acceptance criteria

      • GET /api/health/ready returns 200 with {"status":"ok",...} when all three dependencies are reachable
      • GET /api/health/ready returns 503 with {"status":"degraded",...} and the failing check's {status:"error", error:...} when any dependency is unreachable
      • All three checks are bounded by a 2s timeout; the worst-case request time is ~2s even when one dependency hangs
      • All three checks run in parallel (Promise.all) — total request time is max(timeouts), not sum(timeouts)
      • GET /api/health (liveness) is unchanged
      • Tests pass for both healthy and each-of-three-degraded permutations
      • Docs page describes both endpoints with example Docker Compose healthcheck: and Kubernetes livenessProbe/readinessProbe blocks
      • No PostHog tracking on the new endpoint (track: false, matching the existing liveness endpoint)
      • A CHANGELOG.md entry under [Unreleased] → Added references this PR

      Backward compatibility

      Fully backwards compatible. The existing /api/health endpoint is unchanged. The new endpoint is purely additive. Operators who do not use it see no change.

      Risks

      • A misconfigured /api/health/ready could cause Kubernetes to pull all pods out of rotation if the probe interval collides with a database blip. Mitigated by the per-check timeout and the standard recommendation of a 3-failure failureThreshold on the readiness probe.
      • The Zoekt gRPC check calls List with a 1s wall-time cap; under load this could add to Zoekt's request rate. The check runs at most once per probe interval per pod; for the default 10s interval on a 3-pod deployment this is ~0.3 RPS, negligible.
      • The getRedisClient() lazy singleton means the first readiness probe on a cold pod will create the Redis connection. The 2s timeout is more than enough headroom for the first connect.

      Future work (out of scope for this PR)

      • Prometheus metrics for each check (sourcebot_readiness_check_duration_seconds{check="postgres"}, etc.) — would build on the same per-check helpers introduced here.
      • A /api/health/ready?strict=true mode that treats Zoekt shards-empty as a degraded state (currently List returns success even with zero repos).
      • A /api/health/metrics JSON endpoint that returns Prometheus-style text without exposing /metrics directly.
      • Cache the readiness result for ~1s to absorb thundering-herd probes from multiple orchestrators.

      Happy to take this on. Implementation plan, test plan, and docs update all fit in one focused PR.

      Activity

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

      Metadata

      Metadata

      Labels

      No labels
      No labels

      Type

      No type

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions

        , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
        Skip to content

        [FR] Add /api/health/ready endpoint with dependency health checks (Postgres, Redis, Zoekt) #1506

        Description

        @Harsh23Kashyap

        Problem

        GET /api/health currently returns a hardcoded { "status": "ok" } regardless of whether Sourcebot's actual dependencies (Postgres, Redis, Zoekt) are reachable. Self-hosted operators using Kubernetes, Docker Compose with a healthcheck, an external load balancer, or a monitoring system cannot distinguish a healthy Sourcebot from one whose database connection has dropped, whose Redis is unreachable, or whose Zoekt indexer is dead.

        The previous FR for this (#727) was closed because the endpoint already existed, but the original ask was for a "structured response with details on its inner components' health status" — which was never delivered. PR #728 was opened to document the existing endpoint and closed without merging.

        Current behavior

        $ curl -sS https://sourcebot.example.com/api/health
        {"status":"ok"}

        This is a 12-line stub in packages/web/src/app/api/(server)/health/route.ts. It runs on every orchestrator probe interval, logs a debug line, and returns the same payload whether or not Postgres, Redis, or Zoekt are reachable. A pod that has lost its database connection will still report "ok" to a Kubernetes readiness probe, and traffic will continue to be routed to a broken instance.

        Expected behavior

        A new GET /api/health/ready endpoint that:

        • Checks Postgres via __unsafePrisma.$queryRaw\SELECT 1``
        • Checks Redis via redis.ping()
        • Checks Zoekt via a lightweight gRPC call (a List request with q: { and: { children: [] } } and a small opts: { max_wall_time: 1s })
        • Runs the three checks in parallel with a per-check timeout (default 2s)
        • Returns 200 with {"status":"ok","checks":{...}} if all pass
        • Returns 503 with {"status":"degraded","checks":{...}} if any fail; per-check payload includes {status, latencyMs, error?}

        The existing GET /api/health stays exactly as it is (liveness probe) — a process-up signal that does not depend on any external service.

        The two endpoints give operators the standard Kubernetes liveness/readiness pair out of the box.

        Proposed solution

        Add packages/web/src/app/api/(server)/health/ready/route.ts:

        import{apiHandler}from"@/lib/apiHandler";import{__unsafePrisma}from"@/prisma";import{getRedisClient}from"@/lib/redis";import{createLogger}from"@sourcebot/shared";import*asgrpcfrom"@grpc/grpc-js";import*asprotoLoaderfrom"@grpc/proto-loader";importpathfrom"path";import{env}from"@sourcebot/shared";constREADINESS_TIMEOUT_MS=2000;constlogger=createLogger("health-ready");typeCheckResult={status: "ok"|"error";latencyMs: number;error?: string};typeReadinessResponse={status: "ok"|"degraded";checks: Record<string,CheckResult>};// Each check returns a CheckResult after at most READINESS_TIMEOUT_MS.asyncfunctioncheckPostgres(): Promise<CheckResult>{ ... }asyncfunctioncheckRedis(): Promise<CheckResult>{ ... }asyncfunctioncheckZoekt(): Promise<CheckResult>{ ... }exportconstGET=apiHandler(async()=>{const[postgres,redis,zoekt]=awaitPromise.all([checkPostgres(),checkRedis(),checkZoekt(),]);constchecks={ postgres, redis, zoekt };consthealthy=Object.values(checks).every(c=>c.status==="ok");constbody: ReadinessResponse={status: healthy ? "ok" : "degraded",
        checks,};returnResponse.json(body,{status: healthy ? 200 : 503});},{track: false});

        Tests: packages/web/src/app/api/(server)/health/ready/route.test.ts covering the healthy / degraded paths with mocked prisma + redis + gRPC client.

        Docs: a new docs/docs/api-reference/health.mdx describing both endpoints and the liveness-vs-readiness split, with example probes for Docker Compose and Kubernetes. Add it to the API Reference group in docs/docs.json.

        Alternatives considered

        • A single/api/healththat does both. Rejected: makes Kubernetes-style splitting impossible, and a liveness probe that touches the database can cause cascading restarts when the database is briefly unreachable.
        • Prometheus metrics-only (the spirit ofFR: Add Prometheus support #119**).** Rejected for this PR: not actionable from an orchestrator probe. Could be a follow-up — checkZoekt and the timing data are already in the right shape to emit as metrics.
        • AWebserverService.HealthgRPC method. Not available in the vendored Zoekt proto; would require an upstream change. A List with a 1s wall-time cap is the smallest thing that proves the gRPC channel is alive and the server is responsive.

        Scope

        • One new route file + one new test file + one new docs file + one line in docs/docs.json
        • No schema changes
        • No new dependencies
        • No changes to the existing /api/health liveness endpoint
        • No changes to the existing API key, auth, or entitlement systems — this endpoint is unauthenticated and matches the existing /api/health policy (no user data returned)

        Acceptance criteria

        • GET /api/health/ready returns 200 with {"status":"ok",...} when all three dependencies are reachable
        • GET /api/health/ready returns 503 with {"status":"degraded",...} and the failing check's {status:"error", error:...} when any dependency is unreachable
        • All three checks are bounded by a 2s timeout; the worst-case request time is ~2s even when one dependency hangs
        • All three checks run in parallel (Promise.all) — total request time is max(timeouts), not sum(timeouts)
        • GET /api/health (liveness) is unchanged
        • Tests pass for both healthy and each-of-three-degraded permutations
        • Docs page describes both endpoints with example Docker Compose healthcheck: and Kubernetes livenessProbe/readinessProbe blocks
        • No PostHog tracking on the new endpoint (track: false, matching the existing liveness endpoint)
        • A CHANGELOG.md entry under [Unreleased] → Added references this PR

        Backward compatibility

        Fully backwards compatible. The existing /api/health endpoint is unchanged. The new endpoint is purely additive. Operators who do not use it see no change.

        Risks

        • A misconfigured /api/health/ready could cause Kubernetes to pull all pods out of rotation if the probe interval collides with a database blip. Mitigated by the per-check timeout and the standard recommendation of a 3-failure failureThreshold on the readiness probe.
        • The Zoekt gRPC check calls List with a 1s wall-time cap; under load this could add to Zoekt's request rate. The check runs at most once per probe interval per pod; for the default 10s interval on a 3-pod deployment this is ~0.3 RPS, negligible.
        • The getRedisClient() lazy singleton means the first readiness probe on a cold pod will create the Redis connection. The 2s timeout is more than enough headroom for the first connect.

        Future work (out of scope for this PR)

        • Prometheus metrics for each check (sourcebot_readiness_check_duration_seconds{check="postgres"}, etc.) — would build on the same per-check helpers introduced here.
        • A /api/health/ready?strict=true mode that treats Zoekt shards-empty as a degraded state (currently List returns success even with zero repos).
        • A /api/health/metrics JSON endpoint that returns Prometheus-style text without exposing /metrics directly.
        • Cache the readiness result for ~1s to absorb thundering-herd probes from multiple orchestrators.

        Happy to take this on. Implementation plan, test plan, and docs update all fit in one focused PR.

        Activity

        Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

        Metadata

        Metadata

        Labels

        No labels
        No labels

        Type

        No type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
          Skip to content

          [FR] Add /api/health/ready endpoint with dependency health checks (Postgres, Redis, Zoekt) #1506

          Description

          @Harsh23Kashyap

          Problem

          GET /api/health currently returns a hardcoded { "status": "ok" } regardless of whether Sourcebot's actual dependencies (Postgres, Redis, Zoekt) are reachable. Self-hosted operators using Kubernetes, Docker Compose with a healthcheck, an external load balancer, or a monitoring system cannot distinguish a healthy Sourcebot from one whose database connection has dropped, whose Redis is unreachable, or whose Zoekt indexer is dead.

          The previous FR for this (#727) was closed because the endpoint already existed, but the original ask was for a "structured response with details on its inner components' health status" — which was never delivered. PR #728 was opened to document the existing endpoint and closed without merging.

          Current behavior

          $ curl -sS https://sourcebot.example.com/api/health
          {"status":"ok"}

          This is a 12-line stub in packages/web/src/app/api/(server)/health/route.ts. It runs on every orchestrator probe interval, logs a debug line, and returns the same payload whether or not Postgres, Redis, or Zoekt are reachable. A pod that has lost its database connection will still report "ok" to a Kubernetes readiness probe, and traffic will continue to be routed to a broken instance.

          Expected behavior

          A new GET /api/health/ready endpoint that:

          • Checks Postgres via __unsafePrisma.$queryRaw\SELECT 1``
          • Checks Redis via redis.ping()
          • Checks Zoekt via a lightweight gRPC call (a List request with q: { and: { children: [] } } and a small opts: { max_wall_time: 1s })
          • Runs the three checks in parallel with a per-check timeout (default 2s)
          • Returns 200 with {"status":"ok","checks":{...}} if all pass
          • Returns 503 with {"status":"degraded","checks":{...}} if any fail; per-check payload includes {status, latencyMs, error?}

          The existing GET /api/health stays exactly as it is (liveness probe) — a process-up signal that does not depend on any external service.

          The two endpoints give operators the standard Kubernetes liveness/readiness pair out of the box.

          Proposed solution

          Add packages/web/src/app/api/(server)/health/ready/route.ts:

          import{apiHandler}from"@/lib/apiHandler";import{__unsafePrisma}from"@/prisma";import{getRedisClient}from"@/lib/redis";import{createLogger}from"@sourcebot/shared";import*asgrpcfrom"@grpc/grpc-js";import*asprotoLoaderfrom"@grpc/proto-loader";importpathfrom"path";import{env}from"@sourcebot/shared";constREADINESS_TIMEOUT_MS=2000;constlogger=createLogger("health-ready");typeCheckResult={status: "ok"|"error";latencyMs: number;error?: string};typeReadinessResponse={status: "ok"|"degraded";checks: Record<string,CheckResult>};// Each check returns a CheckResult after at most READINESS_TIMEOUT_MS.asyncfunctioncheckPostgres(): Promise<CheckResult>{ ... }asyncfunctioncheckRedis(): Promise<CheckResult>{ ... }asyncfunctioncheckZoekt(): Promise<CheckResult>{ ... }exportconstGET=apiHandler(async()=>{const[postgres,redis,zoekt]=awaitPromise.all([checkPostgres(),checkRedis(),checkZoekt(),]);constchecks={ postgres, redis, zoekt };consthealthy=Object.values(checks).every(c=>c.status==="ok");constbody: ReadinessResponse={status: healthy ? "ok" : "degraded",
          checks,};returnResponse.json(body,{status: healthy ? 200 : 503});},{track: false});

          Tests: packages/web/src/app/api/(server)/health/ready/route.test.ts covering the healthy / degraded paths with mocked prisma + redis + gRPC client.

          Docs: a new docs/docs/api-reference/health.mdx describing both endpoints and the liveness-vs-readiness split, with example probes for Docker Compose and Kubernetes. Add it to the API Reference group in docs/docs.json.

          Alternatives considered

          • A single/api/healththat does both. Rejected: makes Kubernetes-style splitting impossible, and a liveness probe that touches the database can cause cascading restarts when the database is briefly unreachable.
          • Prometheus metrics-only (the spirit ofFR: Add Prometheus support #119**).** Rejected for this PR: not actionable from an orchestrator probe. Could be a follow-up — checkZoekt and the timing data are already in the right shape to emit as metrics.
          • AWebserverService.HealthgRPC method. Not available in the vendored Zoekt proto; would require an upstream change. A List with a 1s wall-time cap is the smallest thing that proves the gRPC channel is alive and the server is responsive.

          Scope

          • One new route file + one new test file + one new docs file + one line in docs/docs.json
          • No schema changes
          • No new dependencies
          • No changes to the existing /api/health liveness endpoint
          • No changes to the existing API key, auth, or entitlement systems — this endpoint is unauthenticated and matches the existing /api/health policy (no user data returned)

          Acceptance criteria

          • GET /api/health/ready returns 200 with {"status":"ok",...} when all three dependencies are reachable
          • GET /api/health/ready returns 503 with {"status":"degraded",...} and the failing check's {status:"error", error:...} when any dependency is unreachable
          • All three checks are bounded by a 2s timeout; the worst-case request time is ~2s even when one dependency hangs
          • All three checks run in parallel (Promise.all) — total request time is max(timeouts), not sum(timeouts)
          • GET /api/health (liveness) is unchanged
          • Tests pass for both healthy and each-of-three-degraded permutations
          • Docs page describes both endpoints with example Docker Compose healthcheck: and Kubernetes livenessProbe/readinessProbe blocks
          • No PostHog tracking on the new endpoint (track: false, matching the existing liveness endpoint)
          • A CHANGELOG.md entry under [Unreleased] → Added references this PR

          Backward compatibility

          Fully backwards compatible. The existing /api/health endpoint is unchanged. The new endpoint is purely additive. Operators who do not use it see no change.

          Risks

          • A misconfigured /api/health/ready could cause Kubernetes to pull all pods out of rotation if the probe interval collides with a database blip. Mitigated by the per-check timeout and the standard recommendation of a 3-failure failureThreshold on the readiness probe.
          • The Zoekt gRPC check calls List with a 1s wall-time cap; under load this could add to Zoekt's request rate. The check runs at most once per probe interval per pod; for the default 10s interval on a 3-pod deployment this is ~0.3 RPS, negligible.
          • The getRedisClient() lazy singleton means the first readiness probe on a cold pod will create the Redis connection. The 2s timeout is more than enough headroom for the first connect.

          Future work (out of scope for this PR)

          • Prometheus metrics for each check (sourcebot_readiness_check_duration_seconds{check="postgres"}, etc.) — would build on the same per-check helpers introduced here.
          • A /api/health/ready?strict=true mode that treats Zoekt shards-empty as a degraded state (currently List returns success even with zero repos).
          • A /api/health/metrics JSON endpoint that returns Prometheus-style text without exposing /metrics directly.
          • Cache the readiness result for ~1s to absorb thundering-herd probes from multiple orchestrators.

          Happy to take this on. Implementation plan, test plan, and docs update all fit in one focused PR.

          Activity

          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

          Metadata

          Metadata

          Labels

          No labels
          No labels

          Type

          No type

          Projects

          No projects

            Milestone

            No milestone

            Relationships

            None yet

            Development

            No branches or pull requests

            Issue actions

            , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
            Skip to content

            [FR] Add /api/health/ready endpoint with dependency health checks (Postgres, Redis, Zoekt) #1506

            Description

            @Harsh23Kashyap

            Problem

            GET /api/health currently returns a hardcoded { "status": "ok" } regardless of whether Sourcebot's actual dependencies (Postgres, Redis, Zoekt) are reachable. Self-hosted operators using Kubernetes, Docker Compose with a healthcheck, an external load balancer, or a monitoring system cannot distinguish a healthy Sourcebot from one whose database connection has dropped, whose Redis is unreachable, or whose Zoekt indexer is dead.

            The previous FR for this (#727) was closed because the endpoint already existed, but the original ask was for a "structured response with details on its inner components' health status" — which was never delivered. PR #728 was opened to document the existing endpoint and closed without merging.

            Current behavior

            $ curl -sS https://sourcebot.example.com/api/health
            {"status":"ok"}

            This is a 12-line stub in packages/web/src/app/api/(server)/health/route.ts. It runs on every orchestrator probe interval, logs a debug line, and returns the same payload whether or not Postgres, Redis, or Zoekt are reachable. A pod that has lost its database connection will still report "ok" to a Kubernetes readiness probe, and traffic will continue to be routed to a broken instance.

            Expected behavior

            A new GET /api/health/ready endpoint that:

            • Checks Postgres via __unsafePrisma.$queryRaw\SELECT 1``
            • Checks Redis via redis.ping()
            • Checks Zoekt via a lightweight gRPC call (a List request with q: { and: { children: [] } } and a small opts: { max_wall_time: 1s })
            • Runs the three checks in parallel with a per-check timeout (default 2s)
            • Returns 200 with {"status":"ok","checks":{...}} if all pass
            • Returns 503 with {"status":"degraded","checks":{...}} if any fail; per-check payload includes {status, latencyMs, error?}

            The existing GET /api/health stays exactly as it is (liveness probe) — a process-up signal that does not depend on any external service.

            The two endpoints give operators the standard Kubernetes liveness/readiness pair out of the box.

            Proposed solution

            Add packages/web/src/app/api/(server)/health/ready/route.ts:

            import{apiHandler}from"@/lib/apiHandler";import{__unsafePrisma}from"@/prisma";import{getRedisClient}from"@/lib/redis";import{createLogger}from"@sourcebot/shared";import*asgrpcfrom"@grpc/grpc-js";import*asprotoLoaderfrom"@grpc/proto-loader";importpathfrom"path";import{env}from"@sourcebot/shared";constREADINESS_TIMEOUT_MS=2000;constlogger=createLogger("health-ready");typeCheckResult={status: "ok"|"error";latencyMs: number;error?: string};typeReadinessResponse={status: "ok"|"degraded";checks: Record<string,CheckResult>};// Each check returns a CheckResult after at most READINESS_TIMEOUT_MS.asyncfunctioncheckPostgres(): Promise<CheckResult>{ ... }asyncfunctioncheckRedis(): Promise<CheckResult>{ ... }asyncfunctioncheckZoekt(): Promise<CheckResult>{ ... }exportconstGET=apiHandler(async()=>{const[postgres,redis,zoekt]=awaitPromise.all([checkPostgres(),checkRedis(),checkZoekt(),]);constchecks={ postgres, redis, zoekt };consthealthy=Object.values(checks).every(c=>c.status==="ok");constbody: ReadinessResponse={status: healthy ? "ok" : "degraded",
            checks,};returnResponse.json(body,{status: healthy ? 200 : 503});},{track: false});

            Tests: packages/web/src/app/api/(server)/health/ready/route.test.ts covering the healthy / degraded paths with mocked prisma + redis + gRPC client.

            Docs: a new docs/docs/api-reference/health.mdx describing both endpoints and the liveness-vs-readiness split, with example probes for Docker Compose and Kubernetes. Add it to the API Reference group in docs/docs.json.

            Alternatives considered

            • A single/api/healththat does both. Rejected: makes Kubernetes-style splitting impossible, and a liveness probe that touches the database can cause cascading restarts when the database is briefly unreachable.
            • Prometheus metrics-only (the spirit ofFR: Add Prometheus support #119**).** Rejected for this PR: not actionable from an orchestrator probe. Could be a follow-up — checkZoekt and the timing data are already in the right shape to emit as metrics.
            • AWebserverService.HealthgRPC method. Not available in the vendored Zoekt proto; would require an upstream change. A List with a 1s wall-time cap is the smallest thing that proves the gRPC channel is alive and the server is responsive.

            Scope

            • One new route file + one new test file + one new docs file + one line in docs/docs.json
            • No schema changes
            • No new dependencies
            • No changes to the existing /api/health liveness endpoint
            • No changes to the existing API key, auth, or entitlement systems — this endpoint is unauthenticated and matches the existing /api/health policy (no user data returned)

            Acceptance criteria

            • GET /api/health/ready returns 200 with {"status":"ok",...} when all three dependencies are reachable
            • GET /api/health/ready returns 503 with {"status":"degraded",...} and the failing check's {status:"error", error:...} when any dependency is unreachable
            • All three checks are bounded by a 2s timeout; the worst-case request time is ~2s even when one dependency hangs
            • All three checks run in parallel (Promise.all) — total request time is max(timeouts), not sum(timeouts)
            • GET /api/health (liveness) is unchanged
            • Tests pass for both healthy and each-of-three-degraded permutations
            • Docs page describes both endpoints with example Docker Compose healthcheck: and Kubernetes livenessProbe/readinessProbe blocks
            • No PostHog tracking on the new endpoint (track: false, matching the existing liveness endpoint)
            • A CHANGELOG.md entry under [Unreleased] → Added references this PR

            Backward compatibility

            Fully backwards compatible. The existing /api/health endpoint is unchanged. The new endpoint is purely additive. Operators who do not use it see no change.

            Risks

            • A misconfigured /api/health/ready could cause Kubernetes to pull all pods out of rotation if the probe interval collides with a database blip. Mitigated by the per-check timeout and the standard recommendation of a 3-failure failureThreshold on the readiness probe.
            • The Zoekt gRPC check calls List with a 1s wall-time cap; under load this could add to Zoekt's request rate. The check runs at most once per probe interval per pod; for the default 10s interval on a 3-pod deployment this is ~0.3 RPS, negligible.
            • The getRedisClient() lazy singleton means the first readiness probe on a cold pod will create the Redis connection. The 2s timeout is more than enough headroom for the first connect.

            Future work (out of scope for this PR)

            • Prometheus metrics for each check (sourcebot_readiness_check_duration_seconds{check="postgres"}, etc.) — would build on the same per-check helpers introduced here.
            • A /api/health/ready?strict=true mode that treats Zoekt shards-empty as a degraded state (currently List returns success even with zero repos).
            • A /api/health/metrics JSON endpoint that returns Prometheus-style text without exposing /metrics directly.
            • Cache the readiness result for ~1s to absorb thundering-herd probes from multiple orchestrators.

            Happy to take this on. Implementation plan, test plan, and docs update all fit in one focused PR.

            Activity

            Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

            Metadata

            Metadata

            Labels

            No labels
            No labels

            Type

            No type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              [FR] Add /api/health/ready endpoint with dependency health checks (Postgres, Redis, Zoekt) #1506

              Description

              @Harsh23Kashyap

              Problem

              GET /api/health currently returns a hardcoded { "status": "ok" } regardless of whether Sourcebot's actual dependencies (Postgres, Redis, Zoekt) are reachable. Self-hosted operators using Kubernetes, Docker Compose with a healthcheck, an external load balancer, or a monitoring system cannot distinguish a healthy Sourcebot from one whose database connection has dropped, whose Redis is unreachable, or whose Zoekt indexer is dead.

              The previous FR for this (#727) was closed because the endpoint already existed, but the original ask was for a "structured response with details on its inner components' health status" — which was never delivered. PR #728 was opened to document the existing endpoint and closed without merging.

              Current behavior

              $ curl -sS https://sourcebot.example.com/api/health
              {"status":"ok"}

              This is a 12-line stub in packages/web/src/app/api/(server)/health/route.ts. It runs on every orchestrator probe interval, logs a debug line, and returns the same payload whether or not Postgres, Redis, or Zoekt are reachable. A pod that has lost its database connection will still report "ok" to a Kubernetes readiness probe, and traffic will continue to be routed to a broken instance.

              Expected behavior

              A new GET /api/health/ready endpoint that:

              • Checks Postgres via __unsafePrisma.$queryRaw\SELECT 1``
              • Checks Redis via redis.ping()
              • Checks Zoekt via a lightweight gRPC call (a List request with q: { and: { children: [] } } and a small opts: { max_wall_time: 1s })
              • Runs the three checks in parallel with a per-check timeout (default 2s)
              • Returns 200 with {"status":"ok","checks":{...}} if all pass
              • Returns 503 with {"status":"degraded","checks":{...}} if any fail; per-check payload includes {status, latencyMs, error?}

              The existing GET /api/health stays exactly as it is (liveness probe) — a process-up signal that does not depend on any external service.

              The two endpoints give operators the standard Kubernetes liveness/readiness pair out of the box.

              Proposed solution

              Add packages/web/src/app/api/(server)/health/ready/route.ts:

              import{apiHandler}from"@/lib/apiHandler";import{__unsafePrisma}from"@/prisma";import{getRedisClient}from"@/lib/redis";import{createLogger}from"@sourcebot/shared";import*asgrpcfrom"@grpc/grpc-js";import*asprotoLoaderfrom"@grpc/proto-loader";importpathfrom"path";import{env}from"@sourcebot/shared";constREADINESS_TIMEOUT_MS=2000;constlogger=createLogger("health-ready");typeCheckResult={status: "ok"|"error";latencyMs: number;error?: string};typeReadinessResponse={status: "ok"|"degraded";checks: Record<string,CheckResult>};// Each check returns a CheckResult after at most READINESS_TIMEOUT_MS.asyncfunctioncheckPostgres(): Promise<CheckResult>{ ... }asyncfunctioncheckRedis(): Promise<CheckResult>{ ... }asyncfunctioncheckZoekt(): Promise<CheckResult>{ ... }exportconstGET=apiHandler(async()=>{const[postgres,redis,zoekt]=awaitPromise.all([checkPostgres(),checkRedis(),checkZoekt(),]);constchecks={ postgres, redis, zoekt };consthealthy=Object.values(checks).every(c=>c.status==="ok");constbody: ReadinessResponse={status: healthy ? "ok" : "degraded",
              checks,};returnResponse.json(body,{status: healthy ? 200 : 503});},{track: false});

              Tests: packages/web/src/app/api/(server)/health/ready/route.test.ts covering the healthy / degraded paths with mocked prisma + redis + gRPC client.

              Docs: a new docs/docs/api-reference/health.mdx describing both endpoints and the liveness-vs-readiness split, with example probes for Docker Compose and Kubernetes. Add it to the API Reference group in docs/docs.json.

              Alternatives considered

              • A single/api/healththat does both. Rejected: makes Kubernetes-style splitting impossible, and a liveness probe that touches the database can cause cascading restarts when the database is briefly unreachable.
              • Prometheus metrics-only (the spirit ofFR: Add Prometheus support #119**).** Rejected for this PR: not actionable from an orchestrator probe. Could be a follow-up — checkZoekt and the timing data are already in the right shape to emit as metrics.
              • AWebserverService.HealthgRPC method. Not available in the vendored Zoekt proto; would require an upstream change. A List with a 1s wall-time cap is the smallest thing that proves the gRPC channel is alive and the server is responsive.

              Scope

              • One new route file + one new test file + one new docs file + one line in docs/docs.json
              • No schema changes
              • No new dependencies
              • No changes to the existing /api/health liveness endpoint
              • No changes to the existing API key, auth, or entitlement systems — this endpoint is unauthenticated and matches the existing /api/health policy (no user data returned)

              Acceptance criteria

              • GET /api/health/ready returns 200 with {"status":"ok",...} when all three dependencies are reachable
              • GET /api/health/ready returns 503 with {"status":"degraded",...} and the failing check's {status:"error", error:...} when any dependency is unreachable
              • All three checks are bounded by a 2s timeout; the worst-case request time is ~2s even when one dependency hangs
              • All three checks run in parallel (Promise.all) — total request time is max(timeouts), not sum(timeouts)
              • GET /api/health (liveness) is unchanged
              • Tests pass for both healthy and each-of-three-degraded permutations
              • Docs page describes both endpoints with example Docker Compose healthcheck: and Kubernetes livenessProbe/readinessProbe blocks
              • No PostHog tracking on the new endpoint (track: false, matching the existing liveness endpoint)
              • A CHANGELOG.md entry under [Unreleased] → Added references this PR

              Backward compatibility

              Fully backwards compatible. The existing /api/health endpoint is unchanged. The new endpoint is purely additive. Operators who do not use it see no change.

              Risks

              • A misconfigured /api/health/ready could cause Kubernetes to pull all pods out of rotation if the probe interval collides with a database blip. Mitigated by the per-check timeout and the standard recommendation of a 3-failure failureThreshold on the readiness probe.
              • The Zoekt gRPC check calls List with a 1s wall-time cap; under load this could add to Zoekt's request rate. The check runs at most once per probe interval per pod; for the default 10s interval on a 3-pod deployment this is ~0.3 RPS, negligible.
              • The getRedisClient() lazy singleton means the first readiness probe on a cold pod will create the Redis connection. The 2s timeout is more than enough headroom for the first connect.

              Future work (out of scope for this PR)

              • Prometheus metrics for each check (sourcebot_readiness_check_duration_seconds{check="postgres"}, etc.) — would build on the same per-check helpers introduced here.
              • A /api/health/ready?strict=true mode that treats Zoekt shards-empty as a degraded state (currently List returns success even with zero repos).
              • A /api/health/metrics JSON endpoint that returns Prometheus-style text without exposing /metrics directly.
              • Cache the readiness result for ~1s to absorb thundering-herd probes from multiple orchestrators.

              Happy to take this on. Implementation plan, test plan, and docs update all fit in one focused PR.

              Activity

              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

              Metadata

              Metadata

              Labels

              No labels
              No labels

              Type

              No type

              Projects

              No projects

                Milestone

                No milestone

                Relationships

                None yet

                Development

                No branches or pull requests

                Issue actions

                , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                Skip to content

                [FR] Add /api/health/ready endpoint with dependency health checks (Postgres, Redis, Zoekt) #1506

                Description

                @Harsh23Kashyap

                Problem

                GET /api/health currently returns a hardcoded { "status": "ok" } regardless of whether Sourcebot's actual dependencies (Postgres, Redis, Zoekt) are reachable. Self-hosted operators using Kubernetes, Docker Compose with a healthcheck, an external load balancer, or a monitoring system cannot distinguish a healthy Sourcebot from one whose database connection has dropped, whose Redis is unreachable, or whose Zoekt indexer is dead.

                The previous FR for this (#727) was closed because the endpoint already existed, but the original ask was for a "structured response with details on its inner components' health status" — which was never delivered. PR #728 was opened to document the existing endpoint and closed without merging.

                Current behavior

                $ curl -sS https://sourcebot.example.com/api/health
                {"status":"ok"}

                This is a 12-line stub in packages/web/src/app/api/(server)/health/route.ts. It runs on every orchestrator probe interval, logs a debug line, and returns the same payload whether or not Postgres, Redis, or Zoekt are reachable. A pod that has lost its database connection will still report "ok" to a Kubernetes readiness probe, and traffic will continue to be routed to a broken instance.

                Expected behavior

                A new GET /api/health/ready endpoint that:

                • Checks Postgres via __unsafePrisma.$queryRaw\SELECT 1``
                • Checks Redis via redis.ping()
                • Checks Zoekt via a lightweight gRPC call (a List request with q: { and: { children: [] } } and a small opts: { max_wall_time: 1s })
                • Runs the three checks in parallel with a per-check timeout (default 2s)
                • Returns 200 with {"status":"ok","checks":{...}} if all pass
                • Returns 503 with {"status":"degraded","checks":{...}} if any fail; per-check payload includes {status, latencyMs, error?}

                The existing GET /api/health stays exactly as it is (liveness probe) — a process-up signal that does not depend on any external service.

                The two endpoints give operators the standard Kubernetes liveness/readiness pair out of the box.

                Proposed solution

                Add packages/web/src/app/api/(server)/health/ready/route.ts:

                import{apiHandler}from"@/lib/apiHandler";import{__unsafePrisma}from"@/prisma";import{getRedisClient}from"@/lib/redis";import{createLogger}from"@sourcebot/shared";import*asgrpcfrom"@grpc/grpc-js";import*asprotoLoaderfrom"@grpc/proto-loader";importpathfrom"path";import{env}from"@sourcebot/shared";constREADINESS_TIMEOUT_MS=2000;constlogger=createLogger("health-ready");typeCheckResult={status: "ok"|"error";latencyMs: number;error?: string};typeReadinessResponse={status: "ok"|"degraded";checks: Record<string,CheckResult>};// Each check returns a CheckResult after at most READINESS_TIMEOUT_MS.asyncfunctioncheckPostgres(): Promise<CheckResult>{ ... }asyncfunctioncheckRedis(): Promise<CheckResult>{ ... }asyncfunctioncheckZoekt(): Promise<CheckResult>{ ... }exportconstGET=apiHandler(async()=>{const[postgres,redis,zoekt]=awaitPromise.all([checkPostgres(),checkRedis(),checkZoekt(),]);constchecks={ postgres, redis, zoekt };consthealthy=Object.values(checks).every(c=>c.status==="ok");constbody: ReadinessResponse={status: healthy ? "ok" : "degraded",
                checks,};returnResponse.json(body,{status: healthy ? 200 : 503});},{track: false});

                Tests: packages/web/src/app/api/(server)/health/ready/route.test.ts covering the healthy / degraded paths with mocked prisma + redis + gRPC client.

                Docs: a new docs/docs/api-reference/health.mdx describing both endpoints and the liveness-vs-readiness split, with example probes for Docker Compose and Kubernetes. Add it to the API Reference group in docs/docs.json.

                Alternatives considered

                • A single/api/healththat does both. Rejected: makes Kubernetes-style splitting impossible, and a liveness probe that touches the database can cause cascading restarts when the database is briefly unreachable.
                • Prometheus metrics-only (the spirit ofFR: Add Prometheus support #119**).** Rejected for this PR: not actionable from an orchestrator probe. Could be a follow-up — checkZoekt and the timing data are already in the right shape to emit as metrics.
                • AWebserverService.HealthgRPC method. Not available in the vendored Zoekt proto; would require an upstream change. A List with a 1s wall-time cap is the smallest thing that proves the gRPC channel is alive and the server is responsive.

                Scope

                • One new route file + one new test file + one new docs file + one line in docs/docs.json
                • No schema changes
                • No new dependencies
                • No changes to the existing /api/health liveness endpoint
                • No changes to the existing API key, auth, or entitlement systems — this endpoint is unauthenticated and matches the existing /api/health policy (no user data returned)

                Acceptance criteria

                • GET /api/health/ready returns 200 with {"status":"ok",...} when all three dependencies are reachable
                • GET /api/health/ready returns 503 with {"status":"degraded",...} and the failing check's {status:"error", error:...} when any dependency is unreachable
                • All three checks are bounded by a 2s timeout; the worst-case request time is ~2s even when one dependency hangs
                • All three checks run in parallel (Promise.all) — total request time is max(timeouts), not sum(timeouts)
                • GET /api/health (liveness) is unchanged
                • Tests pass for both healthy and each-of-three-degraded permutations
                • Docs page describes both endpoints with example Docker Compose healthcheck: and Kubernetes livenessProbe/readinessProbe blocks
                • No PostHog tracking on the new endpoint (track: false, matching the existing liveness endpoint)
                • A CHANGELOG.md entry under [Unreleased] → Added references this PR

                Backward compatibility

                Fully backwards compatible. The existing /api/health endpoint is unchanged. The new endpoint is purely additive. Operators who do not use it see no change.

                Risks

                • A misconfigured /api/health/ready could cause Kubernetes to pull all pods out of rotation if the probe interval collides with a database blip. Mitigated by the per-check timeout and the standard recommendation of a 3-failure failureThreshold on the readiness probe.
                • The Zoekt gRPC check calls List with a 1s wall-time cap; under load this could add to Zoekt's request rate. The check runs at most once per probe interval per pod; for the default 10s interval on a 3-pod deployment this is ~0.3 RPS, negligible.
                • The getRedisClient() lazy singleton means the first readiness probe on a cold pod will create the Redis connection. The 2s timeout is more than enough headroom for the first connect.

                Future work (out of scope for this PR)

                • Prometheus metrics for each check (sourcebot_readiness_check_duration_seconds{check="postgres"}, etc.) — would build on the same per-check helpers introduced here.
                • A /api/health/ready?strict=true mode that treats Zoekt shards-empty as a degraded state (currently List returns success even with zero repos).
                • A /api/health/metrics JSON endpoint that returns Prometheus-style text without exposing /metrics directly.
                • Cache the readiness result for ~1s to absorb thundering-herd probes from multiple orchestrators.

                Happy to take this on. Implementation plan, test plan, and docs update all fit in one focused PR.

                Activity

                Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

                Metadata

                Metadata

                Labels

                No labels
                No labels

                Type

                No type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions