[FR] Resolve links embedded in Ask responses to URLs rather than relative paths

[brendan-kellam]

Describe the bug

Copying a Ask response as Markdown will return source file links that are relative and not absolute. This makes things non-portable, depending on where the Markdown is pasted. For example, here is a snippet produced by ask. Try clicking on the IndexBuilder.Add() link. It will 404.

---

You're absolutely correct! The primary reason PDFs and other binary files are skipped is because they contain null bytes (0x00), not just because of size limits or trigram counts.

The Null Byte Check

In IndexBuilder.Add() indexbuilder.go:428-431:

---

To reproduce

Create a Ask response with a source link

Sourcebot deployment information

Sourcebot version (e.g. v3.0.1): Latest

Additional information

We should resolve these links as absolute links within the code host, that way they are portable.

[Cprakhar]

@brendan-kellam I didn't see this bug; in my case it is returning the absolute path. Are you referring to https://github.com/username/userRepo/blob/path/to/file as absolute path?

[brendan-kellam]

@brendan-kellam I didn't see this bug; in my case it is returning the absolute path. Are you referring to https://github.com/username/userRepo/blob/path/to/file as absolute path?

yea exactly, have https://github.com/username/userRepo/blob/path/to/file type paths to be resolved instead of /path/to/file

[Cprakhar]

I will try to submit a pull request that includes the fix.

[Cprakhar]

@brendan-kellam I didn't see this bug; in my case it is returning the absolute path. Are you referring to https://github.com/username/userRepo/blob/path/to/file as absolute path?

yea exactly, have https://github.com/username/userRepo/blob/path/to/file type paths to be resolved instead of /path/to/file

It is working properly for me:
I asked to provide the hosted link of package.json

[brendan-kellam]

The issue is still there - the Reference: [package.json](package.json) is not a link to the code host

[Cprakhar]

The issue is still there - the Reference: [package.json](package.json) is not a link to the code host

I understand now that I misinterpreted the problem statement.