fix(worker): Fix type error - #1093

Merged
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error
Apr 3, 2026
Merged

fix(worker): Fix type error#1093
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error

Conversation

@brendan-kellam

@brendan-kellambrendan-kellam commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

In #1092, we added a resolution for path-to-regexp to pin all versions to 8.4.0. The problem is express depended on version 0.1.12, which caused this type error:

[backend] | /app/node_modules/express/lib/router/layer.js:45
[backend] | this.regexp = pathRegexp(path, this.keys = [], opts);
[backend] | ^
[backend] | 2026-04-03T17:02:46.748Z info: [audit-log-pruner] Audit log pruner started. Retaining logs for 180 days.
[backend] | at app.lazyrouter (/app/node_modules/express/lib/application.js:151:18)
[backend] | at app.use (/app/node_modules/express/lib/application.js:221:8)
[backend] | at new Api (file:///app/packages/backend/dist/api.js:23:13)
[backend] | at file:///app/packages/backend/dist/index.js:68:13

The fix is to add separate resolutions for specifically 0.1.12 and ^8

Summary by CodeRabbit

  • Bug Fixes

    • Fixed a TypeError in the worker that prevented proper execution.
  • Chores

    • Updated dependency resolutions for enhanced compatibility.

@github-actions

This comment has been minimized.

@coderabbitai

coderabbitaiBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07393fa7-650b-4771-b7ea-8897dcb55094

📥 Commits

Reviewing files that changed from the base of the PR and between 41bfc3b and b836500.

📒 Files selected for processing (1)
  • CHANGELOG.md

Walkthrough

Updated Yarn resolutions in package.json to expand path-to-regexp overrides: added a specific pin for path-to-regexp@0.1.120.1.13 while retaining the existing path-to-regexp@^8^8.4.0. Also added a Fixed entry in CHANGELOG.md referencing a worker TypeError fix.

Changes

Cohort / File(s)Summary
Dependency Resolutions
package.json
Expanded Yarn resolutions for path-to-regexp to include path-to-regexp@0.1.12: 0.1.13 and path-to-regexp@^8: ^8.4.0.
Changelog
CHANGELOG.md
Added ### Fixed entry under ## [Unreleased] noting a worker TypeError: pathRegexp is not a function fix (PR #1093).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title mentions fixing a type error in a worker, but the actual changes only modify package.json dependency resolutions for path-to-regexp, with no visible type error fixes or worker-related code changes.Update the title to accurately describe the dependency resolution change, such as 'chore(deps): Add yarn resolution for path-to-regexp versions' or verify the PR scope matches the stated objective.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bkellam/fix-type-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam
brendan-kellam merged commit 7ee193c into mainApr 3, 2026
8 of 9 checks passed
@brendan-kellam
brendan-kellam deleted the bkellam/fix-type-error branch April 3, 2026 17:08
@github-actionsgithub-actionsBot mentioned this pull request Apr 3, 2026
@github-actions

github-actionsBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

License Audit

⚠️Status: PASS

MetricCount
Total packages2123
Resolved (non-standard)33
Unresolved0
Strong copyleft0
Weak copyleft27

Weak Copyleft Packages (informational)

PackageVersionLicense
@img/sharp-libvips-darwin-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.0.5LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-ppc641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-riscv641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.2.4LGPL-3.0-or-later
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-later
axe-core4.10.3MPL-2.0
dompurify3.3.1(MPL-2.0 OR Apache-2.0)
Resolved Packages (33)
PackageVersionOriginalResolvedSource
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@react-grab/cli0.1.23UNKNOWNMITMIT LICENSE file found inside published npm tarball; not declared in package.json license field but present in tarball (copyright 2025 Aiden Bai)
@react-grab/cli0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/cli/-/cli-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@react-grab/mcp0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/mcp/-/mcp-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@sentry/cli2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-darwin2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
codemirror-lang-elixir4.0.0UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
dompurify3.3.1(MPL-2.0 OR Apache-2.0)(MPL-2.0 OR Apache-2.0)valid SPDX compound expression (dual-licensed; Apache-2.0 option available)
element-source0.0.3UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/element-source/-/element-source-0.0.3.tgz); not declared in package.json license field (copyright 2026 Aiden Bai)
json-schema0.4.0(AFL-2.1 OR BSD-3-Clause)(AFL-2.1 OR BSD-3-Clause)valid SPDX compound expression
lezer-elixir1.1.2UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
map-stream0.1.0UNKNOWNMITnpm registry (license field in package metadata)
memorystream0.3.1UNKNOWNMITGitHub repository LICENSE file (https://github.com/JSBizon/node-memorystream)
pause-stream0.0.11["MIT","Apache2"]MIT AND Apache-2.0extracted from license array; confirmed dual MIT/Apache-2.0 via GitHub LICENSE file (https://github.com/dominictarr/pause-stream)
posthog-js1.345.5SEE LICENSE IN LICENSEApache-2.0GitHub repository LICENSE file (https://github.com/PostHog/posthog-js)
type-fest0.7.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest0.20.2(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest5.3.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
valid-url1.0.9UNKNOWNMITGitHub repository LICENSE file (https://github.com/ogt/valid-url)
victory-vendor36.9.2MIT AND ISCMIT AND ISCvalid SPDX compound expression

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@brendan-kellam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(worker): Fix type error - #1093

Merged
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error
Apr 3, 2026
Merged

fix(worker): Fix type error#1093
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error

Conversation

@brendan-kellam

@brendan-kellambrendan-kellam commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

In #1092, we added a resolution for path-to-regexp to pin all versions to 8.4.0. The problem is express depended on version 0.1.12, which caused this type error:

[backend] | /app/node_modules/express/lib/router/layer.js:45
[backend] | this.regexp = pathRegexp(path, this.keys = [], opts);
[backend] | ^
[backend] | 2026-04-03T17:02:46.748Z info: [audit-log-pruner] Audit log pruner started. Retaining logs for 180 days.
[backend] | at app.lazyrouter (/app/node_modules/express/lib/application.js:151:18)
[backend] | at app.use (/app/node_modules/express/lib/application.js:221:8)
[backend] | at new Api (file:///app/packages/backend/dist/api.js:23:13)
[backend] | at file:///app/packages/backend/dist/index.js:68:13

The fix is to add separate resolutions for specifically 0.1.12 and ^8

Summary by CodeRabbit

  • Bug Fixes

    • Fixed a TypeError in the worker that prevented proper execution.
  • Chores

    • Updated dependency resolutions for enhanced compatibility.

@github-actions

This comment has been minimized.

@coderabbitai

coderabbitaiBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07393fa7-650b-4771-b7ea-8897dcb55094

📥 Commits

Reviewing files that changed from the base of the PR and between 41bfc3b and b836500.

📒 Files selected for processing (1)
  • CHANGELOG.md

Walkthrough

Updated Yarn resolutions in package.json to expand path-to-regexp overrides: added a specific pin for path-to-regexp@0.1.120.1.13 while retaining the existing path-to-regexp@^8^8.4.0. Also added a Fixed entry in CHANGELOG.md referencing a worker TypeError fix.

Changes

Cohort / File(s)Summary
Dependency Resolutions
package.json
Expanded Yarn resolutions for path-to-regexp to include path-to-regexp@0.1.12: 0.1.13 and path-to-regexp@^8: ^8.4.0.
Changelog
CHANGELOG.md
Added ### Fixed entry under ## [Unreleased] noting a worker TypeError: pathRegexp is not a function fix (PR #1093).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title mentions fixing a type error in a worker, but the actual changes only modify package.json dependency resolutions for path-to-regexp, with no visible type error fixes or worker-related code changes.Update the title to accurately describe the dependency resolution change, such as 'chore(deps): Add yarn resolution for path-to-regexp versions' or verify the PR scope matches the stated objective.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bkellam/fix-type-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam
brendan-kellam merged commit 7ee193c into mainApr 3, 2026
8 of 9 checks passed
@brendan-kellam
brendan-kellam deleted the bkellam/fix-type-error branch April 3, 2026 17:08
@github-actionsgithub-actionsBot mentioned this pull request Apr 3, 2026
@github-actions

github-actionsBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

License Audit

⚠️Status: PASS

MetricCount
Total packages2123
Resolved (non-standard)33
Unresolved0
Strong copyleft0
Weak copyleft27

Weak Copyleft Packages (informational)

PackageVersionLicense
@img/sharp-libvips-darwin-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.0.5LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-ppc641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-riscv641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.2.4LGPL-3.0-or-later
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-later
axe-core4.10.3MPL-2.0
dompurify3.3.1(MPL-2.0 OR Apache-2.0)
Resolved Packages (33)
PackageVersionOriginalResolvedSource
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@react-grab/cli0.1.23UNKNOWNMITMIT LICENSE file found inside published npm tarball; not declared in package.json license field but present in tarball (copyright 2025 Aiden Bai)
@react-grab/cli0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/cli/-/cli-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@react-grab/mcp0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/mcp/-/mcp-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@sentry/cli2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-darwin2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
codemirror-lang-elixir4.0.0UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
dompurify3.3.1(MPL-2.0 OR Apache-2.0)(MPL-2.0 OR Apache-2.0)valid SPDX compound expression (dual-licensed; Apache-2.0 option available)
element-source0.0.3UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/element-source/-/element-source-0.0.3.tgz); not declared in package.json license field (copyright 2026 Aiden Bai)
json-schema0.4.0(AFL-2.1 OR BSD-3-Clause)(AFL-2.1 OR BSD-3-Clause)valid SPDX compound expression
lezer-elixir1.1.2UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
map-stream0.1.0UNKNOWNMITnpm registry (license field in package metadata)
memorystream0.3.1UNKNOWNMITGitHub repository LICENSE file (https://github.com/JSBizon/node-memorystream)
pause-stream0.0.11["MIT","Apache2"]MIT AND Apache-2.0extracted from license array; confirmed dual MIT/Apache-2.0 via GitHub LICENSE file (https://github.com/dominictarr/pause-stream)
posthog-js1.345.5SEE LICENSE IN LICENSEApache-2.0GitHub repository LICENSE file (https://github.com/PostHog/posthog-js)
type-fest0.7.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest0.20.2(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest5.3.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
valid-url1.0.9UNKNOWNMITGitHub repository LICENSE file (https://github.com/ogt/valid-url)
victory-vendor36.9.2MIT AND ISCMIT AND ISCvalid SPDX compound expression

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@brendan-kellam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(worker): Fix type error - #1093

Merged
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error
Apr 3, 2026
Merged

fix(worker): Fix type error#1093
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error

Conversation

@brendan-kellam

@brendan-kellambrendan-kellam commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

In #1092, we added a resolution for path-to-regexp to pin all versions to 8.4.0. The problem is express depended on version 0.1.12, which caused this type error:

[backend] | /app/node_modules/express/lib/router/layer.js:45
[backend] | this.regexp = pathRegexp(path, this.keys = [], opts);
[backend] | ^
[backend] | 2026-04-03T17:02:46.748Z info: [audit-log-pruner] Audit log pruner started. Retaining logs for 180 days.
[backend] | at app.lazyrouter (/app/node_modules/express/lib/application.js:151:18)
[backend] | at app.use (/app/node_modules/express/lib/application.js:221:8)
[backend] | at new Api (file:///app/packages/backend/dist/api.js:23:13)
[backend] | at file:///app/packages/backend/dist/index.js:68:13

The fix is to add separate resolutions for specifically 0.1.12 and ^8

Summary by CodeRabbit

  • Bug Fixes

    • Fixed a TypeError in the worker that prevented proper execution.
  • Chores

    • Updated dependency resolutions for enhanced compatibility.

@github-actions

This comment has been minimized.

@coderabbitai

coderabbitaiBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07393fa7-650b-4771-b7ea-8897dcb55094

📥 Commits

Reviewing files that changed from the base of the PR and between 41bfc3b and b836500.

📒 Files selected for processing (1)
  • CHANGELOG.md

Walkthrough

Updated Yarn resolutions in package.json to expand path-to-regexp overrides: added a specific pin for path-to-regexp@0.1.120.1.13 while retaining the existing path-to-regexp@^8^8.4.0. Also added a Fixed entry in CHANGELOG.md referencing a worker TypeError fix.

Changes

Cohort / File(s)Summary
Dependency Resolutions
package.json
Expanded Yarn resolutions for path-to-regexp to include path-to-regexp@0.1.12: 0.1.13 and path-to-regexp@^8: ^8.4.0.
Changelog
CHANGELOG.md
Added ### Fixed entry under ## [Unreleased] noting a worker TypeError: pathRegexp is not a function fix (PR #1093).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title mentions fixing a type error in a worker, but the actual changes only modify package.json dependency resolutions for path-to-regexp, with no visible type error fixes or worker-related code changes.Update the title to accurately describe the dependency resolution change, such as 'chore(deps): Add yarn resolution for path-to-regexp versions' or verify the PR scope matches the stated objective.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bkellam/fix-type-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam
brendan-kellam merged commit 7ee193c into mainApr 3, 2026
8 of 9 checks passed
@brendan-kellam
brendan-kellam deleted the bkellam/fix-type-error branch April 3, 2026 17:08
@github-actionsgithub-actionsBot mentioned this pull request Apr 3, 2026
@github-actions

github-actionsBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

License Audit

⚠️Status: PASS

MetricCount
Total packages2123
Resolved (non-standard)33
Unresolved0
Strong copyleft0
Weak copyleft27

Weak Copyleft Packages (informational)

PackageVersionLicense
@img/sharp-libvips-darwin-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.0.5LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-ppc641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-riscv641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.2.4LGPL-3.0-or-later
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-later
axe-core4.10.3MPL-2.0
dompurify3.3.1(MPL-2.0 OR Apache-2.0)
Resolved Packages (33)
PackageVersionOriginalResolvedSource
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@react-grab/cli0.1.23UNKNOWNMITMIT LICENSE file found inside published npm tarball; not declared in package.json license field but present in tarball (copyright 2025 Aiden Bai)
@react-grab/cli0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/cli/-/cli-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@react-grab/mcp0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/mcp/-/mcp-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@sentry/cli2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-darwin2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
codemirror-lang-elixir4.0.0UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
dompurify3.3.1(MPL-2.0 OR Apache-2.0)(MPL-2.0 OR Apache-2.0)valid SPDX compound expression (dual-licensed; Apache-2.0 option available)
element-source0.0.3UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/element-source/-/element-source-0.0.3.tgz); not declared in package.json license field (copyright 2026 Aiden Bai)
json-schema0.4.0(AFL-2.1 OR BSD-3-Clause)(AFL-2.1 OR BSD-3-Clause)valid SPDX compound expression
lezer-elixir1.1.2UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
map-stream0.1.0UNKNOWNMITnpm registry (license field in package metadata)
memorystream0.3.1UNKNOWNMITGitHub repository LICENSE file (https://github.com/JSBizon/node-memorystream)
pause-stream0.0.11["MIT","Apache2"]MIT AND Apache-2.0extracted from license array; confirmed dual MIT/Apache-2.0 via GitHub LICENSE file (https://github.com/dominictarr/pause-stream)
posthog-js1.345.5SEE LICENSE IN LICENSEApache-2.0GitHub repository LICENSE file (https://github.com/PostHog/posthog-js)
type-fest0.7.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest0.20.2(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest5.3.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
valid-url1.0.9UNKNOWNMITGitHub repository LICENSE file (https://github.com/ogt/valid-url)
victory-vendor36.9.2MIT AND ISCMIT AND ISCvalid SPDX compound expression

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@brendan-kellam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(worker): Fix type error - #1093

Merged
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error
Apr 3, 2026
Merged

fix(worker): Fix type error#1093
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error

Conversation

@brendan-kellam

@brendan-kellambrendan-kellam commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

In #1092, we added a resolution for path-to-regexp to pin all versions to 8.4.0. The problem is express depended on version 0.1.12, which caused this type error:

[backend] | /app/node_modules/express/lib/router/layer.js:45
[backend] | this.regexp = pathRegexp(path, this.keys = [], opts);
[backend] | ^
[backend] | 2026-04-03T17:02:46.748Z info: [audit-log-pruner] Audit log pruner started. Retaining logs for 180 days.
[backend] | at app.lazyrouter (/app/node_modules/express/lib/application.js:151:18)
[backend] | at app.use (/app/node_modules/express/lib/application.js:221:8)
[backend] | at new Api (file:///app/packages/backend/dist/api.js:23:13)
[backend] | at file:///app/packages/backend/dist/index.js:68:13

The fix is to add separate resolutions for specifically 0.1.12 and ^8

Summary by CodeRabbit

  • Bug Fixes

    • Fixed a TypeError in the worker that prevented proper execution.
  • Chores

    • Updated dependency resolutions for enhanced compatibility.

@github-actions

This comment has been minimized.

@coderabbitai

coderabbitaiBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07393fa7-650b-4771-b7ea-8897dcb55094

📥 Commits

Reviewing files that changed from the base of the PR and between 41bfc3b and b836500.

📒 Files selected for processing (1)
  • CHANGELOG.md

Walkthrough

Updated Yarn resolutions in package.json to expand path-to-regexp overrides: added a specific pin for path-to-regexp@0.1.120.1.13 while retaining the existing path-to-regexp@^8^8.4.0. Also added a Fixed entry in CHANGELOG.md referencing a worker TypeError fix.

Changes

Cohort / File(s)Summary
Dependency Resolutions
package.json
Expanded Yarn resolutions for path-to-regexp to include path-to-regexp@0.1.12: 0.1.13 and path-to-regexp@^8: ^8.4.0.
Changelog
CHANGELOG.md
Added ### Fixed entry under ## [Unreleased] noting a worker TypeError: pathRegexp is not a function fix (PR #1093).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title mentions fixing a type error in a worker, but the actual changes only modify package.json dependency resolutions for path-to-regexp, with no visible type error fixes or worker-related code changes.Update the title to accurately describe the dependency resolution change, such as 'chore(deps): Add yarn resolution for path-to-regexp versions' or verify the PR scope matches the stated objective.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bkellam/fix-type-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam
brendan-kellam merged commit 7ee193c into mainApr 3, 2026
8 of 9 checks passed
@brendan-kellam
brendan-kellam deleted the bkellam/fix-type-error branch April 3, 2026 17:08
@github-actionsgithub-actionsBot mentioned this pull request Apr 3, 2026
@github-actions

github-actionsBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

License Audit

⚠️Status: PASS

MetricCount
Total packages2123
Resolved (non-standard)33
Unresolved0
Strong copyleft0
Weak copyleft27

Weak Copyleft Packages (informational)

PackageVersionLicense
@img/sharp-libvips-darwin-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.0.5LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-ppc641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-riscv641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.2.4LGPL-3.0-or-later
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-later
axe-core4.10.3MPL-2.0
dompurify3.3.1(MPL-2.0 OR Apache-2.0)
Resolved Packages (33)
PackageVersionOriginalResolvedSource
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@react-grab/cli0.1.23UNKNOWNMITMIT LICENSE file found inside published npm tarball; not declared in package.json license field but present in tarball (copyright 2025 Aiden Bai)
@react-grab/cli0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/cli/-/cli-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@react-grab/mcp0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/mcp/-/mcp-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@sentry/cli2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-darwin2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
codemirror-lang-elixir4.0.0UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
dompurify3.3.1(MPL-2.0 OR Apache-2.0)(MPL-2.0 OR Apache-2.0)valid SPDX compound expression (dual-licensed; Apache-2.0 option available)
element-source0.0.3UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/element-source/-/element-source-0.0.3.tgz); not declared in package.json license field (copyright 2026 Aiden Bai)
json-schema0.4.0(AFL-2.1 OR BSD-3-Clause)(AFL-2.1 OR BSD-3-Clause)valid SPDX compound expression
lezer-elixir1.1.2UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
map-stream0.1.0UNKNOWNMITnpm registry (license field in package metadata)
memorystream0.3.1UNKNOWNMITGitHub repository LICENSE file (https://github.com/JSBizon/node-memorystream)
pause-stream0.0.11["MIT","Apache2"]MIT AND Apache-2.0extracted from license array; confirmed dual MIT/Apache-2.0 via GitHub LICENSE file (https://github.com/dominictarr/pause-stream)
posthog-js1.345.5SEE LICENSE IN LICENSEApache-2.0GitHub repository LICENSE file (https://github.com/PostHog/posthog-js)
type-fest0.7.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest0.20.2(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest5.3.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
valid-url1.0.9UNKNOWNMITGitHub repository LICENSE file (https://github.com/ogt/valid-url)
victory-vendor36.9.2MIT AND ISCMIT AND ISCvalid SPDX compound expression

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@brendan-kellam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(worker): Fix type error - #1093

Merged
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error
Apr 3, 2026
Merged

fix(worker): Fix type error#1093
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error

Conversation

@brendan-kellam

@brendan-kellambrendan-kellam commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

In #1092, we added a resolution for path-to-regexp to pin all versions to 8.4.0. The problem is express depended on version 0.1.12, which caused this type error:

[backend] | /app/node_modules/express/lib/router/layer.js:45
[backend] | this.regexp = pathRegexp(path, this.keys = [], opts);
[backend] | ^
[backend] | 2026-04-03T17:02:46.748Z info: [audit-log-pruner] Audit log pruner started. Retaining logs for 180 days.
[backend] | at app.lazyrouter (/app/node_modules/express/lib/application.js:151:18)
[backend] | at app.use (/app/node_modules/express/lib/application.js:221:8)
[backend] | at new Api (file:///app/packages/backend/dist/api.js:23:13)
[backend] | at file:///app/packages/backend/dist/index.js:68:13

The fix is to add separate resolutions for specifically 0.1.12 and ^8

Summary by CodeRabbit

  • Bug Fixes

    • Fixed a TypeError in the worker that prevented proper execution.
  • Chores

    • Updated dependency resolutions for enhanced compatibility.

@github-actions

This comment has been minimized.

@coderabbitai

coderabbitaiBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07393fa7-650b-4771-b7ea-8897dcb55094

📥 Commits

Reviewing files that changed from the base of the PR and between 41bfc3b and b836500.

📒 Files selected for processing (1)
  • CHANGELOG.md

Walkthrough

Updated Yarn resolutions in package.json to expand path-to-regexp overrides: added a specific pin for path-to-regexp@0.1.120.1.13 while retaining the existing path-to-regexp@^8^8.4.0. Also added a Fixed entry in CHANGELOG.md referencing a worker TypeError fix.

Changes

Cohort / File(s)Summary
Dependency Resolutions
package.json
Expanded Yarn resolutions for path-to-regexp to include path-to-regexp@0.1.12: 0.1.13 and path-to-regexp@^8: ^8.4.0.
Changelog
CHANGELOG.md
Added ### Fixed entry under ## [Unreleased] noting a worker TypeError: pathRegexp is not a function fix (PR #1093).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title mentions fixing a type error in a worker, but the actual changes only modify package.json dependency resolutions for path-to-regexp, with no visible type error fixes or worker-related code changes.Update the title to accurately describe the dependency resolution change, such as 'chore(deps): Add yarn resolution for path-to-regexp versions' or verify the PR scope matches the stated objective.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bkellam/fix-type-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam
brendan-kellam merged commit 7ee193c into mainApr 3, 2026
8 of 9 checks passed
@brendan-kellam
brendan-kellam deleted the bkellam/fix-type-error branch April 3, 2026 17:08
@github-actionsgithub-actionsBot mentioned this pull request Apr 3, 2026
@github-actions

github-actionsBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

License Audit

⚠️Status: PASS

MetricCount
Total packages2123
Resolved (non-standard)33
Unresolved0
Strong copyleft0
Weak copyleft27

Weak Copyleft Packages (informational)

PackageVersionLicense
@img/sharp-libvips-darwin-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.0.5LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-ppc641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-riscv641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.2.4LGPL-3.0-or-later
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-later
axe-core4.10.3MPL-2.0
dompurify3.3.1(MPL-2.0 OR Apache-2.0)
Resolved Packages (33)
PackageVersionOriginalResolvedSource
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@react-grab/cli0.1.23UNKNOWNMITMIT LICENSE file found inside published npm tarball; not declared in package.json license field but present in tarball (copyright 2025 Aiden Bai)
@react-grab/cli0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/cli/-/cli-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@react-grab/mcp0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/mcp/-/mcp-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@sentry/cli2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-darwin2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
codemirror-lang-elixir4.0.0UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
dompurify3.3.1(MPL-2.0 OR Apache-2.0)(MPL-2.0 OR Apache-2.0)valid SPDX compound expression (dual-licensed; Apache-2.0 option available)
element-source0.0.3UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/element-source/-/element-source-0.0.3.tgz); not declared in package.json license field (copyright 2026 Aiden Bai)
json-schema0.4.0(AFL-2.1 OR BSD-3-Clause)(AFL-2.1 OR BSD-3-Clause)valid SPDX compound expression
lezer-elixir1.1.2UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
map-stream0.1.0UNKNOWNMITnpm registry (license field in package metadata)
memorystream0.3.1UNKNOWNMITGitHub repository LICENSE file (https://github.com/JSBizon/node-memorystream)
pause-stream0.0.11["MIT","Apache2"]MIT AND Apache-2.0extracted from license array; confirmed dual MIT/Apache-2.0 via GitHub LICENSE file (https://github.com/dominictarr/pause-stream)
posthog-js1.345.5SEE LICENSE IN LICENSEApache-2.0GitHub repository LICENSE file (https://github.com/PostHog/posthog-js)
type-fest0.7.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest0.20.2(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest5.3.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
valid-url1.0.9UNKNOWNMITGitHub repository LICENSE file (https://github.com/ogt/valid-url)
victory-vendor36.9.2MIT AND ISCMIT AND ISCvalid SPDX compound expression

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@brendan-kellam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(worker): Fix type error - #1093

Merged
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error
Apr 3, 2026
Merged

fix(worker): Fix type error#1093
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error

Conversation

@brendan-kellam

@brendan-kellambrendan-kellam commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

In #1092, we added a resolution for path-to-regexp to pin all versions to 8.4.0. The problem is express depended on version 0.1.12, which caused this type error:

[backend] | /app/node_modules/express/lib/router/layer.js:45
[backend] | this.regexp = pathRegexp(path, this.keys = [], opts);
[backend] | ^
[backend] | 2026-04-03T17:02:46.748Z info: [audit-log-pruner] Audit log pruner started. Retaining logs for 180 days.
[backend] | at app.lazyrouter (/app/node_modules/express/lib/application.js:151:18)
[backend] | at app.use (/app/node_modules/express/lib/application.js:221:8)
[backend] | at new Api (file:///app/packages/backend/dist/api.js:23:13)
[backend] | at file:///app/packages/backend/dist/index.js:68:13

The fix is to add separate resolutions for specifically 0.1.12 and ^8

Summary by CodeRabbit

  • Bug Fixes

    • Fixed a TypeError in the worker that prevented proper execution.
  • Chores

    • Updated dependency resolutions for enhanced compatibility.

@github-actions

This comment has been minimized.

@coderabbitai

coderabbitaiBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07393fa7-650b-4771-b7ea-8897dcb55094

📥 Commits

Reviewing files that changed from the base of the PR and between 41bfc3b and b836500.

📒 Files selected for processing (1)
  • CHANGELOG.md

Walkthrough

Updated Yarn resolutions in package.json to expand path-to-regexp overrides: added a specific pin for path-to-regexp@0.1.120.1.13 while retaining the existing path-to-regexp@^8^8.4.0. Also added a Fixed entry in CHANGELOG.md referencing a worker TypeError fix.

Changes

Cohort / File(s)Summary
Dependency Resolutions
package.json
Expanded Yarn resolutions for path-to-regexp to include path-to-regexp@0.1.12: 0.1.13 and path-to-regexp@^8: ^8.4.0.
Changelog
CHANGELOG.md
Added ### Fixed entry under ## [Unreleased] noting a worker TypeError: pathRegexp is not a function fix (PR #1093).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title mentions fixing a type error in a worker, but the actual changes only modify package.json dependency resolutions for path-to-regexp, with no visible type error fixes or worker-related code changes.Update the title to accurately describe the dependency resolution change, such as 'chore(deps): Add yarn resolution for path-to-regexp versions' or verify the PR scope matches the stated objective.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bkellam/fix-type-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam
brendan-kellam merged commit 7ee193c into mainApr 3, 2026
8 of 9 checks passed
@brendan-kellam
brendan-kellam deleted the bkellam/fix-type-error branch April 3, 2026 17:08
@github-actionsgithub-actionsBot mentioned this pull request Apr 3, 2026
@github-actions

github-actionsBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

License Audit

⚠️Status: PASS

MetricCount
Total packages2123
Resolved (non-standard)33
Unresolved0
Strong copyleft0
Weak copyleft27

Weak Copyleft Packages (informational)

PackageVersionLicense
@img/sharp-libvips-darwin-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.0.5LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-ppc641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-riscv641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.2.4LGPL-3.0-or-later
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-later
axe-core4.10.3MPL-2.0
dompurify3.3.1(MPL-2.0 OR Apache-2.0)
Resolved Packages (33)
PackageVersionOriginalResolvedSource
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@react-grab/cli0.1.23UNKNOWNMITMIT LICENSE file found inside published npm tarball; not declared in package.json license field but present in tarball (copyright 2025 Aiden Bai)
@react-grab/cli0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/cli/-/cli-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@react-grab/mcp0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/mcp/-/mcp-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@sentry/cli2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-darwin2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
codemirror-lang-elixir4.0.0UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
dompurify3.3.1(MPL-2.0 OR Apache-2.0)(MPL-2.0 OR Apache-2.0)valid SPDX compound expression (dual-licensed; Apache-2.0 option available)
element-source0.0.3UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/element-source/-/element-source-0.0.3.tgz); not declared in package.json license field (copyright 2026 Aiden Bai)
json-schema0.4.0(AFL-2.1 OR BSD-3-Clause)(AFL-2.1 OR BSD-3-Clause)valid SPDX compound expression
lezer-elixir1.1.2UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
map-stream0.1.0UNKNOWNMITnpm registry (license field in package metadata)
memorystream0.3.1UNKNOWNMITGitHub repository LICENSE file (https://github.com/JSBizon/node-memorystream)
pause-stream0.0.11["MIT","Apache2"]MIT AND Apache-2.0extracted from license array; confirmed dual MIT/Apache-2.0 via GitHub LICENSE file (https://github.com/dominictarr/pause-stream)
posthog-js1.345.5SEE LICENSE IN LICENSEApache-2.0GitHub repository LICENSE file (https://github.com/PostHog/posthog-js)
type-fest0.7.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest0.20.2(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest5.3.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
valid-url1.0.9UNKNOWNMITGitHub repository LICENSE file (https://github.com/ogt/valid-url)
victory-vendor36.9.2MIT AND ISCMIT AND ISCvalid SPDX compound expression

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@brendan-kellam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(worker): Fix type error - #1093

Merged
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error
Apr 3, 2026
Merged

fix(worker): Fix type error#1093
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error

Conversation

@brendan-kellam

@brendan-kellambrendan-kellam commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

In #1092, we added a resolution for path-to-regexp to pin all versions to 8.4.0. The problem is express depended on version 0.1.12, which caused this type error:

[backend] | /app/node_modules/express/lib/router/layer.js:45
[backend] | this.regexp = pathRegexp(path, this.keys = [], opts);
[backend] | ^
[backend] | 2026-04-03T17:02:46.748Z info: [audit-log-pruner] Audit log pruner started. Retaining logs for 180 days.
[backend] | at app.lazyrouter (/app/node_modules/express/lib/application.js:151:18)
[backend] | at app.use (/app/node_modules/express/lib/application.js:221:8)
[backend] | at new Api (file:///app/packages/backend/dist/api.js:23:13)
[backend] | at file:///app/packages/backend/dist/index.js:68:13

The fix is to add separate resolutions for specifically 0.1.12 and ^8

Summary by CodeRabbit

  • Bug Fixes

    • Fixed a TypeError in the worker that prevented proper execution.
  • Chores

    • Updated dependency resolutions for enhanced compatibility.

@github-actions

This comment has been minimized.

@coderabbitai

coderabbitaiBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07393fa7-650b-4771-b7ea-8897dcb55094

📥 Commits

Reviewing files that changed from the base of the PR and between 41bfc3b and b836500.

📒 Files selected for processing (1)
  • CHANGELOG.md

Walkthrough

Updated Yarn resolutions in package.json to expand path-to-regexp overrides: added a specific pin for path-to-regexp@0.1.120.1.13 while retaining the existing path-to-regexp@^8^8.4.0. Also added a Fixed entry in CHANGELOG.md referencing a worker TypeError fix.

Changes

Cohort / File(s)Summary
Dependency Resolutions
package.json
Expanded Yarn resolutions for path-to-regexp to include path-to-regexp@0.1.12: 0.1.13 and path-to-regexp@^8: ^8.4.0.
Changelog
CHANGELOG.md
Added ### Fixed entry under ## [Unreleased] noting a worker TypeError: pathRegexp is not a function fix (PR #1093).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title mentions fixing a type error in a worker, but the actual changes only modify package.json dependency resolutions for path-to-regexp, with no visible type error fixes or worker-related code changes.Update the title to accurately describe the dependency resolution change, such as 'chore(deps): Add yarn resolution for path-to-regexp versions' or verify the PR scope matches the stated objective.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bkellam/fix-type-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam
brendan-kellam merged commit 7ee193c into mainApr 3, 2026
8 of 9 checks passed
@brendan-kellam
brendan-kellam deleted the bkellam/fix-type-error branch April 3, 2026 17:08
@github-actionsgithub-actionsBot mentioned this pull request Apr 3, 2026
@github-actions

github-actionsBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

License Audit

⚠️Status: PASS

MetricCount
Total packages2123
Resolved (non-standard)33
Unresolved0
Strong copyleft0
Weak copyleft27

Weak Copyleft Packages (informational)

PackageVersionLicense
@img/sharp-libvips-darwin-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.0.5LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-ppc641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-riscv641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.2.4LGPL-3.0-or-later
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-later
axe-core4.10.3MPL-2.0
dompurify3.3.1(MPL-2.0 OR Apache-2.0)
Resolved Packages (33)
PackageVersionOriginalResolvedSource
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@react-grab/cli0.1.23UNKNOWNMITMIT LICENSE file found inside published npm tarball; not declared in package.json license field but present in tarball (copyright 2025 Aiden Bai)
@react-grab/cli0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/cli/-/cli-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@react-grab/mcp0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/mcp/-/mcp-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@sentry/cli2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-darwin2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
codemirror-lang-elixir4.0.0UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
dompurify3.3.1(MPL-2.0 OR Apache-2.0)(MPL-2.0 OR Apache-2.0)valid SPDX compound expression (dual-licensed; Apache-2.0 option available)
element-source0.0.3UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/element-source/-/element-source-0.0.3.tgz); not declared in package.json license field (copyright 2026 Aiden Bai)
json-schema0.4.0(AFL-2.1 OR BSD-3-Clause)(AFL-2.1 OR BSD-3-Clause)valid SPDX compound expression
lezer-elixir1.1.2UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
map-stream0.1.0UNKNOWNMITnpm registry (license field in package metadata)
memorystream0.3.1UNKNOWNMITGitHub repository LICENSE file (https://github.com/JSBizon/node-memorystream)
pause-stream0.0.11["MIT","Apache2"]MIT AND Apache-2.0extracted from license array; confirmed dual MIT/Apache-2.0 via GitHub LICENSE file (https://github.com/dominictarr/pause-stream)
posthog-js1.345.5SEE LICENSE IN LICENSEApache-2.0GitHub repository LICENSE file (https://github.com/PostHog/posthog-js)
type-fest0.7.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest0.20.2(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest5.3.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
valid-url1.0.9UNKNOWNMITGitHub repository LICENSE file (https://github.com/ogt/valid-url)
victory-vendor36.9.2MIT AND ISCMIT AND ISCvalid SPDX compound expression

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@brendan-kellam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(worker): Fix type error - #1093

Merged
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error
Apr 3, 2026
Merged

fix(worker): Fix type error#1093
brendan-kellam merged 2 commits into
mainfrom
bkellam/fix-type-error

Conversation

@brendan-kellam

@brendan-kellambrendan-kellam commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

In #1092, we added a resolution for path-to-regexp to pin all versions to 8.4.0. The problem is express depended on version 0.1.12, which caused this type error:

[backend] | /app/node_modules/express/lib/router/layer.js:45
[backend] | this.regexp = pathRegexp(path, this.keys = [], opts);
[backend] | ^
[backend] | 2026-04-03T17:02:46.748Z info: [audit-log-pruner] Audit log pruner started. Retaining logs for 180 days.
[backend] | at app.lazyrouter (/app/node_modules/express/lib/application.js:151:18)
[backend] | at app.use (/app/node_modules/express/lib/application.js:221:8)
[backend] | at new Api (file:///app/packages/backend/dist/api.js:23:13)
[backend] | at file:///app/packages/backend/dist/index.js:68:13

The fix is to add separate resolutions for specifically 0.1.12 and ^8

Summary by CodeRabbit

  • Bug Fixes

    • Fixed a TypeError in the worker that prevented proper execution.
  • Chores

    • Updated dependency resolutions for enhanced compatibility.

@github-actions

This comment has been minimized.

@coderabbitai

coderabbitaiBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07393fa7-650b-4771-b7ea-8897dcb55094

📥 Commits

Reviewing files that changed from the base of the PR and between 41bfc3b and b836500.

📒 Files selected for processing (1)
  • CHANGELOG.md

Walkthrough

Updated Yarn resolutions in package.json to expand path-to-regexp overrides: added a specific pin for path-to-regexp@0.1.120.1.13 while retaining the existing path-to-regexp@^8^8.4.0. Also added a Fixed entry in CHANGELOG.md referencing a worker TypeError fix.

Changes

Cohort / File(s)Summary
Dependency Resolutions
package.json
Expanded Yarn resolutions for path-to-regexp to include path-to-regexp@0.1.12: 0.1.13 and path-to-regexp@^8: ^8.4.0.
Changelog
CHANGELOG.md
Added ### Fixed entry under ## [Unreleased] noting a worker TypeError: pathRegexp is not a function fix (PR #1093).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title mentions fixing a type error in a worker, but the actual changes only modify package.json dependency resolutions for path-to-regexp, with no visible type error fixes or worker-related code changes.Update the title to accurately describe the dependency resolution change, such as 'chore(deps): Add yarn resolution for path-to-regexp versions' or verify the PR scope matches the stated objective.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bkellam/fix-type-error

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@brendan-kellam
brendan-kellam merged commit 7ee193c into mainApr 3, 2026
8 of 9 checks passed
@brendan-kellam
brendan-kellam deleted the bkellam/fix-type-error branch April 3, 2026 17:08
@github-actionsgithub-actionsBot mentioned this pull request Apr 3, 2026
@github-actions

github-actionsBot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

License Audit

⚠️Status: PASS

MetricCount
Total packages2123
Resolved (non-standard)33
Unresolved0
Strong copyleft0
Weak copyleft27

Weak Copyleft Packages (informational)

PackageVersionLicense
@img/sharp-libvips-darwin-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-darwin-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.0.5LGPL-3.0-or-later
@img/sharp-libvips-linux-arm1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-ppc641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-riscv641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-s390x1.2.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linux-x641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-arm641.2.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.0.4LGPL-3.0-or-later
@img/sharp-libvips-linuxmusl-x641.2.4LGPL-3.0-or-later
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MIT
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-later
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-later
axe-core4.10.3MPL-2.0
dompurify3.3.1(MPL-2.0 OR Apache-2.0)
Resolved Packages (33)
PackageVersionOriginalResolvedSource
@img/sharp-wasm320.33.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-wasm320.34.5Apache-2.0 AND LGPL-3.0-or-later AND MITApache-2.0 AND LGPL-3.0-or-later AND MITvalid SPDX compound expression
@img/sharp-win32-arm640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-ia320.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.33.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@img/sharp-win32-x640.34.5Apache-2.0 AND LGPL-3.0-or-laterApache-2.0 AND LGPL-3.0-or-latervalid SPDX compound expression
@react-grab/cli0.1.23UNKNOWNMITMIT LICENSE file found inside published npm tarball; not declared in package.json license field but present in tarball (copyright 2025 Aiden Bai)
@react-grab/cli0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/cli/-/cli-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@react-grab/mcp0.1.29UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/@react-grab/mcp/-/mcp-0.1.29.tgz); not declared in package.json license field (copyright 2025 Aiden Bai)
@sentry/cli2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-darwin2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm2.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-linux-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-arm642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-i6862.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
@sentry/cli-win32-x642.58.5FSL-1.1-MITFSL-1.1-MITnpm registry (confirmed valid SPDX identifier; Functional Source License v1.1 with MIT fallback after 2 years)
codemirror-lang-elixir4.0.0UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
dompurify3.3.1(MPL-2.0 OR Apache-2.0)(MPL-2.0 OR Apache-2.0)valid SPDX compound expression (dual-licensed; Apache-2.0 option available)
element-source0.0.3UNKNOWNMITMIT LICENSE file found inside published npm tarball (https://registry.npmjs.org/element-source/-/element-source-0.0.3.tgz); not declared in package.json license field (copyright 2026 Aiden Bai)
json-schema0.4.0(AFL-2.1 OR BSD-3-Clause)(AFL-2.1 OR BSD-3-Clause)valid SPDX compound expression
lezer-elixir1.1.2UNKNOWNApache-2.0npm registry (top-level license field on package metadata)
map-stream0.1.0UNKNOWNMITnpm registry (license field in package metadata)
memorystream0.3.1UNKNOWNMITGitHub repository LICENSE file (https://github.com/JSBizon/node-memorystream)
pause-stream0.0.11["MIT","Apache2"]MIT AND Apache-2.0extracted from license array; confirmed dual MIT/Apache-2.0 via GitHub LICENSE file (https://github.com/dominictarr/pause-stream)
posthog-js1.345.5SEE LICENSE IN LICENSEApache-2.0GitHub repository LICENSE file (https://github.com/PostHog/posthog-js)
type-fest0.7.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest0.20.2(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
type-fest5.3.1(MIT OR CC0-1.0)(MIT OR CC0-1.0)valid SPDX compound expression
valid-url1.0.9UNKNOWNMITGitHub repository LICENSE file (https://github.com/ogt/valid-url)
victory-vendor36.9.2MIT AND ISCMIT AND ISCvalid SPDX compound expression

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@brendan-kellam