Uh oh!
There was an error while loading. Please reload this page.
fix(web): Prompt anonymous users to login if they want to use connectors in Ask - #1274
Merged
Conversation
Contributor
WalkthroughThreads authentication state into chat toolbar components and gates ConnectorsMenu's MCP servers query on that state. ConnectorsMenu now treats authentication failures as non-retriable and conditionally shows a login prompt for unauthenticated users instead of the connectors list. ChangesAuthentication State Threading and ConnectorsMenu Gating
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment has been minimized.
This comment has been minimized.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/web/src/ee/features/chat/mcp/components/connectorsMenu.tsx`:
- Around line 97-100: The current loginHref uses usePathname() which drops the
query string, so preserve the full current URL by appending the search/query
string when building loginHref (same approach as handleConnect which uses
window.location.search); update the loginHref construction in connectorsMenu.tsx
(where usePathname(), useToast(), useRole() are used and loginHref is defined)
to include the current search params (e.g., pathname + window.location.search or
via useSearchParams) before encodeURIComponent so the callbackUrl contains the
full route and query state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ef24737f-2b49-4dc0-b19d-0e837deb4ff1
📒 Files selected for processing (7)
packages/web/src/app/(app)/askgh/[owner]/[repo]/components/landingPage.tsxpackages/web/src/app/(app)/chat/components/landingPageChatBox.tsxpackages/web/src/ee/features/chat/components/chatThread/chatThread.tsxpackages/web/src/ee/features/chat/mcp/components/connectorsMenu.test.tspackages/web/src/ee/features/chat/mcp/components/connectorsMenu.tsxpackages/web/src/features/chat/components/chatBox/chatBoxPlusButton.tsxpackages/web/src/features/chat/components/chatBox/chatBoxToolbar.tsx
Comment on lines
+97
to
+100
| const pathname = usePathname(); | ||
| const { toast } = useToast(); | ||
| const isOwner = useRole() === OrgRole.OWNER; | ||
| const loginHref = `/login?callbackUrl=${encodeURIComponent(pathname)}`; |
Contributor
There was a problem hiding this comment.
Preserve the full current URL in callbackUrl.
usePathname() drops the current query string, so after login we redirect back to the route but not necessarily the same Ask state. Build loginHref from pathname + searchParams here, the same way handleConnect() preserves window.location.search for the OAuth return path.
Suggested fix
-import { usePathname, useRouter } from "next/navigation";+import { usePathname, useRouter, useSearchParams } from "next/navigation";
...
const router = useRouter();
const pathname = usePathname();
+ const searchParams = useSearchParams();
const { toast } = useToast();
const isOwner = useRole() === OrgRole.OWNER;
- const loginHref = `/login?callbackUrl=${encodeURIComponent(pathname)}`;+ const callbackUrl = `${pathname}${searchParams.size > 0 ? `?${searchParams.toString()}` : ''}`;+ const loginHref = `/login?callbackUrl=${encodeURIComponent(callbackUrl)}`;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/web/src/ee/features/chat/mcp/components/connectorsMenu.tsx` around
lines 97 - 100, The current loginHref uses usePathname() which drops the query
string, so preserve the full current URL by appending the search/query string
when building loginHref (same approach as handleConnect which uses
window.location.search); update the loginHref construction in connectorsMenu.tsx
(where usePathname(), useToast(), useRole() are used and loginHref is defined)
to include the current search params (e.g., pathname + window.location.search or
via useSearchParams) before encodeURIComponent so the callbackUrl contains the
full route and query state.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/sourcebot/issue/SOU-1268/show-login-prompt-for-configuring-connectors
Summary by CodeRabbit
New Features
Improvements