Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [EE] Fixed Ask Sourcebot mermaid diagrams overflowing their container by contain-fitting them to both width and height, and made revealing a diagram from the answer jump it into view instantly to avoid over/undershooting. [#1373](https://github.com/sourcebot-dev/sourcebot/pull/1373)
- Verified GitHub review webhook deliveries before processing them. [#1378](https://github.com/sourcebot-dev/sourcebot/pull/1378)
- Passed Zoekt index parameters via argv to preserve revision names with punctuation. [#1376](https://github.com/sourcebot-dev/sourcebot/pull/1376)
- [EE] Validated OAuth bearer token scopes before allowing access to the Sourcebot MCP resource server. [#1396](https://github.com/sourcebot-dev/sourcebot/pull/1396)

## [5.0.4] - 2026-06-18

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
-- AlterTable
ALTER TABLE "OAuthAuthorizationCode" ADD COLUMN "scope" TEXT NOT NULL DEFAULT '';
Comment thread
brendan-kellam marked this conversation as resolved.
1 change: 1 addition & 0 deletions packages/db/prisma/schema.prisma
Original file line numberDiff line numberDiff line change
Expand Up@@ -732,6 +732,7 @@ model OAuthAuthorizationCode {
user User @relation(fields: [userId], references: [id], onDelete: Cascade)
redirectUri String
codeChallenge String // BASE64URL(SHA-256(codeVerifier))
scope String @default("")
resource String? // RFC 8707: canonical URI of the target resource server
dpopJkt String? // RFC 9449: DPoP JWK SHA-256 thumbprint binding
expiresAt DateTime
Expand Down
3 changes: 2 additions & 1 deletion packages/web/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,8 @@
"openapi:generate": "tsx tools/generateOpenApi.ts",
"generate:protos": "proto-loader-gen-types --includeComments --longs=Number --enums=String --defaults --oneofs --grpcLib=@grpc/grpc-js --keepCase --includeDirs=../../vendor/zoekt/grpc/protos --outDir=src/proto zoekt/webserver/v1/webserver.proto zoekt/webserver/v1/query.proto",
"dev:emails": "email dev --dir ./src/emails",
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts"
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts",
"tool:oauth-flow": "tsx tools/oauthFlow.ts"
},
"dependencies": {
"@ai-sdk/amazon-bedrock": "^4.0.94",
Expand Down
1 change: 0 additions & 1 deletion packages/web/src/__mocks__/prisma.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ export const MOCK_ORG: Org = {
updatedAt: new Date(),
isOnboarded: true,
imageUrl: null,
metadata: null,
memberApprovalRequired: false,
isCredentialsLoginEnabled: true,
isEmailCodeLoginEnabled: false,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
import { SUPPORTED_DPOP_SIGNING_ALGS } from '@/ee/features/oauth/dpop';

Expand All@@ -25,6 +25,7 @@ export const GET = oauthApiHandler(async () => {
revocation_endpoint: `${issuer}/api/ee/oauth/revoke`,
response_types_supported: ['code'],
grant_types_supported: ['authorization_code', 'refresh_token'],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
code_challenge_methods_supported: ['S256'],
token_endpoint_auth_methods_supported: ['none'],
dpop_signing_alg_values_supported: SUPPORTED_DPOP_SIGNING_ALGS,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';

// RFC 9728: OAuth 2.0 Protected Resource Metadata (path-specific form)
Expand DownExpand Up@@ -37,6 +37,7 @@ export const GET = oauthApiHandler(async (_request: NextRequest, { params }: { p
authorization_servers: [
issuer
],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
bearer_methods_supported: ['header'],
});
});
36 changes: 26 additions & 10 deletions packages/web/src/app/api/(server)/ee/mcp/route.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ import { sew } from "@/middleware/sew";
import { apiHandler } from '@/lib/apiHandler';
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';

// On 401, tell MCP clients where to find the OAuth protected resource metadata (RFC 9728)
// so they can discover the authorization server and initiate the authorization code flow.
Expand All@@ -20,20 +21,35 @@ import { hasEntitlement } from '@/lib/entitlements';
// @see: https://datatracker.ietf.org/doc/html/rfc9728
async function mcpErrorResponse(error: ServiceError): Promise<Response> {
const response = serviceErrorResponse(error);
if (error.statusCode === StatusCodes.UNAUTHORIZED && await hasEntitlement('oauth')) {
const issuer = env.AUTH_URL.replace(/\/$/, '');
response.headers.append(
'WWW-Authenticate',
`Bearer realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
response.headers.append(
'WWW-Authenticate',
`DPoP realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
if (
(error.statusCode === StatusCodes.UNAUTHORIZED || error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) &&
await hasEntitlement('oauth')
) {
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('Bearer', error));
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('DPoP', error));
}
return response;
}

function mcpOAuthChallenge(scheme: 'Bearer' | 'DPoP', error: ServiceError): string {
const issuer = env.AUTH_URL.replace(/\/$/, '');
const params = [
'realm="Sourcebot"',
`resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`,
];
const scope = SOURCEBOT_OAUTH_SCOPES.join(' ');
if (scope) {
params.push(`scope="${scope}"`);
}

if (error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) {
params.push('error="insufficient_scope"');
params.push(`error_description="${error.message}"`);
}

return `${scheme} ${params.join(', ')}`;
}

// @see: https://modelcontextprotocol.io/specification/2025-11-25/basic/transports#session-management
interface McpSession {
server: McpServer;
Expand Down
9 changes: 4 additions & 5 deletions packages/web/src/app/api/(server)/ee/oauth/token/route.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { verifyAndExchangeCode, verifyAndRotateRefreshToken } from '@/ee/features/oauth/server';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
Expand DownExpand Up@@ -77,8 +76,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand DownExpand Up@@ -110,8 +109,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import { approveAuthorization, denyAuthorization } from '@/ee/features/oauth/actions';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/constants';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/utils';
import { LoadingButton } from '@/components/ui/loading-button';
import { isServiceError } from '@/lib/utils';
import { ClientIcon } from './clientIcon';
Expand All@@ -17,6 +17,7 @@ interface ConsentScreenProps {
clientLogoUri: string | null;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
Expand All@@ -29,6 +30,7 @@ export function ConsentScreen({
clientLogoUri,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
Expand All@@ -45,7 +47,7 @@ export function ConsentScreen({
const onApprove = async () => {
captureEvent('wa_oauth_authorization_approved', { clientId, clientName });
setPending('approve');
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, resource, dpopJkt, state });
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, requestedScope, resource, dpopJkt, state });
if (!isServiceError(result)) {
if (!isPermittedRedirectUrl(result)) {
toast({ description: `❌ Redirect URL is not permitted.` });
Expand Down
10 changes: 9 additions & 1 deletion packages/web/src/app/oauth/authorize/page.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import { ConsentScreen } from './components/consentScreen';
import { __unsafePrisma } from '@/prisma';
import { hasEntitlement } from '@/lib/entitlements';
import { redirect } from 'next/navigation';
import { resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';

export const dynamic = 'force-dynamic';
Expand All@@ -16,6 +17,7 @@ interface AuthorizePageProps {
code_challenge_method?: string;
response_type?: string;
state?: string;
scope?: string;
Comment thread
brendan-kellam marked this conversation as resolved.
resource?: string | string[];
dpop_jkt?: string | string[];
}>;
Expand All@@ -27,7 +29,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
}

const params = await searchParams;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, resource: _resource, dpop_jkt: _dpopJkt } = params;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, scope, resource: _resource, dpop_jkt: _dpopJkt } = params;

// RFC 8707 allows multiple resource parameters to indicate a token intended for multiple resources.
// Sourcebot only supports a single resource (the MCP endpoint), so we take the first value.
Expand All@@ -50,6 +52,11 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
return <ErrorPage message={`Unsupported code_challenge_method: ${code_challenge_method}. Only "S256" is supported.`} />;
}

const grantedScopes = resolveGrantedOAuthScopes(scope);
if ('error' in grantedScopes) {
return <ErrorPage message={grantedScopes.errorDescription} />;
}

if (dpopJkt && !isValidDpopJkt(dpopJkt)) {
return <ErrorPage message="Invalid dpop_jkt parameter." />;
}
Expand DownExpand Up@@ -80,6 +87,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
clientLogoUri={client.logoUri}
redirectUri={redirect_uri!}
codeChallenge={code_challenge!}
requestedScope={scope}
resource={resource ?? null}
dpopJkt={dpopJkt ?? null}
state={state}
Expand Down
16 changes: 15 additions & 1 deletion packages/web/src/ee/features/oauth/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,10 @@ import { sew } from "@/middleware/sew";
import { generateAndStoreAuthCode } from '@/ee/features/oauth/server';
import { withAuth } from '@/middleware/withAuth';
import { UNPERMITTED_SCHEMES } from '@/ee/features/oauth/constants';
import { formatOAuthScopeString, resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';
import { ErrorCode } from '@/lib/errorCodes';
import type { ServiceError } from '@/lib/serviceError';
import { StatusCodes } from 'http-status-codes';

export interface ConnectedOauthClient {
Expand DownExpand Up@@ -40,31 +42,43 @@ export const approveAuthorization = async ({
clientId,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
}: {
clientId: string;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
}) => sew(() =>
withAuth(async ({ user }) => {
const grantedScopes = resolveGrantedOAuthScopes(requestedScope);
if ('error' in grantedScopes) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_REQUEST_BODY,
message: grantedScopes.errorDescription,
} satisfies ServiceError;
}

if (dpopJkt !== null && !isValidDpopJkt(dpopJkt)) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_QUERY_PARAMS,
message: 'Invalid dpop_jkt parameter.',
};
} satisfies ServiceError;
}

const rawCode = await generateAndStoreAuthCode({
clientId,
userId: user.id,
redirectUri,
codeChallenge,
scope: formatOAuthScopeString(grantedScopes.scopes),
resource,
dpopJkt,
});
Expand Down
19 changes: 2 additions & 17 deletions packages/web/src/ee/features/oauth/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,20 +3,5 @@ export const OAUTH_NOT_SUPPORTED_ERROR_MESSAGE = 'OAuth is not supported on this

export const UNPERMITTED_SCHEMES = /^(javascript|data|vbscript):/i;

/**
* Returns true if the URL is permitted for use as a redirect target.
* Allows relative paths starting with /oauth/complete and http(s) URLs.
* Returns false for dangerous schemes like javascript:, data:, vbscript:.
*/
export function isPermittedRedirectUrl(url: string): boolean {
if (url.startsWith('/oauth/complete')) {
return true;
}

try {
const parsed = new URL(url);
return parsed.protocol === 'http:' || parsed.protocol === 'https:';
} catch {
return false;
}
}
export const SOURCEBOT_OAUTH_SCOPES = [] as const;
export type SourcebotOAuthScope = (typeof SOURCEBOT_OAUTH_SCOPES)[number];
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [EE] Fixed Ask Sourcebot mermaid diagrams overflowing their container by contain-fitting them to both width and height, and made revealing a diagram from the answer jump it into view instantly to avoid over/undershooting. [#1373](https://github.com/sourcebot-dev/sourcebot/pull/1373)
- Verified GitHub review webhook deliveries before processing them. [#1378](https://github.com/sourcebot-dev/sourcebot/pull/1378)
- Passed Zoekt index parameters via argv to preserve revision names with punctuation. [#1376](https://github.com/sourcebot-dev/sourcebot/pull/1376)
- [EE] Validated OAuth bearer token scopes before allowing access to the Sourcebot MCP resource server. [#1396](https://github.com/sourcebot-dev/sourcebot/pull/1396)

## [5.0.4] - 2026-06-18

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
-- AlterTable
ALTER TABLE "OAuthAuthorizationCode" ADD COLUMN "scope" TEXT NOT NULL DEFAULT '';
Comment thread
brendan-kellam marked this conversation as resolved.
1 change: 1 addition & 0 deletions packages/db/prisma/schema.prisma
Original file line numberDiff line numberDiff line change
Expand Up@@ -732,6 +732,7 @@ model OAuthAuthorizationCode {
user User @relation(fields: [userId], references: [id], onDelete: Cascade)
redirectUri String
codeChallenge String // BASE64URL(SHA-256(codeVerifier))
scope String @default("")
resource String? // RFC 8707: canonical URI of the target resource server
dpopJkt String? // RFC 9449: DPoP JWK SHA-256 thumbprint binding
expiresAt DateTime
Expand Down
3 changes: 2 additions & 1 deletion packages/web/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,8 @@
"openapi:generate": "tsx tools/generateOpenApi.ts",
"generate:protos": "proto-loader-gen-types --includeComments --longs=Number --enums=String --defaults --oneofs --grpcLib=@grpc/grpc-js --keepCase --includeDirs=../../vendor/zoekt/grpc/protos --outDir=src/proto zoekt/webserver/v1/webserver.proto zoekt/webserver/v1/query.proto",
"dev:emails": "email dev --dir ./src/emails",
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts"
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts",
"tool:oauth-flow": "tsx tools/oauthFlow.ts"
},
"dependencies": {
"@ai-sdk/amazon-bedrock": "^4.0.94",
Expand Down
1 change: 0 additions & 1 deletion packages/web/src/__mocks__/prisma.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ export const MOCK_ORG: Org = {
updatedAt: new Date(),
isOnboarded: true,
imageUrl: null,
metadata: null,
memberApprovalRequired: false,
isCredentialsLoginEnabled: true,
isEmailCodeLoginEnabled: false,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
import { SUPPORTED_DPOP_SIGNING_ALGS } from '@/ee/features/oauth/dpop';

Expand All@@ -25,6 +25,7 @@ export const GET = oauthApiHandler(async () => {
revocation_endpoint: `${issuer}/api/ee/oauth/revoke`,
response_types_supported: ['code'],
grant_types_supported: ['authorization_code', 'refresh_token'],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
code_challenge_methods_supported: ['S256'],
token_endpoint_auth_methods_supported: ['none'],
dpop_signing_alg_values_supported: SUPPORTED_DPOP_SIGNING_ALGS,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';

// RFC 9728: OAuth 2.0 Protected Resource Metadata (path-specific form)
Expand DownExpand Up@@ -37,6 +37,7 @@ export const GET = oauthApiHandler(async (_request: NextRequest, { params }: { p
authorization_servers: [
issuer
],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
bearer_methods_supported: ['header'],
});
});
36 changes: 26 additions & 10 deletions packages/web/src/app/api/(server)/ee/mcp/route.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ import { sew } from "@/middleware/sew";
import { apiHandler } from '@/lib/apiHandler';
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';

// On 401, tell MCP clients where to find the OAuth protected resource metadata (RFC 9728)
// so they can discover the authorization server and initiate the authorization code flow.
Expand All@@ -20,20 +21,35 @@ import { hasEntitlement } from '@/lib/entitlements';
// @see: https://datatracker.ietf.org/doc/html/rfc9728
async function mcpErrorResponse(error: ServiceError): Promise<Response> {
const response = serviceErrorResponse(error);
if (error.statusCode === StatusCodes.UNAUTHORIZED && await hasEntitlement('oauth')) {
const issuer = env.AUTH_URL.replace(/\/$/, '');
response.headers.append(
'WWW-Authenticate',
`Bearer realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
response.headers.append(
'WWW-Authenticate',
`DPoP realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
if (
(error.statusCode === StatusCodes.UNAUTHORIZED || error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) &&
await hasEntitlement('oauth')
) {
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('Bearer', error));
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('DPoP', error));
}
return response;
}

function mcpOAuthChallenge(scheme: 'Bearer' | 'DPoP', error: ServiceError): string {
const issuer = env.AUTH_URL.replace(/\/$/, '');
const params = [
'realm="Sourcebot"',
`resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`,
];
const scope = SOURCEBOT_OAUTH_SCOPES.join(' ');
if (scope) {
params.push(`scope="${scope}"`);
}

if (error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) {
params.push('error="insufficient_scope"');
params.push(`error_description="${error.message}"`);
}

return `${scheme} ${params.join(', ')}`;
}

// @see: https://modelcontextprotocol.io/specification/2025-11-25/basic/transports#session-management
interface McpSession {
server: McpServer;
Expand Down
9 changes: 4 additions & 5 deletions packages/web/src/app/api/(server)/ee/oauth/token/route.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { verifyAndExchangeCode, verifyAndRotateRefreshToken } from '@/ee/features/oauth/server';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
Expand DownExpand Up@@ -77,8 +76,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand DownExpand Up@@ -110,8 +109,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import { approveAuthorization, denyAuthorization } from '@/ee/features/oauth/actions';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/constants';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/utils';
import { LoadingButton } from '@/components/ui/loading-button';
import { isServiceError } from '@/lib/utils';
import { ClientIcon } from './clientIcon';
Expand All@@ -17,6 +17,7 @@ interface ConsentScreenProps {
clientLogoUri: string | null;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
Expand All@@ -29,6 +30,7 @@ export function ConsentScreen({
clientLogoUri,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
Expand All@@ -45,7 +47,7 @@ export function ConsentScreen({
const onApprove = async () => {
captureEvent('wa_oauth_authorization_approved', { clientId, clientName });
setPending('approve');
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, resource, dpopJkt, state });
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, requestedScope, resource, dpopJkt, state });
if (!isServiceError(result)) {
if (!isPermittedRedirectUrl(result)) {
toast({ description: `❌ Redirect URL is not permitted.` });
Expand Down
10 changes: 9 additions & 1 deletion packages/web/src/app/oauth/authorize/page.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import { ConsentScreen } from './components/consentScreen';
import { __unsafePrisma } from '@/prisma';
import { hasEntitlement } from '@/lib/entitlements';
import { redirect } from 'next/navigation';
import { resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';

export const dynamic = 'force-dynamic';
Expand All@@ -16,6 +17,7 @@ interface AuthorizePageProps {
code_challenge_method?: string;
response_type?: string;
state?: string;
scope?: string;
Comment thread
brendan-kellam marked this conversation as resolved.
resource?: string | string[];
dpop_jkt?: string | string[];
}>;
Expand All@@ -27,7 +29,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
}

const params = await searchParams;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, resource: _resource, dpop_jkt: _dpopJkt } = params;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, scope, resource: _resource, dpop_jkt: _dpopJkt } = params;

// RFC 8707 allows multiple resource parameters to indicate a token intended for multiple resources.
// Sourcebot only supports a single resource (the MCP endpoint), so we take the first value.
Expand All@@ -50,6 +52,11 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
return <ErrorPage message={`Unsupported code_challenge_method: ${code_challenge_method}. Only "S256" is supported.`} />;
}

const grantedScopes = resolveGrantedOAuthScopes(scope);
if ('error' in grantedScopes) {
return <ErrorPage message={grantedScopes.errorDescription} />;
}

if (dpopJkt && !isValidDpopJkt(dpopJkt)) {
return <ErrorPage message="Invalid dpop_jkt parameter." />;
}
Expand DownExpand Up@@ -80,6 +87,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
clientLogoUri={client.logoUri}
redirectUri={redirect_uri!}
codeChallenge={code_challenge!}
requestedScope={scope}
resource={resource ?? null}
dpopJkt={dpopJkt ?? null}
state={state}
Expand Down
16 changes: 15 additions & 1 deletion packages/web/src/ee/features/oauth/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,10 @@ import { sew } from "@/middleware/sew";
import { generateAndStoreAuthCode } from '@/ee/features/oauth/server';
import { withAuth } from '@/middleware/withAuth';
import { UNPERMITTED_SCHEMES } from '@/ee/features/oauth/constants';
import { formatOAuthScopeString, resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';
import { ErrorCode } from '@/lib/errorCodes';
import type { ServiceError } from '@/lib/serviceError';
import { StatusCodes } from 'http-status-codes';

export interface ConnectedOauthClient {
Expand DownExpand Up@@ -40,31 +42,43 @@ export const approveAuthorization = async ({
clientId,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
}: {
clientId: string;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
}) => sew(() =>
withAuth(async ({ user }) => {
const grantedScopes = resolveGrantedOAuthScopes(requestedScope);
if ('error' in grantedScopes) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_REQUEST_BODY,
message: grantedScopes.errorDescription,
} satisfies ServiceError;
}

if (dpopJkt !== null && !isValidDpopJkt(dpopJkt)) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_QUERY_PARAMS,
message: 'Invalid dpop_jkt parameter.',
};
} satisfies ServiceError;
}

const rawCode = await generateAndStoreAuthCode({
clientId,
userId: user.id,
redirectUri,
codeChallenge,
scope: formatOAuthScopeString(grantedScopes.scopes),
resource,
dpopJkt,
});
Expand Down
19 changes: 2 additions & 17 deletions packages/web/src/ee/features/oauth/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,20 +3,5 @@ export const OAUTH_NOT_SUPPORTED_ERROR_MESSAGE = 'OAuth is not supported on this

export const UNPERMITTED_SCHEMES = /^(javascript|data|vbscript):/i;

/**
* Returns true if the URL is permitted for use as a redirect target.
* Allows relative paths starting with /oauth/complete and http(s) URLs.
* Returns false for dangerous schemes like javascript:, data:, vbscript:.
*/
export function isPermittedRedirectUrl(url: string): boolean {
if (url.startsWith('/oauth/complete')) {
return true;
}

try {
const parsed = new URL(url);
return parsed.protocol === 'http:' || parsed.protocol === 'https:';
} catch {
return false;
}
}
export const SOURCEBOT_OAUTH_SCOPES = [] as const;
export type SourcebotOAuthScope = (typeof SOURCEBOT_OAUTH_SCOPES)[number];
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [EE] Fixed Ask Sourcebot mermaid diagrams overflowing their container by contain-fitting them to both width and height, and made revealing a diagram from the answer jump it into view instantly to avoid over/undershooting. [#1373](https://github.com/sourcebot-dev/sourcebot/pull/1373)
- Verified GitHub review webhook deliveries before processing them. [#1378](https://github.com/sourcebot-dev/sourcebot/pull/1378)
- Passed Zoekt index parameters via argv to preserve revision names with punctuation. [#1376](https://github.com/sourcebot-dev/sourcebot/pull/1376)
- [EE] Validated OAuth bearer token scopes before allowing access to the Sourcebot MCP resource server. [#1396](https://github.com/sourcebot-dev/sourcebot/pull/1396)

## [5.0.4] - 2026-06-18

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
-- AlterTable
ALTER TABLE "OAuthAuthorizationCode" ADD COLUMN "scope" TEXT NOT NULL DEFAULT '';
Comment thread
brendan-kellam marked this conversation as resolved.
1 change: 1 addition & 0 deletions packages/db/prisma/schema.prisma
Original file line numberDiff line numberDiff line change
Expand Up@@ -732,6 +732,7 @@ model OAuthAuthorizationCode {
user User @relation(fields: [userId], references: [id], onDelete: Cascade)
redirectUri String
codeChallenge String // BASE64URL(SHA-256(codeVerifier))
scope String @default("")
resource String? // RFC 8707: canonical URI of the target resource server
dpopJkt String? // RFC 9449: DPoP JWK SHA-256 thumbprint binding
expiresAt DateTime
Expand Down
3 changes: 2 additions & 1 deletion packages/web/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,8 @@
"openapi:generate": "tsx tools/generateOpenApi.ts",
"generate:protos": "proto-loader-gen-types --includeComments --longs=Number --enums=String --defaults --oneofs --grpcLib=@grpc/grpc-js --keepCase --includeDirs=../../vendor/zoekt/grpc/protos --outDir=src/proto zoekt/webserver/v1/webserver.proto zoekt/webserver/v1/query.proto",
"dev:emails": "email dev --dir ./src/emails",
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts"
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts",
"tool:oauth-flow": "tsx tools/oauthFlow.ts"
},
"dependencies": {
"@ai-sdk/amazon-bedrock": "^4.0.94",
Expand Down
1 change: 0 additions & 1 deletion packages/web/src/__mocks__/prisma.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ export const MOCK_ORG: Org = {
updatedAt: new Date(),
isOnboarded: true,
imageUrl: null,
metadata: null,
memberApprovalRequired: false,
isCredentialsLoginEnabled: true,
isEmailCodeLoginEnabled: false,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
import { SUPPORTED_DPOP_SIGNING_ALGS } from '@/ee/features/oauth/dpop';

Expand All@@ -25,6 +25,7 @@ export const GET = oauthApiHandler(async () => {
revocation_endpoint: `${issuer}/api/ee/oauth/revoke`,
response_types_supported: ['code'],
grant_types_supported: ['authorization_code', 'refresh_token'],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
code_challenge_methods_supported: ['S256'],
token_endpoint_auth_methods_supported: ['none'],
dpop_signing_alg_values_supported: SUPPORTED_DPOP_SIGNING_ALGS,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';

// RFC 9728: OAuth 2.0 Protected Resource Metadata (path-specific form)
Expand DownExpand Up@@ -37,6 +37,7 @@ export const GET = oauthApiHandler(async (_request: NextRequest, { params }: { p
authorization_servers: [
issuer
],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
bearer_methods_supported: ['header'],
});
});
36 changes: 26 additions & 10 deletions packages/web/src/app/api/(server)/ee/mcp/route.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ import { sew } from "@/middleware/sew";
import { apiHandler } from '@/lib/apiHandler';
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';

// On 401, tell MCP clients where to find the OAuth protected resource metadata (RFC 9728)
// so they can discover the authorization server and initiate the authorization code flow.
Expand All@@ -20,20 +21,35 @@ import { hasEntitlement } from '@/lib/entitlements';
// @see: https://datatracker.ietf.org/doc/html/rfc9728
async function mcpErrorResponse(error: ServiceError): Promise<Response> {
const response = serviceErrorResponse(error);
if (error.statusCode === StatusCodes.UNAUTHORIZED && await hasEntitlement('oauth')) {
const issuer = env.AUTH_URL.replace(/\/$/, '');
response.headers.append(
'WWW-Authenticate',
`Bearer realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
response.headers.append(
'WWW-Authenticate',
`DPoP realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
if (
(error.statusCode === StatusCodes.UNAUTHORIZED || error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) &&
await hasEntitlement('oauth')
) {
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('Bearer', error));
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('DPoP', error));
}
return response;
}

function mcpOAuthChallenge(scheme: 'Bearer' | 'DPoP', error: ServiceError): string {
const issuer = env.AUTH_URL.replace(/\/$/, '');
const params = [
'realm="Sourcebot"',
`resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`,
];
const scope = SOURCEBOT_OAUTH_SCOPES.join(' ');
if (scope) {
params.push(`scope="${scope}"`);
}

if (error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) {
params.push('error="insufficient_scope"');
params.push(`error_description="${error.message}"`);
}

return `${scheme} ${params.join(', ')}`;
}

// @see: https://modelcontextprotocol.io/specification/2025-11-25/basic/transports#session-management
interface McpSession {
server: McpServer;
Expand Down
9 changes: 4 additions & 5 deletions packages/web/src/app/api/(server)/ee/oauth/token/route.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { verifyAndExchangeCode, verifyAndRotateRefreshToken } from '@/ee/features/oauth/server';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
Expand DownExpand Up@@ -77,8 +76,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand DownExpand Up@@ -110,8 +109,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import { approveAuthorization, denyAuthorization } from '@/ee/features/oauth/actions';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/constants';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/utils';
import { LoadingButton } from '@/components/ui/loading-button';
import { isServiceError } from '@/lib/utils';
import { ClientIcon } from './clientIcon';
Expand All@@ -17,6 +17,7 @@ interface ConsentScreenProps {
clientLogoUri: string | null;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
Expand All@@ -29,6 +30,7 @@ export function ConsentScreen({
clientLogoUri,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
Expand All@@ -45,7 +47,7 @@ export function ConsentScreen({
const onApprove = async () => {
captureEvent('wa_oauth_authorization_approved', { clientId, clientName });
setPending('approve');
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, resource, dpopJkt, state });
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, requestedScope, resource, dpopJkt, state });
if (!isServiceError(result)) {
if (!isPermittedRedirectUrl(result)) {
toast({ description: `❌ Redirect URL is not permitted.` });
Expand Down
10 changes: 9 additions & 1 deletion packages/web/src/app/oauth/authorize/page.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import { ConsentScreen } from './components/consentScreen';
import { __unsafePrisma } from '@/prisma';
import { hasEntitlement } from '@/lib/entitlements';
import { redirect } from 'next/navigation';
import { resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';

export const dynamic = 'force-dynamic';
Expand All@@ -16,6 +17,7 @@ interface AuthorizePageProps {
code_challenge_method?: string;
response_type?: string;
state?: string;
scope?: string;
Comment thread
brendan-kellam marked this conversation as resolved.
resource?: string | string[];
dpop_jkt?: string | string[];
}>;
Expand All@@ -27,7 +29,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
}

const params = await searchParams;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, resource: _resource, dpop_jkt: _dpopJkt } = params;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, scope, resource: _resource, dpop_jkt: _dpopJkt } = params;

// RFC 8707 allows multiple resource parameters to indicate a token intended for multiple resources.
// Sourcebot only supports a single resource (the MCP endpoint), so we take the first value.
Expand All@@ -50,6 +52,11 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
return <ErrorPage message={`Unsupported code_challenge_method: ${code_challenge_method}. Only "S256" is supported.`} />;
}

const grantedScopes = resolveGrantedOAuthScopes(scope);
if ('error' in grantedScopes) {
return <ErrorPage message={grantedScopes.errorDescription} />;
}

if (dpopJkt && !isValidDpopJkt(dpopJkt)) {
return <ErrorPage message="Invalid dpop_jkt parameter." />;
}
Expand DownExpand Up@@ -80,6 +87,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
clientLogoUri={client.logoUri}
redirectUri={redirect_uri!}
codeChallenge={code_challenge!}
requestedScope={scope}
resource={resource ?? null}
dpopJkt={dpopJkt ?? null}
state={state}
Expand Down
16 changes: 15 additions & 1 deletion packages/web/src/ee/features/oauth/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,10 @@ import { sew } from "@/middleware/sew";
import { generateAndStoreAuthCode } from '@/ee/features/oauth/server';
import { withAuth } from '@/middleware/withAuth';
import { UNPERMITTED_SCHEMES } from '@/ee/features/oauth/constants';
import { formatOAuthScopeString, resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';
import { ErrorCode } from '@/lib/errorCodes';
import type { ServiceError } from '@/lib/serviceError';
import { StatusCodes } from 'http-status-codes';

export interface ConnectedOauthClient {
Expand DownExpand Up@@ -40,31 +42,43 @@ export const approveAuthorization = async ({
clientId,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
}: {
clientId: string;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
}) => sew(() =>
withAuth(async ({ user }) => {
const grantedScopes = resolveGrantedOAuthScopes(requestedScope);
if ('error' in grantedScopes) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_REQUEST_BODY,
message: grantedScopes.errorDescription,
} satisfies ServiceError;
}

if (dpopJkt !== null && !isValidDpopJkt(dpopJkt)) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_QUERY_PARAMS,
message: 'Invalid dpop_jkt parameter.',
};
} satisfies ServiceError;
}

const rawCode = await generateAndStoreAuthCode({
clientId,
userId: user.id,
redirectUri,
codeChallenge,
scope: formatOAuthScopeString(grantedScopes.scopes),
resource,
dpopJkt,
});
Expand Down
19 changes: 2 additions & 17 deletions packages/web/src/ee/features/oauth/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,20 +3,5 @@ export const OAUTH_NOT_SUPPORTED_ERROR_MESSAGE = 'OAuth is not supported on this

export const UNPERMITTED_SCHEMES = /^(javascript|data|vbscript):/i;

/**
* Returns true if the URL is permitted for use as a redirect target.
* Allows relative paths starting with /oauth/complete and http(s) URLs.
* Returns false for dangerous schemes like javascript:, data:, vbscript:.
*/
export function isPermittedRedirectUrl(url: string): boolean {
if (url.startsWith('/oauth/complete')) {
return true;
}

try {
const parsed = new URL(url);
return parsed.protocol === 'http:' || parsed.protocol === 'https:';
} catch {
return false;
}
}
export const SOURCEBOT_OAUTH_SCOPES = [] as const;
export type SourcebotOAuthScope = (typeof SOURCEBOT_OAUTH_SCOPES)[number];
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [EE] Fixed Ask Sourcebot mermaid diagrams overflowing their container by contain-fitting them to both width and height, and made revealing a diagram from the answer jump it into view instantly to avoid over/undershooting. [#1373](https://github.com/sourcebot-dev/sourcebot/pull/1373)
- Verified GitHub review webhook deliveries before processing them. [#1378](https://github.com/sourcebot-dev/sourcebot/pull/1378)
- Passed Zoekt index parameters via argv to preserve revision names with punctuation. [#1376](https://github.com/sourcebot-dev/sourcebot/pull/1376)
- [EE] Validated OAuth bearer token scopes before allowing access to the Sourcebot MCP resource server. [#1396](https://github.com/sourcebot-dev/sourcebot/pull/1396)

## [5.0.4] - 2026-06-18

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
-- AlterTable
ALTER TABLE "OAuthAuthorizationCode" ADD COLUMN "scope" TEXT NOT NULL DEFAULT '';
Comment thread
brendan-kellam marked this conversation as resolved.
1 change: 1 addition & 0 deletions packages/db/prisma/schema.prisma
Original file line numberDiff line numberDiff line change
Expand Up@@ -732,6 +732,7 @@ model OAuthAuthorizationCode {
user User @relation(fields: [userId], references: [id], onDelete: Cascade)
redirectUri String
codeChallenge String // BASE64URL(SHA-256(codeVerifier))
scope String @default("")
resource String? // RFC 8707: canonical URI of the target resource server
dpopJkt String? // RFC 9449: DPoP JWK SHA-256 thumbprint binding
expiresAt DateTime
Expand Down
3 changes: 2 additions & 1 deletion packages/web/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,8 @@
"openapi:generate": "tsx tools/generateOpenApi.ts",
"generate:protos": "proto-loader-gen-types --includeComments --longs=Number --enums=String --defaults --oneofs --grpcLib=@grpc/grpc-js --keepCase --includeDirs=../../vendor/zoekt/grpc/protos --outDir=src/proto zoekt/webserver/v1/webserver.proto zoekt/webserver/v1/query.proto",
"dev:emails": "email dev --dir ./src/emails",
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts"
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts",
"tool:oauth-flow": "tsx tools/oauthFlow.ts"
},
"dependencies": {
"@ai-sdk/amazon-bedrock": "^4.0.94",
Expand Down
1 change: 0 additions & 1 deletion packages/web/src/__mocks__/prisma.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ export const MOCK_ORG: Org = {
updatedAt: new Date(),
isOnboarded: true,
imageUrl: null,
metadata: null,
memberApprovalRequired: false,
isCredentialsLoginEnabled: true,
isEmailCodeLoginEnabled: false,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
import { SUPPORTED_DPOP_SIGNING_ALGS } from '@/ee/features/oauth/dpop';

Expand All@@ -25,6 +25,7 @@ export const GET = oauthApiHandler(async () => {
revocation_endpoint: `${issuer}/api/ee/oauth/revoke`,
response_types_supported: ['code'],
grant_types_supported: ['authorization_code', 'refresh_token'],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
code_challenge_methods_supported: ['S256'],
token_endpoint_auth_methods_supported: ['none'],
dpop_signing_alg_values_supported: SUPPORTED_DPOP_SIGNING_ALGS,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';

// RFC 9728: OAuth 2.0 Protected Resource Metadata (path-specific form)
Expand DownExpand Up@@ -37,6 +37,7 @@ export const GET = oauthApiHandler(async (_request: NextRequest, { params }: { p
authorization_servers: [
issuer
],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
bearer_methods_supported: ['header'],
});
});
36 changes: 26 additions & 10 deletions packages/web/src/app/api/(server)/ee/mcp/route.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ import { sew } from "@/middleware/sew";
import { apiHandler } from '@/lib/apiHandler';
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';

// On 401, tell MCP clients where to find the OAuth protected resource metadata (RFC 9728)
// so they can discover the authorization server and initiate the authorization code flow.
Expand All@@ -20,20 +21,35 @@ import { hasEntitlement } from '@/lib/entitlements';
// @see: https://datatracker.ietf.org/doc/html/rfc9728
async function mcpErrorResponse(error: ServiceError): Promise<Response> {
const response = serviceErrorResponse(error);
if (error.statusCode === StatusCodes.UNAUTHORIZED && await hasEntitlement('oauth')) {
const issuer = env.AUTH_URL.replace(/\/$/, '');
response.headers.append(
'WWW-Authenticate',
`Bearer realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
response.headers.append(
'WWW-Authenticate',
`DPoP realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
if (
(error.statusCode === StatusCodes.UNAUTHORIZED || error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) &&
await hasEntitlement('oauth')
) {
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('Bearer', error));
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('DPoP', error));
}
return response;
}

function mcpOAuthChallenge(scheme: 'Bearer' | 'DPoP', error: ServiceError): string {
const issuer = env.AUTH_URL.replace(/\/$/, '');
const params = [
'realm="Sourcebot"',
`resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`,
];
const scope = SOURCEBOT_OAUTH_SCOPES.join(' ');
if (scope) {
params.push(`scope="${scope}"`);
}

if (error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) {
params.push('error="insufficient_scope"');
params.push(`error_description="${error.message}"`);
}

return `${scheme} ${params.join(', ')}`;
}

// @see: https://modelcontextprotocol.io/specification/2025-11-25/basic/transports#session-management
interface McpSession {
server: McpServer;
Expand Down
9 changes: 4 additions & 5 deletions packages/web/src/app/api/(server)/ee/oauth/token/route.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { verifyAndExchangeCode, verifyAndRotateRefreshToken } from '@/ee/features/oauth/server';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
Expand DownExpand Up@@ -77,8 +76,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand DownExpand Up@@ -110,8 +109,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import { approveAuthorization, denyAuthorization } from '@/ee/features/oauth/actions';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/constants';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/utils';
import { LoadingButton } from '@/components/ui/loading-button';
import { isServiceError } from '@/lib/utils';
import { ClientIcon } from './clientIcon';
Expand All@@ -17,6 +17,7 @@ interface ConsentScreenProps {
clientLogoUri: string | null;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
Expand All@@ -29,6 +30,7 @@ export function ConsentScreen({
clientLogoUri,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
Expand All@@ -45,7 +47,7 @@ export function ConsentScreen({
const onApprove = async () => {
captureEvent('wa_oauth_authorization_approved', { clientId, clientName });
setPending('approve');
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, resource, dpopJkt, state });
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, requestedScope, resource, dpopJkt, state });
if (!isServiceError(result)) {
if (!isPermittedRedirectUrl(result)) {
toast({ description: `❌ Redirect URL is not permitted.` });
Expand Down
10 changes: 9 additions & 1 deletion packages/web/src/app/oauth/authorize/page.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import { ConsentScreen } from './components/consentScreen';
import { __unsafePrisma } from '@/prisma';
import { hasEntitlement } from '@/lib/entitlements';
import { redirect } from 'next/navigation';
import { resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';

export const dynamic = 'force-dynamic';
Expand All@@ -16,6 +17,7 @@ interface AuthorizePageProps {
code_challenge_method?: string;
response_type?: string;
state?: string;
scope?: string;
Comment thread
brendan-kellam marked this conversation as resolved.
resource?: string | string[];
dpop_jkt?: string | string[];
}>;
Expand All@@ -27,7 +29,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
}

const params = await searchParams;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, resource: _resource, dpop_jkt: _dpopJkt } = params;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, scope, resource: _resource, dpop_jkt: _dpopJkt } = params;

// RFC 8707 allows multiple resource parameters to indicate a token intended for multiple resources.
// Sourcebot only supports a single resource (the MCP endpoint), so we take the first value.
Expand All@@ -50,6 +52,11 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
return <ErrorPage message={`Unsupported code_challenge_method: ${code_challenge_method}. Only "S256" is supported.`} />;
}

const grantedScopes = resolveGrantedOAuthScopes(scope);
if ('error' in grantedScopes) {
return <ErrorPage message={grantedScopes.errorDescription} />;
}

if (dpopJkt && !isValidDpopJkt(dpopJkt)) {
return <ErrorPage message="Invalid dpop_jkt parameter." />;
}
Expand DownExpand Up@@ -80,6 +87,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
clientLogoUri={client.logoUri}
redirectUri={redirect_uri!}
codeChallenge={code_challenge!}
requestedScope={scope}
resource={resource ?? null}
dpopJkt={dpopJkt ?? null}
state={state}
Expand Down
16 changes: 15 additions & 1 deletion packages/web/src/ee/features/oauth/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,10 @@ import { sew } from "@/middleware/sew";
import { generateAndStoreAuthCode } from '@/ee/features/oauth/server';
import { withAuth } from '@/middleware/withAuth';
import { UNPERMITTED_SCHEMES } from '@/ee/features/oauth/constants';
import { formatOAuthScopeString, resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';
import { ErrorCode } from '@/lib/errorCodes';
import type { ServiceError } from '@/lib/serviceError';
import { StatusCodes } from 'http-status-codes';

export interface ConnectedOauthClient {
Expand DownExpand Up@@ -40,31 +42,43 @@ export const approveAuthorization = async ({
clientId,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
}: {
clientId: string;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
}) => sew(() =>
withAuth(async ({ user }) => {
const grantedScopes = resolveGrantedOAuthScopes(requestedScope);
if ('error' in grantedScopes) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_REQUEST_BODY,
message: grantedScopes.errorDescription,
} satisfies ServiceError;
}

if (dpopJkt !== null && !isValidDpopJkt(dpopJkt)) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_QUERY_PARAMS,
message: 'Invalid dpop_jkt parameter.',
};
} satisfies ServiceError;
}

const rawCode = await generateAndStoreAuthCode({
clientId,
userId: user.id,
redirectUri,
codeChallenge,
scope: formatOAuthScopeString(grantedScopes.scopes),
resource,
dpopJkt,
});
Expand Down
19 changes: 2 additions & 17 deletions packages/web/src/ee/features/oauth/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,20 +3,5 @@ export const OAUTH_NOT_SUPPORTED_ERROR_MESSAGE = 'OAuth is not supported on this

export const UNPERMITTED_SCHEMES = /^(javascript|data|vbscript):/i;

/**
* Returns true if the URL is permitted for use as a redirect target.
* Allows relative paths starting with /oauth/complete and http(s) URLs.
* Returns false for dangerous schemes like javascript:, data:, vbscript:.
*/
export function isPermittedRedirectUrl(url: string): boolean {
if (url.startsWith('/oauth/complete')) {
return true;
}

try {
const parsed = new URL(url);
return parsed.protocol === 'http:' || parsed.protocol === 'https:';
} catch {
return false;
}
}
export const SOURCEBOT_OAUTH_SCOPES = [] as const;
export type SourcebotOAuthScope = (typeof SOURCEBOT_OAUTH_SCOPES)[number];
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [EE] Fixed Ask Sourcebot mermaid diagrams overflowing their container by contain-fitting them to both width and height, and made revealing a diagram from the answer jump it into view instantly to avoid over/undershooting. [#1373](https://github.com/sourcebot-dev/sourcebot/pull/1373)
- Verified GitHub review webhook deliveries before processing them. [#1378](https://github.com/sourcebot-dev/sourcebot/pull/1378)
- Passed Zoekt index parameters via argv to preserve revision names with punctuation. [#1376](https://github.com/sourcebot-dev/sourcebot/pull/1376)
- [EE] Validated OAuth bearer token scopes before allowing access to the Sourcebot MCP resource server. [#1396](https://github.com/sourcebot-dev/sourcebot/pull/1396)

## [5.0.4] - 2026-06-18

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
-- AlterTable
ALTER TABLE "OAuthAuthorizationCode" ADD COLUMN "scope" TEXT NOT NULL DEFAULT '';
Comment thread
brendan-kellam marked this conversation as resolved.
1 change: 1 addition & 0 deletions packages/db/prisma/schema.prisma
Original file line numberDiff line numberDiff line change
Expand Up@@ -732,6 +732,7 @@ model OAuthAuthorizationCode {
user User @relation(fields: [userId], references: [id], onDelete: Cascade)
redirectUri String
codeChallenge String // BASE64URL(SHA-256(codeVerifier))
scope String @default("")
resource String? // RFC 8707: canonical URI of the target resource server
dpopJkt String? // RFC 9449: DPoP JWK SHA-256 thumbprint binding
expiresAt DateTime
Expand Down
3 changes: 2 additions & 1 deletion packages/web/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,8 @@
"openapi:generate": "tsx tools/generateOpenApi.ts",
"generate:protos": "proto-loader-gen-types --includeComments --longs=Number --enums=String --defaults --oneofs --grpcLib=@grpc/grpc-js --keepCase --includeDirs=../../vendor/zoekt/grpc/protos --outDir=src/proto zoekt/webserver/v1/webserver.proto zoekt/webserver/v1/query.proto",
"dev:emails": "email dev --dir ./src/emails",
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts"
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts",
"tool:oauth-flow": "tsx tools/oauthFlow.ts"
},
"dependencies": {
"@ai-sdk/amazon-bedrock": "^4.0.94",
Expand Down
1 change: 0 additions & 1 deletion packages/web/src/__mocks__/prisma.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ export const MOCK_ORG: Org = {
updatedAt: new Date(),
isOnboarded: true,
imageUrl: null,
metadata: null,
memberApprovalRequired: false,
isCredentialsLoginEnabled: true,
isEmailCodeLoginEnabled: false,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
import { SUPPORTED_DPOP_SIGNING_ALGS } from '@/ee/features/oauth/dpop';

Expand All@@ -25,6 +25,7 @@ export const GET = oauthApiHandler(async () => {
revocation_endpoint: `${issuer}/api/ee/oauth/revoke`,
response_types_supported: ['code'],
grant_types_supported: ['authorization_code', 'refresh_token'],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
code_challenge_methods_supported: ['S256'],
token_endpoint_auth_methods_supported: ['none'],
dpop_signing_alg_values_supported: SUPPORTED_DPOP_SIGNING_ALGS,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';

// RFC 9728: OAuth 2.0 Protected Resource Metadata (path-specific form)
Expand DownExpand Up@@ -37,6 +37,7 @@ export const GET = oauthApiHandler(async (_request: NextRequest, { params }: { p
authorization_servers: [
issuer
],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
bearer_methods_supported: ['header'],
});
});
36 changes: 26 additions & 10 deletions packages/web/src/app/api/(server)/ee/mcp/route.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ import { sew } from "@/middleware/sew";
import { apiHandler } from '@/lib/apiHandler';
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';

// On 401, tell MCP clients where to find the OAuth protected resource metadata (RFC 9728)
// so they can discover the authorization server and initiate the authorization code flow.
Expand All@@ -20,20 +21,35 @@ import { hasEntitlement } from '@/lib/entitlements';
// @see: https://datatracker.ietf.org/doc/html/rfc9728
async function mcpErrorResponse(error: ServiceError): Promise<Response> {
const response = serviceErrorResponse(error);
if (error.statusCode === StatusCodes.UNAUTHORIZED && await hasEntitlement('oauth')) {
const issuer = env.AUTH_URL.replace(/\/$/, '');
response.headers.append(
'WWW-Authenticate',
`Bearer realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
response.headers.append(
'WWW-Authenticate',
`DPoP realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
if (
(error.statusCode === StatusCodes.UNAUTHORIZED || error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) &&
await hasEntitlement('oauth')
) {
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('Bearer', error));
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('DPoP', error));
}
return response;
}

function mcpOAuthChallenge(scheme: 'Bearer' | 'DPoP', error: ServiceError): string {
const issuer = env.AUTH_URL.replace(/\/$/, '');
const params = [
'realm="Sourcebot"',
`resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`,
];
const scope = SOURCEBOT_OAUTH_SCOPES.join(' ');
if (scope) {
params.push(`scope="${scope}"`);
}

if (error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) {
params.push('error="insufficient_scope"');
params.push(`error_description="${error.message}"`);
}

return `${scheme} ${params.join(', ')}`;
}

// @see: https://modelcontextprotocol.io/specification/2025-11-25/basic/transports#session-management
interface McpSession {
server: McpServer;
Expand Down
9 changes: 4 additions & 5 deletions packages/web/src/app/api/(server)/ee/oauth/token/route.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { verifyAndExchangeCode, verifyAndRotateRefreshToken } from '@/ee/features/oauth/server';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
Expand DownExpand Up@@ -77,8 +76,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand DownExpand Up@@ -110,8 +109,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import { approveAuthorization, denyAuthorization } from '@/ee/features/oauth/actions';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/constants';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/utils';
import { LoadingButton } from '@/components/ui/loading-button';
import { isServiceError } from '@/lib/utils';
import { ClientIcon } from './clientIcon';
Expand All@@ -17,6 +17,7 @@ interface ConsentScreenProps {
clientLogoUri: string | null;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
Expand All@@ -29,6 +30,7 @@ export function ConsentScreen({
clientLogoUri,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
Expand All@@ -45,7 +47,7 @@ export function ConsentScreen({
const onApprove = async () => {
captureEvent('wa_oauth_authorization_approved', { clientId, clientName });
setPending('approve');
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, resource, dpopJkt, state });
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, requestedScope, resource, dpopJkt, state });
if (!isServiceError(result)) {
if (!isPermittedRedirectUrl(result)) {
toast({ description: `❌ Redirect URL is not permitted.` });
Expand Down
10 changes: 9 additions & 1 deletion packages/web/src/app/oauth/authorize/page.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import { ConsentScreen } from './components/consentScreen';
import { __unsafePrisma } from '@/prisma';
import { hasEntitlement } from '@/lib/entitlements';
import { redirect } from 'next/navigation';
import { resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';

export const dynamic = 'force-dynamic';
Expand All@@ -16,6 +17,7 @@ interface AuthorizePageProps {
code_challenge_method?: string;
response_type?: string;
state?: string;
scope?: string;
Comment thread
brendan-kellam marked this conversation as resolved.
resource?: string | string[];
dpop_jkt?: string | string[];
}>;
Expand All@@ -27,7 +29,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
}

const params = await searchParams;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, resource: _resource, dpop_jkt: _dpopJkt } = params;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, scope, resource: _resource, dpop_jkt: _dpopJkt } = params;

// RFC 8707 allows multiple resource parameters to indicate a token intended for multiple resources.
// Sourcebot only supports a single resource (the MCP endpoint), so we take the first value.
Expand All@@ -50,6 +52,11 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
return <ErrorPage message={`Unsupported code_challenge_method: ${code_challenge_method}. Only "S256" is supported.`} />;
}

const grantedScopes = resolveGrantedOAuthScopes(scope);
if ('error' in grantedScopes) {
return <ErrorPage message={grantedScopes.errorDescription} />;
}

if (dpopJkt && !isValidDpopJkt(dpopJkt)) {
return <ErrorPage message="Invalid dpop_jkt parameter." />;
}
Expand DownExpand Up@@ -80,6 +87,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
clientLogoUri={client.logoUri}
redirectUri={redirect_uri!}
codeChallenge={code_challenge!}
requestedScope={scope}
resource={resource ?? null}
dpopJkt={dpopJkt ?? null}
state={state}
Expand Down
16 changes: 15 additions & 1 deletion packages/web/src/ee/features/oauth/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,10 @@ import { sew } from "@/middleware/sew";
import { generateAndStoreAuthCode } from '@/ee/features/oauth/server';
import { withAuth } from '@/middleware/withAuth';
import { UNPERMITTED_SCHEMES } from '@/ee/features/oauth/constants';
import { formatOAuthScopeString, resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';
import { ErrorCode } from '@/lib/errorCodes';
import type { ServiceError } from '@/lib/serviceError';
import { StatusCodes } from 'http-status-codes';

export interface ConnectedOauthClient {
Expand DownExpand Up@@ -40,31 +42,43 @@ export const approveAuthorization = async ({
clientId,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
}: {
clientId: string;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
}) => sew(() =>
withAuth(async ({ user }) => {
const grantedScopes = resolveGrantedOAuthScopes(requestedScope);
if ('error' in grantedScopes) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_REQUEST_BODY,
message: grantedScopes.errorDescription,
} satisfies ServiceError;
}

if (dpopJkt !== null && !isValidDpopJkt(dpopJkt)) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_QUERY_PARAMS,
message: 'Invalid dpop_jkt parameter.',
};
} satisfies ServiceError;
}

const rawCode = await generateAndStoreAuthCode({
clientId,
userId: user.id,
redirectUri,
codeChallenge,
scope: formatOAuthScopeString(grantedScopes.scopes),
resource,
dpopJkt,
});
Expand Down
19 changes: 2 additions & 17 deletions packages/web/src/ee/features/oauth/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,20 +3,5 @@ export const OAUTH_NOT_SUPPORTED_ERROR_MESSAGE = 'OAuth is not supported on this

export const UNPERMITTED_SCHEMES = /^(javascript|data|vbscript):/i;

/**
* Returns true if the URL is permitted for use as a redirect target.
* Allows relative paths starting with /oauth/complete and http(s) URLs.
* Returns false for dangerous schemes like javascript:, data:, vbscript:.
*/
export function isPermittedRedirectUrl(url: string): boolean {
if (url.startsWith('/oauth/complete')) {
return true;
}

try {
const parsed = new URL(url);
return parsed.protocol === 'http:' || parsed.protocol === 'https:';
} catch {
return false;
}
}
export const SOURCEBOT_OAUTH_SCOPES = [] as const;
export type SourcebotOAuthScope = (typeof SOURCEBOT_OAUTH_SCOPES)[number];
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [EE] Fixed Ask Sourcebot mermaid diagrams overflowing their container by contain-fitting them to both width and height, and made revealing a diagram from the answer jump it into view instantly to avoid over/undershooting. [#1373](https://github.com/sourcebot-dev/sourcebot/pull/1373)
- Verified GitHub review webhook deliveries before processing them. [#1378](https://github.com/sourcebot-dev/sourcebot/pull/1378)
- Passed Zoekt index parameters via argv to preserve revision names with punctuation. [#1376](https://github.com/sourcebot-dev/sourcebot/pull/1376)
- [EE] Validated OAuth bearer token scopes before allowing access to the Sourcebot MCP resource server. [#1396](https://github.com/sourcebot-dev/sourcebot/pull/1396)

## [5.0.4] - 2026-06-18

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
-- AlterTable
ALTER TABLE "OAuthAuthorizationCode" ADD COLUMN "scope" TEXT NOT NULL DEFAULT '';
Comment thread
brendan-kellam marked this conversation as resolved.
1 change: 1 addition & 0 deletions packages/db/prisma/schema.prisma
Original file line numberDiff line numberDiff line change
Expand Up@@ -732,6 +732,7 @@ model OAuthAuthorizationCode {
user User @relation(fields: [userId], references: [id], onDelete: Cascade)
redirectUri String
codeChallenge String // BASE64URL(SHA-256(codeVerifier))
scope String @default("")
resource String? // RFC 8707: canonical URI of the target resource server
dpopJkt String? // RFC 9449: DPoP JWK SHA-256 thumbprint binding
expiresAt DateTime
Expand Down
3 changes: 2 additions & 1 deletion packages/web/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,8 @@
"openapi:generate": "tsx tools/generateOpenApi.ts",
"generate:protos": "proto-loader-gen-types --includeComments --longs=Number --enums=String --defaults --oneofs --grpcLib=@grpc/grpc-js --keepCase --includeDirs=../../vendor/zoekt/grpc/protos --outDir=src/proto zoekt/webserver/v1/webserver.proto zoekt/webserver/v1/query.proto",
"dev:emails": "email dev --dir ./src/emails",
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts"
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts",
"tool:oauth-flow": "tsx tools/oauthFlow.ts"
},
"dependencies": {
"@ai-sdk/amazon-bedrock": "^4.0.94",
Expand Down
1 change: 0 additions & 1 deletion packages/web/src/__mocks__/prisma.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ export const MOCK_ORG: Org = {
updatedAt: new Date(),
isOnboarded: true,
imageUrl: null,
metadata: null,
memberApprovalRequired: false,
isCredentialsLoginEnabled: true,
isEmailCodeLoginEnabled: false,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
import { SUPPORTED_DPOP_SIGNING_ALGS } from '@/ee/features/oauth/dpop';

Expand All@@ -25,6 +25,7 @@ export const GET = oauthApiHandler(async () => {
revocation_endpoint: `${issuer}/api/ee/oauth/revoke`,
response_types_supported: ['code'],
grant_types_supported: ['authorization_code', 'refresh_token'],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
code_challenge_methods_supported: ['S256'],
token_endpoint_auth_methods_supported: ['none'],
dpop_signing_alg_values_supported: SUPPORTED_DPOP_SIGNING_ALGS,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';

// RFC 9728: OAuth 2.0 Protected Resource Metadata (path-specific form)
Expand DownExpand Up@@ -37,6 +37,7 @@ export const GET = oauthApiHandler(async (_request: NextRequest, { params }: { p
authorization_servers: [
issuer
],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
bearer_methods_supported: ['header'],
});
});
36 changes: 26 additions & 10 deletions packages/web/src/app/api/(server)/ee/mcp/route.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ import { sew } from "@/middleware/sew";
import { apiHandler } from '@/lib/apiHandler';
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';

// On 401, tell MCP clients where to find the OAuth protected resource metadata (RFC 9728)
// so they can discover the authorization server and initiate the authorization code flow.
Expand All@@ -20,20 +21,35 @@ import { hasEntitlement } from '@/lib/entitlements';
// @see: https://datatracker.ietf.org/doc/html/rfc9728
async function mcpErrorResponse(error: ServiceError): Promise<Response> {
const response = serviceErrorResponse(error);
if (error.statusCode === StatusCodes.UNAUTHORIZED && await hasEntitlement('oauth')) {
const issuer = env.AUTH_URL.replace(/\/$/, '');
response.headers.append(
'WWW-Authenticate',
`Bearer realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
response.headers.append(
'WWW-Authenticate',
`DPoP realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
if (
(error.statusCode === StatusCodes.UNAUTHORIZED || error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) &&
await hasEntitlement('oauth')
) {
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('Bearer', error));
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('DPoP', error));
}
return response;
}

function mcpOAuthChallenge(scheme: 'Bearer' | 'DPoP', error: ServiceError): string {
const issuer = env.AUTH_URL.replace(/\/$/, '');
const params = [
'realm="Sourcebot"',
`resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`,
];
const scope = SOURCEBOT_OAUTH_SCOPES.join(' ');
if (scope) {
params.push(`scope="${scope}"`);
}

if (error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) {
params.push('error="insufficient_scope"');
params.push(`error_description="${error.message}"`);
}

return `${scheme} ${params.join(', ')}`;
}

// @see: https://modelcontextprotocol.io/specification/2025-11-25/basic/transports#session-management
interface McpSession {
server: McpServer;
Expand Down
9 changes: 4 additions & 5 deletions packages/web/src/app/api/(server)/ee/oauth/token/route.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { verifyAndExchangeCode, verifyAndRotateRefreshToken } from '@/ee/features/oauth/server';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
Expand DownExpand Up@@ -77,8 +76,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand DownExpand Up@@ -110,8 +109,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import { approveAuthorization, denyAuthorization } from '@/ee/features/oauth/actions';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/constants';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/utils';
import { LoadingButton } from '@/components/ui/loading-button';
import { isServiceError } from '@/lib/utils';
import { ClientIcon } from './clientIcon';
Expand All@@ -17,6 +17,7 @@ interface ConsentScreenProps {
clientLogoUri: string | null;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
Expand All@@ -29,6 +30,7 @@ export function ConsentScreen({
clientLogoUri,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
Expand All@@ -45,7 +47,7 @@ export function ConsentScreen({
const onApprove = async () => {
captureEvent('wa_oauth_authorization_approved', { clientId, clientName });
setPending('approve');
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, resource, dpopJkt, state });
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, requestedScope, resource, dpopJkt, state });
if (!isServiceError(result)) {
if (!isPermittedRedirectUrl(result)) {
toast({ description: `❌ Redirect URL is not permitted.` });
Expand Down
10 changes: 9 additions & 1 deletion packages/web/src/app/oauth/authorize/page.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import { ConsentScreen } from './components/consentScreen';
import { __unsafePrisma } from '@/prisma';
import { hasEntitlement } from '@/lib/entitlements';
import { redirect } from 'next/navigation';
import { resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';

export const dynamic = 'force-dynamic';
Expand All@@ -16,6 +17,7 @@ interface AuthorizePageProps {
code_challenge_method?: string;
response_type?: string;
state?: string;
scope?: string;
Comment thread
brendan-kellam marked this conversation as resolved.
resource?: string | string[];
dpop_jkt?: string | string[];
}>;
Expand All@@ -27,7 +29,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
}

const params = await searchParams;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, resource: _resource, dpop_jkt: _dpopJkt } = params;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, scope, resource: _resource, dpop_jkt: _dpopJkt } = params;

// RFC 8707 allows multiple resource parameters to indicate a token intended for multiple resources.
// Sourcebot only supports a single resource (the MCP endpoint), so we take the first value.
Expand All@@ -50,6 +52,11 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
return <ErrorPage message={`Unsupported code_challenge_method: ${code_challenge_method}. Only "S256" is supported.`} />;
}

const grantedScopes = resolveGrantedOAuthScopes(scope);
if ('error' in grantedScopes) {
return <ErrorPage message={grantedScopes.errorDescription} />;
}

if (dpopJkt && !isValidDpopJkt(dpopJkt)) {
return <ErrorPage message="Invalid dpop_jkt parameter." />;
}
Expand DownExpand Up@@ -80,6 +87,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
clientLogoUri={client.logoUri}
redirectUri={redirect_uri!}
codeChallenge={code_challenge!}
requestedScope={scope}
resource={resource ?? null}
dpopJkt={dpopJkt ?? null}
state={state}
Expand Down
16 changes: 15 additions & 1 deletion packages/web/src/ee/features/oauth/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,10 @@ import { sew } from "@/middleware/sew";
import { generateAndStoreAuthCode } from '@/ee/features/oauth/server';
import { withAuth } from '@/middleware/withAuth';
import { UNPERMITTED_SCHEMES } from '@/ee/features/oauth/constants';
import { formatOAuthScopeString, resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';
import { ErrorCode } from '@/lib/errorCodes';
import type { ServiceError } from '@/lib/serviceError';
import { StatusCodes } from 'http-status-codes';

export interface ConnectedOauthClient {
Expand DownExpand Up@@ -40,31 +42,43 @@ export const approveAuthorization = async ({
clientId,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
}: {
clientId: string;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
}) => sew(() =>
withAuth(async ({ user }) => {
const grantedScopes = resolveGrantedOAuthScopes(requestedScope);
if ('error' in grantedScopes) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_REQUEST_BODY,
message: grantedScopes.errorDescription,
} satisfies ServiceError;
}

if (dpopJkt !== null && !isValidDpopJkt(dpopJkt)) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_QUERY_PARAMS,
message: 'Invalid dpop_jkt parameter.',
};
} satisfies ServiceError;
}

const rawCode = await generateAndStoreAuthCode({
clientId,
userId: user.id,
redirectUri,
codeChallenge,
scope: formatOAuthScopeString(grantedScopes.scopes),
resource,
dpopJkt,
});
Expand Down
19 changes: 2 additions & 17 deletions packages/web/src/ee/features/oauth/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,20 +3,5 @@ export const OAUTH_NOT_SUPPORTED_ERROR_MESSAGE = 'OAuth is not supported on this

export const UNPERMITTED_SCHEMES = /^(javascript|data|vbscript):/i;

/**
* Returns true if the URL is permitted for use as a redirect target.
* Allows relative paths starting with /oauth/complete and http(s) URLs.
* Returns false for dangerous schemes like javascript:, data:, vbscript:.
*/
export function isPermittedRedirectUrl(url: string): boolean {
if (url.startsWith('/oauth/complete')) {
return true;
}

try {
const parsed = new URL(url);
return parsed.protocol === 'http:' || parsed.protocol === 'https:';
} catch {
return false;
}
}
export const SOURCEBOT_OAUTH_SCOPES = [] as const;
export type SourcebotOAuthScope = (typeof SOURCEBOT_OAUTH_SCOPES)[number];
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [EE] Fixed Ask Sourcebot mermaid diagrams overflowing their container by contain-fitting them to both width and height, and made revealing a diagram from the answer jump it into view instantly to avoid over/undershooting. [#1373](https://github.com/sourcebot-dev/sourcebot/pull/1373)
- Verified GitHub review webhook deliveries before processing them. [#1378](https://github.com/sourcebot-dev/sourcebot/pull/1378)
- Passed Zoekt index parameters via argv to preserve revision names with punctuation. [#1376](https://github.com/sourcebot-dev/sourcebot/pull/1376)
- [EE] Validated OAuth bearer token scopes before allowing access to the Sourcebot MCP resource server. [#1396](https://github.com/sourcebot-dev/sourcebot/pull/1396)

## [5.0.4] - 2026-06-18

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
-- AlterTable
ALTER TABLE "OAuthAuthorizationCode" ADD COLUMN "scope" TEXT NOT NULL DEFAULT '';
Comment thread
brendan-kellam marked this conversation as resolved.
1 change: 1 addition & 0 deletions packages/db/prisma/schema.prisma
Original file line numberDiff line numberDiff line change
Expand Up@@ -732,6 +732,7 @@ model OAuthAuthorizationCode {
user User @relation(fields: [userId], references: [id], onDelete: Cascade)
redirectUri String
codeChallenge String // BASE64URL(SHA-256(codeVerifier))
scope String @default("")
resource String? // RFC 8707: canonical URI of the target resource server
dpopJkt String? // RFC 9449: DPoP JWK SHA-256 thumbprint binding
expiresAt DateTime
Expand Down
3 changes: 2 additions & 1 deletion packages/web/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,8 @@
"openapi:generate": "tsx tools/generateOpenApi.ts",
"generate:protos": "proto-loader-gen-types --includeComments --longs=Number --enums=String --defaults --oneofs --grpcLib=@grpc/grpc-js --keepCase --includeDirs=../../vendor/zoekt/grpc/protos --outDir=src/proto zoekt/webserver/v1/webserver.proto zoekt/webserver/v1/query.proto",
"dev:emails": "email dev --dir ./src/emails",
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts"
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts",
"tool:oauth-flow": "tsx tools/oauthFlow.ts"
},
"dependencies": {
"@ai-sdk/amazon-bedrock": "^4.0.94",
Expand Down
1 change: 0 additions & 1 deletion packages/web/src/__mocks__/prisma.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ export const MOCK_ORG: Org = {
updatedAt: new Date(),
isOnboarded: true,
imageUrl: null,
metadata: null,
memberApprovalRequired: false,
isCredentialsLoginEnabled: true,
isEmailCodeLoginEnabled: false,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
import { SUPPORTED_DPOP_SIGNING_ALGS } from '@/ee/features/oauth/dpop';

Expand All@@ -25,6 +25,7 @@ export const GET = oauthApiHandler(async () => {
revocation_endpoint: `${issuer}/api/ee/oauth/revoke`,
response_types_supported: ['code'],
grant_types_supported: ['authorization_code', 'refresh_token'],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
code_challenge_methods_supported: ['S256'],
token_endpoint_auth_methods_supported: ['none'],
dpop_signing_alg_values_supported: SUPPORTED_DPOP_SIGNING_ALGS,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';

// RFC 9728: OAuth 2.0 Protected Resource Metadata (path-specific form)
Expand DownExpand Up@@ -37,6 +37,7 @@ export const GET = oauthApiHandler(async (_request: NextRequest, { params }: { p
authorization_servers: [
issuer
],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
bearer_methods_supported: ['header'],
});
});
36 changes: 26 additions & 10 deletions packages/web/src/app/api/(server)/ee/mcp/route.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ import { sew } from "@/middleware/sew";
import { apiHandler } from '@/lib/apiHandler';
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';

// On 401, tell MCP clients where to find the OAuth protected resource metadata (RFC 9728)
// so they can discover the authorization server and initiate the authorization code flow.
Expand All@@ -20,20 +21,35 @@ import { hasEntitlement } from '@/lib/entitlements';
// @see: https://datatracker.ietf.org/doc/html/rfc9728
async function mcpErrorResponse(error: ServiceError): Promise<Response> {
const response = serviceErrorResponse(error);
if (error.statusCode === StatusCodes.UNAUTHORIZED && await hasEntitlement('oauth')) {
const issuer = env.AUTH_URL.replace(/\/$/, '');
response.headers.append(
'WWW-Authenticate',
`Bearer realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
response.headers.append(
'WWW-Authenticate',
`DPoP realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
if (
(error.statusCode === StatusCodes.UNAUTHORIZED || error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) &&
await hasEntitlement('oauth')
) {
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('Bearer', error));
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('DPoP', error));
}
return response;
}

function mcpOAuthChallenge(scheme: 'Bearer' | 'DPoP', error: ServiceError): string {
const issuer = env.AUTH_URL.replace(/\/$/, '');
const params = [
'realm="Sourcebot"',
`resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`,
];
const scope = SOURCEBOT_OAUTH_SCOPES.join(' ');
if (scope) {
params.push(`scope="${scope}"`);
}

if (error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) {
params.push('error="insufficient_scope"');
params.push(`error_description="${error.message}"`);
}

return `${scheme} ${params.join(', ')}`;
}

// @see: https://modelcontextprotocol.io/specification/2025-11-25/basic/transports#session-management
interface McpSession {
server: McpServer;
Expand Down
9 changes: 4 additions & 5 deletions packages/web/src/app/api/(server)/ee/oauth/token/route.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { verifyAndExchangeCode, verifyAndRotateRefreshToken } from '@/ee/features/oauth/server';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
Expand DownExpand Up@@ -77,8 +76,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand DownExpand Up@@ -110,8 +109,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import { approveAuthorization, denyAuthorization } from '@/ee/features/oauth/actions';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/constants';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/utils';
import { LoadingButton } from '@/components/ui/loading-button';
import { isServiceError } from '@/lib/utils';
import { ClientIcon } from './clientIcon';
Expand All@@ -17,6 +17,7 @@ interface ConsentScreenProps {
clientLogoUri: string | null;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
Expand All@@ -29,6 +30,7 @@ export function ConsentScreen({
clientLogoUri,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
Expand All@@ -45,7 +47,7 @@ export function ConsentScreen({
const onApprove = async () => {
captureEvent('wa_oauth_authorization_approved', { clientId, clientName });
setPending('approve');
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, resource, dpopJkt, state });
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, requestedScope, resource, dpopJkt, state });
if (!isServiceError(result)) {
if (!isPermittedRedirectUrl(result)) {
toast({ description: `❌ Redirect URL is not permitted.` });
Expand Down
10 changes: 9 additions & 1 deletion packages/web/src/app/oauth/authorize/page.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import { ConsentScreen } from './components/consentScreen';
import { __unsafePrisma } from '@/prisma';
import { hasEntitlement } from '@/lib/entitlements';
import { redirect } from 'next/navigation';
import { resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';

export const dynamic = 'force-dynamic';
Expand All@@ -16,6 +17,7 @@ interface AuthorizePageProps {
code_challenge_method?: string;
response_type?: string;
state?: string;
scope?: string;
Comment thread
brendan-kellam marked this conversation as resolved.
resource?: string | string[];
dpop_jkt?: string | string[];
}>;
Expand All@@ -27,7 +29,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
}

const params = await searchParams;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, resource: _resource, dpop_jkt: _dpopJkt } = params;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, scope, resource: _resource, dpop_jkt: _dpopJkt } = params;

// RFC 8707 allows multiple resource parameters to indicate a token intended for multiple resources.
// Sourcebot only supports a single resource (the MCP endpoint), so we take the first value.
Expand All@@ -50,6 +52,11 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
return <ErrorPage message={`Unsupported code_challenge_method: ${code_challenge_method}. Only "S256" is supported.`} />;
}

const grantedScopes = resolveGrantedOAuthScopes(scope);
if ('error' in grantedScopes) {
return <ErrorPage message={grantedScopes.errorDescription} />;
}

if (dpopJkt && !isValidDpopJkt(dpopJkt)) {
return <ErrorPage message="Invalid dpop_jkt parameter." />;
}
Expand DownExpand Up@@ -80,6 +87,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
clientLogoUri={client.logoUri}
redirectUri={redirect_uri!}
codeChallenge={code_challenge!}
requestedScope={scope}
resource={resource ?? null}
dpopJkt={dpopJkt ?? null}
state={state}
Expand Down
16 changes: 15 additions & 1 deletion packages/web/src/ee/features/oauth/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,10 @@ import { sew } from "@/middleware/sew";
import { generateAndStoreAuthCode } from '@/ee/features/oauth/server';
import { withAuth } from '@/middleware/withAuth';
import { UNPERMITTED_SCHEMES } from '@/ee/features/oauth/constants';
import { formatOAuthScopeString, resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';
import { ErrorCode } from '@/lib/errorCodes';
import type { ServiceError } from '@/lib/serviceError';
import { StatusCodes } from 'http-status-codes';

export interface ConnectedOauthClient {
Expand DownExpand Up@@ -40,31 +42,43 @@ export const approveAuthorization = async ({
clientId,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
}: {
clientId: string;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
}) => sew(() =>
withAuth(async ({ user }) => {
const grantedScopes = resolveGrantedOAuthScopes(requestedScope);
if ('error' in grantedScopes) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_REQUEST_BODY,
message: grantedScopes.errorDescription,
} satisfies ServiceError;
}

if (dpopJkt !== null && !isValidDpopJkt(dpopJkt)) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_QUERY_PARAMS,
message: 'Invalid dpop_jkt parameter.',
};
} satisfies ServiceError;
}

const rawCode = await generateAndStoreAuthCode({
clientId,
userId: user.id,
redirectUri,
codeChallenge,
scope: formatOAuthScopeString(grantedScopes.scopes),
resource,
dpopJkt,
});
Expand Down
19 changes: 2 additions & 17 deletions packages/web/src/ee/features/oauth/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,20 +3,5 @@ export const OAUTH_NOT_SUPPORTED_ERROR_MESSAGE = 'OAuth is not supported on this

export const UNPERMITTED_SCHEMES = /^(javascript|data|vbscript):/i;

/**
* Returns true if the URL is permitted for use as a redirect target.
* Allows relative paths starting with /oauth/complete and http(s) URLs.
* Returns false for dangerous schemes like javascript:, data:, vbscript:.
*/
export function isPermittedRedirectUrl(url: string): boolean {
if (url.startsWith('/oauth/complete')) {
return true;
}

try {
const parsed = new URL(url);
return parsed.protocol === 'http:' || parsed.protocol === 'https:';
} catch {
return false;
}
}
export const SOURCEBOT_OAUTH_SCOPES = [] as const;
export type SourcebotOAuthScope = (typeof SOURCEBOT_OAUTH_SCOPES)[number];
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [EE] Fixed Ask Sourcebot mermaid diagrams overflowing their container by contain-fitting them to both width and height, and made revealing a diagram from the answer jump it into view instantly to avoid over/undershooting. [#1373](https://github.com/sourcebot-dev/sourcebot/pull/1373)
- Verified GitHub review webhook deliveries before processing them. [#1378](https://github.com/sourcebot-dev/sourcebot/pull/1378)
- Passed Zoekt index parameters via argv to preserve revision names with punctuation. [#1376](https://github.com/sourcebot-dev/sourcebot/pull/1376)
- [EE] Validated OAuth bearer token scopes before allowing access to the Sourcebot MCP resource server. [#1396](https://github.com/sourcebot-dev/sourcebot/pull/1396)

## [5.0.4] - 2026-06-18

Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
-- AlterTable
ALTER TABLE "OAuthAuthorizationCode" ADD COLUMN "scope" TEXT NOT NULL DEFAULT '';
Comment thread
brendan-kellam marked this conversation as resolved.
1 change: 1 addition & 0 deletions packages/db/prisma/schema.prisma
Original file line numberDiff line numberDiff line change
Expand Up@@ -732,6 +732,7 @@ model OAuthAuthorizationCode {
user User @relation(fields: [userId], references: [id], onDelete: Cascade)
redirectUri String
codeChallenge String // BASE64URL(SHA-256(codeVerifier))
scope String @default("")
resource String? // RFC 8707: canonical URI of the target resource server
dpopJkt String? // RFC 9449: DPoP JWK SHA-256 thumbprint binding
expiresAt DateTime
Expand Down
3 changes: 2 additions & 1 deletion packages/web/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,8 @@
"openapi:generate": "tsx tools/generateOpenApi.ts",
"generate:protos": "proto-loader-gen-types --includeComments --longs=Number --enums=String --defaults --oneofs --grpcLib=@grpc/grpc-js --keepCase --includeDirs=../../vendor/zoekt/grpc/protos --outDir=src/proto zoekt/webserver/v1/webserver.proto zoekt/webserver/v1/query.proto",
"dev:emails": "email dev --dir ./src/emails",
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts"
"tool:decrypt-jwe": "tsx tools/decryptJWE.ts",
"tool:oauth-flow": "tsx tools/oauthFlow.ts"
},
"dependencies": {
"@ai-sdk/amazon-bedrock": "^4.0.94",
Expand Down
1 change: 0 additions & 1 deletion packages/web/src/__mocks__/prisma.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ export const MOCK_ORG: Org = {
updatedAt: new Date(),
isOnboarded: true,
imageUrl: null,
metadata: null,
memberApprovalRequired: false,
isCredentialsLoginEnabled: true,
isEmailCodeLoginEnabled: false,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
import { SUPPORTED_DPOP_SIGNING_ALGS } from '@/ee/features/oauth/dpop';

Expand All@@ -25,6 +25,7 @@ export const GET = oauthApiHandler(async () => {
revocation_endpoint: `${issuer}/api/ee/oauth/revoke`,
response_types_supported: ['code'],
grant_types_supported: ['authorization_code', 'refresh_token'],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
code_challenge_methods_supported: ['S256'],
token_endpoint_auth_methods_supported: ['none'],
dpop_signing_alg_values_supported: SUPPORTED_DPOP_SIGNING_ALGS,
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE, SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';

// RFC 9728: OAuth 2.0 Protected Resource Metadata (path-specific form)
Expand DownExpand Up@@ -37,6 +37,7 @@ export const GET = oauthApiHandler(async (_request: NextRequest, { params }: { p
authorization_servers: [
issuer
],
scopes_supported: SOURCEBOT_OAUTH_SCOPES,
bearer_methods_supported: ['header'],
});
});
36 changes: 26 additions & 10 deletions packages/web/src/app/api/(server)/ee/mcp/route.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ import { sew } from "@/middleware/sew";
import { apiHandler } from '@/lib/apiHandler';
import { env } from '@sourcebot/shared';
import { hasEntitlement } from '@/lib/entitlements';
import { SOURCEBOT_OAUTH_SCOPES } from '@/ee/features/oauth/constants';

// On 401, tell MCP clients where to find the OAuth protected resource metadata (RFC 9728)
// so they can discover the authorization server and initiate the authorization code flow.
Expand All@@ -20,20 +21,35 @@ import { hasEntitlement } from '@/lib/entitlements';
// @see: https://datatracker.ietf.org/doc/html/rfc9728
async function mcpErrorResponse(error: ServiceError): Promise<Response> {
const response = serviceErrorResponse(error);
if (error.statusCode === StatusCodes.UNAUTHORIZED && await hasEntitlement('oauth')) {
const issuer = env.AUTH_URL.replace(/\/$/, '');
response.headers.append(
'WWW-Authenticate',
`Bearer realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
response.headers.append(
'WWW-Authenticate',
`DPoP realm="Sourcebot", resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`
);
if (
(error.statusCode === StatusCodes.UNAUTHORIZED || error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) &&
await hasEntitlement('oauth')
) {
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('Bearer', error));
response.headers.append('WWW-Authenticate', mcpOAuthChallenge('DPoP', error));
}
return response;
}

function mcpOAuthChallenge(scheme: 'Bearer' | 'DPoP', error: ServiceError): string {
const issuer = env.AUTH_URL.replace(/\/$/, '');
const params = [
'realm="Sourcebot"',
`resource_metadata_uri="${issuer}/.well-known/oauth-protected-resource/api/mcp"`,
];
const scope = SOURCEBOT_OAUTH_SCOPES.join(' ');
if (scope) {
params.push(`scope="${scope}"`);
}

if (error.errorCode === ErrorCode.OAUTH_INSUFFICIENT_SCOPE) {
params.push('error="insufficient_scope"');
params.push(`error_description="${error.message}"`);
}

return `${scheme} ${params.join(', ')}`;
}

// @see: https://modelcontextprotocol.io/specification/2025-11-25/basic/transports#session-management
interface McpSession {
server: McpServer;
Expand Down
9 changes: 4 additions & 5 deletions packages/web/src/app/api/(server)/ee/oauth/token/route.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { verifyAndExchangeCode, verifyAndRotateRefreshToken } from '@/ee/features/oauth/server';
import { oauthApiHandler } from '@/ee/features/oauth/apiHandler';
import { env } from '@sourcebot/shared';
import { NextRequest } from 'next/server';
import { OAUTH_NOT_SUPPORTED_ERROR_MESSAGE } from '@/ee/features/oauth/constants';
import { hasEntitlement } from '@/lib/entitlements';
Expand DownExpand Up@@ -77,8 +76,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand DownExpand Up@@ -110,8 +109,8 @@ export const POST = oauthApiHandler(async (request: NextRequest) => {
access_token: result.token,
refresh_token: result.refreshToken,
token_type: result.dpopJkt ? DPOP_TOKEN_TYPE : 'Bearer',
expires_in: env.OAUTH_ACCESS_TOKEN_TTL_SECONDS,
scope: '',
expires_in: result.expiresIn,
scope: result.scope,
});
}

Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import { approveAuthorization, denyAuthorization } from '@/ee/features/oauth/actions';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/constants';
import { isPermittedRedirectUrl } from '@/ee/features/oauth/utils';
import { LoadingButton } from '@/components/ui/loading-button';
import { isServiceError } from '@/lib/utils';
import { ClientIcon } from './clientIcon';
Expand All@@ -17,6 +17,7 @@ interface ConsentScreenProps {
clientLogoUri: string | null;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
Expand All@@ -29,6 +30,7 @@ export function ConsentScreen({
clientLogoUri,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
Expand All@@ -45,7 +47,7 @@ export function ConsentScreen({
const onApprove = async () => {
captureEvent('wa_oauth_authorization_approved', { clientId, clientName });
setPending('approve');
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, resource, dpopJkt, state });
const result = await approveAuthorization({ clientId, redirectUri, codeChallenge, requestedScope, resource, dpopJkt, state });
if (!isServiceError(result)) {
if (!isPermittedRedirectUrl(result)) {
toast({ description: `❌ Redirect URL is not permitted.` });
Expand Down
10 changes: 9 additions & 1 deletion packages/web/src/app/oauth/authorize/page.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import { ConsentScreen } from './components/consentScreen';
import { __unsafePrisma } from '@/prisma';
import { hasEntitlement } from '@/lib/entitlements';
import { redirect } from 'next/navigation';
import { resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';

export const dynamic = 'force-dynamic';
Expand All@@ -16,6 +17,7 @@ interface AuthorizePageProps {
code_challenge_method?: string;
response_type?: string;
state?: string;
scope?: string;
Comment thread
brendan-kellam marked this conversation as resolved.
resource?: string | string[];
dpop_jkt?: string | string[];
}>;
Expand All@@ -27,7 +29,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
}

const params = await searchParams;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, resource: _resource, dpop_jkt: _dpopJkt } = params;
const { client_id, redirect_uri, code_challenge, code_challenge_method, response_type, state, scope, resource: _resource, dpop_jkt: _dpopJkt } = params;

// RFC 8707 allows multiple resource parameters to indicate a token intended for multiple resources.
// Sourcebot only supports a single resource (the MCP endpoint), so we take the first value.
Expand All@@ -50,6 +52,11 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
return <ErrorPage message={`Unsupported code_challenge_method: ${code_challenge_method}. Only "S256" is supported.`} />;
}

const grantedScopes = resolveGrantedOAuthScopes(scope);
if ('error' in grantedScopes) {
return <ErrorPage message={grantedScopes.errorDescription} />;
}

if (dpopJkt && !isValidDpopJkt(dpopJkt)) {
return <ErrorPage message="Invalid dpop_jkt parameter." />;
}
Expand DownExpand Up@@ -80,6 +87,7 @@ export default async function AuthorizePage({ searchParams }: AuthorizePageProps
clientLogoUri={client.logoUri}
redirectUri={redirect_uri!}
codeChallenge={code_challenge!}
requestedScope={scope}
resource={resource ?? null}
dpopJkt={dpopJkt ?? null}
state={state}
Expand Down
16 changes: 15 additions & 1 deletion packages/web/src/ee/features/oauth/actions.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,8 +4,10 @@ import { sew } from "@/middleware/sew";
import { generateAndStoreAuthCode } from '@/ee/features/oauth/server';
import { withAuth } from '@/middleware/withAuth';
import { UNPERMITTED_SCHEMES } from '@/ee/features/oauth/constants';
import { formatOAuthScopeString, resolveGrantedOAuthScopes } from '@/ee/features/oauth/utils';
import { isValidDpopJkt } from '@/ee/features/oauth/dpop';
import { ErrorCode } from '@/lib/errorCodes';
import type { ServiceError } from '@/lib/serviceError';
import { StatusCodes } from 'http-status-codes';

export interface ConnectedOauthClient {
Expand DownExpand Up@@ -40,31 +42,43 @@ export const approveAuthorization = async ({
clientId,
redirectUri,
codeChallenge,
requestedScope,
resource,
dpopJkt,
state,
}: {
clientId: string;
redirectUri: string;
codeChallenge: string;
requestedScope: string | undefined;
resource: string | null;
dpopJkt: string | null;
state: string | undefined;
}) => sew(() =>
withAuth(async ({ user }) => {
const grantedScopes = resolveGrantedOAuthScopes(requestedScope);
if ('error' in grantedScopes) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_REQUEST_BODY,
message: grantedScopes.errorDescription,
} satisfies ServiceError;
}

if (dpopJkt !== null && !isValidDpopJkt(dpopJkt)) {
return {
statusCode: StatusCodes.BAD_REQUEST,
errorCode: ErrorCode.INVALID_QUERY_PARAMS,
message: 'Invalid dpop_jkt parameter.',
};
} satisfies ServiceError;
}

const rawCode = await generateAndStoreAuthCode({
clientId,
userId: user.id,
redirectUri,
codeChallenge,
scope: formatOAuthScopeString(grantedScopes.scopes),
resource,
dpopJkt,
});
Expand Down
19 changes: 2 additions & 17 deletions packages/web/src/ee/features/oauth/constants.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,20 +3,5 @@ export const OAUTH_NOT_SUPPORTED_ERROR_MESSAGE = 'OAuth is not supported on this

export const UNPERMITTED_SCHEMES = /^(javascript|data|vbscript):/i;

/**
* Returns true if the URL is permitted for use as a redirect target.
* Allows relative paths starting with /oauth/complete and http(s) URLs.
* Returns false for dangerous schemes like javascript:, data:, vbscript:.
*/
export function isPermittedRedirectUrl(url: string): boolean {
if (url.startsWith('/oauth/complete')) {
return true;
}

try {
const parsed = new URL(url);
return parsed.protocol === 'http:' || parsed.protocol === 'https:';
} catch {
return false;
}
}
export const SOURCEBOT_OAUTH_SCOPES = [] as const;
export type SourcebotOAuthScope = (typeof SOURCEBOT_OAUTH_SCOPES)[number];
Loading
Loading