fix: support MCP JSON Schema dialects

[jsourcebot]

• Compile MCP tool schemas using their declared JSON Schema dialect: draft-07, 2019-09, or 2020-12.
• Default schemas without $schema to 2020-12, as required by the MCP specification.
• Register each server’s tools atomically so a schema failure cannot leave that server partially loaded.

---

Note

Medium Risk
Changes runtime MCP tool schema compilation and which tools load in Ask EE; behavior shifts for connectors that relied on the old draft-07-only path or forced additionalProperties, though failures are isolated per server.

Overview
Fixes Ask MCP connectors failing to load when tool inputSchema declares JSON Schema 2019-09 or 2020-12 (MCP’s default when $schema is omitted).

Validation no longer uses a single draft-07 Ajv instance or forces additionalProperties: false on every tool. Schemas are compiled with the matching Ajv dialect (draft-07, 2019-09, 2020-12), with guards for unsupported dialects, $async, and shared $id collisions (addUsedSchema: false).

Tool loading is per-server atomic: if any tool schema is unsupported or fails to compile, that server is marked failed and no partial tools from that server are exposed. Error logging avoids echoing sensitive schema URIs or tokens.

^{Reviewed by Cursor Bugbot for commit 434fb04. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• New Features

  • Added JSON Schema validation support for drafts 07, 2019-09, and 2020-12, with automatic draft selection and 2020-12 as the default.
  • Added clearer validation errors, including parameter-name hints.
  • Added support for schema composition keywords and local references.

• Bug Fixes

  • Unsupported, malformed, or asynchronous schemas are now rejected safely.
  • Failed MCP servers no longer expose partially created tools.
  • Sensitive schema URLs, tokens, and remote references are excluded from logs.

[coderabbitai]

Walkthrough

The change adds shared MCP JSON Schema validation for three dialects, preserves schema declarations in tool validation, formats validation errors, and stages per-server tools before atomic registration.

Changes

MCP schema validation and tool assembly

Layer / File(s)	Summary
Dialect-aware schema compilation packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.ts, packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.test.ts	Adds draft-07, 2019-09, and 2020-12 support, defaults to 2020-12, rejects unsupported dialects and asynchronous schemas, and formats validation errors.
MCP tool validation and staged registration packages/web/src/ee/features/chat/mcp/mcpToolSets.ts, packages/web/src/ee/features/chat/mcp/mcpToolSets.test.ts, CHANGELOG.md	Uses the shared compiler for tool schemas, adds parameter-name hints to errors, commits server tools only after all schemas succeed, and documents the fix. Tests cover dialects, composition keywords, malformed schemas, isolation, and log sanitization.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant MCPServer
participant mcpToolSets
participant compileMcpJsonSchemaValidator
participant ToolRegistry
MCPServer->>mcpToolSets: provide tool schemas
mcpToolSets->>compileMcpJsonSchemaValidator: compile each schema
compileMcpJsonSchemaValidator-->>mcpToolSets: return validator or schema error
mcpToolSets->>ToolRegistry: merge tools after server processing succeeds

Loading

Possibly related PRs

• sourcebot-dev/sourcebot#1423: Modifies shared MCP tool-set handling for tool-name sanitization and display-name mapping.

Suggested reviewers:brendan-kellam

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: support for MCP JSON Schema dialects.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jack/linear-mcp-diagnostics-SOU-1832

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[jsourcebot]

• Compile MCP tool schemas using their declared JSON Schema dialect: draft-07, 2019-09, or 2020-12.
• Default schemas without $schema to 2020-12, as required by the MCP specification.
• Register each server’s tools atomically so a schema failure cannot leave that server partially loaded.

---

Note

Medium Risk
Changes runtime MCP tool schema compilation and which tools load in Ask EE; behavior shifts for connectors that relied on the old draft-07-only path or forced additionalProperties, though failures are isolated per server.

Overview
Fixes Ask MCP connectors failing to load when tool inputSchema declares JSON Schema 2019-09 or 2020-12 (MCP’s default when $schema is omitted).

Validation no longer uses a single draft-07 Ajv instance or forces additionalProperties: false on every tool. Schemas are compiled with the matching Ajv dialect (draft-07, 2019-09, 2020-12), with guards for unsupported dialects, $async, and shared $id collisions (addUsedSchema: false).

Tool loading is per-server atomic: if any tool schema is unsupported or fails to compile, that server is marked failed and no partial tools from that server are exposed. Error logging avoids echoing sensitive schema URIs or tokens.

^{Reviewed by Cursor Bugbot for commit 434fb04. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• New Features

  • Added JSON Schema validation support for drafts 07, 2019-09, and 2020-12, with automatic draft selection and 2020-12 as the default.
  • Added clearer validation errors, including parameter-name hints.
  • Added support for schema composition keywords and local references.

• Bug Fixes

  • Unsupported, malformed, or asynchronous schemas are now rejected safely.
  • Failed MCP servers no longer expose partially created tools.
  • Sensitive schema URLs, tokens, and remote references are excluded from logs.

[coderabbitai]

Walkthrough

The change adds shared MCP JSON Schema validation for three dialects, preserves schema declarations in tool validation, formats validation errors, and stages per-server tools before atomic registration.

Changes

MCP schema validation and tool assembly

Layer / File(s)	Summary
Dialect-aware schema compilation packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.ts, packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.test.ts	Adds draft-07, 2019-09, and 2020-12 support, defaults to 2020-12, rejects unsupported dialects and asynchronous schemas, and formats validation errors.
MCP tool validation and staged registration packages/web/src/ee/features/chat/mcp/mcpToolSets.ts, packages/web/src/ee/features/chat/mcp/mcpToolSets.test.ts, CHANGELOG.md	Uses the shared compiler for tool schemas, adds parameter-name hints to errors, commits server tools only after all schemas succeed, and documents the fix. Tests cover dialects, composition keywords, malformed schemas, isolation, and log sanitization.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant MCPServer
participant mcpToolSets
participant compileMcpJsonSchemaValidator
participant ToolRegistry
MCPServer->>mcpToolSets: provide tool schemas
mcpToolSets->>compileMcpJsonSchemaValidator: compile each schema
compileMcpJsonSchemaValidator-->>mcpToolSets: return validator or schema error
mcpToolSets->>ToolRegistry: merge tools after server processing succeeds

Loading

Possibly related PRs

• sourcebot-dev/sourcebot#1423: Modifies shared MCP tool-set handling for tool-name sanitization and display-name mapping.

Suggested reviewers:brendan-kellam

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: support for MCP JSON Schema dialects.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jack/linear-mcp-diagnostics-SOU-1832

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[jsourcebot]

• Compile MCP tool schemas using their declared JSON Schema dialect: draft-07, 2019-09, or 2020-12.
• Default schemas without $schema to 2020-12, as required by the MCP specification.
• Register each server’s tools atomically so a schema failure cannot leave that server partially loaded.

---

Note

Medium Risk
Changes runtime MCP tool schema compilation and which tools load in Ask EE; behavior shifts for connectors that relied on the old draft-07-only path or forced additionalProperties, though failures are isolated per server.

Overview
Fixes Ask MCP connectors failing to load when tool inputSchema declares JSON Schema 2019-09 or 2020-12 (MCP’s default when $schema is omitted).

Validation no longer uses a single draft-07 Ajv instance or forces additionalProperties: false on every tool. Schemas are compiled with the matching Ajv dialect (draft-07, 2019-09, 2020-12), with guards for unsupported dialects, $async, and shared $id collisions (addUsedSchema: false).

Tool loading is per-server atomic: if any tool schema is unsupported or fails to compile, that server is marked failed and no partial tools from that server are exposed. Error logging avoids echoing sensitive schema URIs or tokens.

^{Reviewed by Cursor Bugbot for commit 434fb04. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• New Features

  • Added JSON Schema validation support for drafts 07, 2019-09, and 2020-12, with automatic draft selection and 2020-12 as the default.
  • Added clearer validation errors, including parameter-name hints.
  • Added support for schema composition keywords and local references.

• Bug Fixes

  • Unsupported, malformed, or asynchronous schemas are now rejected safely.
  • Failed MCP servers no longer expose partially created tools.
  • Sensitive schema URLs, tokens, and remote references are excluded from logs.

[coderabbitai]

Walkthrough

The change adds shared MCP JSON Schema validation for three dialects, preserves schema declarations in tool validation, formats validation errors, and stages per-server tools before atomic registration.

Changes

MCP schema validation and tool assembly

Layer / File(s)	Summary
Dialect-aware schema compilation packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.ts, packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.test.ts	Adds draft-07, 2019-09, and 2020-12 support, defaults to 2020-12, rejects unsupported dialects and asynchronous schemas, and formats validation errors.
MCP tool validation and staged registration packages/web/src/ee/features/chat/mcp/mcpToolSets.ts, packages/web/src/ee/features/chat/mcp/mcpToolSets.test.ts, CHANGELOG.md	Uses the shared compiler for tool schemas, adds parameter-name hints to errors, commits server tools only after all schemas succeed, and documents the fix. Tests cover dialects, composition keywords, malformed schemas, isolation, and log sanitization.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant MCPServer
participant mcpToolSets
participant compileMcpJsonSchemaValidator
participant ToolRegistry
MCPServer->>mcpToolSets: provide tool schemas
mcpToolSets->>compileMcpJsonSchemaValidator: compile each schema
compileMcpJsonSchemaValidator-->>mcpToolSets: return validator or schema error
mcpToolSets->>ToolRegistry: merge tools after server processing succeeds

Loading

Possibly related PRs

• sourcebot-dev/sourcebot#1423: Modifies shared MCP tool-set handling for tool-name sanitization and display-name mapping.

Suggested reviewers:brendan-kellam

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: support for MCP JSON Schema dialects.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jack/linear-mcp-diagnostics-SOU-1832

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[jsourcebot]

• Compile MCP tool schemas using their declared JSON Schema dialect: draft-07, 2019-09, or 2020-12.
• Default schemas without $schema to 2020-12, as required by the MCP specification.
• Register each server’s tools atomically so a schema failure cannot leave that server partially loaded.

---

Note

Medium Risk
Changes runtime MCP tool schema compilation and which tools load in Ask EE; behavior shifts for connectors that relied on the old draft-07-only path or forced additionalProperties, though failures are isolated per server.

Overview
Fixes Ask MCP connectors failing to load when tool inputSchema declares JSON Schema 2019-09 or 2020-12 (MCP’s default when $schema is omitted).

Validation no longer uses a single draft-07 Ajv instance or forces additionalProperties: false on every tool. Schemas are compiled with the matching Ajv dialect (draft-07, 2019-09, 2020-12), with guards for unsupported dialects, $async, and shared $id collisions (addUsedSchema: false).

Tool loading is per-server atomic: if any tool schema is unsupported or fails to compile, that server is marked failed and no partial tools from that server are exposed. Error logging avoids echoing sensitive schema URIs or tokens.

^{Reviewed by Cursor Bugbot for commit 434fb04. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• New Features

  • Added JSON Schema validation support for drafts 07, 2019-09, and 2020-12, with automatic draft selection and 2020-12 as the default.
  • Added clearer validation errors, including parameter-name hints.
  • Added support for schema composition keywords and local references.

• Bug Fixes

  • Unsupported, malformed, or asynchronous schemas are now rejected safely.
  • Failed MCP servers no longer expose partially created tools.
  • Sensitive schema URLs, tokens, and remote references are excluded from logs.

[coderabbitai]

Walkthrough

The change adds shared MCP JSON Schema validation for three dialects, preserves schema declarations in tool validation, formats validation errors, and stages per-server tools before atomic registration.

Changes

MCP schema validation and tool assembly

Layer / File(s)	Summary
Dialect-aware schema compilation packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.ts, packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.test.ts	Adds draft-07, 2019-09, and 2020-12 support, defaults to 2020-12, rejects unsupported dialects and asynchronous schemas, and formats validation errors.
MCP tool validation and staged registration packages/web/src/ee/features/chat/mcp/mcpToolSets.ts, packages/web/src/ee/features/chat/mcp/mcpToolSets.test.ts, CHANGELOG.md	Uses the shared compiler for tool schemas, adds parameter-name hints to errors, commits server tools only after all schemas succeed, and documents the fix. Tests cover dialects, composition keywords, malformed schemas, isolation, and log sanitization.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant MCPServer
participant mcpToolSets
participant compileMcpJsonSchemaValidator
participant ToolRegistry
MCPServer->>mcpToolSets: provide tool schemas
mcpToolSets->>compileMcpJsonSchemaValidator: compile each schema
compileMcpJsonSchemaValidator-->>mcpToolSets: return validator or schema error
mcpToolSets->>ToolRegistry: merge tools after server processing succeeds

Loading

Possibly related PRs

• sourcebot-dev/sourcebot#1423: Modifies shared MCP tool-set handling for tool-name sanitization and display-name mapping.

Suggested reviewers:brendan-kellam

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: support for MCP JSON Schema dialects.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jack/linear-mcp-diagnostics-SOU-1832

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[jsourcebot]

• Compile MCP tool schemas using their declared JSON Schema dialect: draft-07, 2019-09, or 2020-12.
• Default schemas without $schema to 2020-12, as required by the MCP specification.
• Register each server’s tools atomically so a schema failure cannot leave that server partially loaded.

---

Note

Medium Risk
Changes runtime MCP tool schema compilation and which tools load in Ask EE; behavior shifts for connectors that relied on the old draft-07-only path or forced additionalProperties, though failures are isolated per server.

Overview
Fixes Ask MCP connectors failing to load when tool inputSchema declares JSON Schema 2019-09 or 2020-12 (MCP’s default when $schema is omitted).

Validation no longer uses a single draft-07 Ajv instance or forces additionalProperties: false on every tool. Schemas are compiled with the matching Ajv dialect (draft-07, 2019-09, 2020-12), with guards for unsupported dialects, $async, and shared $id collisions (addUsedSchema: false).

Tool loading is per-server atomic: if any tool schema is unsupported or fails to compile, that server is marked failed and no partial tools from that server are exposed. Error logging avoids echoing sensitive schema URIs or tokens.

^{Reviewed by Cursor Bugbot for commit 434fb04. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• New Features

  • Added JSON Schema validation support for drafts 07, 2019-09, and 2020-12, with automatic draft selection and 2020-12 as the default.
  • Added clearer validation errors, including parameter-name hints.
  • Added support for schema composition keywords and local references.

• Bug Fixes

  • Unsupported, malformed, or asynchronous schemas are now rejected safely.
  • Failed MCP servers no longer expose partially created tools.
  • Sensitive schema URLs, tokens, and remote references are excluded from logs.

[coderabbitai]

Walkthrough

The change adds shared MCP JSON Schema validation for three dialects, preserves schema declarations in tool validation, formats validation errors, and stages per-server tools before atomic registration.

Changes

MCP schema validation and tool assembly

Layer / File(s)	Summary
Dialect-aware schema compilation packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.ts, packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.test.ts	Adds draft-07, 2019-09, and 2020-12 support, defaults to 2020-12, rejects unsupported dialects and asynchronous schemas, and formats validation errors.
MCP tool validation and staged registration packages/web/src/ee/features/chat/mcp/mcpToolSets.ts, packages/web/src/ee/features/chat/mcp/mcpToolSets.test.ts, CHANGELOG.md	Uses the shared compiler for tool schemas, adds parameter-name hints to errors, commits server tools only after all schemas succeed, and documents the fix. Tests cover dialects, composition keywords, malformed schemas, isolation, and log sanitization.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant MCPServer
participant mcpToolSets
participant compileMcpJsonSchemaValidator
participant ToolRegistry
MCPServer->>mcpToolSets: provide tool schemas
mcpToolSets->>compileMcpJsonSchemaValidator: compile each schema
compileMcpJsonSchemaValidator-->>mcpToolSets: return validator or schema error
mcpToolSets->>ToolRegistry: merge tools after server processing succeeds

Loading

Possibly related PRs

• sourcebot-dev/sourcebot#1423: Modifies shared MCP tool-set handling for tool-name sanitization and display-name mapping.

Suggested reviewers:brendan-kellam

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: support for MCP JSON Schema dialects.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jack/linear-mcp-diagnostics-SOU-1832

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[jsourcebot]

• Compile MCP tool schemas using their declared JSON Schema dialect: draft-07, 2019-09, or 2020-12.
• Default schemas without $schema to 2020-12, as required by the MCP specification.
• Register each server’s tools atomically so a schema failure cannot leave that server partially loaded.

---

Note

Medium Risk
Changes runtime MCP tool schema compilation and which tools load in Ask EE; behavior shifts for connectors that relied on the old draft-07-only path or forced additionalProperties, though failures are isolated per server.

Overview
Fixes Ask MCP connectors failing to load when tool inputSchema declares JSON Schema 2019-09 or 2020-12 (MCP’s default when $schema is omitted).

Validation no longer uses a single draft-07 Ajv instance or forces additionalProperties: false on every tool. Schemas are compiled with the matching Ajv dialect (draft-07, 2019-09, 2020-12), with guards for unsupported dialects, $async, and shared $id collisions (addUsedSchema: false).

Tool loading is per-server atomic: if any tool schema is unsupported or fails to compile, that server is marked failed and no partial tools from that server are exposed. Error logging avoids echoing sensitive schema URIs or tokens.

^{Reviewed by Cursor Bugbot for commit 434fb04. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• New Features

  • Added JSON Schema validation support for drafts 07, 2019-09, and 2020-12, with automatic draft selection and 2020-12 as the default.
  • Added clearer validation errors, including parameter-name hints.
  • Added support for schema composition keywords and local references.

• Bug Fixes

  • Unsupported, malformed, or asynchronous schemas are now rejected safely.
  • Failed MCP servers no longer expose partially created tools.
  • Sensitive schema URLs, tokens, and remote references are excluded from logs.

[coderabbitai]

Walkthrough

The change adds shared MCP JSON Schema validation for three dialects, preserves schema declarations in tool validation, formats validation errors, and stages per-server tools before atomic registration.

Changes

MCP schema validation and tool assembly

Layer / File(s)	Summary
Dialect-aware schema compilation packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.ts, packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.test.ts	Adds draft-07, 2019-09, and 2020-12 support, defaults to 2020-12, rejects unsupported dialects and asynchronous schemas, and formats validation errors.
MCP tool validation and staged registration packages/web/src/ee/features/chat/mcp/mcpToolSets.ts, packages/web/src/ee/features/chat/mcp/mcpToolSets.test.ts, CHANGELOG.md	Uses the shared compiler for tool schemas, adds parameter-name hints to errors, commits server tools only after all schemas succeed, and documents the fix. Tests cover dialects, composition keywords, malformed schemas, isolation, and log sanitization.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant MCPServer
participant mcpToolSets
participant compileMcpJsonSchemaValidator
participant ToolRegistry
MCPServer->>mcpToolSets: provide tool schemas
mcpToolSets->>compileMcpJsonSchemaValidator: compile each schema
compileMcpJsonSchemaValidator-->>mcpToolSets: return validator or schema error
mcpToolSets->>ToolRegistry: merge tools after server processing succeeds

Loading

Possibly related PRs

• sourcebot-dev/sourcebot#1423: Modifies shared MCP tool-set handling for tool-name sanitization and display-name mapping.

Suggested reviewers:brendan-kellam

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: support for MCP JSON Schema dialects.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jack/linear-mcp-diagnostics-SOU-1832

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[jsourcebot]

• Compile MCP tool schemas using their declared JSON Schema dialect: draft-07, 2019-09, or 2020-12.
• Default schemas without $schema to 2020-12, as required by the MCP specification.
• Register each server’s tools atomically so a schema failure cannot leave that server partially loaded.

---

Note

Medium Risk
Changes runtime MCP tool schema compilation and which tools load in Ask EE; behavior shifts for connectors that relied on the old draft-07-only path or forced additionalProperties, though failures are isolated per server.

Overview
Fixes Ask MCP connectors failing to load when tool inputSchema declares JSON Schema 2019-09 or 2020-12 (MCP’s default when $schema is omitted).

Validation no longer uses a single draft-07 Ajv instance or forces additionalProperties: false on every tool. Schemas are compiled with the matching Ajv dialect (draft-07, 2019-09, 2020-12), with guards for unsupported dialects, $async, and shared $id collisions (addUsedSchema: false).

Tool loading is per-server atomic: if any tool schema is unsupported or fails to compile, that server is marked failed and no partial tools from that server are exposed. Error logging avoids echoing sensitive schema URIs or tokens.

^{Reviewed by Cursor Bugbot for commit 434fb04. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• New Features

  • Added JSON Schema validation support for drafts 07, 2019-09, and 2020-12, with automatic draft selection and 2020-12 as the default.
  • Added clearer validation errors, including parameter-name hints.
  • Added support for schema composition keywords and local references.

• Bug Fixes

  • Unsupported, malformed, or asynchronous schemas are now rejected safely.
  • Failed MCP servers no longer expose partially created tools.
  • Sensitive schema URLs, tokens, and remote references are excluded from logs.

[coderabbitai]

Walkthrough

The change adds shared MCP JSON Schema validation for three dialects, preserves schema declarations in tool validation, formats validation errors, and stages per-server tools before atomic registration.

Changes

MCP schema validation and tool assembly

Layer / File(s)	Summary
Dialect-aware schema compilation packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.ts, packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.test.ts	Adds draft-07, 2019-09, and 2020-12 support, defaults to 2020-12, rejects unsupported dialects and asynchronous schemas, and formats validation errors.
MCP tool validation and staged registration packages/web/src/ee/features/chat/mcp/mcpToolSets.ts, packages/web/src/ee/features/chat/mcp/mcpToolSets.test.ts, CHANGELOG.md	Uses the shared compiler for tool schemas, adds parameter-name hints to errors, commits server tools only after all schemas succeed, and documents the fix. Tests cover dialects, composition keywords, malformed schemas, isolation, and log sanitization.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant MCPServer
participant mcpToolSets
participant compileMcpJsonSchemaValidator
participant ToolRegistry
MCPServer->>mcpToolSets: provide tool schemas
mcpToolSets->>compileMcpJsonSchemaValidator: compile each schema
compileMcpJsonSchemaValidator-->>mcpToolSets: return validator or schema error
mcpToolSets->>ToolRegistry: merge tools after server processing succeeds

Loading

Possibly related PRs

• sourcebot-dev/sourcebot#1423: Modifies shared MCP tool-set handling for tool-name sanitization and display-name mapping.

Suggested reviewers:brendan-kellam

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: support for MCP JSON Schema dialects.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jack/linear-mcp-diagnostics-SOU-1832

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[jsourcebot]

• Compile MCP tool schemas using their declared JSON Schema dialect: draft-07, 2019-09, or 2020-12.
• Default schemas without $schema to 2020-12, as required by the MCP specification.
• Register each server’s tools atomically so a schema failure cannot leave that server partially loaded.

---

Note

Medium Risk
Changes runtime MCP tool schema compilation and which tools load in Ask EE; behavior shifts for connectors that relied on the old draft-07-only path or forced additionalProperties, though failures are isolated per server.

Overview
Fixes Ask MCP connectors failing to load when tool inputSchema declares JSON Schema 2019-09 or 2020-12 (MCP’s default when $schema is omitted).

Validation no longer uses a single draft-07 Ajv instance or forces additionalProperties: false on every tool. Schemas are compiled with the matching Ajv dialect (draft-07, 2019-09, 2020-12), with guards for unsupported dialects, $async, and shared $id collisions (addUsedSchema: false).

Tool loading is per-server atomic: if any tool schema is unsupported or fails to compile, that server is marked failed and no partial tools from that server are exposed. Error logging avoids echoing sensitive schema URIs or tokens.

^{Reviewed by Cursor Bugbot for commit 434fb04. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• New Features

  • Added JSON Schema validation support for drafts 07, 2019-09, and 2020-12, with automatic draft selection and 2020-12 as the default.
  • Added clearer validation errors, including parameter-name hints.
  • Added support for schema composition keywords and local references.

• Bug Fixes

  • Unsupported, malformed, or asynchronous schemas are now rejected safely.
  • Failed MCP servers no longer expose partially created tools.
  • Sensitive schema URLs, tokens, and remote references are excluded from logs.

[coderabbitai]

Walkthrough

The change adds shared MCP JSON Schema validation for three dialects, preserves schema declarations in tool validation, formats validation errors, and stages per-server tools before atomic registration.

Changes

MCP schema validation and tool assembly

Layer / File(s)	Summary
Dialect-aware schema compilation packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.ts, packages/web/src/ee/features/chat/mcp/mcpJsonSchemaValidator.test.ts	Adds draft-07, 2019-09, and 2020-12 support, defaults to 2020-12, rejects unsupported dialects and asynchronous schemas, and formats validation errors.
MCP tool validation and staged registration packages/web/src/ee/features/chat/mcp/mcpToolSets.ts, packages/web/src/ee/features/chat/mcp/mcpToolSets.test.ts, CHANGELOG.md	Uses the shared compiler for tool schemas, adds parameter-name hints to errors, commits server tools only after all schemas succeed, and documents the fix. Tests cover dialects, composition keywords, malformed schemas, isolation, and log sanitization.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
participant MCPServer
participant mcpToolSets
participant compileMcpJsonSchemaValidator
participant ToolRegistry
MCPServer->>mcpToolSets: provide tool schemas
mcpToolSets->>compileMcpJsonSchemaValidator: compile each schema
compileMcpJsonSchemaValidator-->>mcpToolSets: return validator or schema error
mcpToolSets->>ToolRegistry: merge tools after server processing succeeds

Loading

Possibly related PRs

• sourcebot-dev/sourcebot#1423: Modifies shared MCP tool-set handling for tool-name sanitization and display-name mapping.

Suggested reviewers:brendan-kellam

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: support for MCP JSON Schema dialects.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jack/linear-mcp-diagnostics-SOU-1832

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.