Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 44 additions & 14 deletions packages/web/src/app/(app)/components/editorContextMenu.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import { useToast } from "@/components/hooks/use-toast";
import { Button } from "@/components/ui/button";
import { useCreateNewChatThread } from "@/features/chat/useCreateNewChatThread";
import useCaptureEvent from "@/hooks/useCaptureEvent";
import { createPathWithQueryParams } from "@/lib/utils";
import { autoPlacement, computePosition, offset, shift, VirtualElement } from "@floating-ui/react";
Expand All@@ -28,6 +29,7 @@ export const EditorContextMenu = ({
const ref = useRef<HTMLDivElement>(null);
const { toast } = useToast();
const captureEvent = useCaptureEvent();
const { createChatFromSource } = useCreateNewChatThread();
useEffect(() => {
if (selection.empty) {
ref.current?.classList.add('hidden');
Expand DownExpand Up@@ -126,19 +128,47 @@ export const EditorContextMenu = ({
)
}, [selection.from, selection.to, repoName, revisionName, path, toast, captureEvent, view]);

const onAskSourcebot = useCallback(() => {
if (selection.empty) {
return;
}

const startLine = view.state.doc.lineAt(selection.from).number;
const endLine = view.state.doc.lineAt(selection.to - 1).number;

void createChatFromSource({
type: 'file',
repo: repoName,
path,
name: path.split('/').pop() ?? path,
revision: revisionName,
range: { startLine, endLine },
});
}, [createChatFromSource, path, repoName, revisionName, selection, view]);

return (
<div
ref={ref}
className="absolute z-10 flex flex-col gap-2 bg-background border border-gray-300 dark:border-gray-700 rounded-md shadow-lg p-2"
>
<Button
variant="ghost"
size="sm"
onClick={onCopyLinkToSelection}
>
<Link2Icon className="h-4 w-4 mr-1" />
Share selection
</Button>
</div>
<div
ref={ref}
className="absolute z-10 flex items-center gap-1 rounded-lg border border-border bg-popover p-1 shadow-xl"
>
<Button
variant="secondary"
size="sm"
onClick={onCopyLinkToSelection}
className="h-8 px-3 hover:bg-black/50"
>
<Link2Icon className="mr-2 h-4 w-4" />
Share selection
</Button>

<Button
variant="secondary"
size="sm"
onClick={onAskSourcebot}
className="h-8 px-3 hover:bg-black/50"
>
Ask SourceBot
</Button>
Comment thread
cursor[bot] marked this conversation as resolved.
</div>
)
}
}
29 changes: 28 additions & 1 deletion packages/web/src/ee/features/chat/agent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ vi.mock('ai', async (importOriginal) => {
};
});

const { createMessageStream } = await import('./agent');
const { createMessageStream, sliceFileSourceForPrompt } = await import('./agent');
const { getPromptCacheStrategy } = await import('./promptCaching');

// Strategies reused across the prompt-caching tests below.
Expand All@@ -135,6 +135,33 @@ const listReposInput = {
direction: 'asc',
} as const;

describe('sliceFileSourceForPrompt', () => {
test('slices an inclusive range and preserves its original line offset', () => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree\nfour', {
startLine: 2,
endLine: 3,
})).toEqual({
source: 'two\nthree',
lineOffset: 2,
});
});

test('keeps the full file when there is no selected range', () => {
expect(sliceFileSourceForPrompt('one\ntwo', undefined)).toEqual({
source: 'one\ntwo',
lineOffset: 1,
});
});

test.each([
{ startLine: 0, endLine: 1 },
{ startLine: 3, endLine: 2 },
{ startLine: 1, endLine: 4 },
])('ignores invalid ranges safely', (range) => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree', range)).toBeUndefined();
});
});

const dynamicApprovalRespondedPart = {
type: 'dynamic-tool',
toolName: 'mcp_linear__save_issue',
Expand Down
41 changes: 37 additions & 4 deletions packages/web/src/ee/features/chat/agent.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ import {
import { randomUUID } from "crypto";
import _dedent from "dedent";
import { ANSWER_TAG, FILE_REFERENCE_PREFIX } from "@/features/chat/constants";
import { Source } from "@/features/chat/types";
import { FileSource, Source } from "@/features/chat/types";
import { addLineNumbers, fileReferenceToString, formatAttachmentsForPrompt, getAnswerPartFromAssistantMessage, getTurnProgressState, getUserMessageAttachments, getUserMessageText } from "@/features/chat/utils";
import { createTools } from "./tools";
import { getConnectedMcpClients } from "@/ee/features/chat/mcp/mcpClientFactory";
Expand DownExpand Up@@ -551,6 +551,29 @@ interface AgentOptions {
orgId?: number;
}

export const sliceFileSourceForPrompt = (
source: string,
range: FileSource['range'],
): { source: string; lineOffset: number } | undefined => {
if (!range) {
return { source, lineOffset: 1 };
}

const lines = source.split('\n');
if (
range.startLine < 1 ||
range.endLine < range.startLine ||
range.endLine > lines.length
) {
return undefined;
}

return {
source: lines.slice(range.startLine - 1, range.endLine).join('\n'),
lineOffset: range.startLine,
};
};

const createAgentStream = async ({
model,
promptCacheStrategy,
Expand DownExpand Up@@ -591,12 +614,20 @@ const createAgentStream = async ({
return undefined;
}

const selectedSource = sliceFileSourceForPrompt(fileSource.source, source.range);
if (!selectedSource) {
logger.warn(`Ignoring invalid selected range for ${source.repo}:${source.path}`);
return undefined;
}

return {
path: fileSource.path,
source: fileSource.source,
source: selectedSource.source,
repo: fileSource.repo,
language: fileSource.language,
revision: source.revision,
lineOffset: selectedSource.lineOffset,
range: source.range,
};
}))
).filter((source) => source !== undefined);
Expand DownExpand Up@@ -898,6 +929,8 @@ const createPrompt = ({
repo: string;
language: string;
revision: string;
range?: FileSource['range'];
lineOffset: number;
}[],
repos: string[],
mcpToolRegistry: McpToolRegistryEntry[],
Expand DownExpand Up@@ -999,8 +1032,8 @@ const createPrompt = ({
<files>
The user has mentioned the following files, which are automatically included for analysis.

${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}">
${addLineNumbers(file.source)}
${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}"${file.range ? ` selected_lines="${file.range.startLine}-${file.range.endLine}"` : ''}>
${addLineNumbers(file.source, file.lineOffset)}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</file>`).join('\n\n')}
</files>
`);
Expand Down
114 changes: 114 additions & 0 deletions packages/web/src/features/chat/useCreateNewChatThread.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
import { act, renderHook } from "@testing-library/react";
import { afterEach, expect, test, vi } from "vitest";
import type { Source } from "./types";
import { DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY } from "./constants";

const mocks = vi.hoisted(() => ({
createChat: vi.fn(),
createUIMessage: vi.fn(),
push: vi.fn(),
setChatState: vi.fn(),
toast: vi.fn(),
}));

vi.mock("next/navigation", () => ({
useRouter: () => ({ push: mocks.push }),
}));

vi.mock("@/components/hooks/use-toast", () => ({
useToast: () => ({ toast: mocks.toast }),
}));

vi.mock("./actions", () => ({
createChat: mocks.createChat,
}));

vi.mock("@/lib/utils", () => ({
isServiceError: () => false,
createPathWithQueryParams: (path: string) => path,
}));

vi.mock("./utils", () => ({
createUIMessage: mocks.createUIMessage,
getAllMentionElements: () => [],
slateContentToString: () => "",
}));

vi.mock("usehooks-ts", () => ({
useSessionStorage: () => [null, mocks.setChatState],
}));

const { useCreateNewChatThread } = await import("./useCreateNewChatThread");

afterEach(() => {
window.localStorage.clear();
vi.clearAllMocks();
});

test("createChatFromSource preserves disabled MCP servers from local storage", async () => {
const disabledMcpServerIds = ["linear", "github"];
window.localStorage.setItem(
DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY,
JSON.stringify(disabledMcpServerIds),
);
mocks.createChat.mockResolvedValue({ id: "chat-1" });
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

await act(async () => {
await result.current.createChatFromSource(source);
});

expect(mocks.createUIMessage).toHaveBeenCalledWith(
"Explain this selected code.",
[],
[],
disabledMcpServerIds,
[],
[source],
);
expect(mocks.setChatState).toHaveBeenCalledWith({
inputMessage: { id: "initial-message" },
selectedSearchScopes: [],
disabledMcpServerIds,
});
});

test("createChatFromSource ignores duplicate calls while chat creation is pending", async () => {
let resolveCreateChat: ((value: { id: string }) => void) | undefined;
mocks.createChat.mockImplementation(() => new Promise((resolve) => {
resolveCreateChat = resolve;
}));
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

let firstCreate: Promise<void> | undefined;
let secondCreate: Promise<void> | undefined;
act(() => {
firstCreate = result.current.createChatFromSource(source);
secondCreate = result.current.createChatFromSource(source);
});

expect(mocks.createChat).toHaveBeenCalledTimes(1);

resolveCreateChat?.({ id: "chat-1" });
await act(async () => {
await Promise.all([firstCreate, secondCreate]);
});

expect(mocks.push).toHaveBeenCalledTimes(1);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 44 additions & 14 deletions packages/web/src/app/(app)/components/editorContextMenu.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import { useToast } from "@/components/hooks/use-toast";
import { Button } from "@/components/ui/button";
import { useCreateNewChatThread } from "@/features/chat/useCreateNewChatThread";
import useCaptureEvent from "@/hooks/useCaptureEvent";
import { createPathWithQueryParams } from "@/lib/utils";
import { autoPlacement, computePosition, offset, shift, VirtualElement } from "@floating-ui/react";
Expand All@@ -28,6 +29,7 @@ export const EditorContextMenu = ({
const ref = useRef<HTMLDivElement>(null);
const { toast } = useToast();
const captureEvent = useCaptureEvent();
const { createChatFromSource } = useCreateNewChatThread();
useEffect(() => {
if (selection.empty) {
ref.current?.classList.add('hidden');
Expand DownExpand Up@@ -126,19 +128,47 @@ export const EditorContextMenu = ({
)
}, [selection.from, selection.to, repoName, revisionName, path, toast, captureEvent, view]);

const onAskSourcebot = useCallback(() => {
if (selection.empty) {
return;
}

const startLine = view.state.doc.lineAt(selection.from).number;
const endLine = view.state.doc.lineAt(selection.to - 1).number;

void createChatFromSource({
type: 'file',
repo: repoName,
path,
name: path.split('/').pop() ?? path,
revision: revisionName,
range: { startLine, endLine },
});
}, [createChatFromSource, path, repoName, revisionName, selection, view]);

return (
<div
ref={ref}
className="absolute z-10 flex flex-col gap-2 bg-background border border-gray-300 dark:border-gray-700 rounded-md shadow-lg p-2"
>
<Button
variant="ghost"
size="sm"
onClick={onCopyLinkToSelection}
>
<Link2Icon className="h-4 w-4 mr-1" />
Share selection
</Button>
</div>
<div
ref={ref}
className="absolute z-10 flex items-center gap-1 rounded-lg border border-border bg-popover p-1 shadow-xl"
>
<Button
variant="secondary"
size="sm"
onClick={onCopyLinkToSelection}
className="h-8 px-3 hover:bg-black/50"
>
<Link2Icon className="mr-2 h-4 w-4" />
Share selection
</Button>

<Button
variant="secondary"
size="sm"
onClick={onAskSourcebot}
className="h-8 px-3 hover:bg-black/50"
>
Ask SourceBot
</Button>
Comment thread
cursor[bot] marked this conversation as resolved.
</div>
)
}
}
29 changes: 28 additions & 1 deletion packages/web/src/ee/features/chat/agent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ vi.mock('ai', async (importOriginal) => {
};
});

const { createMessageStream } = await import('./agent');
const { createMessageStream, sliceFileSourceForPrompt } = await import('./agent');
const { getPromptCacheStrategy } = await import('./promptCaching');

// Strategies reused across the prompt-caching tests below.
Expand All@@ -135,6 +135,33 @@ const listReposInput = {
direction: 'asc',
} as const;

describe('sliceFileSourceForPrompt', () => {
test('slices an inclusive range and preserves its original line offset', () => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree\nfour', {
startLine: 2,
endLine: 3,
})).toEqual({
source: 'two\nthree',
lineOffset: 2,
});
});

test('keeps the full file when there is no selected range', () => {
expect(sliceFileSourceForPrompt('one\ntwo', undefined)).toEqual({
source: 'one\ntwo',
lineOffset: 1,
});
});

test.each([
{ startLine: 0, endLine: 1 },
{ startLine: 3, endLine: 2 },
{ startLine: 1, endLine: 4 },
])('ignores invalid ranges safely', (range) => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree', range)).toBeUndefined();
});
});

const dynamicApprovalRespondedPart = {
type: 'dynamic-tool',
toolName: 'mcp_linear__save_issue',
Expand Down
41 changes: 37 additions & 4 deletions packages/web/src/ee/features/chat/agent.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ import {
import { randomUUID } from "crypto";
import _dedent from "dedent";
import { ANSWER_TAG, FILE_REFERENCE_PREFIX } from "@/features/chat/constants";
import { Source } from "@/features/chat/types";
import { FileSource, Source } from "@/features/chat/types";
import { addLineNumbers, fileReferenceToString, formatAttachmentsForPrompt, getAnswerPartFromAssistantMessage, getTurnProgressState, getUserMessageAttachments, getUserMessageText } from "@/features/chat/utils";
import { createTools } from "./tools";
import { getConnectedMcpClients } from "@/ee/features/chat/mcp/mcpClientFactory";
Expand DownExpand Up@@ -551,6 +551,29 @@ interface AgentOptions {
orgId?: number;
}

export const sliceFileSourceForPrompt = (
source: string,
range: FileSource['range'],
): { source: string; lineOffset: number } | undefined => {
if (!range) {
return { source, lineOffset: 1 };
}

const lines = source.split('\n');
if (
range.startLine < 1 ||
range.endLine < range.startLine ||
range.endLine > lines.length
) {
return undefined;
}

return {
source: lines.slice(range.startLine - 1, range.endLine).join('\n'),
lineOffset: range.startLine,
};
};

const createAgentStream = async ({
model,
promptCacheStrategy,
Expand DownExpand Up@@ -591,12 +614,20 @@ const createAgentStream = async ({
return undefined;
}

const selectedSource = sliceFileSourceForPrompt(fileSource.source, source.range);
if (!selectedSource) {
logger.warn(`Ignoring invalid selected range for ${source.repo}:${source.path}`);
return undefined;
}

return {
path: fileSource.path,
source: fileSource.source,
source: selectedSource.source,
repo: fileSource.repo,
language: fileSource.language,
revision: source.revision,
lineOffset: selectedSource.lineOffset,
range: source.range,
};
}))
).filter((source) => source !== undefined);
Expand DownExpand Up@@ -898,6 +929,8 @@ const createPrompt = ({
repo: string;
language: string;
revision: string;
range?: FileSource['range'];
lineOffset: number;
}[],
repos: string[],
mcpToolRegistry: McpToolRegistryEntry[],
Expand DownExpand Up@@ -999,8 +1032,8 @@ const createPrompt = ({
<files>
The user has mentioned the following files, which are automatically included for analysis.

${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}">
${addLineNumbers(file.source)}
${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}"${file.range ? ` selected_lines="${file.range.startLine}-${file.range.endLine}"` : ''}>
${addLineNumbers(file.source, file.lineOffset)}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</file>`).join('\n\n')}
</files>
`);
Expand Down
114 changes: 114 additions & 0 deletions packages/web/src/features/chat/useCreateNewChatThread.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
import { act, renderHook } from "@testing-library/react";
import { afterEach, expect, test, vi } from "vitest";
import type { Source } from "./types";
import { DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY } from "./constants";

const mocks = vi.hoisted(() => ({
createChat: vi.fn(),
createUIMessage: vi.fn(),
push: vi.fn(),
setChatState: vi.fn(),
toast: vi.fn(),
}));

vi.mock("next/navigation", () => ({
useRouter: () => ({ push: mocks.push }),
}));

vi.mock("@/components/hooks/use-toast", () => ({
useToast: () => ({ toast: mocks.toast }),
}));

vi.mock("./actions", () => ({
createChat: mocks.createChat,
}));

vi.mock("@/lib/utils", () => ({
isServiceError: () => false,
createPathWithQueryParams: (path: string) => path,
}));

vi.mock("./utils", () => ({
createUIMessage: mocks.createUIMessage,
getAllMentionElements: () => [],
slateContentToString: () => "",
}));

vi.mock("usehooks-ts", () => ({
useSessionStorage: () => [null, mocks.setChatState],
}));

const { useCreateNewChatThread } = await import("./useCreateNewChatThread");

afterEach(() => {
window.localStorage.clear();
vi.clearAllMocks();
});

test("createChatFromSource preserves disabled MCP servers from local storage", async () => {
const disabledMcpServerIds = ["linear", "github"];
window.localStorage.setItem(
DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY,
JSON.stringify(disabledMcpServerIds),
);
mocks.createChat.mockResolvedValue({ id: "chat-1" });
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

await act(async () => {
await result.current.createChatFromSource(source);
});

expect(mocks.createUIMessage).toHaveBeenCalledWith(
"Explain this selected code.",
[],
[],
disabledMcpServerIds,
[],
[source],
);
expect(mocks.setChatState).toHaveBeenCalledWith({
inputMessage: { id: "initial-message" },
selectedSearchScopes: [],
disabledMcpServerIds,
});
});

test("createChatFromSource ignores duplicate calls while chat creation is pending", async () => {
let resolveCreateChat: ((value: { id: string }) => void) | undefined;
mocks.createChat.mockImplementation(() => new Promise((resolve) => {
resolveCreateChat = resolve;
}));
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

let firstCreate: Promise<void> | undefined;
let secondCreate: Promise<void> | undefined;
act(() => {
firstCreate = result.current.createChatFromSource(source);
secondCreate = result.current.createChatFromSource(source);
});

expect(mocks.createChat).toHaveBeenCalledTimes(1);

resolveCreateChat?.({ id: "chat-1" });
await act(async () => {
await Promise.all([firstCreate, secondCreate]);
});

expect(mocks.push).toHaveBeenCalledTimes(1);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 44 additions & 14 deletions packages/web/src/app/(app)/components/editorContextMenu.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import { useToast } from "@/components/hooks/use-toast";
import { Button } from "@/components/ui/button";
import { useCreateNewChatThread } from "@/features/chat/useCreateNewChatThread";
import useCaptureEvent from "@/hooks/useCaptureEvent";
import { createPathWithQueryParams } from "@/lib/utils";
import { autoPlacement, computePosition, offset, shift, VirtualElement } from "@floating-ui/react";
Expand All@@ -28,6 +29,7 @@ export const EditorContextMenu = ({
const ref = useRef<HTMLDivElement>(null);
const { toast } = useToast();
const captureEvent = useCaptureEvent();
const { createChatFromSource } = useCreateNewChatThread();
useEffect(() => {
if (selection.empty) {
ref.current?.classList.add('hidden');
Expand DownExpand Up@@ -126,19 +128,47 @@ export const EditorContextMenu = ({
)
}, [selection.from, selection.to, repoName, revisionName, path, toast, captureEvent, view]);

const onAskSourcebot = useCallback(() => {
if (selection.empty) {
return;
}

const startLine = view.state.doc.lineAt(selection.from).number;
const endLine = view.state.doc.lineAt(selection.to - 1).number;

void createChatFromSource({
type: 'file',
repo: repoName,
path,
name: path.split('/').pop() ?? path,
revision: revisionName,
range: { startLine, endLine },
});
}, [createChatFromSource, path, repoName, revisionName, selection, view]);

return (
<div
ref={ref}
className="absolute z-10 flex flex-col gap-2 bg-background border border-gray-300 dark:border-gray-700 rounded-md shadow-lg p-2"
>
<Button
variant="ghost"
size="sm"
onClick={onCopyLinkToSelection}
>
<Link2Icon className="h-4 w-4 mr-1" />
Share selection
</Button>
</div>
<div
ref={ref}
className="absolute z-10 flex items-center gap-1 rounded-lg border border-border bg-popover p-1 shadow-xl"
>
<Button
variant="secondary"
size="sm"
onClick={onCopyLinkToSelection}
className="h-8 px-3 hover:bg-black/50"
>
<Link2Icon className="mr-2 h-4 w-4" />
Share selection
</Button>

<Button
variant="secondary"
size="sm"
onClick={onAskSourcebot}
className="h-8 px-3 hover:bg-black/50"
>
Ask SourceBot
</Button>
Comment thread
cursor[bot] marked this conversation as resolved.
</div>
)
}
}
29 changes: 28 additions & 1 deletion packages/web/src/ee/features/chat/agent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ vi.mock('ai', async (importOriginal) => {
};
});

const { createMessageStream } = await import('./agent');
const { createMessageStream, sliceFileSourceForPrompt } = await import('./agent');
const { getPromptCacheStrategy } = await import('./promptCaching');

// Strategies reused across the prompt-caching tests below.
Expand All@@ -135,6 +135,33 @@ const listReposInput = {
direction: 'asc',
} as const;

describe('sliceFileSourceForPrompt', () => {
test('slices an inclusive range and preserves its original line offset', () => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree\nfour', {
startLine: 2,
endLine: 3,
})).toEqual({
source: 'two\nthree',
lineOffset: 2,
});
});

test('keeps the full file when there is no selected range', () => {
expect(sliceFileSourceForPrompt('one\ntwo', undefined)).toEqual({
source: 'one\ntwo',
lineOffset: 1,
});
});

test.each([
{ startLine: 0, endLine: 1 },
{ startLine: 3, endLine: 2 },
{ startLine: 1, endLine: 4 },
])('ignores invalid ranges safely', (range) => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree', range)).toBeUndefined();
});
});

const dynamicApprovalRespondedPart = {
type: 'dynamic-tool',
toolName: 'mcp_linear__save_issue',
Expand Down
41 changes: 37 additions & 4 deletions packages/web/src/ee/features/chat/agent.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ import {
import { randomUUID } from "crypto";
import _dedent from "dedent";
import { ANSWER_TAG, FILE_REFERENCE_PREFIX } from "@/features/chat/constants";
import { Source } from "@/features/chat/types";
import { FileSource, Source } from "@/features/chat/types";
import { addLineNumbers, fileReferenceToString, formatAttachmentsForPrompt, getAnswerPartFromAssistantMessage, getTurnProgressState, getUserMessageAttachments, getUserMessageText } from "@/features/chat/utils";
import { createTools } from "./tools";
import { getConnectedMcpClients } from "@/ee/features/chat/mcp/mcpClientFactory";
Expand DownExpand Up@@ -551,6 +551,29 @@ interface AgentOptions {
orgId?: number;
}

export const sliceFileSourceForPrompt = (
source: string,
range: FileSource['range'],
): { source: string; lineOffset: number } | undefined => {
if (!range) {
return { source, lineOffset: 1 };
}

const lines = source.split('\n');
if (
range.startLine < 1 ||
range.endLine < range.startLine ||
range.endLine > lines.length
) {
return undefined;
}

return {
source: lines.slice(range.startLine - 1, range.endLine).join('\n'),
lineOffset: range.startLine,
};
};

const createAgentStream = async ({
model,
promptCacheStrategy,
Expand DownExpand Up@@ -591,12 +614,20 @@ const createAgentStream = async ({
return undefined;
}

const selectedSource = sliceFileSourceForPrompt(fileSource.source, source.range);
if (!selectedSource) {
logger.warn(`Ignoring invalid selected range for ${source.repo}:${source.path}`);
return undefined;
}

return {
path: fileSource.path,
source: fileSource.source,
source: selectedSource.source,
repo: fileSource.repo,
language: fileSource.language,
revision: source.revision,
lineOffset: selectedSource.lineOffset,
range: source.range,
};
}))
).filter((source) => source !== undefined);
Expand DownExpand Up@@ -898,6 +929,8 @@ const createPrompt = ({
repo: string;
language: string;
revision: string;
range?: FileSource['range'];
lineOffset: number;
}[],
repos: string[],
mcpToolRegistry: McpToolRegistryEntry[],
Expand DownExpand Up@@ -999,8 +1032,8 @@ const createPrompt = ({
<files>
The user has mentioned the following files, which are automatically included for analysis.

${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}">
${addLineNumbers(file.source)}
${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}"${file.range ? ` selected_lines="${file.range.startLine}-${file.range.endLine}"` : ''}>
${addLineNumbers(file.source, file.lineOffset)}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</file>`).join('\n\n')}
</files>
`);
Expand Down
114 changes: 114 additions & 0 deletions packages/web/src/features/chat/useCreateNewChatThread.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
import { act, renderHook } from "@testing-library/react";
import { afterEach, expect, test, vi } from "vitest";
import type { Source } from "./types";
import { DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY } from "./constants";

const mocks = vi.hoisted(() => ({
createChat: vi.fn(),
createUIMessage: vi.fn(),
push: vi.fn(),
setChatState: vi.fn(),
toast: vi.fn(),
}));

vi.mock("next/navigation", () => ({
useRouter: () => ({ push: mocks.push }),
}));

vi.mock("@/components/hooks/use-toast", () => ({
useToast: () => ({ toast: mocks.toast }),
}));

vi.mock("./actions", () => ({
createChat: mocks.createChat,
}));

vi.mock("@/lib/utils", () => ({
isServiceError: () => false,
createPathWithQueryParams: (path: string) => path,
}));

vi.mock("./utils", () => ({
createUIMessage: mocks.createUIMessage,
getAllMentionElements: () => [],
slateContentToString: () => "",
}));

vi.mock("usehooks-ts", () => ({
useSessionStorage: () => [null, mocks.setChatState],
}));

const { useCreateNewChatThread } = await import("./useCreateNewChatThread");

afterEach(() => {
window.localStorage.clear();
vi.clearAllMocks();
});

test("createChatFromSource preserves disabled MCP servers from local storage", async () => {
const disabledMcpServerIds = ["linear", "github"];
window.localStorage.setItem(
DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY,
JSON.stringify(disabledMcpServerIds),
);
mocks.createChat.mockResolvedValue({ id: "chat-1" });
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

await act(async () => {
await result.current.createChatFromSource(source);
});

expect(mocks.createUIMessage).toHaveBeenCalledWith(
"Explain this selected code.",
[],
[],
disabledMcpServerIds,
[],
[source],
);
expect(mocks.setChatState).toHaveBeenCalledWith({
inputMessage: { id: "initial-message" },
selectedSearchScopes: [],
disabledMcpServerIds,
});
});

test("createChatFromSource ignores duplicate calls while chat creation is pending", async () => {
let resolveCreateChat: ((value: { id: string }) => void) | undefined;
mocks.createChat.mockImplementation(() => new Promise((resolve) => {
resolveCreateChat = resolve;
}));
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

let firstCreate: Promise<void> | undefined;
let secondCreate: Promise<void> | undefined;
act(() => {
firstCreate = result.current.createChatFromSource(source);
secondCreate = result.current.createChatFromSource(source);
});

expect(mocks.createChat).toHaveBeenCalledTimes(1);

resolveCreateChat?.({ id: "chat-1" });
await act(async () => {
await Promise.all([firstCreate, secondCreate]);
});

expect(mocks.push).toHaveBeenCalledTimes(1);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 44 additions & 14 deletions packages/web/src/app/(app)/components/editorContextMenu.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import { useToast } from "@/components/hooks/use-toast";
import { Button } from "@/components/ui/button";
import { useCreateNewChatThread } from "@/features/chat/useCreateNewChatThread";
import useCaptureEvent from "@/hooks/useCaptureEvent";
import { createPathWithQueryParams } from "@/lib/utils";
import { autoPlacement, computePosition, offset, shift, VirtualElement } from "@floating-ui/react";
Expand All@@ -28,6 +29,7 @@ export const EditorContextMenu = ({
const ref = useRef<HTMLDivElement>(null);
const { toast } = useToast();
const captureEvent = useCaptureEvent();
const { createChatFromSource } = useCreateNewChatThread();
useEffect(() => {
if (selection.empty) {
ref.current?.classList.add('hidden');
Expand DownExpand Up@@ -126,19 +128,47 @@ export const EditorContextMenu = ({
)
}, [selection.from, selection.to, repoName, revisionName, path, toast, captureEvent, view]);

const onAskSourcebot = useCallback(() => {
if (selection.empty) {
return;
}

const startLine = view.state.doc.lineAt(selection.from).number;
const endLine = view.state.doc.lineAt(selection.to - 1).number;

void createChatFromSource({
type: 'file',
repo: repoName,
path,
name: path.split('/').pop() ?? path,
revision: revisionName,
range: { startLine, endLine },
});
}, [createChatFromSource, path, repoName, revisionName, selection, view]);

return (
<div
ref={ref}
className="absolute z-10 flex flex-col gap-2 bg-background border border-gray-300 dark:border-gray-700 rounded-md shadow-lg p-2"
>
<Button
variant="ghost"
size="sm"
onClick={onCopyLinkToSelection}
>
<Link2Icon className="h-4 w-4 mr-1" />
Share selection
</Button>
</div>
<div
ref={ref}
className="absolute z-10 flex items-center gap-1 rounded-lg border border-border bg-popover p-1 shadow-xl"
>
<Button
variant="secondary"
size="sm"
onClick={onCopyLinkToSelection}
className="h-8 px-3 hover:bg-black/50"
>
<Link2Icon className="mr-2 h-4 w-4" />
Share selection
</Button>

<Button
variant="secondary"
size="sm"
onClick={onAskSourcebot}
className="h-8 px-3 hover:bg-black/50"
>
Ask SourceBot
</Button>
Comment thread
cursor[bot] marked this conversation as resolved.
</div>
)
}
}
29 changes: 28 additions & 1 deletion packages/web/src/ee/features/chat/agent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ vi.mock('ai', async (importOriginal) => {
};
});

const { createMessageStream } = await import('./agent');
const { createMessageStream, sliceFileSourceForPrompt } = await import('./agent');
const { getPromptCacheStrategy } = await import('./promptCaching');

// Strategies reused across the prompt-caching tests below.
Expand All@@ -135,6 +135,33 @@ const listReposInput = {
direction: 'asc',
} as const;

describe('sliceFileSourceForPrompt', () => {
test('slices an inclusive range and preserves its original line offset', () => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree\nfour', {
startLine: 2,
endLine: 3,
})).toEqual({
source: 'two\nthree',
lineOffset: 2,
});
});

test('keeps the full file when there is no selected range', () => {
expect(sliceFileSourceForPrompt('one\ntwo', undefined)).toEqual({
source: 'one\ntwo',
lineOffset: 1,
});
});

test.each([
{ startLine: 0, endLine: 1 },
{ startLine: 3, endLine: 2 },
{ startLine: 1, endLine: 4 },
])('ignores invalid ranges safely', (range) => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree', range)).toBeUndefined();
});
});

const dynamicApprovalRespondedPart = {
type: 'dynamic-tool',
toolName: 'mcp_linear__save_issue',
Expand Down
41 changes: 37 additions & 4 deletions packages/web/src/ee/features/chat/agent.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ import {
import { randomUUID } from "crypto";
import _dedent from "dedent";
import { ANSWER_TAG, FILE_REFERENCE_PREFIX } from "@/features/chat/constants";
import { Source } from "@/features/chat/types";
import { FileSource, Source } from "@/features/chat/types";
import { addLineNumbers, fileReferenceToString, formatAttachmentsForPrompt, getAnswerPartFromAssistantMessage, getTurnProgressState, getUserMessageAttachments, getUserMessageText } from "@/features/chat/utils";
import { createTools } from "./tools";
import { getConnectedMcpClients } from "@/ee/features/chat/mcp/mcpClientFactory";
Expand DownExpand Up@@ -551,6 +551,29 @@ interface AgentOptions {
orgId?: number;
}

export const sliceFileSourceForPrompt = (
source: string,
range: FileSource['range'],
): { source: string; lineOffset: number } | undefined => {
if (!range) {
return { source, lineOffset: 1 };
}

const lines = source.split('\n');
if (
range.startLine < 1 ||
range.endLine < range.startLine ||
range.endLine > lines.length
) {
return undefined;
}

return {
source: lines.slice(range.startLine - 1, range.endLine).join('\n'),
lineOffset: range.startLine,
};
};

const createAgentStream = async ({
model,
promptCacheStrategy,
Expand DownExpand Up@@ -591,12 +614,20 @@ const createAgentStream = async ({
return undefined;
}

const selectedSource = sliceFileSourceForPrompt(fileSource.source, source.range);
if (!selectedSource) {
logger.warn(`Ignoring invalid selected range for ${source.repo}:${source.path}`);
return undefined;
}

return {
path: fileSource.path,
source: fileSource.source,
source: selectedSource.source,
repo: fileSource.repo,
language: fileSource.language,
revision: source.revision,
lineOffset: selectedSource.lineOffset,
range: source.range,
};
}))
).filter((source) => source !== undefined);
Expand DownExpand Up@@ -898,6 +929,8 @@ const createPrompt = ({
repo: string;
language: string;
revision: string;
range?: FileSource['range'];
lineOffset: number;
}[],
repos: string[],
mcpToolRegistry: McpToolRegistryEntry[],
Expand DownExpand Up@@ -999,8 +1032,8 @@ const createPrompt = ({
<files>
The user has mentioned the following files, which are automatically included for analysis.

${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}">
${addLineNumbers(file.source)}
${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}"${file.range ? ` selected_lines="${file.range.startLine}-${file.range.endLine}"` : ''}>
${addLineNumbers(file.source, file.lineOffset)}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</file>`).join('\n\n')}
</files>
`);
Expand Down
114 changes: 114 additions & 0 deletions packages/web/src/features/chat/useCreateNewChatThread.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
import { act, renderHook } from "@testing-library/react";
import { afterEach, expect, test, vi } from "vitest";
import type { Source } from "./types";
import { DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY } from "./constants";

const mocks = vi.hoisted(() => ({
createChat: vi.fn(),
createUIMessage: vi.fn(),
push: vi.fn(),
setChatState: vi.fn(),
toast: vi.fn(),
}));

vi.mock("next/navigation", () => ({
useRouter: () => ({ push: mocks.push }),
}));

vi.mock("@/components/hooks/use-toast", () => ({
useToast: () => ({ toast: mocks.toast }),
}));

vi.mock("./actions", () => ({
createChat: mocks.createChat,
}));

vi.mock("@/lib/utils", () => ({
isServiceError: () => false,
createPathWithQueryParams: (path: string) => path,
}));

vi.mock("./utils", () => ({
createUIMessage: mocks.createUIMessage,
getAllMentionElements: () => [],
slateContentToString: () => "",
}));

vi.mock("usehooks-ts", () => ({
useSessionStorage: () => [null, mocks.setChatState],
}));

const { useCreateNewChatThread } = await import("./useCreateNewChatThread");

afterEach(() => {
window.localStorage.clear();
vi.clearAllMocks();
});

test("createChatFromSource preserves disabled MCP servers from local storage", async () => {
const disabledMcpServerIds = ["linear", "github"];
window.localStorage.setItem(
DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY,
JSON.stringify(disabledMcpServerIds),
);
mocks.createChat.mockResolvedValue({ id: "chat-1" });
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

await act(async () => {
await result.current.createChatFromSource(source);
});

expect(mocks.createUIMessage).toHaveBeenCalledWith(
"Explain this selected code.",
[],
[],
disabledMcpServerIds,
[],
[source],
);
expect(mocks.setChatState).toHaveBeenCalledWith({
inputMessage: { id: "initial-message" },
selectedSearchScopes: [],
disabledMcpServerIds,
});
});

test("createChatFromSource ignores duplicate calls while chat creation is pending", async () => {
let resolveCreateChat: ((value: { id: string }) => void) | undefined;
mocks.createChat.mockImplementation(() => new Promise((resolve) => {
resolveCreateChat = resolve;
}));
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

let firstCreate: Promise<void> | undefined;
let secondCreate: Promise<void> | undefined;
act(() => {
firstCreate = result.current.createChatFromSource(source);
secondCreate = result.current.createChatFromSource(source);
});

expect(mocks.createChat).toHaveBeenCalledTimes(1);

resolveCreateChat?.({ id: "chat-1" });
await act(async () => {
await Promise.all([firstCreate, secondCreate]);
});

expect(mocks.push).toHaveBeenCalledTimes(1);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 44 additions & 14 deletions packages/web/src/app/(app)/components/editorContextMenu.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import { useToast } from "@/components/hooks/use-toast";
import { Button } from "@/components/ui/button";
import { useCreateNewChatThread } from "@/features/chat/useCreateNewChatThread";
import useCaptureEvent from "@/hooks/useCaptureEvent";
import { createPathWithQueryParams } from "@/lib/utils";
import { autoPlacement, computePosition, offset, shift, VirtualElement } from "@floating-ui/react";
Expand All@@ -28,6 +29,7 @@ export const EditorContextMenu = ({
const ref = useRef<HTMLDivElement>(null);
const { toast } = useToast();
const captureEvent = useCaptureEvent();
const { createChatFromSource } = useCreateNewChatThread();
useEffect(() => {
if (selection.empty) {
ref.current?.classList.add('hidden');
Expand DownExpand Up@@ -126,19 +128,47 @@ export const EditorContextMenu = ({
)
}, [selection.from, selection.to, repoName, revisionName, path, toast, captureEvent, view]);

const onAskSourcebot = useCallback(() => {
if (selection.empty) {
return;
}

const startLine = view.state.doc.lineAt(selection.from).number;
const endLine = view.state.doc.lineAt(selection.to - 1).number;

void createChatFromSource({
type: 'file',
repo: repoName,
path,
name: path.split('/').pop() ?? path,
revision: revisionName,
range: { startLine, endLine },
});
}, [createChatFromSource, path, repoName, revisionName, selection, view]);

return (
<div
ref={ref}
className="absolute z-10 flex flex-col gap-2 bg-background border border-gray-300 dark:border-gray-700 rounded-md shadow-lg p-2"
>
<Button
variant="ghost"
size="sm"
onClick={onCopyLinkToSelection}
>
<Link2Icon className="h-4 w-4 mr-1" />
Share selection
</Button>
</div>
<div
ref={ref}
className="absolute z-10 flex items-center gap-1 rounded-lg border border-border bg-popover p-1 shadow-xl"
>
<Button
variant="secondary"
size="sm"
onClick={onCopyLinkToSelection}
className="h-8 px-3 hover:bg-black/50"
>
<Link2Icon className="mr-2 h-4 w-4" />
Share selection
</Button>

<Button
variant="secondary"
size="sm"
onClick={onAskSourcebot}
className="h-8 px-3 hover:bg-black/50"
>
Ask SourceBot
</Button>
Comment thread
cursor[bot] marked this conversation as resolved.
</div>
)
}
}
29 changes: 28 additions & 1 deletion packages/web/src/ee/features/chat/agent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ vi.mock('ai', async (importOriginal) => {
};
});

const { createMessageStream } = await import('./agent');
const { createMessageStream, sliceFileSourceForPrompt } = await import('./agent');
const { getPromptCacheStrategy } = await import('./promptCaching');

// Strategies reused across the prompt-caching tests below.
Expand All@@ -135,6 +135,33 @@ const listReposInput = {
direction: 'asc',
} as const;

describe('sliceFileSourceForPrompt', () => {
test('slices an inclusive range and preserves its original line offset', () => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree\nfour', {
startLine: 2,
endLine: 3,
})).toEqual({
source: 'two\nthree',
lineOffset: 2,
});
});

test('keeps the full file when there is no selected range', () => {
expect(sliceFileSourceForPrompt('one\ntwo', undefined)).toEqual({
source: 'one\ntwo',
lineOffset: 1,
});
});

test.each([
{ startLine: 0, endLine: 1 },
{ startLine: 3, endLine: 2 },
{ startLine: 1, endLine: 4 },
])('ignores invalid ranges safely', (range) => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree', range)).toBeUndefined();
});
});

const dynamicApprovalRespondedPart = {
type: 'dynamic-tool',
toolName: 'mcp_linear__save_issue',
Expand Down
41 changes: 37 additions & 4 deletions packages/web/src/ee/features/chat/agent.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ import {
import { randomUUID } from "crypto";
import _dedent from "dedent";
import { ANSWER_TAG, FILE_REFERENCE_PREFIX } from "@/features/chat/constants";
import { Source } from "@/features/chat/types";
import { FileSource, Source } from "@/features/chat/types";
import { addLineNumbers, fileReferenceToString, formatAttachmentsForPrompt, getAnswerPartFromAssistantMessage, getTurnProgressState, getUserMessageAttachments, getUserMessageText } from "@/features/chat/utils";
import { createTools } from "./tools";
import { getConnectedMcpClients } from "@/ee/features/chat/mcp/mcpClientFactory";
Expand DownExpand Up@@ -551,6 +551,29 @@ interface AgentOptions {
orgId?: number;
}

export const sliceFileSourceForPrompt = (
source: string,
range: FileSource['range'],
): { source: string; lineOffset: number } | undefined => {
if (!range) {
return { source, lineOffset: 1 };
}

const lines = source.split('\n');
if (
range.startLine < 1 ||
range.endLine < range.startLine ||
range.endLine > lines.length
) {
return undefined;
}

return {
source: lines.slice(range.startLine - 1, range.endLine).join('\n'),
lineOffset: range.startLine,
};
};

const createAgentStream = async ({
model,
promptCacheStrategy,
Expand DownExpand Up@@ -591,12 +614,20 @@ const createAgentStream = async ({
return undefined;
}

const selectedSource = sliceFileSourceForPrompt(fileSource.source, source.range);
if (!selectedSource) {
logger.warn(`Ignoring invalid selected range for ${source.repo}:${source.path}`);
return undefined;
}

return {
path: fileSource.path,
source: fileSource.source,
source: selectedSource.source,
repo: fileSource.repo,
language: fileSource.language,
revision: source.revision,
lineOffset: selectedSource.lineOffset,
range: source.range,
};
}))
).filter((source) => source !== undefined);
Expand DownExpand Up@@ -898,6 +929,8 @@ const createPrompt = ({
repo: string;
language: string;
revision: string;
range?: FileSource['range'];
lineOffset: number;
}[],
repos: string[],
mcpToolRegistry: McpToolRegistryEntry[],
Expand DownExpand Up@@ -999,8 +1032,8 @@ const createPrompt = ({
<files>
The user has mentioned the following files, which are automatically included for analysis.

${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}">
${addLineNumbers(file.source)}
${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}"${file.range ? ` selected_lines="${file.range.startLine}-${file.range.endLine}"` : ''}>
${addLineNumbers(file.source, file.lineOffset)}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</file>`).join('\n\n')}
</files>
`);
Expand Down
114 changes: 114 additions & 0 deletions packages/web/src/features/chat/useCreateNewChatThread.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
import { act, renderHook } from "@testing-library/react";
import { afterEach, expect, test, vi } from "vitest";
import type { Source } from "./types";
import { DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY } from "./constants";

const mocks = vi.hoisted(() => ({
createChat: vi.fn(),
createUIMessage: vi.fn(),
push: vi.fn(),
setChatState: vi.fn(),
toast: vi.fn(),
}));

vi.mock("next/navigation", () => ({
useRouter: () => ({ push: mocks.push }),
}));

vi.mock("@/components/hooks/use-toast", () => ({
useToast: () => ({ toast: mocks.toast }),
}));

vi.mock("./actions", () => ({
createChat: mocks.createChat,
}));

vi.mock("@/lib/utils", () => ({
isServiceError: () => false,
createPathWithQueryParams: (path: string) => path,
}));

vi.mock("./utils", () => ({
createUIMessage: mocks.createUIMessage,
getAllMentionElements: () => [],
slateContentToString: () => "",
}));

vi.mock("usehooks-ts", () => ({
useSessionStorage: () => [null, mocks.setChatState],
}));

const { useCreateNewChatThread } = await import("./useCreateNewChatThread");

afterEach(() => {
window.localStorage.clear();
vi.clearAllMocks();
});

test("createChatFromSource preserves disabled MCP servers from local storage", async () => {
const disabledMcpServerIds = ["linear", "github"];
window.localStorage.setItem(
DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY,
JSON.stringify(disabledMcpServerIds),
);
mocks.createChat.mockResolvedValue({ id: "chat-1" });
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

await act(async () => {
await result.current.createChatFromSource(source);
});

expect(mocks.createUIMessage).toHaveBeenCalledWith(
"Explain this selected code.",
[],
[],
disabledMcpServerIds,
[],
[source],
);
expect(mocks.setChatState).toHaveBeenCalledWith({
inputMessage: { id: "initial-message" },
selectedSearchScopes: [],
disabledMcpServerIds,
});
});

test("createChatFromSource ignores duplicate calls while chat creation is pending", async () => {
let resolveCreateChat: ((value: { id: string }) => void) | undefined;
mocks.createChat.mockImplementation(() => new Promise((resolve) => {
resolveCreateChat = resolve;
}));
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

let firstCreate: Promise<void> | undefined;
let secondCreate: Promise<void> | undefined;
act(() => {
firstCreate = result.current.createChatFromSource(source);
secondCreate = result.current.createChatFromSource(source);
});

expect(mocks.createChat).toHaveBeenCalledTimes(1);

resolveCreateChat?.({ id: "chat-1" });
await act(async () => {
await Promise.all([firstCreate, secondCreate]);
});

expect(mocks.push).toHaveBeenCalledTimes(1);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 44 additions & 14 deletions packages/web/src/app/(app)/components/editorContextMenu.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import { useToast } from "@/components/hooks/use-toast";
import { Button } from "@/components/ui/button";
import { useCreateNewChatThread } from "@/features/chat/useCreateNewChatThread";
import useCaptureEvent from "@/hooks/useCaptureEvent";
import { createPathWithQueryParams } from "@/lib/utils";
import { autoPlacement, computePosition, offset, shift, VirtualElement } from "@floating-ui/react";
Expand All@@ -28,6 +29,7 @@ export const EditorContextMenu = ({
const ref = useRef<HTMLDivElement>(null);
const { toast } = useToast();
const captureEvent = useCaptureEvent();
const { createChatFromSource } = useCreateNewChatThread();
useEffect(() => {
if (selection.empty) {
ref.current?.classList.add('hidden');
Expand DownExpand Up@@ -126,19 +128,47 @@ export const EditorContextMenu = ({
)
}, [selection.from, selection.to, repoName, revisionName, path, toast, captureEvent, view]);

const onAskSourcebot = useCallback(() => {
if (selection.empty) {
return;
}

const startLine = view.state.doc.lineAt(selection.from).number;
const endLine = view.state.doc.lineAt(selection.to - 1).number;

void createChatFromSource({
type: 'file',
repo: repoName,
path,
name: path.split('/').pop() ?? path,
revision: revisionName,
range: { startLine, endLine },
});
}, [createChatFromSource, path, repoName, revisionName, selection, view]);

return (
<div
ref={ref}
className="absolute z-10 flex flex-col gap-2 bg-background border border-gray-300 dark:border-gray-700 rounded-md shadow-lg p-2"
>
<Button
variant="ghost"
size="sm"
onClick={onCopyLinkToSelection}
>
<Link2Icon className="h-4 w-4 mr-1" />
Share selection
</Button>
</div>
<div
ref={ref}
className="absolute z-10 flex items-center gap-1 rounded-lg border border-border bg-popover p-1 shadow-xl"
>
<Button
variant="secondary"
size="sm"
onClick={onCopyLinkToSelection}
className="h-8 px-3 hover:bg-black/50"
>
<Link2Icon className="mr-2 h-4 w-4" />
Share selection
</Button>

<Button
variant="secondary"
size="sm"
onClick={onAskSourcebot}
className="h-8 px-3 hover:bg-black/50"
>
Ask SourceBot
</Button>
Comment thread
cursor[bot] marked this conversation as resolved.
</div>
)
}
}
29 changes: 28 additions & 1 deletion packages/web/src/ee/features/chat/agent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ vi.mock('ai', async (importOriginal) => {
};
});

const { createMessageStream } = await import('./agent');
const { createMessageStream, sliceFileSourceForPrompt } = await import('./agent');
const { getPromptCacheStrategy } = await import('./promptCaching');

// Strategies reused across the prompt-caching tests below.
Expand All@@ -135,6 +135,33 @@ const listReposInput = {
direction: 'asc',
} as const;

describe('sliceFileSourceForPrompt', () => {
test('slices an inclusive range and preserves its original line offset', () => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree\nfour', {
startLine: 2,
endLine: 3,
})).toEqual({
source: 'two\nthree',
lineOffset: 2,
});
});

test('keeps the full file when there is no selected range', () => {
expect(sliceFileSourceForPrompt('one\ntwo', undefined)).toEqual({
source: 'one\ntwo',
lineOffset: 1,
});
});

test.each([
{ startLine: 0, endLine: 1 },
{ startLine: 3, endLine: 2 },
{ startLine: 1, endLine: 4 },
])('ignores invalid ranges safely', (range) => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree', range)).toBeUndefined();
});
});

const dynamicApprovalRespondedPart = {
type: 'dynamic-tool',
toolName: 'mcp_linear__save_issue',
Expand Down
41 changes: 37 additions & 4 deletions packages/web/src/ee/features/chat/agent.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ import {
import { randomUUID } from "crypto";
import _dedent from "dedent";
import { ANSWER_TAG, FILE_REFERENCE_PREFIX } from "@/features/chat/constants";
import { Source } from "@/features/chat/types";
import { FileSource, Source } from "@/features/chat/types";
import { addLineNumbers, fileReferenceToString, formatAttachmentsForPrompt, getAnswerPartFromAssistantMessage, getTurnProgressState, getUserMessageAttachments, getUserMessageText } from "@/features/chat/utils";
import { createTools } from "./tools";
import { getConnectedMcpClients } from "@/ee/features/chat/mcp/mcpClientFactory";
Expand DownExpand Up@@ -551,6 +551,29 @@ interface AgentOptions {
orgId?: number;
}

export const sliceFileSourceForPrompt = (
source: string,
range: FileSource['range'],
): { source: string; lineOffset: number } | undefined => {
if (!range) {
return { source, lineOffset: 1 };
}

const lines = source.split('\n');
if (
range.startLine < 1 ||
range.endLine < range.startLine ||
range.endLine > lines.length
) {
return undefined;
}

return {
source: lines.slice(range.startLine - 1, range.endLine).join('\n'),
lineOffset: range.startLine,
};
};

const createAgentStream = async ({
model,
promptCacheStrategy,
Expand DownExpand Up@@ -591,12 +614,20 @@ const createAgentStream = async ({
return undefined;
}

const selectedSource = sliceFileSourceForPrompt(fileSource.source, source.range);
if (!selectedSource) {
logger.warn(`Ignoring invalid selected range for ${source.repo}:${source.path}`);
return undefined;
}

return {
path: fileSource.path,
source: fileSource.source,
source: selectedSource.source,
repo: fileSource.repo,
language: fileSource.language,
revision: source.revision,
lineOffset: selectedSource.lineOffset,
range: source.range,
};
}))
).filter((source) => source !== undefined);
Expand DownExpand Up@@ -898,6 +929,8 @@ const createPrompt = ({
repo: string;
language: string;
revision: string;
range?: FileSource['range'];
lineOffset: number;
}[],
repos: string[],
mcpToolRegistry: McpToolRegistryEntry[],
Expand DownExpand Up@@ -999,8 +1032,8 @@ const createPrompt = ({
<files>
The user has mentioned the following files, which are automatically included for analysis.

${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}">
${addLineNumbers(file.source)}
${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}"${file.range ? ` selected_lines="${file.range.startLine}-${file.range.endLine}"` : ''}>
${addLineNumbers(file.source, file.lineOffset)}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</file>`).join('\n\n')}
</files>
`);
Expand Down
114 changes: 114 additions & 0 deletions packages/web/src/features/chat/useCreateNewChatThread.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
import { act, renderHook } from "@testing-library/react";
import { afterEach, expect, test, vi } from "vitest";
import type { Source } from "./types";
import { DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY } from "./constants";

const mocks = vi.hoisted(() => ({
createChat: vi.fn(),
createUIMessage: vi.fn(),
push: vi.fn(),
setChatState: vi.fn(),
toast: vi.fn(),
}));

vi.mock("next/navigation", () => ({
useRouter: () => ({ push: mocks.push }),
}));

vi.mock("@/components/hooks/use-toast", () => ({
useToast: () => ({ toast: mocks.toast }),
}));

vi.mock("./actions", () => ({
createChat: mocks.createChat,
}));

vi.mock("@/lib/utils", () => ({
isServiceError: () => false,
createPathWithQueryParams: (path: string) => path,
}));

vi.mock("./utils", () => ({
createUIMessage: mocks.createUIMessage,
getAllMentionElements: () => [],
slateContentToString: () => "",
}));

vi.mock("usehooks-ts", () => ({
useSessionStorage: () => [null, mocks.setChatState],
}));

const { useCreateNewChatThread } = await import("./useCreateNewChatThread");

afterEach(() => {
window.localStorage.clear();
vi.clearAllMocks();
});

test("createChatFromSource preserves disabled MCP servers from local storage", async () => {
const disabledMcpServerIds = ["linear", "github"];
window.localStorage.setItem(
DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY,
JSON.stringify(disabledMcpServerIds),
);
mocks.createChat.mockResolvedValue({ id: "chat-1" });
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

await act(async () => {
await result.current.createChatFromSource(source);
});

expect(mocks.createUIMessage).toHaveBeenCalledWith(
"Explain this selected code.",
[],
[],
disabledMcpServerIds,
[],
[source],
);
expect(mocks.setChatState).toHaveBeenCalledWith({
inputMessage: { id: "initial-message" },
selectedSearchScopes: [],
disabledMcpServerIds,
});
});

test("createChatFromSource ignores duplicate calls while chat creation is pending", async () => {
let resolveCreateChat: ((value: { id: string }) => void) | undefined;
mocks.createChat.mockImplementation(() => new Promise((resolve) => {
resolveCreateChat = resolve;
}));
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

let firstCreate: Promise<void> | undefined;
let secondCreate: Promise<void> | undefined;
act(() => {
firstCreate = result.current.createChatFromSource(source);
secondCreate = result.current.createChatFromSource(source);
});

expect(mocks.createChat).toHaveBeenCalledTimes(1);

resolveCreateChat?.({ id: "chat-1" });
await act(async () => {
await Promise.all([firstCreate, secondCreate]);
});

expect(mocks.push).toHaveBeenCalledTimes(1);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 44 additions & 14 deletions packages/web/src/app/(app)/components/editorContextMenu.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import { useToast } from "@/components/hooks/use-toast";
import { Button } from "@/components/ui/button";
import { useCreateNewChatThread } from "@/features/chat/useCreateNewChatThread";
import useCaptureEvent from "@/hooks/useCaptureEvent";
import { createPathWithQueryParams } from "@/lib/utils";
import { autoPlacement, computePosition, offset, shift, VirtualElement } from "@floating-ui/react";
Expand All@@ -28,6 +29,7 @@ export const EditorContextMenu = ({
const ref = useRef<HTMLDivElement>(null);
const { toast } = useToast();
const captureEvent = useCaptureEvent();
const { createChatFromSource } = useCreateNewChatThread();
useEffect(() => {
if (selection.empty) {
ref.current?.classList.add('hidden');
Expand DownExpand Up@@ -126,19 +128,47 @@ export const EditorContextMenu = ({
)
}, [selection.from, selection.to, repoName, revisionName, path, toast, captureEvent, view]);

const onAskSourcebot = useCallback(() => {
if (selection.empty) {
return;
}

const startLine = view.state.doc.lineAt(selection.from).number;
const endLine = view.state.doc.lineAt(selection.to - 1).number;

void createChatFromSource({
type: 'file',
repo: repoName,
path,
name: path.split('/').pop() ?? path,
revision: revisionName,
range: { startLine, endLine },
});
}, [createChatFromSource, path, repoName, revisionName, selection, view]);

return (
<div
ref={ref}
className="absolute z-10 flex flex-col gap-2 bg-background border border-gray-300 dark:border-gray-700 rounded-md shadow-lg p-2"
>
<Button
variant="ghost"
size="sm"
onClick={onCopyLinkToSelection}
>
<Link2Icon className="h-4 w-4 mr-1" />
Share selection
</Button>
</div>
<div
ref={ref}
className="absolute z-10 flex items-center gap-1 rounded-lg border border-border bg-popover p-1 shadow-xl"
>
<Button
variant="secondary"
size="sm"
onClick={onCopyLinkToSelection}
className="h-8 px-3 hover:bg-black/50"
>
<Link2Icon className="mr-2 h-4 w-4" />
Share selection
</Button>

<Button
variant="secondary"
size="sm"
onClick={onAskSourcebot}
className="h-8 px-3 hover:bg-black/50"
>
Ask SourceBot
</Button>
Comment thread
cursor[bot] marked this conversation as resolved.
</div>
)
}
}
29 changes: 28 additions & 1 deletion packages/web/src/ee/features/chat/agent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ vi.mock('ai', async (importOriginal) => {
};
});

const { createMessageStream } = await import('./agent');
const { createMessageStream, sliceFileSourceForPrompt } = await import('./agent');
const { getPromptCacheStrategy } = await import('./promptCaching');

// Strategies reused across the prompt-caching tests below.
Expand All@@ -135,6 +135,33 @@ const listReposInput = {
direction: 'asc',
} as const;

describe('sliceFileSourceForPrompt', () => {
test('slices an inclusive range and preserves its original line offset', () => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree\nfour', {
startLine: 2,
endLine: 3,
})).toEqual({
source: 'two\nthree',
lineOffset: 2,
});
});

test('keeps the full file when there is no selected range', () => {
expect(sliceFileSourceForPrompt('one\ntwo', undefined)).toEqual({
source: 'one\ntwo',
lineOffset: 1,
});
});

test.each([
{ startLine: 0, endLine: 1 },
{ startLine: 3, endLine: 2 },
{ startLine: 1, endLine: 4 },
])('ignores invalid ranges safely', (range) => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree', range)).toBeUndefined();
});
});

const dynamicApprovalRespondedPart = {
type: 'dynamic-tool',
toolName: 'mcp_linear__save_issue',
Expand Down
41 changes: 37 additions & 4 deletions packages/web/src/ee/features/chat/agent.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ import {
import { randomUUID } from "crypto";
import _dedent from "dedent";
import { ANSWER_TAG, FILE_REFERENCE_PREFIX } from "@/features/chat/constants";
import { Source } from "@/features/chat/types";
import { FileSource, Source } from "@/features/chat/types";
import { addLineNumbers, fileReferenceToString, formatAttachmentsForPrompt, getAnswerPartFromAssistantMessage, getTurnProgressState, getUserMessageAttachments, getUserMessageText } from "@/features/chat/utils";
import { createTools } from "./tools";
import { getConnectedMcpClients } from "@/ee/features/chat/mcp/mcpClientFactory";
Expand DownExpand Up@@ -551,6 +551,29 @@ interface AgentOptions {
orgId?: number;
}

export const sliceFileSourceForPrompt = (
source: string,
range: FileSource['range'],
): { source: string; lineOffset: number } | undefined => {
if (!range) {
return { source, lineOffset: 1 };
}

const lines = source.split('\n');
if (
range.startLine < 1 ||
range.endLine < range.startLine ||
range.endLine > lines.length
) {
return undefined;
}

return {
source: lines.slice(range.startLine - 1, range.endLine).join('\n'),
lineOffset: range.startLine,
};
};

const createAgentStream = async ({
model,
promptCacheStrategy,
Expand DownExpand Up@@ -591,12 +614,20 @@ const createAgentStream = async ({
return undefined;
}

const selectedSource = sliceFileSourceForPrompt(fileSource.source, source.range);
if (!selectedSource) {
logger.warn(`Ignoring invalid selected range for ${source.repo}:${source.path}`);
return undefined;
}

return {
path: fileSource.path,
source: fileSource.source,
source: selectedSource.source,
repo: fileSource.repo,
language: fileSource.language,
revision: source.revision,
lineOffset: selectedSource.lineOffset,
range: source.range,
};
}))
).filter((source) => source !== undefined);
Expand DownExpand Up@@ -898,6 +929,8 @@ const createPrompt = ({
repo: string;
language: string;
revision: string;
range?: FileSource['range'];
lineOffset: number;
}[],
repos: string[],
mcpToolRegistry: McpToolRegistryEntry[],
Expand DownExpand Up@@ -999,8 +1032,8 @@ const createPrompt = ({
<files>
The user has mentioned the following files, which are automatically included for analysis.

${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}">
${addLineNumbers(file.source)}
${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}"${file.range ? ` selected_lines="${file.range.startLine}-${file.range.endLine}"` : ''}>
${addLineNumbers(file.source, file.lineOffset)}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</file>`).join('\n\n')}
</files>
`);
Expand Down
114 changes: 114 additions & 0 deletions packages/web/src/features/chat/useCreateNewChatThread.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
import { act, renderHook } from "@testing-library/react";
import { afterEach, expect, test, vi } from "vitest";
import type { Source } from "./types";
import { DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY } from "./constants";

const mocks = vi.hoisted(() => ({
createChat: vi.fn(),
createUIMessage: vi.fn(),
push: vi.fn(),
setChatState: vi.fn(),
toast: vi.fn(),
}));

vi.mock("next/navigation", () => ({
useRouter: () => ({ push: mocks.push }),
}));

vi.mock("@/components/hooks/use-toast", () => ({
useToast: () => ({ toast: mocks.toast }),
}));

vi.mock("./actions", () => ({
createChat: mocks.createChat,
}));

vi.mock("@/lib/utils", () => ({
isServiceError: () => false,
createPathWithQueryParams: (path: string) => path,
}));

vi.mock("./utils", () => ({
createUIMessage: mocks.createUIMessage,
getAllMentionElements: () => [],
slateContentToString: () => "",
}));

vi.mock("usehooks-ts", () => ({
useSessionStorage: () => [null, mocks.setChatState],
}));

const { useCreateNewChatThread } = await import("./useCreateNewChatThread");

afterEach(() => {
window.localStorage.clear();
vi.clearAllMocks();
});

test("createChatFromSource preserves disabled MCP servers from local storage", async () => {
const disabledMcpServerIds = ["linear", "github"];
window.localStorage.setItem(
DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY,
JSON.stringify(disabledMcpServerIds),
);
mocks.createChat.mockResolvedValue({ id: "chat-1" });
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

await act(async () => {
await result.current.createChatFromSource(source);
});

expect(mocks.createUIMessage).toHaveBeenCalledWith(
"Explain this selected code.",
[],
[],
disabledMcpServerIds,
[],
[source],
);
expect(mocks.setChatState).toHaveBeenCalledWith({
inputMessage: { id: "initial-message" },
selectedSearchScopes: [],
disabledMcpServerIds,
});
});

test("createChatFromSource ignores duplicate calls while chat creation is pending", async () => {
let resolveCreateChat: ((value: { id: string }) => void) | undefined;
mocks.createChat.mockImplementation(() => new Promise((resolve) => {
resolveCreateChat = resolve;
}));
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

let firstCreate: Promise<void> | undefined;
let secondCreate: Promise<void> | undefined;
act(() => {
firstCreate = result.current.createChatFromSource(source);
secondCreate = result.current.createChatFromSource(source);
});

expect(mocks.createChat).toHaveBeenCalledTimes(1);

resolveCreateChat?.({ id: "chat-1" });
await act(async () => {
await Promise.all([firstCreate, secondCreate]);
});

expect(mocks.push).toHaveBeenCalledTimes(1);
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 44 additions & 14 deletions packages/web/src/app/(app)/components/editorContextMenu.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,6 +2,7 @@

import { useToast } from "@/components/hooks/use-toast";
import { Button } from "@/components/ui/button";
import { useCreateNewChatThread } from "@/features/chat/useCreateNewChatThread";
import useCaptureEvent from "@/hooks/useCaptureEvent";
import { createPathWithQueryParams } from "@/lib/utils";
import { autoPlacement, computePosition, offset, shift, VirtualElement } from "@floating-ui/react";
Expand All@@ -28,6 +29,7 @@ export const EditorContextMenu = ({
const ref = useRef<HTMLDivElement>(null);
const { toast } = useToast();
const captureEvent = useCaptureEvent();
const { createChatFromSource } = useCreateNewChatThread();
useEffect(() => {
if (selection.empty) {
ref.current?.classList.add('hidden');
Expand DownExpand Up@@ -126,19 +128,47 @@ export const EditorContextMenu = ({
)
}, [selection.from, selection.to, repoName, revisionName, path, toast, captureEvent, view]);

const onAskSourcebot = useCallback(() => {
if (selection.empty) {
return;
}

const startLine = view.state.doc.lineAt(selection.from).number;
const endLine = view.state.doc.lineAt(selection.to - 1).number;

void createChatFromSource({
type: 'file',
repo: repoName,
path,
name: path.split('/').pop() ?? path,
revision: revisionName,
range: { startLine, endLine },
});
}, [createChatFromSource, path, repoName, revisionName, selection, view]);

return (
<div
ref={ref}
className="absolute z-10 flex flex-col gap-2 bg-background border border-gray-300 dark:border-gray-700 rounded-md shadow-lg p-2"
>
<Button
variant="ghost"
size="sm"
onClick={onCopyLinkToSelection}
>
<Link2Icon className="h-4 w-4 mr-1" />
Share selection
</Button>
</div>
<div
ref={ref}
className="absolute z-10 flex items-center gap-1 rounded-lg border border-border bg-popover p-1 shadow-xl"
>
<Button
variant="secondary"
size="sm"
onClick={onCopyLinkToSelection}
className="h-8 px-3 hover:bg-black/50"
>
<Link2Icon className="mr-2 h-4 w-4" />
Share selection
</Button>

<Button
variant="secondary"
size="sm"
onClick={onAskSourcebot}
className="h-8 px-3 hover:bg-black/50"
>
Ask SourceBot
</Button>
Comment thread
cursor[bot] marked this conversation as resolved.
</div>
)
}
}
29 changes: 28 additions & 1 deletion packages/web/src/ee/features/chat/agent.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -121,7 +121,7 @@ vi.mock('ai', async (importOriginal) => {
};
});

const { createMessageStream } = await import('./agent');
const { createMessageStream, sliceFileSourceForPrompt } = await import('./agent');
const { getPromptCacheStrategy } = await import('./promptCaching');

// Strategies reused across the prompt-caching tests below.
Expand All@@ -135,6 +135,33 @@ const listReposInput = {
direction: 'asc',
} as const;

describe('sliceFileSourceForPrompt', () => {
test('slices an inclusive range and preserves its original line offset', () => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree\nfour', {
startLine: 2,
endLine: 3,
})).toEqual({
source: 'two\nthree',
lineOffset: 2,
});
});

test('keeps the full file when there is no selected range', () => {
expect(sliceFileSourceForPrompt('one\ntwo', undefined)).toEqual({
source: 'one\ntwo',
lineOffset: 1,
});
});

test.each([
{ startLine: 0, endLine: 1 },
{ startLine: 3, endLine: 2 },
{ startLine: 1, endLine: 4 },
])('ignores invalid ranges safely', (range) => {
expect(sliceFileSourceForPrompt('one\ntwo\nthree', range)).toBeUndefined();
});
});

const dynamicApprovalRespondedPart = {
type: 'dynamic-tool',
toolName: 'mcp_linear__save_issue',
Expand Down
41 changes: 37 additions & 4 deletions packages/web/src/ee/features/chat/agent.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ import {
import { randomUUID } from "crypto";
import _dedent from "dedent";
import { ANSWER_TAG, FILE_REFERENCE_PREFIX } from "@/features/chat/constants";
import { Source } from "@/features/chat/types";
import { FileSource, Source } from "@/features/chat/types";
import { addLineNumbers, fileReferenceToString, formatAttachmentsForPrompt, getAnswerPartFromAssistantMessage, getTurnProgressState, getUserMessageAttachments, getUserMessageText } from "@/features/chat/utils";
import { createTools } from "./tools";
import { getConnectedMcpClients } from "@/ee/features/chat/mcp/mcpClientFactory";
Expand DownExpand Up@@ -551,6 +551,29 @@ interface AgentOptions {
orgId?: number;
}

export const sliceFileSourceForPrompt = (
source: string,
range: FileSource['range'],
): { source: string; lineOffset: number } | undefined => {
if (!range) {
return { source, lineOffset: 1 };
}

const lines = source.split('\n');
if (
range.startLine < 1 ||
range.endLine < range.startLine ||
range.endLine > lines.length
) {
return undefined;
}

return {
source: lines.slice(range.startLine - 1, range.endLine).join('\n'),
lineOffset: range.startLine,
};
};

const createAgentStream = async ({
model,
promptCacheStrategy,
Expand DownExpand Up@@ -591,12 +614,20 @@ const createAgentStream = async ({
return undefined;
}

const selectedSource = sliceFileSourceForPrompt(fileSource.source, source.range);
if (!selectedSource) {
logger.warn(`Ignoring invalid selected range for ${source.repo}:${source.path}`);
return undefined;
}

return {
path: fileSource.path,
source: fileSource.source,
source: selectedSource.source,
repo: fileSource.repo,
language: fileSource.language,
revision: source.revision,
lineOffset: selectedSource.lineOffset,
range: source.range,
};
}))
).filter((source) => source !== undefined);
Expand DownExpand Up@@ -898,6 +929,8 @@ const createPrompt = ({
repo: string;
language: string;
revision: string;
range?: FileSource['range'];
lineOffset: number;
}[],
repos: string[],
mcpToolRegistry: McpToolRegistryEntry[],
Expand DownExpand Up@@ -999,8 +1032,8 @@ const createPrompt = ({
<files>
The user has mentioned the following files, which are automatically included for analysis.

${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}">
${addLineNumbers(file.source)}
${files.map(file => `<file path="${file.path}" repository="${file.repo}" language="${file.language}" revision="${file.revision}"${file.range ? ` selected_lines="${file.range.startLine}-${file.range.endLine}"` : ''}>
${addLineNumbers(file.source, file.lineOffset)}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</file>`).join('\n\n')}
</files>
`);
Expand Down
114 changes: 114 additions & 0 deletions packages/web/src/features/chat/useCreateNewChatThread.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
import { act, renderHook } from "@testing-library/react";
import { afterEach, expect, test, vi } from "vitest";
import type { Source } from "./types";
import { DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY } from "./constants";

const mocks = vi.hoisted(() => ({
createChat: vi.fn(),
createUIMessage: vi.fn(),
push: vi.fn(),
setChatState: vi.fn(),
toast: vi.fn(),
}));

vi.mock("next/navigation", () => ({
useRouter: () => ({ push: mocks.push }),
}));

vi.mock("@/components/hooks/use-toast", () => ({
useToast: () => ({ toast: mocks.toast }),
}));

vi.mock("./actions", () => ({
createChat: mocks.createChat,
}));

vi.mock("@/lib/utils", () => ({
isServiceError: () => false,
createPathWithQueryParams: (path: string) => path,
}));

vi.mock("./utils", () => ({
createUIMessage: mocks.createUIMessage,
getAllMentionElements: () => [],
slateContentToString: () => "",
}));

vi.mock("usehooks-ts", () => ({
useSessionStorage: () => [null, mocks.setChatState],
}));

const { useCreateNewChatThread } = await import("./useCreateNewChatThread");

afterEach(() => {
window.localStorage.clear();
vi.clearAllMocks();
});

test("createChatFromSource preserves disabled MCP servers from local storage", async () => {
const disabledMcpServerIds = ["linear", "github"];
window.localStorage.setItem(
DISABLED_MCP_SERVER_IDS_LOCAL_STORAGE_KEY,
JSON.stringify(disabledMcpServerIds),
);
mocks.createChat.mockResolvedValue({ id: "chat-1" });
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

await act(async () => {
await result.current.createChatFromSource(source);
});

expect(mocks.createUIMessage).toHaveBeenCalledWith(
"Explain this selected code.",
[],
[],
disabledMcpServerIds,
[],
[source],
);
expect(mocks.setChatState).toHaveBeenCalledWith({
inputMessage: { id: "initial-message" },
selectedSearchScopes: [],
disabledMcpServerIds,
});
});

test("createChatFromSource ignores duplicate calls while chat creation is pending", async () => {
let resolveCreateChat: ((value: { id: string }) => void) | undefined;
mocks.createChat.mockImplementation(() => new Promise((resolve) => {
resolveCreateChat = resolve;
}));
mocks.createUIMessage.mockReturnValue({ id: "initial-message" });
const { result } = renderHook(() => useCreateNewChatThread());
const source: Source = {
type: "file",
repo: "github.com/sourcebot-dev/sourcebot",
path: "packages/web/src/auth.ts",
name: "auth.ts",
revision: "main",
};

let firstCreate: Promise<void> | undefined;
let secondCreate: Promise<void> | undefined;
act(() => {
firstCreate = result.current.createChatFromSource(source);
secondCreate = result.current.createChatFromSource(source);
});

expect(mocks.createChat).toHaveBeenCalledTimes(1);

resolveCreateChat?.({ id: "chat-1" });
await act(async () => {
await Promise.all([firstCreate, secondCreate]);
});

expect(mocks.push).toHaveBeenCalledTimes(1);
});
Loading