Uh oh!
There was an error while loading. Please reload this page.
fix(web): prevent stalled code search result navigation - #1574
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
WalkthroughChangesNavigation and preview behavior
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score:⚪ Minimal · up to The change is localized to search-result navigation and has no actionable merge-blocking risk remaining; the additional modifier-path assertions are a non-blocking follow-up. Sequence Diagram(s)sequenceDiagram
participant User
participant FileMatch
participant FileMatchContainer
User->>FileMatch: Modifier-click or modifier-plus-Enter
FileMatch->>FileMatchContainer: onOpenPreview()
FileMatchContainer->>FileMatchContainer: Calculate cumulative match index
FileMatchContainer-->>User: Open file preview at match index
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/web/src/app/`(app)/search/components/searchResultsPanel/fileMatch.test.tsx:
- Around line 63-92: Update the ordinary-click test for FileMatch to assert its
click event is not defaultPrevented while preserving the existing no-preview
assertion. Extend the modifier-plus-Enter test coverage to run for both metaKey
(Cmd) and ctrlKey (Ctrl), asserting each event prevents navigation and calls
onOpenPreview once.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e10de595-2c40-4e5d-bf3a-651fc177f98a
📒 Files selected for processing (5)
CHANGELOG.mdpackages/web/src/app/(app)/components/pathHeader.tsxpackages/web/src/app/(app)/search/components/searchResultsPanel/fileMatch.test.tsxpackages/web/src/app/(app)/search/components/searchResultsPanel/fileMatch.tsxpackages/web/src/app/(app)/search/components/searchResultsPanel/fileMatchContainer.tsx
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathHeaderlinksTest plan
yarn workspace @sourcebot/web test src/app/\(app\)/search/components/searchResultsPanel/fileMatch.test.tsxyarn workspace @sourcebot/web eslint src/app/\(app\)/search/components/searchResultsPanel/fileMatch.tsx src/app/\(app\)/search/components/searchResultsPanel/fileMatch.test.tsx src/app/\(app\)/search/components/searchResultsPanel/fileMatchContainer.tsx src/app/\(app\)/components/pathHeader.tsxNote
Cursor Bugbot is generating a summary for commit 74f3951. Configure here.
Summary by CodeRabbit