Merged
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- Fixed Bitbucket Server and Cloud repo identifiers to include the project key, preventing collisions across projects. **Note:** Bitbucket Cloud users with `exclude.repos` patterns must update them from `workspace/repo` to `workspace/PROJECT_KEY/repo` format. [#904](https://github.com/sourcebot-dev/sourcebot/pull/904)

### Added
- Added optional `visibility` parameter to `/api/chat/blocking` endpoint and MCP `ask_codebase` tool to allow controlling chat session visibility in shared environments. [#903](https://github.com/sourcebot-dev/sourcebot/pull/903)

Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/bitbucket.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,8 +104,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/connection.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -781,8 +781,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/index.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -1196,8 +1196,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
173 changes: 173 additions & 0 deletions packages/backend/src/bitbucket.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { expect, test, describe } from 'vitest';
import { cloudShouldExcludeRepo, serverShouldExcludeRepo, BitbucketRepository } from './bitbucket';
import { BitbucketConnectionConfig } from '@sourcebot/schemas/v3/bitbucket.type';
import { SchemaRepository as CloudRepository } from '@coderabbitai/bitbucket/cloud/openapi';
import { SchemaRestRepository as ServerRepository } from '@coderabbitai/bitbucket/server/openapi';

const makeCloudRepo = (overrides: Partial<CloudRepository> = {}): BitbucketRepository => ({
type: 'repository',
full_name: 'myworkspace/my-repo',
project: { type: 'project', key: 'PROJ' },
is_private: false,
...overrides,
} as CloudRepository);

const makeServerRepo = (overrides: Partial<ServerRepository> = {}): BitbucketRepository => ({
slug: 'my-repo',
project: { key: 'PROJ' },
archived: false,
...overrides,
} as ServerRepository);

const baseConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'cloud',
};

describe('cloudShouldExcludeRepo', () => {
test('returns false when no exclusions are configured', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), baseConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/*'] },
})).toBe(true);
});

test('returns true when repo matches a workspace-level glob in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/**'] },
})).toBe(true);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: false },
})).toBe(false);
});
});

describe('serverShouldExcludeRepo', () => {
const serverConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'server',
url: 'https://bitbucket.example.com',
};

test('returns false when no exclusions are configured', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), serverConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/*'] },
})).toBe(true);
});

test('returns false when exclude.archived is true but repo is not archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: false }), {
...serverConfig,
exclude: { archived: true },
})).toBe(false);
});

test('returns true when exclude.archived is true and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: true },
})).toBe(true);
});

test('returns false when exclude.archived is false and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: false },
})).toBe(false);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: false },
})).toBe(false);
});
});
7 changes: 4 additions & 3 deletions packages/backend/src/bitbucket.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -345,10 +345,11 @@ async function cloudGetRepos(client: BitbucketClient, repoList: string[]): Promi
};
}

function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const cloudRepo = repo as CloudRepository;
let reason = '';
const repoName = cloudRepo.full_name!;
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
const repoName = `${workspace}/${cloudRepo.project?.key}/${repoSlug}`;
Comment thread
brendan-kellam marked this conversation as resolved.

const shouldExclude = (() => {
if (config.exclude?.repos) {
Expand DownExpand Up@@ -552,7 +553,7 @@ async function serverGetRepos(client: BitbucketClient, repoList: string[]): Prom
};
}

function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const serverRepo = repo as ServerRepository;

const projectName = serverRepo.project!.key;
Expand Down
13 changes: 12 additions & 1 deletion packages/backend/src/repoCompileUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -454,7 +454,18 @@ export const compileBitbucketConfig = async (
const repos = bitbucketRepos.map((repo) => {
const isServer = config.deploymentType === 'server';
const codeHostType: CodeHostType = isServer ? 'bitbucketServer' : 'bitbucketCloud';
const displayName = isServer ? (repo as BitbucketServerRepository).name! : (repo as BitbucketCloudRepository).full_name!;
const displayName = (() => {
if (isServer) {
const serverRepo = repo as BitbucketServerRepository;
// Server repos are of the format `project/repo`
return `${serverRepo.project!.key}/${serverRepo.slug!}`;
} else {
const cloudRepo = repo as BitbucketCloudRepository;
// Cloud repos are of the format `workspace/project/repo`
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
return `${workspace}/${cloudRepo.project?.key!}/${repoSlug}`;
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/bitbucket.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,8 +103,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/connection.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -780,8 +780,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/index.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1195,8 +1195,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions schemas/v3/bitbucket.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,8 +72,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- Fixed Bitbucket Server and Cloud repo identifiers to include the project key, preventing collisions across projects. **Note:** Bitbucket Cloud users with `exclude.repos` patterns must update them from `workspace/repo` to `workspace/PROJECT_KEY/repo` format. [#904](https://github.com/sourcebot-dev/sourcebot/pull/904)

### Added
- Added optional `visibility` parameter to `/api/chat/blocking` endpoint and MCP `ask_codebase` tool to allow controlling chat session visibility in shared environments. [#903](https://github.com/sourcebot-dev/sourcebot/pull/903)

Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/bitbucket.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,8 +104,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/connection.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -781,8 +781,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/index.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -1196,8 +1196,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
173 changes: 173 additions & 0 deletions packages/backend/src/bitbucket.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { expect, test, describe } from 'vitest';
import { cloudShouldExcludeRepo, serverShouldExcludeRepo, BitbucketRepository } from './bitbucket';
import { BitbucketConnectionConfig } from '@sourcebot/schemas/v3/bitbucket.type';
import { SchemaRepository as CloudRepository } from '@coderabbitai/bitbucket/cloud/openapi';
import { SchemaRestRepository as ServerRepository } from '@coderabbitai/bitbucket/server/openapi';

const makeCloudRepo = (overrides: Partial<CloudRepository> = {}): BitbucketRepository => ({
type: 'repository',
full_name: 'myworkspace/my-repo',
project: { type: 'project', key: 'PROJ' },
is_private: false,
...overrides,
} as CloudRepository);

const makeServerRepo = (overrides: Partial<ServerRepository> = {}): BitbucketRepository => ({
slug: 'my-repo',
project: { key: 'PROJ' },
archived: false,
...overrides,
} as ServerRepository);

const baseConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'cloud',
};

describe('cloudShouldExcludeRepo', () => {
test('returns false when no exclusions are configured', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), baseConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/*'] },
})).toBe(true);
});

test('returns true when repo matches a workspace-level glob in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/**'] },
})).toBe(true);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: false },
})).toBe(false);
});
});

describe('serverShouldExcludeRepo', () => {
const serverConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'server',
url: 'https://bitbucket.example.com',
};

test('returns false when no exclusions are configured', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), serverConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/*'] },
})).toBe(true);
});

test('returns false when exclude.archived is true but repo is not archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: false }), {
...serverConfig,
exclude: { archived: true },
})).toBe(false);
});

test('returns true when exclude.archived is true and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: true },
})).toBe(true);
});

test('returns false when exclude.archived is false and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: false },
})).toBe(false);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: false },
})).toBe(false);
});
});
7 changes: 4 additions & 3 deletions packages/backend/src/bitbucket.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -345,10 +345,11 @@ async function cloudGetRepos(client: BitbucketClient, repoList: string[]): Promi
};
}

function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const cloudRepo = repo as CloudRepository;
let reason = '';
const repoName = cloudRepo.full_name!;
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
const repoName = `${workspace}/${cloudRepo.project?.key}/${repoSlug}`;
Comment thread
brendan-kellam marked this conversation as resolved.

const shouldExclude = (() => {
if (config.exclude?.repos) {
Expand DownExpand Up@@ -552,7 +553,7 @@ async function serverGetRepos(client: BitbucketClient, repoList: string[]): Prom
};
}

function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const serverRepo = repo as ServerRepository;

const projectName = serverRepo.project!.key;
Expand Down
13 changes: 12 additions & 1 deletion packages/backend/src/repoCompileUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -454,7 +454,18 @@ export const compileBitbucketConfig = async (
const repos = bitbucketRepos.map((repo) => {
const isServer = config.deploymentType === 'server';
const codeHostType: CodeHostType = isServer ? 'bitbucketServer' : 'bitbucketCloud';
const displayName = isServer ? (repo as BitbucketServerRepository).name! : (repo as BitbucketCloudRepository).full_name!;
const displayName = (() => {
if (isServer) {
const serverRepo = repo as BitbucketServerRepository;
// Server repos are of the format `project/repo`
return `${serverRepo.project!.key}/${serverRepo.slug!}`;
} else {
const cloudRepo = repo as BitbucketCloudRepository;
// Cloud repos are of the format `workspace/project/repo`
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
return `${workspace}/${cloudRepo.project?.key!}/${repoSlug}`;
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/bitbucket.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,8 +103,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/connection.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -780,8 +780,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/index.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1195,8 +1195,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions schemas/v3/bitbucket.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,8 +72,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- Fixed Bitbucket Server and Cloud repo identifiers to include the project key, preventing collisions across projects. **Note:** Bitbucket Cloud users with `exclude.repos` patterns must update them from `workspace/repo` to `workspace/PROJECT_KEY/repo` format. [#904](https://github.com/sourcebot-dev/sourcebot/pull/904)

### Added
- Added optional `visibility` parameter to `/api/chat/blocking` endpoint and MCP `ask_codebase` tool to allow controlling chat session visibility in shared environments. [#903](https://github.com/sourcebot-dev/sourcebot/pull/903)

Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/bitbucket.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,8 +104,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/connection.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -781,8 +781,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/index.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -1196,8 +1196,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
173 changes: 173 additions & 0 deletions packages/backend/src/bitbucket.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { expect, test, describe } from 'vitest';
import { cloudShouldExcludeRepo, serverShouldExcludeRepo, BitbucketRepository } from './bitbucket';
import { BitbucketConnectionConfig } from '@sourcebot/schemas/v3/bitbucket.type';
import { SchemaRepository as CloudRepository } from '@coderabbitai/bitbucket/cloud/openapi';
import { SchemaRestRepository as ServerRepository } from '@coderabbitai/bitbucket/server/openapi';

const makeCloudRepo = (overrides: Partial<CloudRepository> = {}): BitbucketRepository => ({
type: 'repository',
full_name: 'myworkspace/my-repo',
project: { type: 'project', key: 'PROJ' },
is_private: false,
...overrides,
} as CloudRepository);

const makeServerRepo = (overrides: Partial<ServerRepository> = {}): BitbucketRepository => ({
slug: 'my-repo',
project: { key: 'PROJ' },
archived: false,
...overrides,
} as ServerRepository);

const baseConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'cloud',
};

describe('cloudShouldExcludeRepo', () => {
test('returns false when no exclusions are configured', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), baseConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/*'] },
})).toBe(true);
});

test('returns true when repo matches a workspace-level glob in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/**'] },
})).toBe(true);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: false },
})).toBe(false);
});
});

describe('serverShouldExcludeRepo', () => {
const serverConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'server',
url: 'https://bitbucket.example.com',
};

test('returns false when no exclusions are configured', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), serverConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/*'] },
})).toBe(true);
});

test('returns false when exclude.archived is true but repo is not archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: false }), {
...serverConfig,
exclude: { archived: true },
})).toBe(false);
});

test('returns true when exclude.archived is true and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: true },
})).toBe(true);
});

test('returns false when exclude.archived is false and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: false },
})).toBe(false);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: false },
})).toBe(false);
});
});
7 changes: 4 additions & 3 deletions packages/backend/src/bitbucket.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -345,10 +345,11 @@ async function cloudGetRepos(client: BitbucketClient, repoList: string[]): Promi
};
}

function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const cloudRepo = repo as CloudRepository;
let reason = '';
const repoName = cloudRepo.full_name!;
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
const repoName = `${workspace}/${cloudRepo.project?.key}/${repoSlug}`;
Comment thread
brendan-kellam marked this conversation as resolved.

const shouldExclude = (() => {
if (config.exclude?.repos) {
Expand DownExpand Up@@ -552,7 +553,7 @@ async function serverGetRepos(client: BitbucketClient, repoList: string[]): Prom
};
}

function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const serverRepo = repo as ServerRepository;

const projectName = serverRepo.project!.key;
Expand Down
13 changes: 12 additions & 1 deletion packages/backend/src/repoCompileUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -454,7 +454,18 @@ export const compileBitbucketConfig = async (
const repos = bitbucketRepos.map((repo) => {
const isServer = config.deploymentType === 'server';
const codeHostType: CodeHostType = isServer ? 'bitbucketServer' : 'bitbucketCloud';
const displayName = isServer ? (repo as BitbucketServerRepository).name! : (repo as BitbucketCloudRepository).full_name!;
const displayName = (() => {
if (isServer) {
const serverRepo = repo as BitbucketServerRepository;
// Server repos are of the format `project/repo`
return `${serverRepo.project!.key}/${serverRepo.slug!}`;
} else {
const cloudRepo = repo as BitbucketCloudRepository;
// Cloud repos are of the format `workspace/project/repo`
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
return `${workspace}/${cloudRepo.project?.key!}/${repoSlug}`;
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/bitbucket.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,8 +103,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/connection.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -780,8 +780,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/index.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1195,8 +1195,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions schemas/v3/bitbucket.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,8 +72,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- Fixed Bitbucket Server and Cloud repo identifiers to include the project key, preventing collisions across projects. **Note:** Bitbucket Cloud users with `exclude.repos` patterns must update them from `workspace/repo` to `workspace/PROJECT_KEY/repo` format. [#904](https://github.com/sourcebot-dev/sourcebot/pull/904)

### Added
- Added optional `visibility` parameter to `/api/chat/blocking` endpoint and MCP `ask_codebase` tool to allow controlling chat session visibility in shared environments. [#903](https://github.com/sourcebot-dev/sourcebot/pull/903)

Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/bitbucket.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,8 +104,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/connection.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -781,8 +781,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/index.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -1196,8 +1196,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
173 changes: 173 additions & 0 deletions packages/backend/src/bitbucket.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { expect, test, describe } from 'vitest';
import { cloudShouldExcludeRepo, serverShouldExcludeRepo, BitbucketRepository } from './bitbucket';
import { BitbucketConnectionConfig } from '@sourcebot/schemas/v3/bitbucket.type';
import { SchemaRepository as CloudRepository } from '@coderabbitai/bitbucket/cloud/openapi';
import { SchemaRestRepository as ServerRepository } from '@coderabbitai/bitbucket/server/openapi';

const makeCloudRepo = (overrides: Partial<CloudRepository> = {}): BitbucketRepository => ({
type: 'repository',
full_name: 'myworkspace/my-repo',
project: { type: 'project', key: 'PROJ' },
is_private: false,
...overrides,
} as CloudRepository);

const makeServerRepo = (overrides: Partial<ServerRepository> = {}): BitbucketRepository => ({
slug: 'my-repo',
project: { key: 'PROJ' },
archived: false,
...overrides,
} as ServerRepository);

const baseConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'cloud',
};

describe('cloudShouldExcludeRepo', () => {
test('returns false when no exclusions are configured', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), baseConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/*'] },
})).toBe(true);
});

test('returns true when repo matches a workspace-level glob in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/**'] },
})).toBe(true);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: false },
})).toBe(false);
});
});

describe('serverShouldExcludeRepo', () => {
const serverConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'server',
url: 'https://bitbucket.example.com',
};

test('returns false when no exclusions are configured', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), serverConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/*'] },
})).toBe(true);
});

test('returns false when exclude.archived is true but repo is not archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: false }), {
...serverConfig,
exclude: { archived: true },
})).toBe(false);
});

test('returns true when exclude.archived is true and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: true },
})).toBe(true);
});

test('returns false when exclude.archived is false and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: false },
})).toBe(false);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: false },
})).toBe(false);
});
});
7 changes: 4 additions & 3 deletions packages/backend/src/bitbucket.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -345,10 +345,11 @@ async function cloudGetRepos(client: BitbucketClient, repoList: string[]): Promi
};
}

function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const cloudRepo = repo as CloudRepository;
let reason = '';
const repoName = cloudRepo.full_name!;
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
const repoName = `${workspace}/${cloudRepo.project?.key}/${repoSlug}`;
Comment thread
brendan-kellam marked this conversation as resolved.

const shouldExclude = (() => {
if (config.exclude?.repos) {
Expand DownExpand Up@@ -552,7 +553,7 @@ async function serverGetRepos(client: BitbucketClient, repoList: string[]): Prom
};
}

function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const serverRepo = repo as ServerRepository;

const projectName = serverRepo.project!.key;
Expand Down
13 changes: 12 additions & 1 deletion packages/backend/src/repoCompileUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -454,7 +454,18 @@ export const compileBitbucketConfig = async (
const repos = bitbucketRepos.map((repo) => {
const isServer = config.deploymentType === 'server';
const codeHostType: CodeHostType = isServer ? 'bitbucketServer' : 'bitbucketCloud';
const displayName = isServer ? (repo as BitbucketServerRepository).name! : (repo as BitbucketCloudRepository).full_name!;
const displayName = (() => {
if (isServer) {
const serverRepo = repo as BitbucketServerRepository;
// Server repos are of the format `project/repo`
return `${serverRepo.project!.key}/${serverRepo.slug!}`;
} else {
const cloudRepo = repo as BitbucketCloudRepository;
// Cloud repos are of the format `workspace/project/repo`
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
return `${workspace}/${cloudRepo.project?.key!}/${repoSlug}`;
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/bitbucket.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,8 +103,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/connection.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -780,8 +780,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/index.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1195,8 +1195,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions schemas/v3/bitbucket.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,8 +72,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- Fixed Bitbucket Server and Cloud repo identifiers to include the project key, preventing collisions across projects. **Note:** Bitbucket Cloud users with `exclude.repos` patterns must update them from `workspace/repo` to `workspace/PROJECT_KEY/repo` format. [#904](https://github.com/sourcebot-dev/sourcebot/pull/904)

### Added
- Added optional `visibility` parameter to `/api/chat/blocking` endpoint and MCP `ask_codebase` tool to allow controlling chat session visibility in shared environments. [#903](https://github.com/sourcebot-dev/sourcebot/pull/903)

Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/bitbucket.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,8 +104,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/connection.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -781,8 +781,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/index.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -1196,8 +1196,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
173 changes: 173 additions & 0 deletions packages/backend/src/bitbucket.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { expect, test, describe } from 'vitest';
import { cloudShouldExcludeRepo, serverShouldExcludeRepo, BitbucketRepository } from './bitbucket';
import { BitbucketConnectionConfig } from '@sourcebot/schemas/v3/bitbucket.type';
import { SchemaRepository as CloudRepository } from '@coderabbitai/bitbucket/cloud/openapi';
import { SchemaRestRepository as ServerRepository } from '@coderabbitai/bitbucket/server/openapi';

const makeCloudRepo = (overrides: Partial<CloudRepository> = {}): BitbucketRepository => ({
type: 'repository',
full_name: 'myworkspace/my-repo',
project: { type: 'project', key: 'PROJ' },
is_private: false,
...overrides,
} as CloudRepository);

const makeServerRepo = (overrides: Partial<ServerRepository> = {}): BitbucketRepository => ({
slug: 'my-repo',
project: { key: 'PROJ' },
archived: false,
...overrides,
} as ServerRepository);

const baseConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'cloud',
};

describe('cloudShouldExcludeRepo', () => {
test('returns false when no exclusions are configured', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), baseConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/*'] },
})).toBe(true);
});

test('returns true when repo matches a workspace-level glob in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/**'] },
})).toBe(true);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: false },
})).toBe(false);
});
});

describe('serverShouldExcludeRepo', () => {
const serverConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'server',
url: 'https://bitbucket.example.com',
};

test('returns false when no exclusions are configured', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), serverConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/*'] },
})).toBe(true);
});

test('returns false when exclude.archived is true but repo is not archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: false }), {
...serverConfig,
exclude: { archived: true },
})).toBe(false);
});

test('returns true when exclude.archived is true and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: true },
})).toBe(true);
});

test('returns false when exclude.archived is false and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: false },
})).toBe(false);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: false },
})).toBe(false);
});
});
7 changes: 4 additions & 3 deletions packages/backend/src/bitbucket.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -345,10 +345,11 @@ async function cloudGetRepos(client: BitbucketClient, repoList: string[]): Promi
};
}

function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const cloudRepo = repo as CloudRepository;
let reason = '';
const repoName = cloudRepo.full_name!;
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
const repoName = `${workspace}/${cloudRepo.project?.key}/${repoSlug}`;
Comment thread
brendan-kellam marked this conversation as resolved.

const shouldExclude = (() => {
if (config.exclude?.repos) {
Expand DownExpand Up@@ -552,7 +553,7 @@ async function serverGetRepos(client: BitbucketClient, repoList: string[]): Prom
};
}

function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const serverRepo = repo as ServerRepository;

const projectName = serverRepo.project!.key;
Expand Down
13 changes: 12 additions & 1 deletion packages/backend/src/repoCompileUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -454,7 +454,18 @@ export const compileBitbucketConfig = async (
const repos = bitbucketRepos.map((repo) => {
const isServer = config.deploymentType === 'server';
const codeHostType: CodeHostType = isServer ? 'bitbucketServer' : 'bitbucketCloud';
const displayName = isServer ? (repo as BitbucketServerRepository).name! : (repo as BitbucketCloudRepository).full_name!;
const displayName = (() => {
if (isServer) {
const serverRepo = repo as BitbucketServerRepository;
// Server repos are of the format `project/repo`
return `${serverRepo.project!.key}/${serverRepo.slug!}`;
} else {
const cloudRepo = repo as BitbucketCloudRepository;
// Cloud repos are of the format `workspace/project/repo`
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
return `${workspace}/${cloudRepo.project?.key!}/${repoSlug}`;
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/bitbucket.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,8 +103,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/connection.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -780,8 +780,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/index.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1195,8 +1195,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions schemas/v3/bitbucket.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,8 +72,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- Fixed Bitbucket Server and Cloud repo identifiers to include the project key, preventing collisions across projects. **Note:** Bitbucket Cloud users with `exclude.repos` patterns must update them from `workspace/repo` to `workspace/PROJECT_KEY/repo` format. [#904](https://github.com/sourcebot-dev/sourcebot/pull/904)

### Added
- Added optional `visibility` parameter to `/api/chat/blocking` endpoint and MCP `ask_codebase` tool to allow controlling chat session visibility in shared environments. [#903](https://github.com/sourcebot-dev/sourcebot/pull/903)

Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/bitbucket.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,8 +104,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/connection.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -781,8 +781,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/index.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -1196,8 +1196,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
173 changes: 173 additions & 0 deletions packages/backend/src/bitbucket.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { expect, test, describe } from 'vitest';
import { cloudShouldExcludeRepo, serverShouldExcludeRepo, BitbucketRepository } from './bitbucket';
import { BitbucketConnectionConfig } from '@sourcebot/schemas/v3/bitbucket.type';
import { SchemaRepository as CloudRepository } from '@coderabbitai/bitbucket/cloud/openapi';
import { SchemaRestRepository as ServerRepository } from '@coderabbitai/bitbucket/server/openapi';

const makeCloudRepo = (overrides: Partial<CloudRepository> = {}): BitbucketRepository => ({
type: 'repository',
full_name: 'myworkspace/my-repo',
project: { type: 'project', key: 'PROJ' },
is_private: false,
...overrides,
} as CloudRepository);

const makeServerRepo = (overrides: Partial<ServerRepository> = {}): BitbucketRepository => ({
slug: 'my-repo',
project: { key: 'PROJ' },
archived: false,
...overrides,
} as ServerRepository);

const baseConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'cloud',
};

describe('cloudShouldExcludeRepo', () => {
test('returns false when no exclusions are configured', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), baseConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/*'] },
})).toBe(true);
});

test('returns true when repo matches a workspace-level glob in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/**'] },
})).toBe(true);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: false },
})).toBe(false);
});
});

describe('serverShouldExcludeRepo', () => {
const serverConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'server',
url: 'https://bitbucket.example.com',
};

test('returns false when no exclusions are configured', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), serverConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/*'] },
})).toBe(true);
});

test('returns false when exclude.archived is true but repo is not archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: false }), {
...serverConfig,
exclude: { archived: true },
})).toBe(false);
});

test('returns true when exclude.archived is true and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: true },
})).toBe(true);
});

test('returns false when exclude.archived is false and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: false },
})).toBe(false);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: false },
})).toBe(false);
});
});
7 changes: 4 additions & 3 deletions packages/backend/src/bitbucket.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -345,10 +345,11 @@ async function cloudGetRepos(client: BitbucketClient, repoList: string[]): Promi
};
}

function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const cloudRepo = repo as CloudRepository;
let reason = '';
const repoName = cloudRepo.full_name!;
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
const repoName = `${workspace}/${cloudRepo.project?.key}/${repoSlug}`;
Comment thread
brendan-kellam marked this conversation as resolved.

const shouldExclude = (() => {
if (config.exclude?.repos) {
Expand DownExpand Up@@ -552,7 +553,7 @@ async function serverGetRepos(client: BitbucketClient, repoList: string[]): Prom
};
}

function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const serverRepo = repo as ServerRepository;

const projectName = serverRepo.project!.key;
Expand Down
13 changes: 12 additions & 1 deletion packages/backend/src/repoCompileUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -454,7 +454,18 @@ export const compileBitbucketConfig = async (
const repos = bitbucketRepos.map((repo) => {
const isServer = config.deploymentType === 'server';
const codeHostType: CodeHostType = isServer ? 'bitbucketServer' : 'bitbucketCloud';
const displayName = isServer ? (repo as BitbucketServerRepository).name! : (repo as BitbucketCloudRepository).full_name!;
const displayName = (() => {
if (isServer) {
const serverRepo = repo as BitbucketServerRepository;
// Server repos are of the format `project/repo`
return `${serverRepo.project!.key}/${serverRepo.slug!}`;
} else {
const cloudRepo = repo as BitbucketCloudRepository;
// Cloud repos are of the format `workspace/project/repo`
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
return `${workspace}/${cloudRepo.project?.key!}/${repoSlug}`;
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/bitbucket.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,8 +103,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/connection.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -780,8 +780,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/index.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1195,8 +1195,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions schemas/v3/bitbucket.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,8 +72,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- Fixed Bitbucket Server and Cloud repo identifiers to include the project key, preventing collisions across projects. **Note:** Bitbucket Cloud users with `exclude.repos` patterns must update them from `workspace/repo` to `workspace/PROJECT_KEY/repo` format. [#904](https://github.com/sourcebot-dev/sourcebot/pull/904)

### Added
- Added optional `visibility` parameter to `/api/chat/blocking` endpoint and MCP `ask_codebase` tool to allow controlling chat session visibility in shared environments. [#903](https://github.com/sourcebot-dev/sourcebot/pull/903)

Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/bitbucket.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,8 +104,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/connection.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -781,8 +781,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/index.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -1196,8 +1196,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
173 changes: 173 additions & 0 deletions packages/backend/src/bitbucket.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { expect, test, describe } from 'vitest';
import { cloudShouldExcludeRepo, serverShouldExcludeRepo, BitbucketRepository } from './bitbucket';
import { BitbucketConnectionConfig } from '@sourcebot/schemas/v3/bitbucket.type';
import { SchemaRepository as CloudRepository } from '@coderabbitai/bitbucket/cloud/openapi';
import { SchemaRestRepository as ServerRepository } from '@coderabbitai/bitbucket/server/openapi';

const makeCloudRepo = (overrides: Partial<CloudRepository> = {}): BitbucketRepository => ({
type: 'repository',
full_name: 'myworkspace/my-repo',
project: { type: 'project', key: 'PROJ' },
is_private: false,
...overrides,
} as CloudRepository);

const makeServerRepo = (overrides: Partial<ServerRepository> = {}): BitbucketRepository => ({
slug: 'my-repo',
project: { key: 'PROJ' },
archived: false,
...overrides,
} as ServerRepository);

const baseConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'cloud',
};

describe('cloudShouldExcludeRepo', () => {
test('returns false when no exclusions are configured', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), baseConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/*'] },
})).toBe(true);
});

test('returns true when repo matches a workspace-level glob in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/**'] },
})).toBe(true);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: false },
})).toBe(false);
});
});

describe('serverShouldExcludeRepo', () => {
const serverConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'server',
url: 'https://bitbucket.example.com',
};

test('returns false when no exclusions are configured', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), serverConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/*'] },
})).toBe(true);
});

test('returns false when exclude.archived is true but repo is not archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: false }), {
...serverConfig,
exclude: { archived: true },
})).toBe(false);
});

test('returns true when exclude.archived is true and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: true },
})).toBe(true);
});

test('returns false when exclude.archived is false and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: false },
})).toBe(false);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: false },
})).toBe(false);
});
});
7 changes: 4 additions & 3 deletions packages/backend/src/bitbucket.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -345,10 +345,11 @@ async function cloudGetRepos(client: BitbucketClient, repoList: string[]): Promi
};
}

function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const cloudRepo = repo as CloudRepository;
let reason = '';
const repoName = cloudRepo.full_name!;
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
const repoName = `${workspace}/${cloudRepo.project?.key}/${repoSlug}`;
Comment thread
brendan-kellam marked this conversation as resolved.

const shouldExclude = (() => {
if (config.exclude?.repos) {
Expand DownExpand Up@@ -552,7 +553,7 @@ async function serverGetRepos(client: BitbucketClient, repoList: string[]): Prom
};
}

function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const serverRepo = repo as ServerRepository;

const projectName = serverRepo.project!.key;
Expand Down
13 changes: 12 additions & 1 deletion packages/backend/src/repoCompileUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -454,7 +454,18 @@ export const compileBitbucketConfig = async (
const repos = bitbucketRepos.map((repo) => {
const isServer = config.deploymentType === 'server';
const codeHostType: CodeHostType = isServer ? 'bitbucketServer' : 'bitbucketCloud';
const displayName = isServer ? (repo as BitbucketServerRepository).name! : (repo as BitbucketCloudRepository).full_name!;
const displayName = (() => {
if (isServer) {
const serverRepo = repo as BitbucketServerRepository;
// Server repos are of the format `project/repo`
return `${serverRepo.project!.key}/${serverRepo.slug!}`;
} else {
const cloudRepo = repo as BitbucketCloudRepository;
// Cloud repos are of the format `workspace/project/repo`
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
return `${workspace}/${cloudRepo.project?.key!}/${repoSlug}`;
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/bitbucket.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,8 +103,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/connection.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -780,8 +780,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/index.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1195,8 +1195,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions schemas/v3/bitbucket.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,8 +72,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed
- Fixed Bitbucket Server and Cloud repo identifiers to include the project key, preventing collisions across projects. **Note:** Bitbucket Cloud users with `exclude.repos` patterns must update them from `workspace/repo` to `workspace/PROJECT_KEY/repo` format. [#904](https://github.com/sourcebot-dev/sourcebot/pull/904)

### Added
- Added optional `visibility` parameter to `/api/chat/blocking` endpoint and MCP `ask_codebase` tool to allow controlling chat session visibility in shared environments. [#903](https://github.com/sourcebot-dev/sourcebot/pull/903)

Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/bitbucket.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -104,8 +104,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/connection.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -781,8 +781,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions docs/snippets/schemas/v3/index.schema.mdx
Original file line numberDiff line numberDiff line change
Expand Up@@ -1196,8 +1196,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
173 changes: 173 additions & 0 deletions packages/backend/src/bitbucket.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { expect, test, describe } from 'vitest';
import { cloudShouldExcludeRepo, serverShouldExcludeRepo, BitbucketRepository } from './bitbucket';
import { BitbucketConnectionConfig } from '@sourcebot/schemas/v3/bitbucket.type';
import { SchemaRepository as CloudRepository } from '@coderabbitai/bitbucket/cloud/openapi';
import { SchemaRestRepository as ServerRepository } from '@coderabbitai/bitbucket/server/openapi';

const makeCloudRepo = (overrides: Partial<CloudRepository> = {}): BitbucketRepository => ({
type: 'repository',
full_name: 'myworkspace/my-repo',
project: { type: 'project', key: 'PROJ' },
is_private: false,
...overrides,
} as CloudRepository);

const makeServerRepo = (overrides: Partial<ServerRepository> = {}): BitbucketRepository => ({
slug: 'my-repo',
project: { key: 'PROJ' },
archived: false,
...overrides,
} as ServerRepository);

const baseConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'cloud',
};

describe('cloudShouldExcludeRepo', () => {
test('returns false when no exclusions are configured', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), baseConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/PROJ/*'] },
})).toBe(true);
});

test('returns true when repo matches a workspace-level glob in exclude.repos', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { repos: ['myworkspace/**'] },
})).toBe(true);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(cloudShouldExcludeRepo(makeCloudRepo(), {
...baseConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeCloudRepo({ parent: { type: 'repository' } as CloudRepository });
expect(cloudShouldExcludeRepo(forkedRepo, {
...baseConfig,
exclude: { forks: false },
})).toBe(false);
});
});

describe('serverShouldExcludeRepo', () => {
const serverConfig: BitbucketConnectionConfig = {
type: 'bitbucket',
deploymentType: 'server',
url: 'https://bitbucket.example.com',
};

test('returns false when no exclusions are configured', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), serverConfig)).toBe(false);
});

test('returns false when exclude.repos is empty', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: [] },
})).toBe(false);
});

test('returns true when repo matches exclude.repos exactly', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/my-repo'] },
})).toBe(true);
});

test('returns false when exclude.repos does not match', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/other-repo'] },
})).toBe(false);
});

test('returns true when repo matches a glob pattern in exclude.repos', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { repos: ['PROJ/*'] },
})).toBe(true);
});

test('returns false when exclude.archived is true but repo is not archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: false }), {
...serverConfig,
exclude: { archived: true },
})).toBe(false);
});

test('returns true when exclude.archived is true and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: true },
})).toBe(true);
});

test('returns false when exclude.archived is false and repo is archived', () => {
expect(serverShouldExcludeRepo(makeServerRepo({ archived: true }), {
...serverConfig,
exclude: { archived: false },
})).toBe(false);
});

test('returns false when exclude.forks is true but repo is not a fork', () => {
expect(serverShouldExcludeRepo(makeServerRepo(), {
...serverConfig,
exclude: { forks: true },
})).toBe(false);
});

test('returns true when exclude.forks is true and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: true },
})).toBe(true);
});

test('returns false when exclude.forks is false and repo is a fork', () => {
const forkedRepo = makeServerRepo({ origin: { slug: 'original-repo' } as ServerRepository });
expect(serverShouldExcludeRepo(forkedRepo, {
...serverConfig,
exclude: { forks: false },
})).toBe(false);
});
});
7 changes: 4 additions & 3 deletions packages/backend/src/bitbucket.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -345,10 +345,11 @@ async function cloudGetRepos(client: BitbucketClient, repoList: string[]): Promi
};
}

function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function cloudShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const cloudRepo = repo as CloudRepository;
let reason = '';
const repoName = cloudRepo.full_name!;
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
const repoName = `${workspace}/${cloudRepo.project?.key}/${repoSlug}`;
Comment thread
brendan-kellam marked this conversation as resolved.

const shouldExclude = (() => {
if (config.exclude?.repos) {
Expand DownExpand Up@@ -552,7 +553,7 @@ async function serverGetRepos(client: BitbucketClient, repoList: string[]): Prom
};
}

function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
export function serverShouldExcludeRepo(repo: BitbucketRepository, config: BitbucketConnectionConfig): boolean {
const serverRepo = repo as ServerRepository;

const projectName = serverRepo.project!.key;
Expand Down
13 changes: 12 additions & 1 deletion packages/backend/src/repoCompileUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -454,7 +454,18 @@ export const compileBitbucketConfig = async (
const repos = bitbucketRepos.map((repo) => {
const isServer = config.deploymentType === 'server';
const codeHostType: CodeHostType = isServer ? 'bitbucketServer' : 'bitbucketCloud';
const displayName = isServer ? (repo as BitbucketServerRepository).name! : (repo as BitbucketCloudRepository).full_name!;
const displayName = (() => {
if (isServer) {
const serverRepo = repo as BitbucketServerRepository;
// Server repos are of the format `project/repo`
return `${serverRepo.project!.key}/${serverRepo.slug!}`;
} else {
const cloudRepo = repo as BitbucketCloudRepository;
// Cloud repos are of the format `workspace/project/repo`
const [workspace, repoSlug] = cloudRepo.full_name!.split('/');
return `${workspace}/${cloudRepo.project?.key!}/${repoSlug}`;
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/bitbucket.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,8 +103,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/connection.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -780,8 +780,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions packages/schemas/src/v3/index.schema.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1195,8 +1195,8 @@ const schema = {
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down
4 changes: 2 additions & 2 deletions schemas/v3/bitbucket.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,8 +72,8 @@
},
"examples": [
[
"cloud_workspace/repo1",
"server_project/repo2"
"cloud_workspace/PROJECT_KEY/repo1",
"SERVER_PROJECT_KEY/repo2"
]
],
"description": "List of specific repos to exclude from syncing."
Expand Down