feat(backend): skip getCommitHashForRefName for empty repos

[brendan-kellam]

Summary

• Adds isRepoEmpty utility to git.ts that detects repositories with no commits using git log --all -1 --format=%H
• Uses isRepoEmpty in repoIndexManager.ts to skip calling getCommitHashForRefName for empty repos, avoiding noisy debug log output

Test plan

• Index a repository that has no commits and verify no debug error is logged for getCommitHashForRefName
• Index a normal repository and verify indexedCommitHash is still set correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Reduced noisy debug output when processing empty repositories by skipping unnecessary operations.

[coderabbitai]

Walkthrough

The PR adds a check to prevent unnecessary log noise from empty repositories. A new isRepoEmpty utility function is introduced to detect repositories without commits, and repoIndexManager conditionally computes commit hash only when the repository is non-empty.

Changes

Cohort / File(s)	Summary
Documentation CHANGELOG.md	Adds changelog entry documenting the fix to skip getCommitHashForRefName for empty repositories, referencing PR #914.
Git Utilities packages/backend/src/git.ts	Exports new isRepoEmpty() function that runs git log --all -1 --format=%H to determine if a repository has commits, returning true when no commits exist or the command fails.
Core Logic packages/backend/src/repoIndexManager.ts	Imports isRepoEmpty and adds conditional logic to compute commitHash only for non-empty repositories; commits in empty repos result in undefined commitHash.
Test Mocks packages/backend/src/repoIndexManager.test.ts	Adds mock implementation for isRepoEmpty in the git module mock used by tests, returning false.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• chore(worker): Migrate off of groupmq #860: Modifies packages/backend/src/repoIndexManager.ts with changes to job completion logic and commit-hash handling, overlapping with this PR's scope.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately and concisely summarizes the main change: adding a check to skip calling getCommitHashForRefName for empty repositories to reduce noisy logs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch brendan/skip-commit-hash-for-empty-repos

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[brendan-kellam]

@claude please fix the failing test

[claude]

Claude finished @brendan-kellam's task in 1m 24s —— View job

---

Fixed failing test

• Identify failing test from CI
• Read relevant source and test files
• Fix the failing test
• Commit and push changes

Root cause: The ./git.js mock in repoIndexManager.test.ts was missing isRepoEmpty. When onJobCompleted called isRepoEmpty(...), it was undefined, throwing a TypeError. The try-catch in onJobCompleted silently swallowed the error, so this.db.repo.update was never called — causing the assertion at line 449 to fail with 0 calls.

Fix: Added isRepoEmpty: vi.fn().mockResolvedValue(false) to the ./git.js mock in repoIndexManager.test.ts (returning false = repo is not empty, so commitHash is still populated from getCommitHashForRefName).

Commit: 0d5cad3

[coderabbitai]

🧹 Nitpick comments (1)

packages/backend/src/repoIndexManager.test.ts (1)

51-51: Mock looks correct for existing tests.

Mocking isRepoEmpty to return false preserves the existing behavior where getCommitHashForRefName is called and returns 'abc123'. Consider adding a test case where isRepoEmpty returns true to verify that indexedCommitHash is undefined for empty repos—this would directly cover the new feature's happy path.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.
In `@packages/backend/src/repoIndexManager.test.ts` at line 51, Add a new unit
test in repoIndexManager.test.ts that stubs isRepoEmpty to resolve true and
ensures getCommitHashForRefName is not relied upon and the resulting
indexedCommitHash is undefined; specifically, mock isRepoEmpty
(vi.fn().mockResolvedValue(true)), call the same flow that currently uses
getCommitHashForRefName, and assert indexedCommitHash === undefined and that
getCommitHashForRefName was not used (or not called) to cover the empty-repo
happy path.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/backend/src/repoIndexManager.test.ts`:
- Line 51: Add a new unit test in repoIndexManager.test.ts that stubs
isRepoEmpty to resolve true and ensures getCommitHashForRefName is not relied
upon and the resulting indexedCommitHash is undefined; specifically, mock
isRepoEmpty (vi.fn().mockResolvedValue(true)), call the same flow that currently
uses getCommitHashForRefName, and assert indexedCommitHash === undefined and
that getCommitHashForRefName was not used (or not called) to cover the
empty-repo happy path.

[brendan-kellam]

Summary

• Adds isRepoEmpty utility to git.ts that detects repositories with no commits using git log --all -1 --format=%H
• Uses isRepoEmpty in repoIndexManager.ts to skip calling getCommitHashForRefName for empty repos, avoiding noisy debug log output

Test plan

• Index a repository that has no commits and verify no debug error is logged for getCommitHashForRefName
• Index a normal repository and verify indexedCommitHash is still set correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Reduced noisy debug output when processing empty repositories by skipping unnecessary operations.

[coderabbitai]

Walkthrough

The PR adds a check to prevent unnecessary log noise from empty repositories. A new isRepoEmpty utility function is introduced to detect repositories without commits, and repoIndexManager conditionally computes commit hash only when the repository is non-empty.

Changes

Cohort / File(s)	Summary
Documentation CHANGELOG.md	Adds changelog entry documenting the fix to skip getCommitHashForRefName for empty repositories, referencing PR #914.
Git Utilities packages/backend/src/git.ts	Exports new isRepoEmpty() function that runs git log --all -1 --format=%H to determine if a repository has commits, returning true when no commits exist or the command fails.
Core Logic packages/backend/src/repoIndexManager.ts	Imports isRepoEmpty and adds conditional logic to compute commitHash only for non-empty repositories; commits in empty repos result in undefined commitHash.
Test Mocks packages/backend/src/repoIndexManager.test.ts	Adds mock implementation for isRepoEmpty in the git module mock used by tests, returning false.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• chore(worker): Migrate off of groupmq #860: Modifies packages/backend/src/repoIndexManager.ts with changes to job completion logic and commit-hash handling, overlapping with this PR's scope.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately and concisely summarizes the main change: adding a check to skip calling getCommitHashForRefName for empty repositories to reduce noisy logs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch brendan/skip-commit-hash-for-empty-repos

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[brendan-kellam]

@claude please fix the failing test

[claude]

Claude finished @brendan-kellam's task in 1m 24s —— View job

---

Fixed failing test

• Identify failing test from CI
• Read relevant source and test files
• Fix the failing test
• Commit and push changes

Root cause: The ./git.js mock in repoIndexManager.test.ts was missing isRepoEmpty. When onJobCompleted called isRepoEmpty(...), it was undefined, throwing a TypeError. The try-catch in onJobCompleted silently swallowed the error, so this.db.repo.update was never called — causing the assertion at line 449 to fail with 0 calls.

Fix: Added isRepoEmpty: vi.fn().mockResolvedValue(false) to the ./git.js mock in repoIndexManager.test.ts (returning false = repo is not empty, so commitHash is still populated from getCommitHashForRefName).

Commit: 0d5cad3

[coderabbitai]

🧹 Nitpick comments (1)

packages/backend/src/repoIndexManager.test.ts (1)

51-51: Mock looks correct for existing tests.

Mocking isRepoEmpty to return false preserves the existing behavior where getCommitHashForRefName is called and returns 'abc123'. Consider adding a test case where isRepoEmpty returns true to verify that indexedCommitHash is undefined for empty repos—this would directly cover the new feature's happy path.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.
In `@packages/backend/src/repoIndexManager.test.ts` at line 51, Add a new unit
test in repoIndexManager.test.ts that stubs isRepoEmpty to resolve true and
ensures getCommitHashForRefName is not relied upon and the resulting
indexedCommitHash is undefined; specifically, mock isRepoEmpty
(vi.fn().mockResolvedValue(true)), call the same flow that currently uses
getCommitHashForRefName, and assert indexedCommitHash === undefined and that
getCommitHashForRefName was not used (or not called) to cover the empty-repo
happy path.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/backend/src/repoIndexManager.test.ts`:
- Line 51: Add a new unit test in repoIndexManager.test.ts that stubs
isRepoEmpty to resolve true and ensures getCommitHashForRefName is not relied
upon and the resulting indexedCommitHash is undefined; specifically, mock
isRepoEmpty (vi.fn().mockResolvedValue(true)), call the same flow that currently
uses getCommitHashForRefName, and assert indexedCommitHash === undefined and
that getCommitHashForRefName was not used (or not called) to cover the
empty-repo happy path.

[brendan-kellam]

Summary

• Adds isRepoEmpty utility to git.ts that detects repositories with no commits using git log --all -1 --format=%H
• Uses isRepoEmpty in repoIndexManager.ts to skip calling getCommitHashForRefName for empty repos, avoiding noisy debug log output

Test plan

• Index a repository that has no commits and verify no debug error is logged for getCommitHashForRefName
• Index a normal repository and verify indexedCommitHash is still set correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Reduced noisy debug output when processing empty repositories by skipping unnecessary operations.

[coderabbitai]

Walkthrough

The PR adds a check to prevent unnecessary log noise from empty repositories. A new isRepoEmpty utility function is introduced to detect repositories without commits, and repoIndexManager conditionally computes commit hash only when the repository is non-empty.

Changes

Cohort / File(s)	Summary
Documentation CHANGELOG.md	Adds changelog entry documenting the fix to skip getCommitHashForRefName for empty repositories, referencing PR #914.
Git Utilities packages/backend/src/git.ts	Exports new isRepoEmpty() function that runs git log --all -1 --format=%H to determine if a repository has commits, returning true when no commits exist or the command fails.
Core Logic packages/backend/src/repoIndexManager.ts	Imports isRepoEmpty and adds conditional logic to compute commitHash only for non-empty repositories; commits in empty repos result in undefined commitHash.
Test Mocks packages/backend/src/repoIndexManager.test.ts	Adds mock implementation for isRepoEmpty in the git module mock used by tests, returning false.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• chore(worker): Migrate off of groupmq #860: Modifies packages/backend/src/repoIndexManager.ts with changes to job completion logic and commit-hash handling, overlapping with this PR's scope.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately and concisely summarizes the main change: adding a check to skip calling getCommitHashForRefName for empty repositories to reduce noisy logs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch brendan/skip-commit-hash-for-empty-repos

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[brendan-kellam]

@claude please fix the failing test

[claude]

Claude finished @brendan-kellam's task in 1m 24s —— View job

---

Fixed failing test

• Identify failing test from CI
• Read relevant source and test files
• Fix the failing test
• Commit and push changes

Root cause: The ./git.js mock in repoIndexManager.test.ts was missing isRepoEmpty. When onJobCompleted called isRepoEmpty(...), it was undefined, throwing a TypeError. The try-catch in onJobCompleted silently swallowed the error, so this.db.repo.update was never called — causing the assertion at line 449 to fail with 0 calls.

Fix: Added isRepoEmpty: vi.fn().mockResolvedValue(false) to the ./git.js mock in repoIndexManager.test.ts (returning false = repo is not empty, so commitHash is still populated from getCommitHashForRefName).

Commit: 0d5cad3

[coderabbitai]

🧹 Nitpick comments (1)

packages/backend/src/repoIndexManager.test.ts (1)

51-51: Mock looks correct for existing tests.

Mocking isRepoEmpty to return false preserves the existing behavior where getCommitHashForRefName is called and returns 'abc123'. Consider adding a test case where isRepoEmpty returns true to verify that indexedCommitHash is undefined for empty repos—this would directly cover the new feature's happy path.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.
In `@packages/backend/src/repoIndexManager.test.ts` at line 51, Add a new unit
test in repoIndexManager.test.ts that stubs isRepoEmpty to resolve true and
ensures getCommitHashForRefName is not relied upon and the resulting
indexedCommitHash is undefined; specifically, mock isRepoEmpty
(vi.fn().mockResolvedValue(true)), call the same flow that currently uses
getCommitHashForRefName, and assert indexedCommitHash === undefined and that
getCommitHashForRefName was not used (or not called) to cover the empty-repo
happy path.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/backend/src/repoIndexManager.test.ts`:
- Line 51: Add a new unit test in repoIndexManager.test.ts that stubs
isRepoEmpty to resolve true and ensures getCommitHashForRefName is not relied
upon and the resulting indexedCommitHash is undefined; specifically, mock
isRepoEmpty (vi.fn().mockResolvedValue(true)), call the same flow that currently
uses getCommitHashForRefName, and assert indexedCommitHash === undefined and
that getCommitHashForRefName was not used (or not called) to cover the
empty-repo happy path.

[brendan-kellam]

Summary

• Adds isRepoEmpty utility to git.ts that detects repositories with no commits using git log --all -1 --format=%H
• Uses isRepoEmpty in repoIndexManager.ts to skip calling getCommitHashForRefName for empty repos, avoiding noisy debug log output

Test plan

• Index a repository that has no commits and verify no debug error is logged for getCommitHashForRefName
• Index a normal repository and verify indexedCommitHash is still set correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Reduced noisy debug output when processing empty repositories by skipping unnecessary operations.

[coderabbitai]

Walkthrough

The PR adds a check to prevent unnecessary log noise from empty repositories. A new isRepoEmpty utility function is introduced to detect repositories without commits, and repoIndexManager conditionally computes commit hash only when the repository is non-empty.

Changes

Cohort / File(s)	Summary
Documentation CHANGELOG.md	Adds changelog entry documenting the fix to skip getCommitHashForRefName for empty repositories, referencing PR #914.
Git Utilities packages/backend/src/git.ts	Exports new isRepoEmpty() function that runs git log --all -1 --format=%H to determine if a repository has commits, returning true when no commits exist or the command fails.
Core Logic packages/backend/src/repoIndexManager.ts	Imports isRepoEmpty and adds conditional logic to compute commitHash only for non-empty repositories; commits in empty repos result in undefined commitHash.
Test Mocks packages/backend/src/repoIndexManager.test.ts	Adds mock implementation for isRepoEmpty in the git module mock used by tests, returning false.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• chore(worker): Migrate off of groupmq #860: Modifies packages/backend/src/repoIndexManager.ts with changes to job completion logic and commit-hash handling, overlapping with this PR's scope.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately and concisely summarizes the main change: adding a check to skip calling getCommitHashForRefName for empty repositories to reduce noisy logs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch brendan/skip-commit-hash-for-empty-repos

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[brendan-kellam]

@claude please fix the failing test

[claude]

Claude finished @brendan-kellam's task in 1m 24s —— View job

---

Fixed failing test

• Identify failing test from CI
• Read relevant source and test files
• Fix the failing test
• Commit and push changes

Root cause: The ./git.js mock in repoIndexManager.test.ts was missing isRepoEmpty. When onJobCompleted called isRepoEmpty(...), it was undefined, throwing a TypeError. The try-catch in onJobCompleted silently swallowed the error, so this.db.repo.update was never called — causing the assertion at line 449 to fail with 0 calls.

Fix: Added isRepoEmpty: vi.fn().mockResolvedValue(false) to the ./git.js mock in repoIndexManager.test.ts (returning false = repo is not empty, so commitHash is still populated from getCommitHashForRefName).

Commit: 0d5cad3

[coderabbitai]

🧹 Nitpick comments (1)

packages/backend/src/repoIndexManager.test.ts (1)

51-51: Mock looks correct for existing tests.

Mocking isRepoEmpty to return false preserves the existing behavior where getCommitHashForRefName is called and returns 'abc123'. Consider adding a test case where isRepoEmpty returns true to verify that indexedCommitHash is undefined for empty repos—this would directly cover the new feature's happy path.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.
In `@packages/backend/src/repoIndexManager.test.ts` at line 51, Add a new unit
test in repoIndexManager.test.ts that stubs isRepoEmpty to resolve true and
ensures getCommitHashForRefName is not relied upon and the resulting
indexedCommitHash is undefined; specifically, mock isRepoEmpty
(vi.fn().mockResolvedValue(true)), call the same flow that currently uses
getCommitHashForRefName, and assert indexedCommitHash === undefined and that
getCommitHashForRefName was not used (or not called) to cover the empty-repo
happy path.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/backend/src/repoIndexManager.test.ts`:
- Line 51: Add a new unit test in repoIndexManager.test.ts that stubs
isRepoEmpty to resolve true and ensures getCommitHashForRefName is not relied
upon and the resulting indexedCommitHash is undefined; specifically, mock
isRepoEmpty (vi.fn().mockResolvedValue(true)), call the same flow that currently
uses getCommitHashForRefName, and assert indexedCommitHash === undefined and
that getCommitHashForRefName was not used (or not called) to cover the
empty-repo happy path.

[brendan-kellam]

Summary

• Adds isRepoEmpty utility to git.ts that detects repositories with no commits using git log --all -1 --format=%H
• Uses isRepoEmpty in repoIndexManager.ts to skip calling getCommitHashForRefName for empty repos, avoiding noisy debug log output

Test plan

• Index a repository that has no commits and verify no debug error is logged for getCommitHashForRefName
• Index a normal repository and verify indexedCommitHash is still set correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Reduced noisy debug output when processing empty repositories by skipping unnecessary operations.

[coderabbitai]

Walkthrough

The PR adds a check to prevent unnecessary log noise from empty repositories. A new isRepoEmpty utility function is introduced to detect repositories without commits, and repoIndexManager conditionally computes commit hash only when the repository is non-empty.

Changes

Cohort / File(s)	Summary
Documentation CHANGELOG.md	Adds changelog entry documenting the fix to skip getCommitHashForRefName for empty repositories, referencing PR #914.
Git Utilities packages/backend/src/git.ts	Exports new isRepoEmpty() function that runs git log --all -1 --format=%H to determine if a repository has commits, returning true when no commits exist or the command fails.
Core Logic packages/backend/src/repoIndexManager.ts	Imports isRepoEmpty and adds conditional logic to compute commitHash only for non-empty repositories; commits in empty repos result in undefined commitHash.
Test Mocks packages/backend/src/repoIndexManager.test.ts	Adds mock implementation for isRepoEmpty in the git module mock used by tests, returning false.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• chore(worker): Migrate off of groupmq #860: Modifies packages/backend/src/repoIndexManager.ts with changes to job completion logic and commit-hash handling, overlapping with this PR's scope.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately and concisely summarizes the main change: adding a check to skip calling getCommitHashForRefName for empty repositories to reduce noisy logs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch brendan/skip-commit-hash-for-empty-repos

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[brendan-kellam]

@claude please fix the failing test

[claude]

Claude finished @brendan-kellam's task in 1m 24s —— View job

---

Fixed failing test

• Identify failing test from CI
• Read relevant source and test files
• Fix the failing test
• Commit and push changes

Root cause: The ./git.js mock in repoIndexManager.test.ts was missing isRepoEmpty. When onJobCompleted called isRepoEmpty(...), it was undefined, throwing a TypeError. The try-catch in onJobCompleted silently swallowed the error, so this.db.repo.update was never called — causing the assertion at line 449 to fail with 0 calls.

Fix: Added isRepoEmpty: vi.fn().mockResolvedValue(false) to the ./git.js mock in repoIndexManager.test.ts (returning false = repo is not empty, so commitHash is still populated from getCommitHashForRefName).

Commit: 0d5cad3

[coderabbitai]

🧹 Nitpick comments (1)

packages/backend/src/repoIndexManager.test.ts (1)

51-51: Mock looks correct for existing tests.

Mocking isRepoEmpty to return false preserves the existing behavior where getCommitHashForRefName is called and returns 'abc123'. Consider adding a test case where isRepoEmpty returns true to verify that indexedCommitHash is undefined for empty repos—this would directly cover the new feature's happy path.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.
In `@packages/backend/src/repoIndexManager.test.ts` at line 51, Add a new unit
test in repoIndexManager.test.ts that stubs isRepoEmpty to resolve true and
ensures getCommitHashForRefName is not relied upon and the resulting
indexedCommitHash is undefined; specifically, mock isRepoEmpty
(vi.fn().mockResolvedValue(true)), call the same flow that currently uses
getCommitHashForRefName, and assert indexedCommitHash === undefined and that
getCommitHashForRefName was not used (or not called) to cover the empty-repo
happy path.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/backend/src/repoIndexManager.test.ts`:
- Line 51: Add a new unit test in repoIndexManager.test.ts that stubs
isRepoEmpty to resolve true and ensures getCommitHashForRefName is not relied
upon and the resulting indexedCommitHash is undefined; specifically, mock
isRepoEmpty (vi.fn().mockResolvedValue(true)), call the same flow that currently
uses getCommitHashForRefName, and assert indexedCommitHash === undefined and
that getCommitHashForRefName was not used (or not called) to cover the
empty-repo happy path.

[brendan-kellam]

Summary

• Adds isRepoEmpty utility to git.ts that detects repositories with no commits using git log --all -1 --format=%H
• Uses isRepoEmpty in repoIndexManager.ts to skip calling getCommitHashForRefName for empty repos, avoiding noisy debug log output

Test plan

• Index a repository that has no commits and verify no debug error is logged for getCommitHashForRefName
• Index a normal repository and verify indexedCommitHash is still set correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Reduced noisy debug output when processing empty repositories by skipping unnecessary operations.

[coderabbitai]

Walkthrough

The PR adds a check to prevent unnecessary log noise from empty repositories. A new isRepoEmpty utility function is introduced to detect repositories without commits, and repoIndexManager conditionally computes commit hash only when the repository is non-empty.

Changes

Cohort / File(s)	Summary
Documentation CHANGELOG.md	Adds changelog entry documenting the fix to skip getCommitHashForRefName for empty repositories, referencing PR #914.
Git Utilities packages/backend/src/git.ts	Exports new isRepoEmpty() function that runs git log --all -1 --format=%H to determine if a repository has commits, returning true when no commits exist or the command fails.
Core Logic packages/backend/src/repoIndexManager.ts	Imports isRepoEmpty and adds conditional logic to compute commitHash only for non-empty repositories; commits in empty repos result in undefined commitHash.
Test Mocks packages/backend/src/repoIndexManager.test.ts	Adds mock implementation for isRepoEmpty in the git module mock used by tests, returning false.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• chore(worker): Migrate off of groupmq #860: Modifies packages/backend/src/repoIndexManager.ts with changes to job completion logic and commit-hash handling, overlapping with this PR's scope.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately and concisely summarizes the main change: adding a check to skip calling getCommitHashForRefName for empty repositories to reduce noisy logs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch brendan/skip-commit-hash-for-empty-repos

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[brendan-kellam]

@claude please fix the failing test

[claude]

Claude finished @brendan-kellam's task in 1m 24s —— View job

---

Fixed failing test

• Identify failing test from CI
• Read relevant source and test files
• Fix the failing test
• Commit and push changes

Root cause: The ./git.js mock in repoIndexManager.test.ts was missing isRepoEmpty. When onJobCompleted called isRepoEmpty(...), it was undefined, throwing a TypeError. The try-catch in onJobCompleted silently swallowed the error, so this.db.repo.update was never called — causing the assertion at line 449 to fail with 0 calls.

Fix: Added isRepoEmpty: vi.fn().mockResolvedValue(false) to the ./git.js mock in repoIndexManager.test.ts (returning false = repo is not empty, so commitHash is still populated from getCommitHashForRefName).

Commit: 0d5cad3

[coderabbitai]

🧹 Nitpick comments (1)

packages/backend/src/repoIndexManager.test.ts (1)

51-51: Mock looks correct for existing tests.

Mocking isRepoEmpty to return false preserves the existing behavior where getCommitHashForRefName is called and returns 'abc123'. Consider adding a test case where isRepoEmpty returns true to verify that indexedCommitHash is undefined for empty repos—this would directly cover the new feature's happy path.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.
In `@packages/backend/src/repoIndexManager.test.ts` at line 51, Add a new unit
test in repoIndexManager.test.ts that stubs isRepoEmpty to resolve true and
ensures getCommitHashForRefName is not relied upon and the resulting
indexedCommitHash is undefined; specifically, mock isRepoEmpty
(vi.fn().mockResolvedValue(true)), call the same flow that currently uses
getCommitHashForRefName, and assert indexedCommitHash === undefined and that
getCommitHashForRefName was not used (or not called) to cover the empty-repo
happy path.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/backend/src/repoIndexManager.test.ts`:
- Line 51: Add a new unit test in repoIndexManager.test.ts that stubs
isRepoEmpty to resolve true and ensures getCommitHashForRefName is not relied
upon and the resulting indexedCommitHash is undefined; specifically, mock
isRepoEmpty (vi.fn().mockResolvedValue(true)), call the same flow that currently
uses getCommitHashForRefName, and assert indexedCommitHash === undefined and
that getCommitHashForRefName was not used (or not called) to cover the
empty-repo happy path.

[brendan-kellam]

Summary

• Adds isRepoEmpty utility to git.ts that detects repositories with no commits using git log --all -1 --format=%H
• Uses isRepoEmpty in repoIndexManager.ts to skip calling getCommitHashForRefName for empty repos, avoiding noisy debug log output

Test plan

• Index a repository that has no commits and verify no debug error is logged for getCommitHashForRefName
• Index a normal repository and verify indexedCommitHash is still set correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Reduced noisy debug output when processing empty repositories by skipping unnecessary operations.

[coderabbitai]

Walkthrough

The PR adds a check to prevent unnecessary log noise from empty repositories. A new isRepoEmpty utility function is introduced to detect repositories without commits, and repoIndexManager conditionally computes commit hash only when the repository is non-empty.

Changes

Cohort / File(s)	Summary
Documentation CHANGELOG.md	Adds changelog entry documenting the fix to skip getCommitHashForRefName for empty repositories, referencing PR #914.
Git Utilities packages/backend/src/git.ts	Exports new isRepoEmpty() function that runs git log --all -1 --format=%H to determine if a repository has commits, returning true when no commits exist or the command fails.
Core Logic packages/backend/src/repoIndexManager.ts	Imports isRepoEmpty and adds conditional logic to compute commitHash only for non-empty repositories; commits in empty repos result in undefined commitHash.
Test Mocks packages/backend/src/repoIndexManager.test.ts	Adds mock implementation for isRepoEmpty in the git module mock used by tests, returning false.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• chore(worker): Migrate off of groupmq #860: Modifies packages/backend/src/repoIndexManager.ts with changes to job completion logic and commit-hash handling, overlapping with this PR's scope.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately and concisely summarizes the main change: adding a check to skip calling getCommitHashForRefName for empty repositories to reduce noisy logs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch brendan/skip-commit-hash-for-empty-repos

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[brendan-kellam]

@claude please fix the failing test

[claude]

Claude finished @brendan-kellam's task in 1m 24s —— View job

---

Fixed failing test

• Identify failing test from CI
• Read relevant source and test files
• Fix the failing test
• Commit and push changes

Root cause: The ./git.js mock in repoIndexManager.test.ts was missing isRepoEmpty. When onJobCompleted called isRepoEmpty(...), it was undefined, throwing a TypeError. The try-catch in onJobCompleted silently swallowed the error, so this.db.repo.update was never called — causing the assertion at line 449 to fail with 0 calls.

Fix: Added isRepoEmpty: vi.fn().mockResolvedValue(false) to the ./git.js mock in repoIndexManager.test.ts (returning false = repo is not empty, so commitHash is still populated from getCommitHashForRefName).

Commit: 0d5cad3

[coderabbitai]

🧹 Nitpick comments (1)

packages/backend/src/repoIndexManager.test.ts (1)

51-51: Mock looks correct for existing tests.

Mocking isRepoEmpty to return false preserves the existing behavior where getCommitHashForRefName is called and returns 'abc123'. Consider adding a test case where isRepoEmpty returns true to verify that indexedCommitHash is undefined for empty repos—this would directly cover the new feature's happy path.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.
In `@packages/backend/src/repoIndexManager.test.ts` at line 51, Add a new unit
test in repoIndexManager.test.ts that stubs isRepoEmpty to resolve true and
ensures getCommitHashForRefName is not relied upon and the resulting
indexedCommitHash is undefined; specifically, mock isRepoEmpty
(vi.fn().mockResolvedValue(true)), call the same flow that currently uses
getCommitHashForRefName, and assert indexedCommitHash === undefined and that
getCommitHashForRefName was not used (or not called) to cover the empty-repo
happy path.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/backend/src/repoIndexManager.test.ts`:
- Line 51: Add a new unit test in repoIndexManager.test.ts that stubs
isRepoEmpty to resolve true and ensures getCommitHashForRefName is not relied
upon and the resulting indexedCommitHash is undefined; specifically, mock
isRepoEmpty (vi.fn().mockResolvedValue(true)), call the same flow that currently
uses getCommitHashForRefName, and assert indexedCommitHash === undefined and
that getCommitHashForRefName was not used (or not called) to cover the
empty-repo happy path.

[brendan-kellam]

Summary

• Adds isRepoEmpty utility to git.ts that detects repositories with no commits using git log --all -1 --format=%H
• Uses isRepoEmpty in repoIndexManager.ts to skip calling getCommitHashForRefName for empty repos, avoiding noisy debug log output

Test plan

• Index a repository that has no commits and verify no debug error is logged for getCommitHashForRefName
• Index a normal repository and verify indexedCommitHash is still set correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Reduced noisy debug output when processing empty repositories by skipping unnecessary operations.

[coderabbitai]

Walkthrough

The PR adds a check to prevent unnecessary log noise from empty repositories. A new isRepoEmpty utility function is introduced to detect repositories without commits, and repoIndexManager conditionally computes commit hash only when the repository is non-empty.

Changes

Cohort / File(s)	Summary
Documentation CHANGELOG.md	Adds changelog entry documenting the fix to skip getCommitHashForRefName for empty repositories, referencing PR #914.
Git Utilities packages/backend/src/git.ts	Exports new isRepoEmpty() function that runs git log --all -1 --format=%H to determine if a repository has commits, returning true when no commits exist or the command fails.
Core Logic packages/backend/src/repoIndexManager.ts	Imports isRepoEmpty and adds conditional logic to compute commitHash only for non-empty repositories; commits in empty repos result in undefined commitHash.
Test Mocks packages/backend/src/repoIndexManager.test.ts	Adds mock implementation for isRepoEmpty in the git module mock used by tests, returning false.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• chore(worker): Migrate off of groupmq #860: Modifies packages/backend/src/repoIndexManager.ts with changes to job completion logic and commit-hash handling, overlapping with this PR's scope.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately and concisely summarizes the main change: adding a check to skip calling getCommitHashForRefName for empty repositories to reduce noisy logs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch brendan/skip-commit-hash-for-empty-repos

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[brendan-kellam]

@claude please fix the failing test

[claude]

Claude finished @brendan-kellam's task in 1m 24s —— View job

---

Fixed failing test

• Identify failing test from CI
• Read relevant source and test files
• Fix the failing test
• Commit and push changes

Root cause: The ./git.js mock in repoIndexManager.test.ts was missing isRepoEmpty. When onJobCompleted called isRepoEmpty(...), it was undefined, throwing a TypeError. The try-catch in onJobCompleted silently swallowed the error, so this.db.repo.update was never called — causing the assertion at line 449 to fail with 0 calls.

Fix: Added isRepoEmpty: vi.fn().mockResolvedValue(false) to the ./git.js mock in repoIndexManager.test.ts (returning false = repo is not empty, so commitHash is still populated from getCommitHashForRefName).

Commit: 0d5cad3

[coderabbitai]

🧹 Nitpick comments (1)

packages/backend/src/repoIndexManager.test.ts (1)

51-51: Mock looks correct for existing tests.

Mocking isRepoEmpty to return false preserves the existing behavior where getCommitHashForRefName is called and returns 'abc123'. Consider adding a test case where isRepoEmpty returns true to verify that indexedCommitHash is undefined for empty repos—this would directly cover the new feature's happy path.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.
In `@packages/backend/src/repoIndexManager.test.ts` at line 51, Add a new unit
test in repoIndexManager.test.ts that stubs isRepoEmpty to resolve true and
ensures getCommitHashForRefName is not relied upon and the resulting
indexedCommitHash is undefined; specifically, mock isRepoEmpty
(vi.fn().mockResolvedValue(true)), call the same flow that currently uses
getCommitHashForRefName, and assert indexedCommitHash === undefined and that
getCommitHashForRefName was not used (or not called) to cover the empty-repo
happy path.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/backend/src/repoIndexManager.test.ts`:
- Line 51: Add a new unit test in repoIndexManager.test.ts that stubs
isRepoEmpty to resolve true and ensures getCommitHashForRefName is not relied
upon and the resulting indexedCommitHash is undefined; specifically, mock
isRepoEmpty (vi.fn().mockResolvedValue(true)), call the same flow that currently
uses getCommitHashForRefName, and assert indexedCommitHash === undefined and
that getCommitHashForRefName was not used (or not called) to cover the
empty-repo happy path.