Uh oh!
There was an error while loading. Please reload this page.
feat(worker): add env var to disable repo-driven permission syncing - #989
Conversation
…repo driven permission syncing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughAdds a new environment flag PERMISSION_SYNC_REPO_DRIVEN_ENABLED (default true), exposes it in the runtime env schema, updates docs and changelog, and gates repo-driven permission sync scheduler startup behind that flag during application initialization. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor AppInit as Application
participant Env as Environment
participant Ent as EntitlementService
participant Repo as RepoPermissionSyncer
participant Account as AccountPermissionSyncer
AppInit->>Env: read PERMISSION_SYNC_REPO_DRIVEN_ENABLED
AppInit->>Ent: hasEntitlement("permission-syncing")?
Ent-->>AppInit: true
alt PERMISSION_SYNC_REPO_DRIVEN_ENABLED == "true"
AppInit->>Repo: repoPermissionSyncer.startScheduler()
Repo-->>AppInit: scheduler started
else PERMISSION_SYNC_REPO_DRIVEN_ENABLED != "true"
AppInit->>Repo: do not start repo scheduler
end
AppInit->>Account: accountPermissionSyncer.startScheduler()
Account-->>AppInit: scheduler started
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…m support table Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
Summary
PERMISSION_SYNC_REPO_DRIVEN_ENABLED(defaulttrue) to enable/disable repo-driven permission syncingEXPERIMENT_EE_PERMISSION_SYNC_ENABLED=trueenvironment-variables.mdxandpermission-syncing.mdxCloses SOU-634
Test plan
EXPERIMENT_EE_PERMISSION_SYNC_ENABLED=trueandPERMISSION_SYNC_REPO_DRIVEN_ENABLED=false— verify only user-driven syncer startsPERMISSION_SYNC_REPO_DRIVEN_ENABLEDunset (defaulttrue) — verify both syncers start as before🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation