fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled#999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendan-kellam merged 1 commit into from
Mar 13, 2026
Merged

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- [EE] Fixed account-driven permission sync silently wiping all Bitbucket Server repository permissions when the OAuth token expires on instances with anonymous access enabled. [#998](https://github.com/sourcebot-dev/sourcebot/pull/998)
- [EE] Fixed Bitbucket Server repos being incorrectly treated as public in Sourcebot when the instance-level `feature.public.access` flag is disabled but per-repo public flags were not reset. [#999](https://github.com/sourcebot-dev/sourcebot/pull/999)

## [4.15.5] - 2026-03-12

Expand Down
27 changes: 27 additions & 0 deletions packages/backend/src/bitbucket.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -782,6 +782,33 @@ export const getUserPermissionsForServerRepo = async (
.map(entry => ({ userId: String(entry.user.id) }));
};

/**
* Checks if the Bitbucket Server instance has the `feature.public.access` flag enabled
* by making a single unauthenticated request to a repo that the API reports as public.
*/
export const isBitbucketServerPublicAccessEnabled = async (
serverUrl: string,
publicRepo: ServerRepository,
): Promise<boolean> => {
const projectKey = publicRepo.project?.key;
const repoSlug = publicRepo.slug;
if (!projectKey || !repoSlug) {
return false;
}

const url = `${serverUrl}/rest/api/1.0/projects/${projectKey}/repos/${repoSlug}`;
try {
const response = await fetch(url, {
headers: { Accept: 'application/json' },
// Intentionally no Authorization header - we want to test anonymous access
});
return response.ok;
} catch (e) {
logger.warn(`Failed to probe public access for ${projectKey}/${repoSlug}: ${e}`);
return false;
}
};

/**
* Returns true if the Bitbucket Server client is authenticated as a real user,
* false if the token is expired, invalid, or the request is being treated as anonymous.
Expand Down
22 changes: 20 additions & 2 deletions packages/backend/src/repoCompileUtils.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import { getGitHubReposFromConfig, OctokitRepository } from "./github.js";
import { getGitLabReposFromConfig } from "./gitlab.js";
import { getGiteaReposFromConfig } from "./gitea.js";
import { getGerritReposFromConfig } from "./gerrit.js";
import { BitbucketRepository, getBitbucketReposFromConfig } from "./bitbucket.js";
import { BitbucketRepository, getBitbucketReposFromConfig, isBitbucketServerPublicAccessEnabled } from "./bitbucket.js";
import { getAzureDevOpsReposFromConfig } from "./azuredevops.js";
import { SchemaRestRepository as BitbucketServerRepository } from "@coderabbitai/bitbucket/server/openapi";
import { SchemaRepository as BitbucketCloudRepository } from "@coderabbitai/bitbucket/cloud/openapi";
Expand DownExpand Up@@ -401,6 +401,22 @@ export const compileBitbucketConfig = async (
.toString()
.replace(/^https?:\/\//, '');

// For Bitbucket Server, verify that the instance-level `feature.public.access` flag is
// actually enabled. When it is disabled, per-repo `public` flags may still be stale
// (i.e., remain `true` from before the flag was turned off) but repos are no longer
// anonymously accessible. We detect this by making a single unauthenticated probe
// request to one of the repos the API reports as public.
let isServerPublicAccessEnabled = true;
if (config.deploymentType === 'server') {
const firstPublicRepo = bitbucketRepos.find(repo => (repo as BitbucketServerRepository).public === true);
if (firstPublicRepo) {
isServerPublicAccessEnabled = await isBitbucketServerPublicAccessEnabled(hostUrl, firstPublicRepo as BitbucketServerRepository);
if (!isServerPublicAccessEnabled) {
logger.warn(`Bitbucket Server at ${hostUrl} has repos marked as public but they are not anonymously accessible. The feature.public.access flag may be disabled. Treating all repos as private.`);
}
}
}

const getCloneUrl = (repo: BitbucketRepository) => {
if (!repo.links) {
throw new Error(`No clone links found for server repo ${repo.name}`);
Expand DownExpand Up@@ -467,7 +483,9 @@ export const compileBitbucketConfig = async (
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isPublic = isServer
? (isServerPublicAccessEnabled && (repo as BitbucketServerRepository).public === true)
: (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
const isFork = isServer ? (repo as BitbucketServerRepository).origin !== undefined : (repo as BitbucketCloudRepository).parent !== undefined;
const repoName = path.join(repoNameRoot, displayName);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled#999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendan-kellam merged 1 commit into from
Mar 13, 2026
Merged

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- [EE] Fixed account-driven permission sync silently wiping all Bitbucket Server repository permissions when the OAuth token expires on instances with anonymous access enabled. [#998](https://github.com/sourcebot-dev/sourcebot/pull/998)
- [EE] Fixed Bitbucket Server repos being incorrectly treated as public in Sourcebot when the instance-level `feature.public.access` flag is disabled but per-repo public flags were not reset. [#999](https://github.com/sourcebot-dev/sourcebot/pull/999)

## [4.15.5] - 2026-03-12

Expand Down
27 changes: 27 additions & 0 deletions packages/backend/src/bitbucket.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -782,6 +782,33 @@ export const getUserPermissionsForServerRepo = async (
.map(entry => ({ userId: String(entry.user.id) }));
};

/**
* Checks if the Bitbucket Server instance has the `feature.public.access` flag enabled
* by making a single unauthenticated request to a repo that the API reports as public.
*/
export const isBitbucketServerPublicAccessEnabled = async (
serverUrl: string,
publicRepo: ServerRepository,
): Promise<boolean> => {
const projectKey = publicRepo.project?.key;
const repoSlug = publicRepo.slug;
if (!projectKey || !repoSlug) {
return false;
}

const url = `${serverUrl}/rest/api/1.0/projects/${projectKey}/repos/${repoSlug}`;
try {
const response = await fetch(url, {
headers: { Accept: 'application/json' },
// Intentionally no Authorization header - we want to test anonymous access
});
return response.ok;
} catch (e) {
logger.warn(`Failed to probe public access for ${projectKey}/${repoSlug}: ${e}`);
return false;
}
};

/**
* Returns true if the Bitbucket Server client is authenticated as a real user,
* false if the token is expired, invalid, or the request is being treated as anonymous.
Expand Down
22 changes: 20 additions & 2 deletions packages/backend/src/repoCompileUtils.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import { getGitHubReposFromConfig, OctokitRepository } from "./github.js";
import { getGitLabReposFromConfig } from "./gitlab.js";
import { getGiteaReposFromConfig } from "./gitea.js";
import { getGerritReposFromConfig } from "./gerrit.js";
import { BitbucketRepository, getBitbucketReposFromConfig } from "./bitbucket.js";
import { BitbucketRepository, getBitbucketReposFromConfig, isBitbucketServerPublicAccessEnabled } from "./bitbucket.js";
import { getAzureDevOpsReposFromConfig } from "./azuredevops.js";
import { SchemaRestRepository as BitbucketServerRepository } from "@coderabbitai/bitbucket/server/openapi";
import { SchemaRepository as BitbucketCloudRepository } from "@coderabbitai/bitbucket/cloud/openapi";
Expand DownExpand Up@@ -401,6 +401,22 @@ export const compileBitbucketConfig = async (
.toString()
.replace(/^https?:\/\//, '');

// For Bitbucket Server, verify that the instance-level `feature.public.access` flag is
// actually enabled. When it is disabled, per-repo `public` flags may still be stale
// (i.e., remain `true` from before the flag was turned off) but repos are no longer
// anonymously accessible. We detect this by making a single unauthenticated probe
// request to one of the repos the API reports as public.
let isServerPublicAccessEnabled = true;
if (config.deploymentType === 'server') {
const firstPublicRepo = bitbucketRepos.find(repo => (repo as BitbucketServerRepository).public === true);
if (firstPublicRepo) {
isServerPublicAccessEnabled = await isBitbucketServerPublicAccessEnabled(hostUrl, firstPublicRepo as BitbucketServerRepository);
if (!isServerPublicAccessEnabled) {
logger.warn(`Bitbucket Server at ${hostUrl} has repos marked as public but they are not anonymously accessible. The feature.public.access flag may be disabled. Treating all repos as private.`);
}
}
}

const getCloneUrl = (repo: BitbucketRepository) => {
if (!repo.links) {
throw new Error(`No clone links found for server repo ${repo.name}`);
Expand DownExpand Up@@ -467,7 +483,9 @@ export const compileBitbucketConfig = async (
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isPublic = isServer
? (isServerPublicAccessEnabled && (repo as BitbucketServerRepository).public === true)
: (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
const isFork = isServer ? (repo as BitbucketServerRepository).origin !== undefined : (repo as BitbucketCloudRepository).parent !== undefined;
const repoName = path.join(repoNameRoot, displayName);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled#999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendan-kellam merged 1 commit into from
Mar 13, 2026
Merged

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- [EE] Fixed account-driven permission sync silently wiping all Bitbucket Server repository permissions when the OAuth token expires on instances with anonymous access enabled. [#998](https://github.com/sourcebot-dev/sourcebot/pull/998)
- [EE] Fixed Bitbucket Server repos being incorrectly treated as public in Sourcebot when the instance-level `feature.public.access` flag is disabled but per-repo public flags were not reset. [#999](https://github.com/sourcebot-dev/sourcebot/pull/999)

## [4.15.5] - 2026-03-12

Expand Down
27 changes: 27 additions & 0 deletions packages/backend/src/bitbucket.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -782,6 +782,33 @@ export const getUserPermissionsForServerRepo = async (
.map(entry => ({ userId: String(entry.user.id) }));
};

/**
* Checks if the Bitbucket Server instance has the `feature.public.access` flag enabled
* by making a single unauthenticated request to a repo that the API reports as public.
*/
export const isBitbucketServerPublicAccessEnabled = async (
serverUrl: string,
publicRepo: ServerRepository,
): Promise<boolean> => {
const projectKey = publicRepo.project?.key;
const repoSlug = publicRepo.slug;
if (!projectKey || !repoSlug) {
return false;
}

const url = `${serverUrl}/rest/api/1.0/projects/${projectKey}/repos/${repoSlug}`;
try {
const response = await fetch(url, {
headers: { Accept: 'application/json' },
// Intentionally no Authorization header - we want to test anonymous access
});
return response.ok;
} catch (e) {
logger.warn(`Failed to probe public access for ${projectKey}/${repoSlug}: ${e}`);
return false;
}
};

/**
* Returns true if the Bitbucket Server client is authenticated as a real user,
* false if the token is expired, invalid, or the request is being treated as anonymous.
Expand Down
22 changes: 20 additions & 2 deletions packages/backend/src/repoCompileUtils.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import { getGitHubReposFromConfig, OctokitRepository } from "./github.js";
import { getGitLabReposFromConfig } from "./gitlab.js";
import { getGiteaReposFromConfig } from "./gitea.js";
import { getGerritReposFromConfig } from "./gerrit.js";
import { BitbucketRepository, getBitbucketReposFromConfig } from "./bitbucket.js";
import { BitbucketRepository, getBitbucketReposFromConfig, isBitbucketServerPublicAccessEnabled } from "./bitbucket.js";
import { getAzureDevOpsReposFromConfig } from "./azuredevops.js";
import { SchemaRestRepository as BitbucketServerRepository } from "@coderabbitai/bitbucket/server/openapi";
import { SchemaRepository as BitbucketCloudRepository } from "@coderabbitai/bitbucket/cloud/openapi";
Expand DownExpand Up@@ -401,6 +401,22 @@ export const compileBitbucketConfig = async (
.toString()
.replace(/^https?:\/\//, '');

// For Bitbucket Server, verify that the instance-level `feature.public.access` flag is
// actually enabled. When it is disabled, per-repo `public` flags may still be stale
// (i.e., remain `true` from before the flag was turned off) but repos are no longer
// anonymously accessible. We detect this by making a single unauthenticated probe
// request to one of the repos the API reports as public.
let isServerPublicAccessEnabled = true;
if (config.deploymentType === 'server') {
const firstPublicRepo = bitbucketRepos.find(repo => (repo as BitbucketServerRepository).public === true);
if (firstPublicRepo) {
isServerPublicAccessEnabled = await isBitbucketServerPublicAccessEnabled(hostUrl, firstPublicRepo as BitbucketServerRepository);
if (!isServerPublicAccessEnabled) {
logger.warn(`Bitbucket Server at ${hostUrl} has repos marked as public but they are not anonymously accessible. The feature.public.access flag may be disabled. Treating all repos as private.`);
}
}
}

const getCloneUrl = (repo: BitbucketRepository) => {
if (!repo.links) {
throw new Error(`No clone links found for server repo ${repo.name}`);
Expand DownExpand Up@@ -467,7 +483,9 @@ export const compileBitbucketConfig = async (
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isPublic = isServer
? (isServerPublicAccessEnabled && (repo as BitbucketServerRepository).public === true)
: (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
const isFork = isServer ? (repo as BitbucketServerRepository).origin !== undefined : (repo as BitbucketCloudRepository).parent !== undefined;
const repoName = path.join(repoNameRoot, displayName);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled#999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendan-kellam merged 1 commit into from
Mar 13, 2026
Merged

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- [EE] Fixed account-driven permission sync silently wiping all Bitbucket Server repository permissions when the OAuth token expires on instances with anonymous access enabled. [#998](https://github.com/sourcebot-dev/sourcebot/pull/998)
- [EE] Fixed Bitbucket Server repos being incorrectly treated as public in Sourcebot when the instance-level `feature.public.access` flag is disabled but per-repo public flags were not reset. [#999](https://github.com/sourcebot-dev/sourcebot/pull/999)

## [4.15.5] - 2026-03-12

Expand Down
27 changes: 27 additions & 0 deletions packages/backend/src/bitbucket.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -782,6 +782,33 @@ export const getUserPermissionsForServerRepo = async (
.map(entry => ({ userId: String(entry.user.id) }));
};

/**
* Checks if the Bitbucket Server instance has the `feature.public.access` flag enabled
* by making a single unauthenticated request to a repo that the API reports as public.
*/
export const isBitbucketServerPublicAccessEnabled = async (
serverUrl: string,
publicRepo: ServerRepository,
): Promise<boolean> => {
const projectKey = publicRepo.project?.key;
const repoSlug = publicRepo.slug;
if (!projectKey || !repoSlug) {
return false;
}

const url = `${serverUrl}/rest/api/1.0/projects/${projectKey}/repos/${repoSlug}`;
try {
const response = await fetch(url, {
headers: { Accept: 'application/json' },
// Intentionally no Authorization header - we want to test anonymous access
});
return response.ok;
} catch (e) {
logger.warn(`Failed to probe public access for ${projectKey}/${repoSlug}: ${e}`);
return false;
}
};

/**
* Returns true if the Bitbucket Server client is authenticated as a real user,
* false if the token is expired, invalid, or the request is being treated as anonymous.
Expand Down
22 changes: 20 additions & 2 deletions packages/backend/src/repoCompileUtils.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import { getGitHubReposFromConfig, OctokitRepository } from "./github.js";
import { getGitLabReposFromConfig } from "./gitlab.js";
import { getGiteaReposFromConfig } from "./gitea.js";
import { getGerritReposFromConfig } from "./gerrit.js";
import { BitbucketRepository, getBitbucketReposFromConfig } from "./bitbucket.js";
import { BitbucketRepository, getBitbucketReposFromConfig, isBitbucketServerPublicAccessEnabled } from "./bitbucket.js";
import { getAzureDevOpsReposFromConfig } from "./azuredevops.js";
import { SchemaRestRepository as BitbucketServerRepository } from "@coderabbitai/bitbucket/server/openapi";
import { SchemaRepository as BitbucketCloudRepository } from "@coderabbitai/bitbucket/cloud/openapi";
Expand DownExpand Up@@ -401,6 +401,22 @@ export const compileBitbucketConfig = async (
.toString()
.replace(/^https?:\/\//, '');

// For Bitbucket Server, verify that the instance-level `feature.public.access` flag is
// actually enabled. When it is disabled, per-repo `public` flags may still be stale
// (i.e., remain `true` from before the flag was turned off) but repos are no longer
// anonymously accessible. We detect this by making a single unauthenticated probe
// request to one of the repos the API reports as public.
let isServerPublicAccessEnabled = true;
if (config.deploymentType === 'server') {
const firstPublicRepo = bitbucketRepos.find(repo => (repo as BitbucketServerRepository).public === true);
if (firstPublicRepo) {
isServerPublicAccessEnabled = await isBitbucketServerPublicAccessEnabled(hostUrl, firstPublicRepo as BitbucketServerRepository);
if (!isServerPublicAccessEnabled) {
logger.warn(`Bitbucket Server at ${hostUrl} has repos marked as public but they are not anonymously accessible. The feature.public.access flag may be disabled. Treating all repos as private.`);
}
}
}

const getCloneUrl = (repo: BitbucketRepository) => {
if (!repo.links) {
throw new Error(`No clone links found for server repo ${repo.name}`);
Expand DownExpand Up@@ -467,7 +483,9 @@ export const compileBitbucketConfig = async (
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isPublic = isServer
? (isServerPublicAccessEnabled && (repo as BitbucketServerRepository).public === true)
: (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
const isFork = isServer ? (repo as BitbucketServerRepository).origin !== undefined : (repo as BitbucketCloudRepository).parent !== undefined;
const repoName = path.join(repoNameRoot, displayName);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled#999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendan-kellam merged 1 commit into from
Mar 13, 2026
Merged

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- [EE] Fixed account-driven permission sync silently wiping all Bitbucket Server repository permissions when the OAuth token expires on instances with anonymous access enabled. [#998](https://github.com/sourcebot-dev/sourcebot/pull/998)
- [EE] Fixed Bitbucket Server repos being incorrectly treated as public in Sourcebot when the instance-level `feature.public.access` flag is disabled but per-repo public flags were not reset. [#999](https://github.com/sourcebot-dev/sourcebot/pull/999)

## [4.15.5] - 2026-03-12

Expand Down
27 changes: 27 additions & 0 deletions packages/backend/src/bitbucket.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -782,6 +782,33 @@ export const getUserPermissionsForServerRepo = async (
.map(entry => ({ userId: String(entry.user.id) }));
};

/**
* Checks if the Bitbucket Server instance has the `feature.public.access` flag enabled
* by making a single unauthenticated request to a repo that the API reports as public.
*/
export const isBitbucketServerPublicAccessEnabled = async (
serverUrl: string,
publicRepo: ServerRepository,
): Promise<boolean> => {
const projectKey = publicRepo.project?.key;
const repoSlug = publicRepo.slug;
if (!projectKey || !repoSlug) {
return false;
}

const url = `${serverUrl}/rest/api/1.0/projects/${projectKey}/repos/${repoSlug}`;
try {
const response = await fetch(url, {
headers: { Accept: 'application/json' },
// Intentionally no Authorization header - we want to test anonymous access
});
return response.ok;
} catch (e) {
logger.warn(`Failed to probe public access for ${projectKey}/${repoSlug}: ${e}`);
return false;
}
};

/**
* Returns true if the Bitbucket Server client is authenticated as a real user,
* false if the token is expired, invalid, or the request is being treated as anonymous.
Expand Down
22 changes: 20 additions & 2 deletions packages/backend/src/repoCompileUtils.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import { getGitHubReposFromConfig, OctokitRepository } from "./github.js";
import { getGitLabReposFromConfig } from "./gitlab.js";
import { getGiteaReposFromConfig } from "./gitea.js";
import { getGerritReposFromConfig } from "./gerrit.js";
import { BitbucketRepository, getBitbucketReposFromConfig } from "./bitbucket.js";
import { BitbucketRepository, getBitbucketReposFromConfig, isBitbucketServerPublicAccessEnabled } from "./bitbucket.js";
import { getAzureDevOpsReposFromConfig } from "./azuredevops.js";
import { SchemaRestRepository as BitbucketServerRepository } from "@coderabbitai/bitbucket/server/openapi";
import { SchemaRepository as BitbucketCloudRepository } from "@coderabbitai/bitbucket/cloud/openapi";
Expand DownExpand Up@@ -401,6 +401,22 @@ export const compileBitbucketConfig = async (
.toString()
.replace(/^https?:\/\//, '');

// For Bitbucket Server, verify that the instance-level `feature.public.access` flag is
// actually enabled. When it is disabled, per-repo `public` flags may still be stale
// (i.e., remain `true` from before the flag was turned off) but repos are no longer
// anonymously accessible. We detect this by making a single unauthenticated probe
// request to one of the repos the API reports as public.
let isServerPublicAccessEnabled = true;
if (config.deploymentType === 'server') {
const firstPublicRepo = bitbucketRepos.find(repo => (repo as BitbucketServerRepository).public === true);
if (firstPublicRepo) {
isServerPublicAccessEnabled = await isBitbucketServerPublicAccessEnabled(hostUrl, firstPublicRepo as BitbucketServerRepository);
if (!isServerPublicAccessEnabled) {
logger.warn(`Bitbucket Server at ${hostUrl} has repos marked as public but they are not anonymously accessible. The feature.public.access flag may be disabled. Treating all repos as private.`);
}
}
}

const getCloneUrl = (repo: BitbucketRepository) => {
if (!repo.links) {
throw new Error(`No clone links found for server repo ${repo.name}`);
Expand DownExpand Up@@ -467,7 +483,9 @@ export const compileBitbucketConfig = async (
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isPublic = isServer
? (isServerPublicAccessEnabled && (repo as BitbucketServerRepository).public === true)
: (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
const isFork = isServer ? (repo as BitbucketServerRepository).origin !== undefined : (repo as BitbucketCloudRepository).parent !== undefined;
const repoName = path.join(repoNameRoot, displayName);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled#999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendan-kellam merged 1 commit into from
Mar 13, 2026
Merged

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- [EE] Fixed account-driven permission sync silently wiping all Bitbucket Server repository permissions when the OAuth token expires on instances with anonymous access enabled. [#998](https://github.com/sourcebot-dev/sourcebot/pull/998)
- [EE] Fixed Bitbucket Server repos being incorrectly treated as public in Sourcebot when the instance-level `feature.public.access` flag is disabled but per-repo public flags were not reset. [#999](https://github.com/sourcebot-dev/sourcebot/pull/999)

## [4.15.5] - 2026-03-12

Expand Down
27 changes: 27 additions & 0 deletions packages/backend/src/bitbucket.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -782,6 +782,33 @@ export const getUserPermissionsForServerRepo = async (
.map(entry => ({ userId: String(entry.user.id) }));
};

/**
* Checks if the Bitbucket Server instance has the `feature.public.access` flag enabled
* by making a single unauthenticated request to a repo that the API reports as public.
*/
export const isBitbucketServerPublicAccessEnabled = async (
serverUrl: string,
publicRepo: ServerRepository,
): Promise<boolean> => {
const projectKey = publicRepo.project?.key;
const repoSlug = publicRepo.slug;
if (!projectKey || !repoSlug) {
return false;
}

const url = `${serverUrl}/rest/api/1.0/projects/${projectKey}/repos/${repoSlug}`;
try {
const response = await fetch(url, {
headers: { Accept: 'application/json' },
// Intentionally no Authorization header - we want to test anonymous access
});
return response.ok;
} catch (e) {
logger.warn(`Failed to probe public access for ${projectKey}/${repoSlug}: ${e}`);
return false;
}
};

/**
* Returns true if the Bitbucket Server client is authenticated as a real user,
* false if the token is expired, invalid, or the request is being treated as anonymous.
Expand Down
22 changes: 20 additions & 2 deletions packages/backend/src/repoCompileUtils.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import { getGitHubReposFromConfig, OctokitRepository } from "./github.js";
import { getGitLabReposFromConfig } from "./gitlab.js";
import { getGiteaReposFromConfig } from "./gitea.js";
import { getGerritReposFromConfig } from "./gerrit.js";
import { BitbucketRepository, getBitbucketReposFromConfig } from "./bitbucket.js";
import { BitbucketRepository, getBitbucketReposFromConfig, isBitbucketServerPublicAccessEnabled } from "./bitbucket.js";
import { getAzureDevOpsReposFromConfig } from "./azuredevops.js";
import { SchemaRestRepository as BitbucketServerRepository } from "@coderabbitai/bitbucket/server/openapi";
import { SchemaRepository as BitbucketCloudRepository } from "@coderabbitai/bitbucket/cloud/openapi";
Expand DownExpand Up@@ -401,6 +401,22 @@ export const compileBitbucketConfig = async (
.toString()
.replace(/^https?:\/\//, '');

// For Bitbucket Server, verify that the instance-level `feature.public.access` flag is
// actually enabled. When it is disabled, per-repo `public` flags may still be stale
// (i.e., remain `true` from before the flag was turned off) but repos are no longer
// anonymously accessible. We detect this by making a single unauthenticated probe
// request to one of the repos the API reports as public.
let isServerPublicAccessEnabled = true;
if (config.deploymentType === 'server') {
const firstPublicRepo = bitbucketRepos.find(repo => (repo as BitbucketServerRepository).public === true);
if (firstPublicRepo) {
isServerPublicAccessEnabled = await isBitbucketServerPublicAccessEnabled(hostUrl, firstPublicRepo as BitbucketServerRepository);
if (!isServerPublicAccessEnabled) {
logger.warn(`Bitbucket Server at ${hostUrl} has repos marked as public but they are not anonymously accessible. The feature.public.access flag may be disabled. Treating all repos as private.`);
}
}
}

const getCloneUrl = (repo: BitbucketRepository) => {
if (!repo.links) {
throw new Error(`No clone links found for server repo ${repo.name}`);
Expand DownExpand Up@@ -467,7 +483,9 @@ export const compileBitbucketConfig = async (
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isPublic = isServer
? (isServerPublicAccessEnabled && (repo as BitbucketServerRepository).public === true)
: (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
const isFork = isServer ? (repo as BitbucketServerRepository).origin !== undefined : (repo as BitbucketCloudRepository).parent !== undefined;
const repoName = path.join(repoNameRoot, displayName);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled#999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendan-kellam merged 1 commit into from
Mar 13, 2026
Merged

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- [EE] Fixed account-driven permission sync silently wiping all Bitbucket Server repository permissions when the OAuth token expires on instances with anonymous access enabled. [#998](https://github.com/sourcebot-dev/sourcebot/pull/998)
- [EE] Fixed Bitbucket Server repos being incorrectly treated as public in Sourcebot when the instance-level `feature.public.access` flag is disabled but per-repo public flags were not reset. [#999](https://github.com/sourcebot-dev/sourcebot/pull/999)

## [4.15.5] - 2026-03-12

Expand Down
27 changes: 27 additions & 0 deletions packages/backend/src/bitbucket.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -782,6 +782,33 @@ export const getUserPermissionsForServerRepo = async (
.map(entry => ({ userId: String(entry.user.id) }));
};

/**
* Checks if the Bitbucket Server instance has the `feature.public.access` flag enabled
* by making a single unauthenticated request to a repo that the API reports as public.
*/
export const isBitbucketServerPublicAccessEnabled = async (
serverUrl: string,
publicRepo: ServerRepository,
): Promise<boolean> => {
const projectKey = publicRepo.project?.key;
const repoSlug = publicRepo.slug;
if (!projectKey || !repoSlug) {
return false;
}

const url = `${serverUrl}/rest/api/1.0/projects/${projectKey}/repos/${repoSlug}`;
try {
const response = await fetch(url, {
headers: { Accept: 'application/json' },
// Intentionally no Authorization header - we want to test anonymous access
});
return response.ok;
} catch (e) {
logger.warn(`Failed to probe public access for ${projectKey}/${repoSlug}: ${e}`);
return false;
}
};

/**
* Returns true if the Bitbucket Server client is authenticated as a real user,
* false if the token is expired, invalid, or the request is being treated as anonymous.
Expand Down
22 changes: 20 additions & 2 deletions packages/backend/src/repoCompileUtils.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import { getGitHubReposFromConfig, OctokitRepository } from "./github.js";
import { getGitLabReposFromConfig } from "./gitlab.js";
import { getGiteaReposFromConfig } from "./gitea.js";
import { getGerritReposFromConfig } from "./gerrit.js";
import { BitbucketRepository, getBitbucketReposFromConfig } from "./bitbucket.js";
import { BitbucketRepository, getBitbucketReposFromConfig, isBitbucketServerPublicAccessEnabled } from "./bitbucket.js";
import { getAzureDevOpsReposFromConfig } from "./azuredevops.js";
import { SchemaRestRepository as BitbucketServerRepository } from "@coderabbitai/bitbucket/server/openapi";
import { SchemaRepository as BitbucketCloudRepository } from "@coderabbitai/bitbucket/cloud/openapi";
Expand DownExpand Up@@ -401,6 +401,22 @@ export const compileBitbucketConfig = async (
.toString()
.replace(/^https?:\/\//, '');

// For Bitbucket Server, verify that the instance-level `feature.public.access` flag is
// actually enabled. When it is disabled, per-repo `public` flags may still be stale
// (i.e., remain `true` from before the flag was turned off) but repos are no longer
// anonymously accessible. We detect this by making a single unauthenticated probe
// request to one of the repos the API reports as public.
let isServerPublicAccessEnabled = true;
if (config.deploymentType === 'server') {
const firstPublicRepo = bitbucketRepos.find(repo => (repo as BitbucketServerRepository).public === true);
if (firstPublicRepo) {
isServerPublicAccessEnabled = await isBitbucketServerPublicAccessEnabled(hostUrl, firstPublicRepo as BitbucketServerRepository);
if (!isServerPublicAccessEnabled) {
logger.warn(`Bitbucket Server at ${hostUrl} has repos marked as public but they are not anonymously accessible. The feature.public.access flag may be disabled. Treating all repos as private.`);
}
}
}

const getCloneUrl = (repo: BitbucketRepository) => {
if (!repo.links) {
throw new Error(`No clone links found for server repo ${repo.name}`);
Expand DownExpand Up@@ -467,7 +483,9 @@ export const compileBitbucketConfig = async (
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isPublic = isServer
? (isServerPublicAccessEnabled && (repo as BitbucketServerRepository).public === true)
: (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
const isFork = isServer ? (repo as BitbucketServerRepository).origin !== undefined : (repo as BitbucketCloudRepository).parent !== undefined;
const repoName = path.join(repoNameRoot, displayName);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled#999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendan-kellam merged 1 commit into from
Mar 13, 2026
Merged

fix(worker): guard against stale public flags when Bitbucket Server feature.public.access is disabled #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- [EE] Fixed account-driven permission sync silently wiping all Bitbucket Server repository permissions when the OAuth token expires on instances with anonymous access enabled. [#998](https://github.com/sourcebot-dev/sourcebot/pull/998)
- [EE] Fixed Bitbucket Server repos being incorrectly treated as public in Sourcebot when the instance-level `feature.public.access` flag is disabled but per-repo public flags were not reset. [#999](https://github.com/sourcebot-dev/sourcebot/pull/999)

## [4.15.5] - 2026-03-12

Expand Down
27 changes: 27 additions & 0 deletions packages/backend/src/bitbucket.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -782,6 +782,33 @@ export const getUserPermissionsForServerRepo = async (
.map(entry => ({ userId: String(entry.user.id) }));
};

/**
* Checks if the Bitbucket Server instance has the `feature.public.access` flag enabled
* by making a single unauthenticated request to a repo that the API reports as public.
*/
export const isBitbucketServerPublicAccessEnabled = async (
serverUrl: string,
publicRepo: ServerRepository,
): Promise<boolean> => {
const projectKey = publicRepo.project?.key;
const repoSlug = publicRepo.slug;
if (!projectKey || !repoSlug) {
return false;
}

const url = `${serverUrl}/rest/api/1.0/projects/${projectKey}/repos/${repoSlug}`;
try {
const response = await fetch(url, {
headers: { Accept: 'application/json' },
// Intentionally no Authorization header - we want to test anonymous access
});
return response.ok;
} catch (e) {
logger.warn(`Failed to probe public access for ${projectKey}/${repoSlug}: ${e}`);
return false;
}
};

/**
* Returns true if the Bitbucket Server client is authenticated as a real user,
* false if the token is expired, invalid, or the request is being treated as anonymous.
Expand Down
22 changes: 20 additions & 2 deletions packages/backend/src/repoCompileUtils.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,7 +3,7 @@ import { getGitHubReposFromConfig, OctokitRepository } from "./github.js";
import { getGitLabReposFromConfig } from "./gitlab.js";
import { getGiteaReposFromConfig } from "./gitea.js";
import { getGerritReposFromConfig } from "./gerrit.js";
import { BitbucketRepository, getBitbucketReposFromConfig } from "./bitbucket.js";
import { BitbucketRepository, getBitbucketReposFromConfig, isBitbucketServerPublicAccessEnabled } from "./bitbucket.js";
import { getAzureDevOpsReposFromConfig } from "./azuredevops.js";
import { SchemaRestRepository as BitbucketServerRepository } from "@coderabbitai/bitbucket/server/openapi";
import { SchemaRepository as BitbucketCloudRepository } from "@coderabbitai/bitbucket/cloud/openapi";
Expand DownExpand Up@@ -401,6 +401,22 @@ export const compileBitbucketConfig = async (
.toString()
.replace(/^https?:\/\//, '');

// For Bitbucket Server, verify that the instance-level `feature.public.access` flag is
// actually enabled. When it is disabled, per-repo `public` flags may still be stale
// (i.e., remain `true` from before the flag was turned off) but repos are no longer
// anonymously accessible. We detect this by making a single unauthenticated probe
// request to one of the repos the API reports as public.
let isServerPublicAccessEnabled = true;
if (config.deploymentType === 'server') {
const firstPublicRepo = bitbucketRepos.find(repo => (repo as BitbucketServerRepository).public === true);
if (firstPublicRepo) {
isServerPublicAccessEnabled = await isBitbucketServerPublicAccessEnabled(hostUrl, firstPublicRepo as BitbucketServerRepository);
if (!isServerPublicAccessEnabled) {
logger.warn(`Bitbucket Server at ${hostUrl} has repos marked as public but they are not anonymously accessible. The feature.public.access flag may be disabled. Treating all repos as private.`);
}
}
}

const getCloneUrl = (repo: BitbucketRepository) => {
if (!repo.links) {
throw new Error(`No clone links found for server repo ${repo.name}`);
Expand DownExpand Up@@ -467,7 +483,9 @@ export const compileBitbucketConfig = async (
}
})();
const externalId = isServer ? (repo as BitbucketServerRepository).id!.toString() : (repo as BitbucketCloudRepository).uuid!;
const isPublic = isServer ? (repo as BitbucketServerRepository).public : (repo as BitbucketCloudRepository).is_private === false;
const isPublic = isServer
? (isServerPublicAccessEnabled && (repo as BitbucketServerRepository).public === true)
: (repo as BitbucketCloudRepository).is_private === false;
const isArchived = isServer ? (repo as BitbucketServerRepository).archived === true : false;
const isFork = isServer ? (repo as BitbucketServerRepository).origin !== undefined : (repo as BitbucketCloudRepository).parent !== undefined;
const repoName = path.join(repoNameRoot, displayName);
Expand Down
Loading