Skip to content

Reimpl/simple functions set 1 - #199

Draft
gynt wants to merge 61 commits into
mainfrom
reimpl/simple-functions-set-1
Draft

Reimpl/simple functions set 1#199
gynt wants to merge 61 commits into
mainfrom
reimpl/simple-functions-set-1

Conversation

@gynt

@gyntgynt commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@gynt
gyntforce-pushed the reimpl/simple-functions-set-1 branch 2 times, most recently from dbc6c35 to 96be230CompareAugust 23, 2026 02:19
@@ -1,4 +1,4 @@
#include "../SoundSystem.func.hpp"

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My clang-format fixes this relative import to its absolute version. Why doesn't yours do the same @TheRedDaemon and what do you prefer?

@TheRedDaemonTheRedDaemonAug 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed on using the relative import to mark the "main" header file, so this is something that should stay.

No idea on your question, though. I still use the integrated clang version of Visual Studio Code. Did you update your version recently to the newest? Maybe something was added regarding the imports?

@gynt
gyntforce-pushed the reimpl/simple-functions-set-1 branch 3 times, most recently from 0b76486 to e6f6ab7CompareAugust 24, 2026 19:03
@gynt
gyntforce-pushed the reimpl/simple-functions-set-1 branch from 91680df to d7291dbCompareSeptember 1, 2026 15:19
@gynt
gyntforce-pushed the reimpl/simple-functions-set-1 branch from 4de8840 to 4dbcfb4CompareSeptember 2, 2026 09:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gynt@TheRedDaemon