Skip to content

Lock down the empty standalone promotion of anonymous atoms - #130

Merged
jviotti merged 1 commit into
mainfrom
lock-empty-rdf
Aug 5, 2026
Merged

Lock down the empty standalone promotion of anonymous atoms#130
jviotti merged 1 commit into
mainfrom
lock-empty-rdf

Conversation

@jviotti

@jviottijviotti commented Aug 5, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti merged commit 2159597 into mainAug 5, 2026
3 checks passed
@jviotti
jviotti deleted the lock-empty-rdf branch August 5, 2026 00:52
@augmentcode

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR tightens test expectations around RDF generation for “anonymous atom” inputs.

Changes:

  • Updates many schema fixture files under test/schemas/** to explicitly assert an empty RDF output for certain valid cases by adding "rdf": [].
  • Applies this mainly to baseline/edge “atom” values (e.g., 0, 0.0, and empty strings), where RDF emission should be empty.
  • Covers a wide range of domains (SI units, IEEE floats, IETF encodings/URIs/GeoJSON, ISO types, W3C XML Schema primitives, etc.).

Why: Makes RDF-related behavior explicit in the test suite, helping prevent regressions where empty RDF outputs might incorrectly “promote” standalone anonymous atoms.

Technical Notes: The jsonschema test runner already supports an rdf expectation (including empty arrays), so these fixtures now validate both schema validity and RDF output shape for the selected cases.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcodeaugmentcodeBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@jviotti