Skip to content

chore: add frozen_string_literal and apt_update to test recipes - #56

Open
damacus wants to merge 4 commits into
mainfrom
fix/modernize-standards
Open

chore: add frozen_string_literal and apt_update to test recipes#56
damacus wants to merge 4 commits into
mainfrom
fix/modernize-standards

Conversation

@damacus

Copy link
Copy Markdown
Member
  • 11 files missing frozen_string_literal: true
  • 1 test recipe missing apt_update

…t_update
- Replace legacy Spork spec_helper with modern ChefSpec
- Add github_deploy resource spec (3 examples, 0 failures)
- Add frozen_string_literal to 11 files
- Add apt_update to test recipe
- Replace all EOL platforms with current non-EOL in kitchen.yml, kitchen.dokken.yml, CI
@damacus
damacusforce-pushed the fix/modernize-standards branch from e67fa33 to 96311f2CompareMarch 19, 2026 11:22
@damacus
damacus requested a review from a team as a code ownerMarch 19, 2026 11:22
@damacus
damacusforce-pushed the fix/modernize-standards branch 2 times, most recently from 0ac93cd to 8b718daCompareMarch 19, 2026 11:35
- Pin release workflow to @main (was @5.0.8)
- Add slack_bot_token and slack_channel_id secrets
- Add .rubocop.yml with cookstyle require
@damacus
damacusforce-pushed the fix/modernize-standards branch from 8b718da to f27a844CompareMarch 19, 2026 11:38
Replace actionshub/chef-install with Cinc composite action.
Use cincproject/cinc Docker image and product_name: cinc in Dokken.
Remove CHEF_LICENSE env vars (Cinc doesn't need them).
… images
Cinc Docker images use 'latest' tag, not 'current' like Chef.
@github-actions

Copy link
Copy Markdown

Slowest examples

Top 3 slowest examples (0.15 seconds, 100% of total time)
ExampleDescriptionTime in seconds
spec/resources/deploy_spec.rb:19github_deploy deploy action is expected to create directory "/opt/deployments/test-repo/releases"0.07185
spec/resources/deploy_spec.rb:21github_deploy deploy action is expected to create link "/opt/deployments/test-repo/current"0.04158
spec/resources/deploy_spec.rb:20github_deploy deploy action is expected to create directory "/opt/deployments/test-repo/shared"0.04121

@damacusdamacus changed the title fix: add frozen_string_literal and apt_update to test recipeschore: add frozen_string_literal and apt_update to test recipesApr 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@damacus