Uh oh!
There was an error while loading. Please reload this page.
Add _SPARKFUNBME280_NO_SPI and _SPARKFUNBME280_NO_I2C flag - #44
Conversation
Added _SPARKFUNBME280_NO_SPI and _SPARKFUNBME280_NO_I2C compile flag for smaller binary size. Example1_BasicReadings.ino binary size | global consts without flag 275152 | 27660 with _SPARKFUNBME280_NO_SPI 273300 | 27616 difference -1852 | -44 SPI/Example1_BasicReadings.ino binary size | global consts without flag 275136 | 27660 with _SPARKFUNBME280_NO_I2C 271300 | 27180 difference -3836 | -480
Remove unnecessary and wrong build flag check before settings.commInterface = SPI_MODE
AndyEngland521
commented
Apr 10, 2020
@drhideg I like what you've done here, but we usually don't like customers having to fiddle about in the library's source files to enable or disable features. I understand that you have a default to I2C if the customer doesn't define anything, but this still means the customer has to go into the library to enable SPI. For now I don't think I can pull this request in, I'm sorry. |
I hope i dont make any wrong, therefor both I2C and SPI enabled by default. At least that was my intention. However i dont have any SPI device to try it on board. -- |
AndyEngland521
commented
Apr 10, 2020
@drhideg Oh I see what you're doing now, the double negatives had me thrown off for a second, can you please update the version number in library.properties to 2.0.9 and I will pull this in |
drhideg
commented
Apr 10, 2020
Bumped. But now its all wrong with the global intances things, which doesn't work yet, and i made a typo in the commit title :) |
AndyEngland521
commented
Apr 10, 2020
Go right ahead! |
Added _SPARKFUNBME280_NO_SPI and _SPARKFUNBME280_NO_I2C compile flag for smaller binary size.