Skip to content

feat: remittances - #72

Open
luigimorel wants to merge 13 commits into
sparkplug:masterfrom
luigimorel:feat-remittances
Open

feat: remittances#72
luigimorel wants to merge 13 commits into
sparkplug:masterfrom
luigimorel:feat-remittances

Conversation

@luigimorel

Copy link
Copy Markdown
Contributor

Add the remittance operation to SDK.

Fixes#14.

Please test and let me there's anything I'm missing.

Comment threadexamples/remittances.js Outdated
Comment threadexamples/remittances.js Outdated
Comment threadsrc/errors.ts
Comment threadsrc/remittances.ts
Comment threadsrc/validate.ts Outdated

@ernest-okoternest-okot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job so far, just take a look at the comments I have left

@ernest-okoternest-okot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to squash the commits and use conventional commit messages (prefixed with feat: or fix:) to make a release and push to npm happen

@ernest-okoternest-okot changed the title Feat: remittancesfeat: remittancesApr 20, 2022
@luigimorel

luigimorel commented Apr 20, 2022 via email

Copy link
Copy Markdown
ContributorAuthor

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add remittances

2 participants

@luigimorel@ernest-okot