Uh oh!
There was an error while loading. Please reload this page.
refactor: dynamic import for assets - #2233
Closed
saschanaz wants to merge 20 commits into
Closed
Conversation
marcoscaceres
commented
Apr 7, 2019
Contributor
Amazing :) If you want to send this in pieces, it would be awesome. |
saschanaz
marked this pull request as ready for review
April 8, 2019 08:55
saschanaz
commented
Apr 8, 2019
CollaboratorAuthor
Will soon send some smaller pieces from this. |
saschanaz
commented
Apr 8, 2019
CollaboratorAuthor
@marcoscaceres This contains asset loading part and karma part... The former is okay, but the latter requires Chrome because it's the only browser that supports dynamic import now. Should we wait until Firefox stable enables dynamic import? |
marcoscaceres
commented
Apr 8, 2019
Contributor
No, I don't think we should wait... If we want to test against Firefox, we could figure out how to enable them via setting |
saschanaz
commented
Apr 9, 2019
CollaboratorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently blocked bymarkeddependency incore/utils:ES modules cannot reference a package via its package namemarkeddoes not have a ES module distributionThe first problem can be fixed by import maps but currently only Chrome beta 74 implements it. The second one is being worked on but it seems not to be active now.Resolved by #2240