fix: package agent plugin under plugins root by ian-pascoe · Pull Request #46 · spiritledsoftware/caplets

ian-pascoe · 2026-05-16T13:27:00Z

Summary

Packages the Caplets agent plugin using the same installable-root shape as Compound Engineering: the repo-level marketplaces point to ./plugins/caplets, and that plugin root owns the Codex manifest, Claude manifest, shared skills/, shared mcp.json, and icon asset.

What changed

Moved Codex and Claude plugin manifests under plugins/caplets/.codex-plugin/ and plugins/caplets/.claude-plugin/.
Moved the shared MCP config to plugins/caplets/mcp.json and pointed both plugin manifests at it.
Moved the Caplets skill into plugins/caplets/skills/caplets/SKILL.md so Codex copies it into the plugin cache during install.
Pointed both Codex and Claude marketplace metadata at ./plugins/caplets.
Updated docs, release/version sync, and plugin artifact tests for the new layout.
Added a patch changeset for caplets.

Validation

Local Codex app-server install from /home/ianpascoe/code/caplets: marketplace/add, plugin/install, plugin/read, and follow-up plugin/list succeeded.
plugin/read resolved source to /home/ianpascoe/code/caplets/plugins/caplets, reported installed/enabled, found skills: ["caplets:caplets"], and found mcpServers: ["caplets"].
Codex cache contains .codex-plugin/plugin.json, .claude-plugin/plugin.json, assets/icon.png, mcp.json, and skills/caplets/SKILL.md.
CODEX_HOME=/home/ianpascoe/.tmp/codex-app-install-read-home.N8oX58 codex debug prompt-input included both the Caplets plugin and caplets:caplets skill.
pnpm --filter @caplets/core test -- test/agent-plugins.test.ts
pnpm changeset status --since=origin/main
pnpm verify
Pre-push hook reran pnpm verify successfully before the force-push.

Summary by CodeRabbit

Bug Fixes
- Fixed plugin marketplace installation by adopting a standardized, self-contained plugin layout.
Chores
- Consolidated agent plugin structure under a centralized plugin layout and updated marketplace/manifest references.
- Updated release/version tooling to operate against the new plugin manifests.
Documentation
- Updated README to reflect the shared plugin/MCP layout and updated plugin icon reference.
Tests
- Updated tests to validate the new plugin layout and manifest structure.

coderabbitai · 2026-05-16T13:27:06Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 424c2037-084a-45e7-b01e-a3e273190f52

📥 Commits

Reviewing files that changed from the base of the PR and between 6beb89c and dfaed31.

📒 Files selected for processing (2)

.claude-plugin/marketplace.json
packages/benchmarks/lib/config.mjs

📝 Walkthrough

Walkthrough

This PR consolidates the caplets plugin into plugins/caplets/: shared mcp.json and skills, plugin manifests updated to reference ./mcp.json, marketplace entries and build scripts adjusted to new paths, tests and README updated, and a Changeset added documenting the fix.

Changes

Caplets plugin structure migration

Layer / File(s)	Summary
MCP config wrapper and shared plugin source `codex.mcp.json`, `plugins/caplets/.codex-plugin/plugin.json`, `plugins/caplets/.claude-plugin/plugin.json`, `.agents/plugins/marketplace.json`, `.claude-plugin/marketplace.json`	MCP server configuration is wrapped under `mcpServers` in `codex.mcp.json`; both agent-specific plugin manifests now reference the shared `./mcp.json`; marketplace entries now point to `./plugins/caplets` as the plugin source.
Build scripts updated for new plugin paths `package.json`, `scripts/sync-plugin-versions.mjs`	The `version-packages` npm script and `sync-plugin-versions.mjs` utility read and write plugin manifest files using fully-qualified paths under `plugins/caplets/.codex-plugin/` and `plugins/caplets/.claude-plugin/` instead of root-level paths.
Test updates and structure validation `packages/core/test/agent-plugins.test.ts`	Test imports expanded to include `lstatSync`; manifest and marketplace assertions now validate `plugins/caplets/...`; new tests verify plugin directory structure and required files; forbidden/required path lists updated to the consolidated layout.
README and changelog updates `README.md`, `.changeset/fix-codex-plugin-install.md`	Logo image path updated to `plugins/caplets/assets/icon.png`; "Agent Plugins" section documents the new consolidated plugin root, agent-specific manifests, shared skills and MCP config, and marketplace advertisement file locations; changeset documents the installation/config fix.
Benchmarks path constant usage `packages/benchmarks/lib/config.mjs`	Returns `capletsCliPath` from `CAPLETS_CLI_PATH` constant rather than recomputing from the repo root.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

spiritledsoftware/caplets#39: Introduces the initial plugins/caplets/ directory structure that this PR builds upon, aligning marketplace and MCP expectations.

Poem

🐰 From root to tidy nests I hop and mend,
Plugins gathered where their skills attend,
MCPs shared, manifests aligned,
Tests confirm the paths I've signed,
Version-sync hums — the migration's end.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: package agent plugin under plugins root' clearly and specifically summarizes the main change—reorganizing the plugin structure to use a plugins/caplets directory layout.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/fix-codex-plugin-install

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

coderabbitai

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/fix-codex-plugin-install.md:
- Line 5: Update the release note text in .changeset/fix-codex-plugin-install.md
so the marketplace source path mentioned matches the implemented behavior:
replace the string "plugins/caplets" with ".codex-plugins/caplets" (ensure the
note now reads that the fix uses the supported ".codex-plugins/caplets" local
plugin source layout with bundled skills and shared MCP config).
In @.claude-plugin/marketplace.json:
- Line 4: The company name value for the "name" field is inconsistent (one
occurrence is "Spirit-Led Software LLC" with a hyphen and another is "Spirit Led
Software LLC" without); pick the correct branded form and update all "name"
entries in the JSON to match exactly (e.g., change the value in the second
occurrence to "Spirit-Led Software LLC" or vice versa) so every "name" key uses
the same string.
In `@README.md`:
- Around line 84-88: Update the README section that references the installable
plugin root so it matches the install fix: replace occurrences of
"plugins/caplets/" with "./.codex-plugins/caplets" (the symlinked repo-root
install path) and ensure the surrounding text that mentions agent-specific
manifests (".codex-plugin/" and ".claude-plugin/"), shared "skills/" and
"mcp.json", and the repo-level marketplace files still accurately point to the
new marketplace source path; edit the paragraph (lines describing Codex and
Claude Code plugins) to use "./.codex-plugins/caplets" as the installable plugin
root.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1421b08f-91d6-465a-9c81-53530ee429e8

📥 Commits

Reviewing files that changed from the base of the PR and between 5db06c9 and 6beb89c.

⛔ Files ignored due to path filters (1)

plugins/caplets/assets/icon.png is excluded by !**/*.png

📒 Files selected for processing (12)

.agents/plugins/marketplace.json
.changeset/fix-codex-plugin-install.md
.claude-plugin/marketplace.json
README.md
codex.mcp.json
package.json
packages/core/test/agent-plugins.test.ts
plugins/caplets/.claude-plugin/plugin.json
plugins/caplets/.codex-plugin/plugin.json
plugins/caplets/mcp.json
plugins/caplets/skills/caplets/SKILL.md
scripts/sync-plugin-versions.mjs

💤 Files with no reviewable changes (1)

codex.mcp.json

greptile-apps

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

ian-pascoe changed the title ~~[codex] fix Codex plugin install~~fix: Codex plugin installMay 16, 2026

ian-pascoe marked this pull request as ready for review May 16, 2026 13:40

greptile-appsBot reviewed May 16, 2026
View reviewed changes

ian-pascoe force-pushed the codex/fix-codex-plugin-install branch from efcce1f to fc438aeCompare May 16, 2026 13:57

greptile-appsBot reviewed May 16, 2026
View reviewed changes

ian-pascoe force-pushed the codex/fix-codex-plugin-install branch from fc438ae to 5db06c9Compare May 16, 2026 14:35

greptile-appsBot reviewed May 16, 2026
View reviewed changes

fix: package agent plugin under plugins root
6beb89c

ian-pascoe force-pushed the codex/fix-codex-plugin-install branch from 5db06c9 to 6beb89cCompare May 17, 2026 10:48

greptile-appsBot reviewed May 17, 2026
View reviewed changes

ian-pascoe changed the title ~~fix: Codex plugin install~~fix: package agent plugin under plugins rootMay 17, 2026

coderabbitaiBot reviewed May 17, 2026
View reviewed changes

Comment thread.changeset/fix-codex-plugin-install.md
Comment thread.claude-plugin/marketplace.json
Comment threadREADME.md

fix: address PR review feedback
dfaed31

greptile-appsBot reviewed May 17, 2026
View reviewed changes

ian-pascoe merged commit a615ee5 into mainMay 17, 2026
3 of 4 checks passed

ian-pascoe deleted the codex/fix-codex-plugin-install branch May 17, 2026 10:58

coderabbitaiBot mentioned this pull request May 18, 2026
fix: native extensions and monorepo #55
Merged

Navigation Menu

Uh oh!

Uh oh!

fix: package agent plugin under plugins root - #46

fix: package agent plugin under plugins root#46
ian-pascoe merged 2 commits into
mainfrom
codex/fix-codex-plugin-install

ian-pascoe commented May 16, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented May 16, 2026•
edited
Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

greptile-appsBot left a comment

Uh oh!

greptile-appsBot left a comment

Uh oh!

greptile-appsBot left a comment

Uh oh!

greptile-appsBot left a comment

Uh oh!

coderabbitaiBot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-appsBot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

ian-pascoe commented May 16, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What changed

Validation

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented May 16, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

greptile-appsBot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-appsBot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-appsBot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-appsBot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-appsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ian-pascoe commented May 16, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented May 16, 2026•
edited
Loading