Skip to content

Semver matchers & Flags spec query param - #116

Merged
EmilianoSanchez merged 4 commits into
developmentfrom
semver_matchers
May 6, 2024
Merged

Semver matchers & Flags spec query param #116
EmilianoSanchez merged 4 commits into
developmentfrom
semver_matchers

Conversation

@EmilianoSanchez

@EmilianoSanchezEmilianoSanchez commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

JS Browser SDK

What did you accomplish?

How do we test the changes introduced in this PR?

Extra Notes

@EmilianoSanchez
EmilianoSanchez requested a review from a team as a code ownerApril 18, 2024 20:03
@sonarqube-pull-requests

sonarqube-pull-requestsBot commented May 6, 2024

Copy link
Copy Markdown

SonarQube Quality Gate

Quality Gate failed

Failed condition0.0% 0.0% Coverage on New Code (is less than 80%)
Failed condition18.4% 18.37% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

javrudsky
javrudsky approved these changes May 6, 2024
View reviewed changes

@javrudskyjavrudsky left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EmilianoSanchez
EmilianoSanchez merged commit 6280063 into developmentMay 6, 2024
@EmilianoSanchez
EmilianoSanchez deleted the semver_matchers branch May 6, 2024 14:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@javrudskyjavrudskyjavrudsky approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EmilianoSanchez@javrudsky