Skip to content

Upgrade JS commons v1.18.0: large segments and factory destroy method - #121

Merged
EmilianoSanchez merged 43 commits into
developmentfrom
SDKS-8407_baseline
Nov 2, 2024
Merged

Upgrade JS commons v1.18.0: large segments and factory destroy method#121
EmilianoSanchez merged 43 commits into
developmentfrom
SDKS-8407_baseline

Conversation

@EmilianoSanchez

@EmilianoSanchezEmilianoSanchez commented Jul 26, 2024

Copy link
Copy Markdown
Contributor

JS Browser SDK

What did you accomplish?

How do we test the changes introduced in this PR?

Extra Notes

@EmilianoSanchez
EmilianoSanchez requested a review from a team as a code ownerJuly 26, 2024 13:11
@sonarqube-pull-requests

sonarqube-pull-requestsBot commented Jul 31, 2024

Copy link
Copy Markdown

SonarQube Quality Gate

Quality Gate failed

Failed condition0.0% 0.0% Coverage on New Code (is less than 80%)
Failed condition18.2% 18.18% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@EmilianoSanchezEmilianoSanchez changed the title Large Segments supportUpgrade JS commons v1.18.0: large segments and factory destroy methodSep 20, 2024
@sonarqube-pull-requests

sonarqube-pull-requestsBot commented Sep 20, 2024

Copy link
Copy Markdown

SonarQube Quality Gate

Quality Gate failed

Failed condition0.0% 0.0% Coverage on New Code (is less than 80%)
Failed condition23.7% 23.68% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@EmilianoSanchez
Remove unused waitForLargeSegments config
32002c7
@EmilianoSanchez
Upgrade JS-commons. Updated type definitions & tests
9a787a8
@EmilianoSanchez
Revert some removed type definitions
cfd4859
@EmilianoSanchez
Add type definition comment
982bff3
@EmilianoSanchez
rc
4c5f3c6
@EmilianoSanchez
Remove sync.localhostMode option and validation utils
f0b7dfe
@EmilianoSanchez
Remove 'full' subpackage, since there is not significant difference w…
23668a9
…ith the default 'slim' subpackage
@EmilianoSanchez
1st step: move SplitIO namespace definition from Browser SDK to JS-Co…
b935a91
…mmons
@EmilianoSanchez
update JS-commons
d5104b5
@EmilianoSanchez
Merge branch 'remove_pluggable_localhost_mode' into remove_full_entry…
59106de
…point
@EmilianoSanchez
Update changelog entry
d9a18dd
@EmilianoSanchez
Merge branch 'remove_pluggable_localhost_mode' into remove_full_entry…
1d4444c
…point
@EmilianoSanchez
Merge branch 'remove_full_entrypoint' into refactor_type_definitions
a331623
@EmilianoSanchez
2nd step: move SplitIO namespace definition from React Native SDK to …
dabfdab
…JS-Commons and merge
@EmilianoSanchez
3rd step: move SplitIO namespace definition from JS SDK to JS-Commons…
3e5d640
… and merge
@EmilianoSanchez
EmilianoSanchez changed the base branch from development to mainNovember 2, 2024 01:07
@EmilianoSanchez
EmilianoSanchez changed the base branch from main to developmentNovember 2, 2024 01:11
@sonarqube-pull-requests

sonarqube-pull-requestsBot commented Nov 2, 2024

Copy link
Copy Markdown

SonarQube Quality Gate

Quality Gate failed

Failed condition0.0% 0.0% Coverage on New Code (is less than 80%)
Failed condition22.8% 22.79% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@EmilianoSanchez
EmilianoSanchez merged commit 6c9cd48 into developmentNov 2, 2024
@EmilianoSanchez
EmilianoSanchez deleted the SDKS-8407_baseline branch November 2, 2024 01:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gtheagtheagthea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EmilianoSanchez@gthea